)]}'
{"quantum/plugins/brocade/QuantumPlugin.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":34,"context_line":"from quantum.common import topics"},{"line_number":35,"context_line":"from quantum.common import utils"},{"line_number":36,"context_line":"from quantum.db import agents_db"},{"line_number":37,"context_line":"from quantum.db import agentschedulers_db"},{"line_number":38,"context_line":"from quantum.db import api as db"},{"line_number":39,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":40,"context_line":"from quantum.db import dhcp_rpc_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F5dY%3D","line":37,"updated":"2013-03-07 05:50:15.000000000","message":"To address the bug, only agents_db is needed.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"6af3f7a5b50eda2a3f6755f5155486ff7621b992","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from quantum.common import topics"},{"line_number":35,"context_line":"from quantum.common import utils"},{"line_number":36,"context_line":"from quantum.db import agents_db"},{"line_number":37,"context_line":"from quantum.db import agentschedulers_db"},{"line_number":38,"context_line":"from quantum.db import api as db"},{"line_number":39,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":40,"context_line":"from quantum.db import dhcp_rpc_base"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F398%3D","line":37,"in_reply_to":"AAAAN3%2F%2F5dY%3D","updated":"2013-03-07 23:56:50.000000000","message":"ok.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":38,"context_line":"from quantum.db import api as db"},{"line_number":39,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":40,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":41,"context_line":"from quantum.db import extraroute_db"},{"line_number":42,"context_line":"from quantum.db import l3_db"},{"line_number":43,"context_line":"from quantum.db import l3_rpc_base"},{"line_number":44,"context_line":"from quantum.db import securitygroups_rpc_base as sg_db_rpc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F5dU%3D","line":41,"updated":"2013-03-07 05:50:15.000000000","message":"It is not related to this fix.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"6af3f7a5b50eda2a3f6755f5155486ff7621b992","unresolved":false,"context_lines":[{"line_number":38,"context_line":"from quantum.db import api as db"},{"line_number":39,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":40,"context_line":"from quantum.db import dhcp_rpc_base"},{"line_number":41,"context_line":"from quantum.db import extraroute_db"},{"line_number":42,"context_line":"from quantum.db import l3_db"},{"line_number":43,"context_line":"from quantum.db import l3_rpc_base"},{"line_number":44,"context_line":"from quantum.db import securitygroups_rpc_base as sg_db_rpc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F394%3D","line":41,"in_reply_to":"AAAAN3%2F%2F5dU%3D","updated":"2013-03-07 23:56:50.000000000","message":"agreed.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5fb01084aeb124c11d085e67c724df51ec830e31","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class BrocadePluginV2(db_base_plugin_v2.QuantumDbPluginV2,"},{"line_number":198,"context_line":"                      l3_db.L3_NAT_db_mixin,"},{"line_number":199,"context_line":"                      sg_db_rpc.SecurityGroupServerRpcMixin,"},{"line_number":200,"context_line":"                      agentschedulers_db.AgentSchedulerDbMixin):"},{"line_number":201,"context_line":"    \"\"\"BrocadePluginV2 is a Quantum plugin."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F5iw%3D","line":198,"updated":"2013-03-07 04:49:06.000000000","message":"If you\u0027re going to support the extraroute extension replace L3 with:\n \nextraroute_db.ExtraRoute_db_mixin,","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"6af3f7a5b50eda2a3f6755f5155486ff7621b992","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"class BrocadePluginV2(db_base_plugin_v2.QuantumDbPluginV2,"},{"line_number":198,"context_line":"                      l3_db.L3_NAT_db_mixin,"},{"line_number":199,"context_line":"                      sg_db_rpc.SecurityGroupServerRpcMixin,"},{"line_number":200,"context_line":"                      agentschedulers_db.AgentSchedulerDbMixin):"},{"line_number":201,"context_line":"    \"\"\"BrocadePluginV2 is a Quantum plugin."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F3%2BE%3D","line":198,"in_reply_to":"AAAAN3%2F%2F5iw%3D","updated":"2013-03-07 23:56:50.000000000","message":"@Mark: The purpose of this change was to fix the bug 1150294  at hand without enhancing features as was suggested by Dan in bug 1147190 which addressed the extensions. Hence, I was trying to skirt the situation by not enhancing and fixing the bug nevertheless.\n\nAgreed I added more than necessary imports and can do with a lot less as suggested by Akihiro.\n\n@Akihiro: Thanks for the suggestion.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":197,"context_line":"class BrocadePluginV2(db_base_plugin_v2.QuantumDbPluginV2,"},{"line_number":198,"context_line":"                      l3_db.L3_NAT_db_mixin,"},{"line_number":199,"context_line":"                      sg_db_rpc.SecurityGroupServerRpcMixin,"},{"line_number":200,"context_line":"                      agentschedulers_db.AgentSchedulerDbMixin):"},{"line_number":201,"context_line":"    \"\"\"BrocadePluginV2 is a Quantum plugin."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    Provides L2 Virtual Network functionality using VDX. Upper"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F5dI%3D","line":200,"updated":"2013-03-07 05:50:15.000000000","message":"The minimum requirement to fix the bug is to add agents_db.AgentDbMixin instead of AgentSchedulerDbMixin.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"6af3f7a5b50eda2a3f6755f5155486ff7621b992","unresolved":false,"context_lines":[{"line_number":197,"context_line":"class BrocadePluginV2(db_base_plugin_v2.QuantumDbPluginV2,"},{"line_number":198,"context_line":"                      l3_db.L3_NAT_db_mixin,"},{"line_number":199,"context_line":"                      sg_db_rpc.SecurityGroupServerRpcMixin,"},{"line_number":200,"context_line":"                      agentschedulers_db.AgentSchedulerDbMixin):"},{"line_number":201,"context_line":"    \"\"\"BrocadePluginV2 is a Quantum plugin."},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    Provides L2 Virtual Network functionality using VDX. Upper"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F3%2BA%3D","line":200,"in_reply_to":"AAAAN3%2F%2F5dI%3D","updated":"2013-03-07 23:56:50.000000000","message":"Done","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"5fb01084aeb124c11d085e67c724df51ec830e31","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        \"\"\"Initialize Brocade Plugin, specify switch address"},{"line_number":210,"context_line":"        and db configuration."},{"line_number":211,"context_line":"        \"\"\""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self.supported_extension_aliases \u003d [\"binding\", \"security-group\"]"},{"line_number":214,"context_line":"        self.binding_view \u003d \"extension:port_binding:view\""},{"line_number":215,"context_line":"        self.binding_set \u003d \"extension:port_binding:set\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F5ik%3D","line":212,"updated":"2013-03-07 04:49:06.000000000","message":"extraroute, router, agent_scheduler, agent need to be in this list.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"6af3f7a5b50eda2a3f6755f5155486ff7621b992","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        \"\"\"Initialize Brocade Plugin, specify switch address"},{"line_number":210,"context_line":"        and db configuration."},{"line_number":211,"context_line":"        \"\"\""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self.supported_extension_aliases \u003d [\"binding\", \"security-group\"]"},{"line_number":214,"context_line":"        self.binding_view \u003d \"extension:port_binding:view\""},{"line_number":215,"context_line":"        self.binding_set \u003d \"extension:port_binding:set\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F39U%3D","line":212,"in_reply_to":"AAAAN3%2F%2F5cw%3D","updated":"2013-03-07 23:56:50.000000000","message":"will remove L3RpcCallbackMixin for now.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":209,"context_line":"        \"\"\"Initialize Brocade Plugin, specify switch address"},{"line_number":210,"context_line":"        and db configuration."},{"line_number":211,"context_line":"        \"\"\""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self.supported_extension_aliases \u003d [\"binding\", \"security-group\"]"},{"line_number":214,"context_line":"        self.binding_view \u003d \"extension:port_binding:view\""},{"line_number":215,"context_line":"        self.binding_set \u003d \"extension:port_binding:set\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F5cw%3D","line":212,"in_reply_to":"AAAAN3%2F%2F5ik%3D","updated":"2013-03-07 05:50:15.000000000","message":"Callback has L3RpcCallbackMixin, so Brocade plugin seems to have a support  \"router\" extension. Missing \"router\" in extension list looks a bug.\n\nAdding \"agent\" is not required necessarily. When AgentExtCallback is enabled and non \"agent\" in supported_extensions_aliases, state report works well but API does not provide agent related method.\n\nI am not sure about extraroute and agent_scheduler. we had a discussion about mini feature such as agent_scheduler at the beginning of this week.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"6af3f7a5b50eda2a3f6755f5155486ff7621b992","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        \"\"\"Initialize Brocade Plugin, specify switch address"},{"line_number":210,"context_line":"        and db configuration."},{"line_number":211,"context_line":"        \"\"\""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        self.supported_extension_aliases \u003d [\"binding\", \"security-group\"]"},{"line_number":214,"context_line":"        self.binding_view \u003d \"extension:port_binding:view\""},{"line_number":215,"context_line":"        self.binding_set \u003d \"extension:port_binding:set\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F390%3D","line":212,"in_reply_to":"AAAAN3%2F%2F5ik%3D","updated":"2013-03-07 23:56:50.000000000","message":"prefer what you said but need to postpone adding features while in FF.","commit_id":"98d31924c019038ed87f5b2e2ed6ac6530a250f7"}]}
