)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"98ce6e52912c987e99fd1b25cb0e637454bcfd01","unresolved":false,"context_lines":[{"line_number":12,"context_line":"simplify code and remove a poorly tested case (use_namespace\u003dFalse)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TODO:"},{"line_number":15,"context_line":"* How to handle router_id option?"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Closes-Bug: #1508188"},{"line_number":18,"context_line":"Related-Bug: #1435382"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a29b11f_254b432d","line":15,"updated":"2015-10-27 00:46:28.000000000","message":"Add DocImpact/UpgradeImpact\nUpdate *-aas tests first","commit_id":"e15a2363c5d77479bff2f20a2c029d33c6897741"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7c0e24fcc278737e0abf9c34d35ef0954ca67c2c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The use_namespaces option has been defined as a workaround to kernels"},{"line_number":10,"context_line":"not properly supporting namespaces. This limitation is behind us, it\u0027s"},{"line_number":11,"context_line":"time to remove use_namespace afteir its deprecation in Kilo in order to"},{"line_number":12,"context_line":"simplify code and remove a poorly tested case (use_namespace\u003dFalse)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a26ad4f_20126763","line":11,"updated":"2015-10-28 10:32:57.000000000","message":"nit: afteir \u003d\u003d\u003e after","commit_id":"67b8095730809b3abece1d7cd8d19f951acc988b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d1bd576160a04b999d16db63f4bd70115a85ccc1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The use_namespaces option has been defined as a workaround to kernels"},{"line_number":10,"context_line":"not properly supporting namespaces. This limitation is behind us, it\u0027s"},{"line_number":11,"context_line":"time to remove use_namespace after its deprecation in Kilo in order to"},{"line_number":12,"context_line":"simplify code and remove a poorly tested case (use_namespace\u003dFalse)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ba8a016a_9676a1a2","line":12,"range":{"start_line":12,"start_character":47,"end_line":12,"end_character":60},"updated":"2015-11-18 14:09:44.000000000","message":"typo: use_namespaces","commit_id":"11ff1c063cd67742fba81c7b98e6ab84101614ef"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d09393e2db38b26e414a6eed25f77d9be7acdbee","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The use_namespaces option has been defined as a workaround to kernels"},{"line_number":10,"context_line":"not properly supporting namespaces. This limitation is behind us, it\u0027s"},{"line_number":11,"context_line":"time to remove use_namespace after its deprecation in Kilo in order to"},{"line_number":12,"context_line":"simplify code and remove a poorly tested case (use_namespace\u003dFalse)."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"},{"line_number":15,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"ba8a016a_cd7b2cf4","line":12,"in_reply_to":"ba8a016a_9676a1a2","updated":"2015-11-18 18:02:51.000000000","message":"Done","commit_id":"11ff1c063cd67742fba81c7b98e6ab84101614ef"}],"neutron/agent/l3/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c2ab1baa117dc4b7098bc29fa946ea313a9f2de","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                      \"less than or equal to 0, the feature is disabled\")),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027router_id\u0027, default\u003d\u0027\u0027,"},{"line_number":52,"context_line":"               help\u003d_(\"If non-empty, the l3 agent can only configure a router \""},{"line_number":53,"context_line":"                      \"that has the matching router ID.\")),"},{"line_number":54,"context_line":"    cfg.BoolOpt(\u0027handle_internal_only_routers\u0027,"},{"line_number":55,"context_line":"                default\u003dTrue,"},{"line_number":56,"context_line":"                help\u003d_(\"Agent should implement routers with no gateway\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_f87fd7a8","line":53,"updated":"2015-11-18 15:45:00.000000000","message":"I don\u0027t get what\u0027s the use case for the option now that we always use namespaces. Should we deprecate it now?","commit_id":"11ff1c063cd67742fba81c7b98e6ab84101614ef"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d09393e2db38b26e414a6eed25f77d9be7acdbee","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                      \"less than or equal to 0, the feature is disabled\")),"},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027router_id\u0027, default\u003d\u0027\u0027,"},{"line_number":52,"context_line":"               help\u003d_(\"If non-empty, the l3 agent can only configure a router \""},{"line_number":53,"context_line":"                      \"that has the matching router ID.\")),"},{"line_number":54,"context_line":"    cfg.BoolOpt(\u0027handle_internal_only_routers\u0027,"},{"line_number":55,"context_line":"                default\u003dTrue,"},{"line_number":56,"context_line":"                help\u003d_(\"Agent should implement routers with no gateway\")),"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_cd97acea","line":53,"in_reply_to":"ba8a016a_f87fd7a8","updated":"2015-11-18 18:02:51.000000000","message":"I would prefer to deprecate it in a follow-up change based on a similar discussion related to gateway_external_network_id deprecation[1]\n\n[1] https://review.openstack.org/#/c/219928/2/etc/l3_agent.ini","commit_id":"11ff1c063cd67742fba81c7b98e6ab84101614ef"}],"neutron/agent/l3/namespace_manager.py":[{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"79ecb48f6ffafc3f2390a86706e3c5ad0794d891","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param agent_conf: configuration from l3 agent"},{"line_number":56,"context_line":"        :param driver: to perform operations on devices"},{"line_number":57,"context_line":"        :param clean_stale: Whether to try to clean stale namespaces"},{"line_number":58,"context_line":"        :param metadata_driver: used to cleanup stale metadata proxy processes"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        self.agent_conf \u003d agent_conf"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_dbe33404","line":57,"updated":"2015-11-04 21:47:41.000000000","message":"Remove this line about clean_stale.","commit_id":"43aca7b54095528bac838213b1be3a58945128d6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c33c59220e57eb1ffa5032bc18cea33461dda819","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        :param agent_conf: configuration from l3 agent"},{"line_number":56,"context_line":"        :param driver: to perform operations on devices"},{"line_number":57,"context_line":"        :param clean_stale: Whether to try to clean stale namespaces"},{"line_number":58,"context_line":"        :param metadata_driver: used to cleanup stale metadata proxy processes"},{"line_number":59,"context_line":"        \"\"\""},{"line_number":60,"context_line":"        self.agent_conf \u003d agent_conf"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_b8f3c809","line":57,"in_reply_to":"fa80f949_dbe33404","updated":"2015-11-05 07:34:58.000000000","message":"Done","commit_id":"43aca7b54095528bac838213b1be3a58945128d6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"a560f3515fe4fa0e7ebca269348f490807a715f7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # namespaces was only done once after restart.  Still a good idea?"},{"line_number":79,"context_line":"        if exc_type:"},{"line_number":80,"context_line":"            # An exception occurred in the caller\u0027s with statement"},{"line_number":81,"context_line":"            return False"},{"line_number":82,"context_line":"        if not self._clean_stale:"},{"line_number":83,"context_line":"            # No need to cleanup"},{"line_number":84,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_d24a2e83","line":81,"updated":"2015-11-05 03:41:27.000000000","message":"Well, if clean_state is definitely set to True, it seems we don\u0027t need L72, and need fix this __exit__ method.","commit_id":"43aca7b54095528bac838213b1be3a58945128d6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"9f93a6661c79cae7fb7a3e99b6b354b48fa58279","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # namespaces was only done once after restart.  Still a good idea?"},{"line_number":79,"context_line":"        if exc_type:"},{"line_number":80,"context_line":"            # An exception occurred in the caller\u0027s with statement"},{"line_number":81,"context_line":"            return False"},{"line_number":82,"context_line":"        if not self._clean_stale:"},{"line_number":83,"context_line":"            # No need to cleanup"},{"line_number":84,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_b8dd0844","line":81,"in_reply_to":"fa80f949_18ed3425","updated":"2015-11-05 07:44:30.000000000","message":"Sorry for my blind.","commit_id":"43aca7b54095528bac838213b1be3a58945128d6"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c33c59220e57eb1ffa5032bc18cea33461dda819","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        # namespaces was only done once after restart.  Still a good idea?"},{"line_number":79,"context_line":"        if exc_type:"},{"line_number":80,"context_line":"            # An exception occurred in the caller\u0027s with statement"},{"line_number":81,"context_line":"            return False"},{"line_number":82,"context_line":"        if not self._clean_stale:"},{"line_number":83,"context_line":"            # No need to cleanup"},{"line_number":84,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa80f949_18ed3425","line":81,"in_reply_to":"fa80f949_d24a2e83","updated":"2015-11-05 07:34:58.000000000","message":"Definitely? It\u0027s updated in L85","commit_id":"43aca7b54095528bac838213b1be3a58945128d6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c2ab1baa117dc4b7098bc29fa946ea313a9f2de","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        self.agent_conf \u003d agent_conf"},{"line_number":60,"context_line":"        self.driver \u003d driver"},{"line_number":61,"context_line":"        self._clean_stale \u003d True"},{"line_number":62,"context_line":"        self.metadata_driver \u003d metadata_driver"},{"line_number":63,"context_line":"        if metadata_driver:"},{"line_number":64,"context_line":"            self.process_monitor \u003d external_process.ProcessMonitor("}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7bdbe14f","line":61,"updated":"2015-11-18 15:45:00.000000000","message":"Should we then remove the attribute from the class?","commit_id":"11ff1c063cd67742fba81c7b98e6ab84101614ef"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d09393e2db38b26e414a6eed25f77d9be7acdbee","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        \"\"\""},{"line_number":59,"context_line":"        self.agent_conf \u003d agent_conf"},{"line_number":60,"context_line":"        self.driver \u003d driver"},{"line_number":61,"context_line":"        self._clean_stale \u003d True"},{"line_number":62,"context_line":"        self.metadata_driver \u003d metadata_driver"},{"line_number":63,"context_line":"        if metadata_driver:"},{"line_number":64,"context_line":"            self.process_monitor \u003d external_process.ProcessMonitor("}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_2d4518b2","line":61,"in_reply_to":"ba8a016a_7bdbe14f","updated":"2015-11-18 18:02:51.000000000","message":"This option is updated in L84 in order clean stale namespace once after l3-agent start","commit_id":"11ff1c063cd67742fba81c7b98e6ab84101614ef"}],"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c2ab1baa117dc4b7098bc29fa946ea313a9f2de","unresolved":false,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        return retval"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    def pullup_route(self, interface_name, ip_version):"},{"line_number":726,"context_line":"        \"\"\"Ensures that the route entry for the interface is before all"},{"line_number":727,"context_line":"        others on the same subnet."},{"line_number":728,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_7bfc4172","side":"PARENT","line":725,"updated":"2015-11-18 15:45:00.000000000","message":"Should we follow some deprecation period before removing the method? I thought those *_lib.py files are considered public API.","commit_id":"445a6feb24e5b5f946ae31f0508e58cc933031aa"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d09393e2db38b26e414a6eed25f77d9be7acdbee","unresolved":false,"context_lines":[{"line_number":722,"context_line":""},{"line_number":723,"context_line":"        return retval"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    def pullup_route(self, interface_name, ip_version):"},{"line_number":726,"context_line":"        \"\"\"Ensures that the route entry for the interface is before all"},{"line_number":727,"context_line":"        others on the same subnet."},{"line_number":728,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_2830a6e7","side":"PARENT","line":725,"in_reply_to":"ba8a016a_7bfc4172","updated":"2015-11-18 18:02:51.000000000","message":"Done","commit_id":"445a6feb24e5b5f946ae31f0508e58cc933031aa"}]}