)]}'
{"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"1a6724ea0486d550c0bd5b0648900fb3559c847a","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":520,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":521,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":522,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":523,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"},{"line_number":524,"context_line":"                 new_port[\u0027binding:host_id\u0027])):"},{"line_number":525,"context_line":"            l3plugin \u003d manager.NeutronManager.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_6be4fa3a","line":522,"updated":"2015-11-16 13:11:25.000000000","message":"I think you should restrict this to non dvr-snat agent. For example, I update the host_id of dhcp port in the host of dvr-snat. And according to the code here, the dvr router is cleared on the host, including the snat and qrouter namespace.","commit_id":"149d1a59d96ec77aa26724061e6489744bf3bad6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"89d583247ef0766de87d8c3417b2dd5423c12160","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":520,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":521,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":522,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":523,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"},{"line_number":524,"context_line":"                 new_port[\u0027binding:host_id\u0027])):"},{"line_number":525,"context_line":"            l3plugin \u003d manager.NeutronManager.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_1b853658","line":522,"in_reply_to":"ba8a016a_1eb44acf","updated":"2015-12-10 17:01:36.000000000","message":"I filed a bug for this case https://bugs.launchpad.net/neutron/+bug/1524908 review https://review.openstack.org/#/c/255989/","commit_id":"149d1a59d96ec77aa26724061e6489744bf3bad6"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"61466dfeab18fa8538a9f5838cf83c210535b186","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":520,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":521,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":522,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":523,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"},{"line_number":524,"context_line":"                 new_port[\u0027binding:host_id\u0027])):"},{"line_number":525,"context_line":"            l3plugin \u003d manager.NeutronManager.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_2496ce4c","line":522,"in_reply_to":"ba8a016a_1eb44acf","updated":"2015-11-23 16:33:39.000000000","message":"Oleg, I would recommend just to check for the \"compute:\" ports. \n\nI don\u0027t think if \"dhcp\" ports will be migrated or the \"lbaas\" ports.","commit_id":"149d1a59d96ec77aa26724061e6489744bf3bad6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a0c148522e2c0774bcb46530192750dc3264af78","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":520,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":521,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":522,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":523,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"},{"line_number":524,"context_line":"                 new_port[\u0027binding:host_id\u0027])):"},{"line_number":525,"context_line":"            l3plugin \u003d manager.NeutronManager.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_347fb818","line":522,"in_reply_to":"ba8a016a_2496ce4c","updated":"2015-11-24 09:22:09.000000000","message":"What if they could be migrated (in future)? For dhcp ports it is already possible to change host (active -\u003e reserved - \u003e active) so I\u0027d avoid special handling fo compute ports only unless there is a strong reason for it, is there any?","commit_id":"149d1a59d96ec77aa26724061e6489744bf3bad6"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"91abec2f9c603ec5b75b317c93423fca0843fbff","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":520,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":521,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":522,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":523,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"},{"line_number":524,"context_line":"                 new_port[\u0027binding:host_id\u0027])):"},{"line_number":525,"context_line":"            l3plugin \u003d manager.NeutronManager.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_f0d44cbe","line":522,"in_reply_to":"ba8a016a_347fb818","updated":"2015-11-30 18:40:31.000000000","message":"makes sense.","commit_id":"149d1a59d96ec77aa26724061e6489744bf3bad6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1923d83f32f452d193e2ba008e44f875c019c6ea","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":520,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":521,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":522,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":523,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"},{"line_number":524,"context_line":"                 new_port[\u0027binding:host_id\u0027])):"},{"line_number":525,"context_line":"            l3plugin \u003d manager.NeutronManager.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_1eb44acf","line":522,"in_reply_to":"ba8a016a_5e62d2ae","updated":"2015-11-17 13:52:58.000000000","message":"I\u0027m going to work on blueprint metioned above, so yes, I should cover this case","commit_id":"149d1a59d96ec77aa26724061e6489744bf3bad6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ebe54a61e7c92198d3a6eb80a197a56566e0abe5","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":520,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":521,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":522,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":523,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"},{"line_number":524,"context_line":"                 new_port[\u0027binding:host_id\u0027])):"},{"line_number":525,"context_line":"            l3plugin \u003d manager.NeutronManager.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_8551cdda","line":522,"in_reply_to":"ba8a016a_6be4fa3a","updated":"2015-11-17 12:58:10.000000000","message":"Good catch. However I\u0027d not say this patch introduced the issue you\u0027ve described, it should probably be fixed in dvr_deletens_if_no_port() in scope of a separate bug or this will likely be covered in dvr binding refactoring blueprint [1]\n\n[1] https://review.openstack.org/#/c/175237/","commit_id":"149d1a59d96ec77aa26724061e6489744bf3bad6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"61577fe2f5fdb8b9a3a141ea4a1d55523c9fe0cb","unresolved":false,"context_lines":[{"line_number":519,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":520,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":521,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":522,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":523,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"},{"line_number":524,"context_line":"                 new_port[\u0027binding:host_id\u0027])):"},{"line_number":525,"context_line":"            l3plugin \u003d manager.NeutronManager.get_service_plugins().get("}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_5e62d2ae","line":522,"in_reply_to":"ba8a016a_8551cdda","updated":"2015-11-17 13:49:52.000000000","message":"yeah, I would think the check in dvr_deletens_if_no_port failed to consider centralized router of dvr. So, you don\u0027t plan to consider this case in this patch and you will consider it in future patch, right? If so, I would revert my score, because it is indeed a corner case here.","commit_id":"149d1a59d96ec77aa26724061e6489744bf3bad6"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"268d5bacc45838fdced34cb99a4169c695178fa5","unresolved":false,"context_lines":[{"line_number":492,"context_line":"    if new_port and original_port:"},{"line_number":493,"context_line":"        original_device_owner \u003d original_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":494,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":495,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":496,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":497,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":498,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_4137bdfe","line":495,"updated":"2015-12-09 00:45:27.000000000","message":"This is a pretty complex boolean expression.  Can it be broken up for readability? ...\n\n        is_port_no_longer_serviced \u003d (\n            n_utils.is_dvr_serviced(original_device_owner) and\n            not n_utils.is_dvr_serviced(new_device_owner))\n        is_port_moved \u003d (\n            original_port[\u0027binding:host_id\u0027] and\n            original_port[\u0027binding:host_id\u0027] !\u003d new_port[\u0027binding:host_id\u0027])\n        if is_port_no_longer_serviced or is_port_moved:\n            ...","commit_id":"579db2889725e3bbb46076cbd115eda6f46cb84c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b67df35c679366a66929c489259c097fb8862938","unresolved":false,"context_lines":[{"line_number":492,"context_line":"    if new_port and original_port:"},{"line_number":493,"context_line":"        original_device_owner \u003d original_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":494,"context_line":"        new_device_owner \u003d new_port.get(\u0027device_owner\u0027, \u0027\u0027)"},{"line_number":495,"context_line":"        if ((n_utils.is_dvr_serviced(original_device_owner) and"},{"line_number":496,"context_line":"             not n_utils.is_dvr_serviced(new_device_owner)) or"},{"line_number":497,"context_line":"                (original_port[\u0027binding:host_id\u0027] and"},{"line_number":498,"context_line":"                 original_port[\u0027binding:host_id\u0027] !\u003d"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_22506431","line":495,"in_reply_to":"7a740942_4137bdfe","updated":"2015-12-09 08:02:08.000000000","message":"that\u0027s a good point","commit_id":"579db2889725e3bbb46076cbd115eda6f46cb84c"}],"neutron/tests/functional/services/l3_router/test_l3_dvr_router_plugin.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"c6f16b0d90961b7e8f2bf038a151637509aef5bf","unresolved":false,"context_lines":[{"line_number":382,"context_line":"                    self.context, router[\u0027id\u0027])"},{"line_number":383,"context_line":"                self.assertEqual(2, len(agents[\u0027agents\u0027]))"},{"line_number":384,"context_line":"                self.assertIn(dvr_agent1[\u0027id\u0027],"},{"line_number":385,"context_line":"                              [agent[\u0027id\u0027] for agent in agents[\u0027agents\u0027]])"},{"line_number":386,"context_line":"                self.assertNotIn(dvr_agent2[\u0027id\u0027],"},{"line_number":387,"context_line":"                                 [agent[\u0027id\u0027] for agent in agents[\u0027agents\u0027]])"},{"line_number":388,"context_line":"                # and notification should only be sent to the agent on host1"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_6a072682","line":385,"updated":"2015-10-22 17:06:32.000000000","message":"it\u0027s better to extract the list expression as a variable","commit_id":"e853b791e15c72e4b7b381853e120479ec8768f6"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"590337dba56eaa195c0e9554328e524394a4597d","unresolved":false,"context_lines":[{"line_number":382,"context_line":"                    self.context, router[\u0027id\u0027])"},{"line_number":383,"context_line":"                self.assertEqual(2, len(agents[\u0027agents\u0027]))"},{"line_number":384,"context_line":"                self.assertIn(dvr_agent1[\u0027id\u0027],"},{"line_number":385,"context_line":"                              [agent[\u0027id\u0027] for agent in agents[\u0027agents\u0027]])"},{"line_number":386,"context_line":"                self.assertNotIn(dvr_agent2[\u0027id\u0027],"},{"line_number":387,"context_line":"                                 [agent[\u0027id\u0027] for agent in agents[\u0027agents\u0027]])"},{"line_number":388,"context_line":"                # and notification should only be sent to the agent on host1"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_72f7d4f5","line":385,"in_reply_to":"3a29b11f_028be81f","updated":"2015-10-26 06:47:39.000000000","message":"It was at PS1, but now I begin to think it\u0027s OK.","commit_id":"e853b791e15c72e4b7b381853e120479ec8768f6"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"aad9cd171b51be4632f7c2c0b34cfd8aa5aa6d2a","unresolved":false,"context_lines":[{"line_number":382,"context_line":"                    self.context, router[\u0027id\u0027])"},{"line_number":383,"context_line":"                self.assertEqual(2, len(agents[\u0027agents\u0027]))"},{"line_number":384,"context_line":"                self.assertIn(dvr_agent1[\u0027id\u0027],"},{"line_number":385,"context_line":"                              [agent[\u0027id\u0027] for agent in agents[\u0027agents\u0027]])"},{"line_number":386,"context_line":"                self.assertNotIn(dvr_agent2[\u0027id\u0027],"},{"line_number":387,"context_line":"                                 [agent[\u0027id\u0027] for agent in agents[\u0027agents\u0027]])"},{"line_number":388,"context_line":"                # and notification should only be sent to the agent on host1"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_028be81f","line":385,"in_reply_to":"3a29b11f_6a072682","updated":"2015-10-23 05:36:49.000000000","message":"I\u0027ll do in the next patch set but is it the reason for -1?","commit_id":"e853b791e15c72e4b7b381853e120479ec8768f6"}]}
