)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"538a6491a4ca24071901b15ec9d6ddf7536495cf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding notification when subnet is being updated to allow a check"},{"line_number":10,"context_line":"for subnet in use (as needed by VPNaaS for IPSec connections that"},{"line_number":11,"context_line":"are using the subnet). This will be used to blick the change, as"},{"line_number":12,"context_line":"is done for deletes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I33245daa158889db8a7cc9a61db8964acf5038ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a29b11f_3ef83b7c","line":11,"updated":"2015-10-26 15:53:23.000000000","message":"nit: block","commit_id":"599c3c93d1a87c30be2e8327deb52d9b8e66d38e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"bad95852685ca5832fe18e7f8bd1aa6dcad6e600","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding notification when subnet is being updated to allow a check"},{"line_number":10,"context_line":"for subnet in use (as needed by VPNaaS for IPSec connections that"},{"line_number":11,"context_line":"are using the subnet). This will be used to blick the change, as"},{"line_number":12,"context_line":"is done for deletes."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I33245daa158889db8a7cc9a61db8964acf5038ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a29b11f_8013250d","line":11,"in_reply_to":"3a29b11f_3ef83b7c","updated":"2015-10-27 01:29:46.000000000","message":"Done","commit_id":"599c3c93d1a87c30be2e8327deb52d9b8e66d38e"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7a0ec2e392ec7a203d8dba157877b1278a51b5ef","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        \"\"\""},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # Make sure the subnet isn\u0027t used by other resources"},{"line_number":695,"context_line":"        _check_subnet_not_used(context, id, action\u003devents.BEFORE_UPDATE)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        s \u003d subnet[\u0027subnet\u0027]"},{"line_number":698,"context_line":"        new_cidr \u003d s.get(\u0027cidr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_61a97d23","line":695,"updated":"2015-10-23 03:25:08.000000000","message":"how about passing in the requested changes from the API so the callback listeners can determine if they care about the update without a db lookup.\n\ne.g. i think most won\u0027t care if the only thing changing is the name","commit_id":"599c3c93d1a87c30be2e8327deb52d9b8e66d38e"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"538a6491a4ca24071901b15ec9d6ddf7536495cf","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        \"\"\""},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # Make sure the subnet isn\u0027t used by other resources"},{"line_number":695,"context_line":"        _check_subnet_not_used(context, id, action\u003devents.BEFORE_UPDATE)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        s \u003d subnet[\u0027subnet\u0027]"},{"line_number":698,"context_line":"        new_cidr \u003d s.get(\u0027cidr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_fef16396","line":695,"in_reply_to":"3a29b11f_61a97d23","updated":"2015-10-26 15:53:23.000000000","message":"If we can do that, I like the idea","commit_id":"599c3c93d1a87c30be2e8327deb52d9b8e66d38e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"733d8f20cda0c4acf191cf094c7074b480d3d72d","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        \"\"\""},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # Make sure the subnet isn\u0027t used by other resources"},{"line_number":695,"context_line":"        _check_subnet_not_used(context, id, action\u003devents.BEFORE_UPDATE)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        s \u003d subnet[\u0027subnet\u0027]"},{"line_number":698,"context_line":"        new_cidr \u003d s.get(\u0027cidr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_93c97caf","line":695,"in_reply_to":"3a29b11f_802a452b","updated":"2015-10-27 06:22:44.000000000","message":"Done","commit_id":"599c3c93d1a87c30be2e8327deb52d9b8e66d38e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"bad95852685ca5832fe18e7f8bd1aa6dcad6e600","unresolved":false,"context_lines":[{"line_number":692,"context_line":"        \"\"\""},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        # Make sure the subnet isn\u0027t used by other resources"},{"line_number":695,"context_line":"        _check_subnet_not_used(context, id, action\u003devents.BEFORE_UPDATE)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        s \u003d subnet[\u0027subnet\u0027]"},{"line_number":698,"context_line":"        new_cidr \u003d s.get(\u0027cidr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_802a452b","line":695,"in_reply_to":"3a29b11f_fef16396","updated":"2015-10-27 01:29:46.000000000","message":"Good point, will push a revision, and will update in VPN repo to check specific attributes, like CIDR.","commit_id":"599c3c93d1a87c30be2e8327deb52d9b8e66d38e"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"726894aafc598c8d4588c3df7b91f1a84b34d74d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                           data\u003dNone):"},{"line_number":72,"context_line":"    kwargs \u003d {\u0027context\u0027: context, \u0027subnet_id\u0027: subnet_id}"},{"line_number":73,"context_line":"    if data is not None:"},{"line_number":74,"context_line":"        kwargs[\u0027data\u0027] \u003d data"},{"line_number":75,"context_line":"    try:"},{"line_number":76,"context_line":"        registry.notify("},{"line_number":77,"context_line":"            resources.SUBNET, action, None, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_a74bfbaf","line":74,"updated":"2015-10-28 01:25:03.000000000","message":"To passing the subnet here, it would be better in this way\n      kwargs[\u0027subnet\u0027] \u003d subnet\npls take [1][2] for reference.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/securitygroups_db.py#L185\n[2] https://github.com/openstack/neutron/blob/master/neutron/agent/l3/agent.py#L333","commit_id":"4aabb91f0e29660e6c36dd3e830f15dee120252d"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"726894aafc598c8d4588c3df7b91f1a84b34d74d","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        s \u003d subnet[\u0027subnet\u0027]"},{"line_number":698,"context_line":"        # Make sure the subnet isn\u0027t used by other resources"},{"line_number":699,"context_line":"        _check_subnet_not_used(context, id, action\u003devents.BEFORE_UPDATE,"},{"line_number":700,"context_line":"                               data\u003ds)"},{"line_number":701,"context_line":"        new_cidr \u003d s.get(\u0027cidr\u0027)"},{"line_number":702,"context_line":"        db_subnet \u003d self._get_subnet(context, id)"},{"line_number":703,"context_line":"        # Fill \u0027ip_version\u0027 and \u0027allocation_pools\u0027 fields with the current"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_c7db97ec","line":700,"updated":"2015-10-28 01:25:03.000000000","message":"You might need to change here according to last comment.","commit_id":"4aabb91f0e29660e6c36dd3e830f15dee120252d"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"dba4a739fdbc68bcf5cba5c9a23fecbb1c835997","unresolved":false,"context_lines":[{"line_number":3985,"context_line":"        with self.subnet() as subnet, \\"},{"line_number":3986,"context_line":"                mock.patch.object(registry, \u0027notify\u0027) as notify:"},{"line_number":3987,"context_line":"            errors \u003d ["},{"line_number":3988,"context_line":"                exceptions.NotificationError(\u0027fake-id\u0027, "},{"line_number":3989,"context_line":"                                             n_exc.NeutronException())"},{"line_number":3990,"context_line":"            ]"},{"line_number":3991,"context_line":"            notify.side_effect \u003d exceptions.CallbackFailure(errors\u003derrors)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_7baf9a94","line":3988,"updated":"2015-10-27 02:33:19.000000000","message":"a extra space here.","commit_id":"599c3c93d1a87c30be2e8327deb52d9b8e66d38e"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"f8b3c32e834a50067bc8e925df68f0ce47e2e654","unresolved":false,"context_lines":[{"line_number":3985,"context_line":"        with self.subnet() as subnet, \\"},{"line_number":3986,"context_line":"                mock.patch.object(registry, \u0027notify\u0027) as notify:"},{"line_number":3987,"context_line":"            errors \u003d ["},{"line_number":3988,"context_line":"                exceptions.NotificationError(\u0027fake-id\u0027, "},{"line_number":3989,"context_line":"                                             n_exc.NeutronException())"},{"line_number":3990,"context_line":"            ]"},{"line_number":3991,"context_line":"            notify.side_effect \u003d exceptions.CallbackFailure(errors\u003derrors)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_f6f89f4b","line":3988,"in_reply_to":"3a29b11f_7baf9a94","updated":"2015-10-27 03:54:42.000000000","message":"remove pep8 warnings","commit_id":"599c3c93d1a87c30be2e8327deb52d9b8e66d38e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"733d8f20cda0c4acf191cf094c7074b480d3d72d","unresolved":false,"context_lines":[{"line_number":3985,"context_line":"        with self.subnet() as subnet, \\"},{"line_number":3986,"context_line":"                mock.patch.object(registry, \u0027notify\u0027) as notify:"},{"line_number":3987,"context_line":"            errors \u003d ["},{"line_number":3988,"context_line":"                exceptions.NotificationError(\u0027fake-id\u0027, "},{"line_number":3989,"context_line":"                                             n_exc.NeutronException())"},{"line_number":3990,"context_line":"            ]"},{"line_number":3991,"context_line":"            notify.side_effect \u003d exceptions.CallbackFailure(errors\u003derrors)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_33bbc810","line":3988,"in_reply_to":"3a29b11f_f6f89f4b","updated":"2015-10-27 06:22:44.000000000","message":"Done","commit_id":"599c3c93d1a87c30be2e8327deb52d9b8e66d38e"}]}
