)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a35b694b2f73c48a7319de0208662b3e2eccbe3b","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-10-26 11:39:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Constrain exception handling in neutron.api.v2.attributes._validate_subnet."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug 1510149."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8678be4d1b7ed7361883c62f4f2008f76a7615c0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a29b11f_f6ff3fa8","line":8,"updated":"2015-10-27 03:34:16.000000000","message":"More details here to explain this patch will be good. Pls take other patches as reference","commit_id":"22eebe1400ffb0009dd4863d555ac735a79b26d0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"29a0a591f96562e4293c324751701a02a25ded9f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Constrain exception handling in neutron.api.v2.attributes._validate_subnet."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug 1510149."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I8678be4d1b7ed7361883c62f4f2008f76a7615c0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a29b11f_54ce335b","line":9,"updated":"2015-10-26 20:53:29.000000000","message":"Uses:\n\n Closes-Bug: #...\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"22eebe1400ffb0009dd4863d555ac735a79b26d0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f1230eab3c1fe41d413235b60ac61fa01a72d22c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Margaret Frances \u003cmargaret_frances@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-29 07:56:35 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Constrain exception handling to the netaddr call in"},{"line_number":8,"context_line":"neutron.api.v2.attributes._validate_subnet. This prevents exceptions that may"},{"line_number":9,"context_line":"occur on unrelated lines from being unintentionally handled."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a26ad4f_0d4e5b96","line":7,"updated":"2015-10-29 13:11:20.000000000","message":"commit lines are really too long (it should be \u003c\u003d72 characters)","commit_id":"56175ca44933951cf26556cf26942cc8e21b1b2f"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"9888d38970deb8ebafdefb3dac2a00714ee1c680","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Margaret Frances \u003cmargaret_frances@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-29 09:54:18 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Constrain exception handling in _validate_subnet function."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Constraining exception handling to the netaddr call in"},{"line_number":10,"context_line":"neutron.api.v2.attributes._validate_subnet prevents exceptions that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba8a016a_67ca7b1c","line":7,"updated":"2015-11-24 07:02:34.000000000","message":"update the test case for the code change.","commit_id":"a53d18e00d2c0cf640e83534e6883fc72ea0cd1f"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"6be391b51fe63437c496d9d604d4ea0ee97fad7a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Margaret Frances \u003cmargaret_frances@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-29 09:54:18 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Constrain exception handling in _validate_subnet function."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Constraining exception handling to the netaddr call in"},{"line_number":10,"context_line":"neutron.api.v2.attributes._validate_subnet prevents exceptions that"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9a8ffd7b_db57e9c8","line":7,"in_reply_to":"ba8a016a_67ca7b1c","updated":"2015-11-24 16:35:01.000000000","message":"I will do that and re-submit.  Thank you!","commit_id":"a53d18e00d2c0cf640e83534e6883fc72ea0cd1f"},{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"a72ab205043735a4b45985e0bbf4ed5bcfb520cf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-10-26 11:38:33 -0400"},{"line_number":4,"context_line":"Commit:     Margaret Frances \u003cmargaret_frances@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 11:14:48 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Constrain exception handling in _validate_subnet function."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Constraining exception handling to the netaddr call in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7a740942_8e8ac219","line":6,"updated":"2015-12-14 12:18:51.000000000","message":"The first line should be limited to 50 characters and should not end with a period.","commit_id":"003bf73d689db7b625e57fd2b03d9b3348e5be44"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"dfe0fbc68fe9dd83f818bb913e59935f3df9f251","unresolved":false,"context_lines":[{"line_number":3,"context_line":"AuthorDate: 2015-10-26 11:38:33 -0400"},{"line_number":4,"context_line":"Commit:     Margaret Frances \u003cmargaret_frances@cable.comcast.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-07 11:14:48 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Constrain exception handling in _validate_subnet function."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Constraining exception handling to the netaddr call in"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da6ed579_900e7a8a","line":6,"in_reply_to":"7a740942_8e8ac219","updated":"2016-03-29 22:35:20.000000000","message":"Done","commit_id":"003bf73d689db7b625e57fd2b03d9b3348e5be44"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"29a0a591f96562e4293c324751701a02a25ded9f","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    try:"},{"line_number":322,"context_line":"        net \u003d netaddr.IPNetwork(_validate_no_whitespace(data))"},{"line_number":323,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":324,"context_line":"        msg \u003d (_(\"\u0027%(data)s\u0027 is not a valid IP subnet\") % {\u0027data\u0027: data})"},{"line_number":325,"context_line":"    except TypeError as e:"},{"line_number":326,"context_line":"        msg \u003d (_(\"This is not a valid IP subnet because: %(reason)s\") %"},{"line_number":327,"context_line":"               {\u0027reason\u0027: str(e)})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_34f8577c","line":324,"updated":"2015-10-26 20:53:29.000000000","message":"It\u0027s a bit overkill to use %(data)s when %s is fine","commit_id":"22eebe1400ffb0009dd4863d555ac735a79b26d0"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"8673b04ccee769400f7109edd044e0a18f630c88","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    try:"},{"line_number":322,"context_line":"        net \u003d netaddr.IPNetwork(_validate_no_whitespace(data))"},{"line_number":323,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":324,"context_line":"        msg \u003d (_(\"\u0027%(data)s\u0027 is not a valid IP subnet\") % {\u0027data\u0027: data})"},{"line_number":325,"context_line":"    except TypeError as e:"},{"line_number":326,"context_line":"        msg \u003d (_(\"This is not a valid IP subnet because: %(reason)s\") %"},{"line_number":327,"context_line":"               {\u0027reason\u0027: str(e)})"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_36ce175b","line":324,"in_reply_to":"3a29b11f_34f8577c","updated":"2015-10-27 03:40:47.000000000","message":"Yes, can use %s","commit_id":"22eebe1400ffb0009dd4863d555ac735a79b26d0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"29a0a591f96562e4293c324751701a02a25ded9f","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        msg \u003d (_(\"\u0027%(data)s\u0027 is not a valid IP subnet\") % {\u0027data\u0027: data})"},{"line_number":325,"context_line":"    except TypeError as e:"},{"line_number":326,"context_line":"        msg \u003d (_(\"This is not a valid IP subnet because: %(reason)s\") %"},{"line_number":327,"context_line":"               {\u0027reason\u0027: str(e)})"},{"line_number":328,"context_line":"    else:"},{"line_number":329,"context_line":"        if \u0027/\u0027 not in data or (net.version \u003d\u003d 4 and str(net) !\u003d data):"},{"line_number":330,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP subnet cidr,\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_b42a27e6","line":327,"updated":"2015-10-26 20:53:29.000000000","message":"itto + you can directly use e instead of str(e) as:\n\n \"%s\" % blah \u003d\u003d str(blah)","commit_id":"22eebe1400ffb0009dd4863d555ac735a79b26d0"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a35b694b2f73c48a7319de0208662b3e2eccbe3b","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    if msg:"},{"line_number":334,"context_line":"        LOG.debug(msg)"},{"line_number":335,"context_line":"        return msg"},{"line_number":336,"context_line":"    else:"},{"line_number":337,"context_line":"        return"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_b68c6736","line":336,"updated":"2015-10-27 03:34:16.000000000","message":"I can\u0027t see any difference of this change except an extra line of code. So, it might be better to keep this line untouched.\nBesides, you should refine the test case for your change.","commit_id":"22eebe1400ffb0009dd4863d555ac735a79b26d0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f1230eab3c1fe41d413235b60ac61fa01a72d22c","unresolved":false,"context_lines":[{"line_number":321,"context_line":"    try:"},{"line_number":322,"context_line":"        net \u003d netaddr.IPNetwork(_validate_no_whitespace(data))"},{"line_number":323,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":324,"context_line":"        msg \u003d (_(\"\u0027%s\u0027 is not a valid IP subnet\") % data)"},{"line_number":325,"context_line":"    except TypeError as e:"},{"line_number":326,"context_line":"        msg \u003d (_(\"This is not a valid IP subnet because: %s\") % e)"},{"line_number":327,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_ed63df18","line":324,"updated":"2015-10-29 13:11:20.000000000","message":"useless braces","commit_id":"56175ca44933951cf26556cf26942cc8e21b1b2f"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f1230eab3c1fe41d413235b60ac61fa01a72d22c","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":324,"context_line":"        msg \u003d (_(\"\u0027%s\u0027 is not a valid IP subnet\") % data)"},{"line_number":325,"context_line":"    except TypeError as e:"},{"line_number":326,"context_line":"        msg \u003d (_(\"This is not a valid IP subnet because: %s\") % e)"},{"line_number":327,"context_line":"    else:"},{"line_number":328,"context_line":"        if \u0027/\u0027 not in data or (net.version \u003d\u003d 4 and str(net) !\u003d data):"},{"line_number":329,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP subnet cidr,\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_ad6de705","line":326,"updated":"2015-10-29 13:11:20.000000000","message":"itto","commit_id":"56175ca44933951cf26556cf26942cc8e21b1b2f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a8bd53013b88dbcba518a69ef24bcd7f1c2b3dde","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":324,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet\") % data"},{"line_number":325,"context_line":"    except TypeError as e:"},{"line_number":326,"context_line":"        msg \u003d _(\"This is not a valid IP subnet because: %s\") % e"},{"line_number":327,"context_line":"    else:"},{"line_number":328,"context_line":"        if \u0027/\u0027 not in data or (net.version \u003d\u003d 4 and str(net) !\u003d data):"},{"line_number":329,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP subnet cidr,\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_601342b9","line":326,"updated":"2015-11-24 07:57:30.000000000","message":"what about other possible exceptions","commit_id":"a53d18e00d2c0cf640e83534e6883fc72ea0cd1f"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"6be391b51fe63437c496d9d604d4ea0ee97fad7a","unresolved":false,"context_lines":[{"line_number":323,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":324,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet\") % data"},{"line_number":325,"context_line":"    except TypeError as e:"},{"line_number":326,"context_line":"        msg \u003d _(\"This is not a valid IP subnet because: %s\") % e"},{"line_number":327,"context_line":"    else:"},{"line_number":328,"context_line":"        if \u0027/\u0027 not in data or (net.version \u003d\u003d 4 and str(net) !\u003d data):"},{"line_number":329,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP subnet cidr,\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_3b3cf592","line":326,"in_reply_to":"ba8a016a_601342b9","updated":"2015-11-24 16:35:01.000000000","message":"I don\u0027t believe other exceptions should be handled here.  Are there specific ones that you believe should?","commit_id":"a53d18e00d2c0cf640e83534e6883fc72ea0cd1f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a8bd53013b88dbcba518a69ef24bcd7f1c2b3dde","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                                                     \"cidr\": net.cidr}"},{"line_number":332,"context_line":"    if msg:"},{"line_number":333,"context_line":"        LOG.debug(msg)"},{"line_number":334,"context_line":"        return msg"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"def _validate_subnet_list(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_8031865c","line":334,"updated":"2015-11-24 07:57:30.000000000","message":"why this change?","commit_id":"a53d18e00d2c0cf640e83534e6883fc72ea0cd1f"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"6be391b51fe63437c496d9d604d4ea0ee97fad7a","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                                                     \"cidr\": net.cidr}"},{"line_number":332,"context_line":"    if msg:"},{"line_number":333,"context_line":"        LOG.debug(msg)"},{"line_number":334,"context_line":"        return msg"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"def _validate_subnet_list(data, valid_values\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_1b5ed1e9","line":334,"in_reply_to":"ba8a016a_8031865c","updated":"2015-11-24 16:35:01.000000000","message":"Thank you!  I think this change was in error and I\u0027ll fix it.","commit_id":"a53d18e00d2c0cf640e83534e6883fc72ea0cd1f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7a495100dba1b7421a1753de91886cd9a4320a51","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    msg \u003d None"},{"line_number":321,"context_line":"    try:"},{"line_number":322,"context_line":"        net \u003d netaddr.IPNetwork(_validate_no_whitespace(data))"},{"line_number":323,"context_line":"    except n_exc.InvalidInput:"},{"line_number":324,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet because it contains\""},{"line_number":325,"context_line":"                \" whitespace\") % data"},{"line_number":326,"context_line":"    except netaddr.core.AddrFormatError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_27e3e9a5","line":323,"updated":"2016-01-05 18:55:14.000000000","message":"Should have test cases for all four conditions that are being caught here.","commit_id":"003bf73d689db7b625e57fd2b03d9b3348e5be44"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"dfe0fbc68fe9dd83f818bb913e59935f3df9f251","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    msg \u003d None"},{"line_number":321,"context_line":"    try:"},{"line_number":322,"context_line":"        net \u003d netaddr.IPNetwork(_validate_no_whitespace(data))"},{"line_number":323,"context_line":"    except n_exc.InvalidInput:"},{"line_number":324,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet because it contains\""},{"line_number":325,"context_line":"                \" whitespace\") % data"},{"line_number":326,"context_line":"    except netaddr.core.AddrFormatError:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba0121b8_0ce1dcd0","line":323,"in_reply_to":"fa69d971_27e3e9a5","updated":"2016-03-29 22:35:20.000000000","message":"Thank you.  I\u0027ll do that.","commit_id":"003bf73d689db7b625e57fd2b03d9b3348e5be44"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"eab51cfbccd0beaebb71ddd2c49ab94035e8eae8","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        net \u003d netaddr.IPNetwork(_validate_no_whitespace(data))"},{"line_number":323,"context_line":"    except n_exc.InvalidInput:"},{"line_number":324,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet because it contains\""},{"line_number":325,"context_line":"                \" whitespace\") % data"},{"line_number":326,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":327,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet\") % data"},{"line_number":328,"context_line":"    except TypeError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_f6ea7473","line":325,"updated":"2015-12-07 23:42:11.000000000","message":"In L163-164, debug shows \"\u0027%(data)s\u0027 contains whitespace\" so the message(because it contains whitespace) is duplicated.","commit_id":"003bf73d689db7b625e57fd2b03d9b3348e5be44"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"dfe0fbc68fe9dd83f818bb913e59935f3df9f251","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        net \u003d netaddr.IPNetwork(_validate_no_whitespace(data))"},{"line_number":323,"context_line":"    except n_exc.InvalidInput:"},{"line_number":324,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet because it contains\""},{"line_number":325,"context_line":"                \" whitespace\") % data"},{"line_number":326,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":327,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet\") % data"},{"line_number":328,"context_line":"    except TypeError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_50256206","line":325,"in_reply_to":"7a740942_ae3d252c","updated":"2016-03-29 22:35:20.000000000","message":"Done.  Thank you!","commit_id":"003bf73d689db7b625e57fd2b03d9b3348e5be44"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e7960b0e6a8de1c05e7e422bab62829bec25086c","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        net \u003d netaddr.IPNetwork(_validate_no_whitespace(data))"},{"line_number":323,"context_line":"    except n_exc.InvalidInput:"},{"line_number":324,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet because it contains\""},{"line_number":325,"context_line":"                \" whitespace\") % data"},{"line_number":326,"context_line":"    except netaddr.core.AddrFormatError:"},{"line_number":327,"context_line":"        msg \u003d _(\"\u0027%s\u0027 is not a valid IP subnet\") % data"},{"line_number":328,"context_line":"    except TypeError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_ae3d252c","line":325,"in_reply_to":"7a740942_f6ea7473","updated":"2015-12-09 06:06:40.000000000","message":"Agreed with Hirofumi, you should consider using message in exception, instead of creating a new msg here.","commit_id":"003bf73d689db7b625e57fd2b03d9b3348e5be44"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"e88e9ef30758708c76e54615eb1112343b3ea34e","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    except TypeError as e:"},{"line_number":329,"context_line":"        msg \u003d _(\"\u0027%(data)s\u0027 is not a valid IP subnet because:\""},{"line_number":330,"context_line":"                \" %(reason)s\") % {\"data\": data,"},{"line_number":331,"context_line":"                                  \"reason\": e}"},{"line_number":332,"context_line":"    else:"},{"line_number":333,"context_line":"        if \u0027/\u0027 not in data or (net.version \u003d\u003d 4 and str(net) !\u003d data):"},{"line_number":334,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP subnet cidr,\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_1575d362","line":331,"range":{"start_line":331,"start_character":34,"end_line":331,"end_character":45},"updated":"2016-01-05 04:56:53.000000000","message":"I think \"expected string or buffer\" is not a good reason, maybe \"input is not a string or buffer\" is better","commit_id":"003bf73d689db7b625e57fd2b03d9b3348e5be44"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"dfe0fbc68fe9dd83f818bb913e59935f3df9f251","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    except TypeError as e:"},{"line_number":329,"context_line":"        msg \u003d _(\"\u0027%(data)s\u0027 is not a valid IP subnet because:\""},{"line_number":330,"context_line":"                \" %(reason)s\") % {\"data\": data,"},{"line_number":331,"context_line":"                                  \"reason\": e}"},{"line_number":332,"context_line":"    else:"},{"line_number":333,"context_line":"        if \u0027/\u0027 not in data or (net.version \u003d\u003d 4 and str(net) !\u003d data):"},{"line_number":334,"context_line":"            msg \u003d _(\"\u0027%(data)s\u0027 isn\u0027t a recognized IP subnet cidr,\""}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_f01fb6b4","line":331,"range":{"start_line":331,"start_character":34,"end_line":331,"end_character":45},"in_reply_to":"fa69d971_1575d362","updated":"2016-03-29 22:35:20.000000000","message":"Done.  Thank you!","commit_id":"003bf73d689db7b625e57fd2b03d9b3348e5be44"}]}
