)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"fd92c6874514202cd0df846966ac85e53f88076b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixes Hyper-V agent issue with mixed network types"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixes bug: bug/1153274"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Due to a bug in setting up external ports the Hyper-V agent fails to work in"},{"line_number":12,"context_line":"scenarios with VLAN and flat networks."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAN3%2F%2F1Qs%3D","line":9,"updated":"2013-03-10 22:00:59.000000000","message":"nit remove: and  / so that bug is linked to launchpad.","commit_id":"d040af9fb4d0ea75ae2e4b0710b2b59ac899380a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"fd92c6874514202cd0df846966ac85e53f88076b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"scenarios with VLAN and flat networks."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Furthermore, a warning message on Hyper-V 2012 indicates that external"},{"line_number":15,"context_line":"port settings are ignored. As a result the agent can be semplified by"},{"line_number":16,"context_line":"avoiding vswitch external ports configurations."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I860d22f427cb10dbeac422c1db2b3bcf9e84150f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAN3%2F%2F1P8%3D","line":15,"updated":"2013-03-10 22:35:53.000000000","message":"simplified","commit_id":"18e1bbb5aed059148d75a8c9e2d4cce8244926a2"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"unresolved":false,"context_lines":[{"line_number":12,"context_line":"scenarios with VLAN and flat networks."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Furthermore, a warning message on Hyper-V 2012 indicates that external"},{"line_number":15,"context_line":"port settings are ignored. As a result the agent can be semplified by"},{"line_number":16,"context_line":"avoiding vswitch external ports configurations."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I860d22f427cb10dbeac422c1db2b3bcf9e84150f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAN3%2F%2F1N0%3D","line":15,"in_reply_to":"AAAAN3%2F%2F1P8%3D","updated":"2013-03-11 00:34:58.000000000","message":"Done","commit_id":"18e1bbb5aed059148d75a8c9e2d4cce8244926a2"}],"quantum/plugins/hyperv/agent/hyperv_quantum_agent.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"fd92c6874514202cd0df846966ac85e53f88076b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        vswitch_name \u003d self._get_vswitch_name(network_type, physical_network)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"},{"line_number":156,"context_line":"            #Nothing to do"},{"line_number":157,"context_line":"            pass"},{"line_number":158,"context_line":"        elif network_type \u003d\u003d constants.TYPE_LOCAL:"},{"line_number":159,"context_line":"            #TODO (alexpilotti): Check that the switch type is private"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F1Q0%3D","line":156,"updated":"2013-03-10 21:59:34.000000000","message":"nit: I don\u0027t think this commit adds anything as pass is pretty much do nothing.  Also why pass? Why not raise utils.HyperVException? If you pass it seems this will fail silently?","commit_id":"d040af9fb4d0ea75ae2e4b0710b2b59ac899380a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"fd92c6874514202cd0df846966ac85e53f88076b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        vswitch_name \u003d self._get_vswitch_name(network_type, physical_network)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"},{"line_number":156,"context_line":"            #Nothing to do"},{"line_number":157,"context_line":"            pass"},{"line_number":158,"context_line":"        elif network_type \u003d\u003d constants.TYPE_LOCAL:"},{"line_number":159,"context_line":"            #TODO (alexpilotti): Check that the switch type is private"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F1Pw%3D","line":156,"updated":"2013-03-10 22:36:48.000000000","message":"i still have the same question i asked about this.","commit_id":"18e1bbb5aed059148d75a8c9e2d4cce8244926a2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"fd92c6874514202cd0df846966ac85e53f88076b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        vswitch_name \u003d self._get_vswitch_name(network_type, physical_network)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"},{"line_number":156,"context_line":"            #Nothing to do"},{"line_number":157,"context_line":"            pass"},{"line_number":158,"context_line":"        elif network_type \u003d\u003d constants.TYPE_LOCAL:"},{"line_number":159,"context_line":"            #TODO (alexpilotti): Check that the switch type is private"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F1PY%3D","line":156,"in_reply_to":"AAAAN3%2F%2F1Pk%3D","updated":"2013-03-10 22:46:21.000000000","message":"gotcha thx","commit_id":"18e1bbb5aed059148d75a8c9e2d4cce8244926a2"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"unresolved":false,"context_lines":[{"line_number":153,"context_line":"        vswitch_name \u003d self._get_vswitch_name(network_type, physical_network)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"        if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"},{"line_number":156,"context_line":"            #Nothing to do"},{"line_number":157,"context_line":"            pass"},{"line_number":158,"context_line":"        elif network_type \u003d\u003d constants.TYPE_LOCAL:"},{"line_number":159,"context_line":"            #TODO (alexpilotti): Check that the switch type is private"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F1Pk%3D","line":156,"in_reply_to":"AAAAN3%2F%2F1Pw%3D","updated":"2013-03-10 22:43:03.000000000","message":"TYPE_VLAN and TYPE_FLAT are perfectly valid values here. Previously we were attaching the VLAN ID to the external port of the vswitch, now it\u0027s not necessary. Unlike TYPE_LOCAL and TYPE_NVGRE (to be added for Havana) there\u0027s nothing to do for those types. I could rephrase the \"if\" to avoid the \"pass\" but this way it the intention looks IMO more clear.","commit_id":"18e1bbb5aed059148d75a8c9e2d4cce8244926a2"}]}