)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"26dda81c35b6859881889aeb9f68b4659c69c947","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    neutron-sanity-check --config-file /etc/neutron/neutron.conf"},{"line_number":17,"context_line":"    --config-file /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DocImpact"},{"line_number":20,"context_line":"Closes-Bug: #1510680"},{"line_number":21,"context_line":"Change-Id: I2b9d6b13087a970bb0919a8217e428ce60d6e0c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_c9396cf4","line":19,"updated":"2015-11-13 01:20:22.000000000","message":"What for? I guess that this patch doesn\u0027t include anything should\nbe documented.","commit_id":"5b15306405afd98df4b1305d0d1e5e7b94cc1311"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5b26515d2d7bc64f3e12588079b5add24f231021","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    neutron-sanity-check --config-file /etc/neutron/neutron.conf"},{"line_number":17,"context_line":"    --config-file /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"DocImpact"},{"line_number":20,"context_line":"Closes-Bug: #1510680"},{"line_number":21,"context_line":"Change-Id: I2b9d6b13087a970bb0919a8217e428ce60d6e0c3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_7f7b522a","line":19,"in_reply_to":"da85f559_c9396cf4","updated":"2015-11-13 02:08:16.000000000","message":"I\u0027m not sure whether need add this change to docs, so I use DocImpact. If not, I will remove.","commit_id":"5b15306405afd98df4b1305d0d1e5e7b94cc1311"}],"neutron/agent/linux/ipset_manager.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d7769245f18990cfefa2914bbb17c886daa1fdf0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if cfg.CONF.SECURITYGROUP.enable_ipset:"},{"line_number":45,"context_line":"            self._check_ipset_support()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _check_ipset_support(self):"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            self.execute([\u0027ipset\u0027, \u0027--version\u0027], check_exit_code\u003dTrue)"},{"line_number":50,"context_line":"        except OSError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_7e92a1f7","line":47,"updated":"2015-11-12 12:10:36.000000000","message":"IMO, we should add sanity check (if it doesn\u0027t exists) instead of a runtime check","commit_id":"62179f3bbd53679bf20be83a7e72fb8002bbb91c"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"8bf56b02e8ef76ef988fd9bed72638683eb118bc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if cfg.CONF.SECURITYGROUP.enable_ipset:"},{"line_number":45,"context_line":"            self._check_ipset_support()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _check_ipset_support(self):"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            self.execute([\u0027ipset\u0027, \u0027--version\u0027], check_exit_code\u003dTrue)"},{"line_number":50,"context_line":"        except OSError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_841cd46a","line":47,"in_reply_to":"da85f559_09c9ddab","updated":"2015-11-12 12:25:03.000000000","message":"THX","commit_id":"62179f3bbd53679bf20be83a7e72fb8002bbb91c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"19f18ac7e6da0cccd93bed7de0cf1e8763f5fdb3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if cfg.CONF.SECURITYGROUP.enable_ipset:"},{"line_number":45,"context_line":"            self._check_ipset_support()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _check_ipset_support(self):"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            self.execute([\u0027ipset\u0027, \u0027--version\u0027], check_exit_code\u003dTrue)"},{"line_number":50,"context_line":"        except OSError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_09c9ddab","line":47,"in_reply_to":"da85f559_7e92a1f7","updated":"2015-11-12 12:21:02.000000000","message":"I agree with Cedric.\n\nIf you want runtime check, please add UT (but I don\u0027t prefer the check...)","commit_id":"62179f3bbd53679bf20be83a7e72fb8002bbb91c"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"8bf56b02e8ef76ef988fd9bed72638683eb118bc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        if cfg.CONF.SECURITYGROUP.enable_ipset:"},{"line_number":45,"context_line":"            self._check_ipset_support()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def _check_ipset_support(self):"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            self.execute([\u0027ipset\u0027, \u0027--version\u0027], check_exit_code\u003dTrue)"},{"line_number":50,"context_line":"        except OSError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_c90f5535","line":47,"in_reply_to":"da85f559_7e92a1f7","updated":"2015-11-12 12:25:03.000000000","message":"THX, I will add.","commit_id":"62179f3bbd53679bf20be83a7e72fb8002bbb91c"}],"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":12000,"name":"Ian Cordasco","email":"sigmavirus24@gmail.com","username":"sigmavirus24"},"change_message_id":"4f477072b81db8e445042534b66365cff30bf222","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import collections"},{"line_number":17,"context_line":"from distutils import spawn"},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"import re"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_b3919d9b","line":16,"updated":"2015-10-30 16:38:25.000000000","message":"So these imports need to look like the following:\n\n    import collections\n    import distutils\n    import re\n    import sys\n\n    import netaddr\n    from oslo_config import cfg\n    from oslo_log import log as logging\n    import six\n\n    from neutron.agent import firewall\n    # etc.\n\nBecause OpenStack only ever allows for modules to be imported and they have to be grouped in the following manner:\n\n    standard library imports (alphabetized)\n\n    third party imports (alphabetized)\n\n    project imports (alphabetized)\n\nPlease fix these. Fixing this should also fix the pep8 gate job. You can test that this fixes them by running\n\n    tox -e pep8\n\nLocally","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0aa3ca393b6d532c1e42ca9ece2a2e9fd09e2eac","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            namespace\u003dnamespace)"},{"line_number":71,"context_line":"        # TODO(majopela, shihanzhang): refactor out ipset to a separate"},{"line_number":72,"context_line":"        # driver composed over this one"},{"line_number":73,"context_line":"        self.enable_ipset \u003d cfg.CONF.SECURITYGROUP.enable_ipset"},{"line_number":74,"context_line":"        if self.enable_ipset:"},{"line_number":75,"context_line":"            self._validate_ipset_support()"},{"line_number":76,"context_line":"        self.ipset \u003d ipset_manager.IpsetManager(namespace\u003dnamespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_e509a6de","line":73,"updated":"2015-10-30 01:29:03.000000000","message":"TODO should be with its code. Now it seems like they are separated.","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5db34a22cb9685331da56c23f3a897a88e39e0e2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            namespace\u003dnamespace)"},{"line_number":71,"context_line":"        # TODO(majopela, shihanzhang): refactor out ipset to a separate"},{"line_number":72,"context_line":"        # driver composed over this one"},{"line_number":73,"context_line":"        self.enable_ipset \u003d cfg.CONF.SECURITYGROUP.enable_ipset"},{"line_number":74,"context_line":"        if self.enable_ipset:"},{"line_number":75,"context_line":"            self._validate_ipset_support()"},{"line_number":76,"context_line":"        self.ipset \u003d ipset_manager.IpsetManager(namespace\u003dnamespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_e51c4679","line":73,"in_reply_to":"1a26ad4f_e509a6de","updated":"2015-10-30 01:45:38.000000000","message":"@Hong Hui, Currently I had not seen the refactor in master.","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"69b9689bcd8d180d6d9490a105e51bb9d9d83359","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            namespace\u003dnamespace)"},{"line_number":71,"context_line":"        # TODO(majopela, shihanzhang): refactor out ipset to a separate"},{"line_number":72,"context_line":"        # driver composed over this one"},{"line_number":73,"context_line":"        self.enable_ipset \u003d cfg.CONF.SECURITYGROUP.enable_ipset"},{"line_number":74,"context_line":"        if self.enable_ipset:"},{"line_number":75,"context_line":"            self._validate_ipset_support()"},{"line_number":76,"context_line":"        self.ipset \u003d ipset_manager.IpsetManager(namespace\u003dnamespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_1330b59d","line":73,"in_reply_to":"1a26ad4f_e51c4679","updated":"2015-11-05 08:28:18.000000000","message":"+1, TODO should be with its original code.","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5a62ba8bd9b1725db3a559a89f73bc28967d45d3","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            namespace\u003dnamespace)"},{"line_number":71,"context_line":"        # TODO(majopela, shihanzhang): refactor out ipset to a separate"},{"line_number":72,"context_line":"        # driver composed over this one"},{"line_number":73,"context_line":"        self.enable_ipset \u003d cfg.CONF.SECURITYGROUP.enable_ipset"},{"line_number":74,"context_line":"        if self.enable_ipset:"},{"line_number":75,"context_line":"            self._validate_ipset_support()"},{"line_number":76,"context_line":"        self.ipset \u003d ipset_manager.IpsetManager(namespace\u003dnamespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_f5594e5b","line":73,"in_reply_to":"fa80f949_1330b59d","updated":"2015-11-05 12:23:52.000000000","message":"Done","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"69b9689bcd8d180d6d9490a105e51bb9d9d83359","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.devices_with_udpated_sg_members \u003d collections.defaultdict(list)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _validate_ipset_support(self):"},{"line_number":100,"context_line":"        if not spawn.find_executable(\"ipset\"):"},{"line_number":101,"context_line":"            LOG.error(_LE(\"ipset utility not exist on the host you running, \""},{"line_number":102,"context_line":"                          \"Please check and install.\"))"},{"line_number":103,"context_line":"            sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_3377f93b","line":100,"updated":"2015-11-05 08:28:18.000000000","message":"In other scenario, when we test the validation of an external command, we just run the command and catch the exception to check its availability and also its version.\n\nYou can see examples in linuxbridge-agent.\n\nI suggest you follow this method.","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5a62ba8bd9b1725db3a559a89f73bc28967d45d3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.devices_with_udpated_sg_members \u003d collections.defaultdict(list)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _validate_ipset_support(self):"},{"line_number":100,"context_line":"        if not spawn.find_executable(\"ipset\"):"},{"line_number":101,"context_line":"            LOG.error(_LE(\"ipset utility not exist on the host you running, \""},{"line_number":102,"context_line":"                          \"Please check and install.\"))"},{"line_number":103,"context_line":"            sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_75455e6e","line":100,"in_reply_to":"fa80f949_3377f93b","updated":"2015-11-05 12:23:52.000000000","message":"agree, thx.","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0aa3ca393b6d532c1e42ca9ece2a2e9fd09e2eac","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _validate_ipset_support(self):"},{"line_number":100,"context_line":"        if not spawn.find_executable(\"ipset\"):"},{"line_number":101,"context_line":"            LOG.error(_LE(\"ipset utility not exist on the host you running, \""},{"line_number":102,"context_line":"                          \"Please check and install.\"))"},{"line_number":103,"context_line":"            sys.exit(1)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_65927659","line":101,"updated":"2015-10-30 01:29:03.000000000","message":"English is not my native language, but it looks like the message should be refined.\nFor example: \"ipset utility does not exist on the host that you are running, please *******\"","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"623f34d0f3066607706b2d28bf048f7744bec9c9","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _validate_ipset_support(self):"},{"line_number":100,"context_line":"        if not spawn.find_executable(\"ipset\"):"},{"line_number":101,"context_line":"            LOG.error(_LE(\"ipset utility not exist on the host you running, \""},{"line_number":102,"context_line":"                          \"Please check and install.\"))"},{"line_number":103,"context_line":"            sys.exit(1)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_9be37405","line":101,"updated":"2015-10-30 02:54:36.000000000","message":"Wording suggestion:\n\nConfiguration requires IPSet, but \u0027ipset\u0027 utility missing on host.","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"5db34a22cb9685331da56c23f3a897a88e39e0e2","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _validate_ipset_support(self):"},{"line_number":100,"context_line":"        if not spawn.find_executable(\"ipset\"):"},{"line_number":101,"context_line":"            LOG.error(_LE(\"ipset utility not exist on the host you running, \""},{"line_number":102,"context_line":"                          \"Please check and install.\"))"},{"line_number":103,"context_line":"            sys.exit(1)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_25031e11","line":101,"in_reply_to":"1a26ad4f_65927659","updated":"2015-10-30 01:45:38.000000000","message":"Thx, -:)","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"b3ab5706818c31bf92cac50d6da50c500afa91db","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _validate_ipset_support(self):"},{"line_number":100,"context_line":"        if not spawn.find_executable(\"ipset\"):"},{"line_number":101,"context_line":"            LOG.error(_LE(\"ipset utility not exist on the host you running, \""},{"line_number":102,"context_line":"                          \"Please check and install.\"))"},{"line_number":103,"context_line":"            sys.exit(1)"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_d4645623","line":101,"in_reply_to":"1a26ad4f_9be37405","updated":"2015-10-30 05:09:23.000000000","message":"Thx, -:)","commit_id":"54178c5dd2943c49a482d2d7d741c85e84036df1"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a66991f10a3aca8c81e37b911429d04ac5b2aaf5","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        cmd \u003d [\u0027ipset\u0027, \u0027--version\u0027]"},{"line_number":349,"context_line":"        agent_utils.execute(cmd)"},{"line_number":350,"context_line":"        return True"},{"line_number":351,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":352,"context_line":"        LOG.debug(\"Exception while checking for installed ipset. \""},{"line_number":353,"context_line":"                  \"Exception: %s\", e)"},{"line_number":354,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_cfe2bd9f","line":351,"updated":"2015-11-16 19:42:30.000000000","message":"I\u0027m not sure what would cause all of these exceptions.  I\u0027d almost rather just catch Exception and report whatever it is below.","commit_id":"a3f7d795b64ef913814afb9d9e17f3449a85fd3e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a66991f10a3aca8c81e37b911429d04ac5b2aaf5","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        agent_utils.execute(cmd)"},{"line_number":350,"context_line":"        return True"},{"line_number":351,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":352,"context_line":"        LOG.debug(\"Exception while checking for installed ipset. \""},{"line_number":353,"context_line":"                  \"Exception: %s\", e)"},{"line_number":354,"context_line":"        return False"},{"line_number":355,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_ef7c6122","line":352,"updated":"2015-11-16 19:42:30.000000000","message":"Why not use LOG.exception?","commit_id":"a3f7d795b64ef913814afb9d9e17f3449a85fd3e"}],"neutron/tests/functional/sanity/test_sanity.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a66991f10a3aca8c81e37b911429d04ac5b2aaf5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        checks.dibbler_version_supported()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def test_ipset_support(self):"},{"line_number":42,"context_line":"        checks.ipset_supported()"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class SanityTestCaseRoot(functional_base.BaseSudoTestCase):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_2fb6e98a","line":42,"updated":"2015-11-16 19:42:30.000000000","message":"This just runs the code.  It doesn\u0027t really test any of the behavior.","commit_id":"a3f7d795b64ef913814afb9d9e17f3449a85fd3e"}]}
