)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e7caa32a26df1dc38e0d75f597a58f790374855e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"reload configuration and restart. This functionality, including"},{"line_number":11,"context_line":"defining signal handler, is defined by oslo.service."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Meanwhile, this is currently not so for l3 agent. PrefixDelegation"},{"line_number":14,"context_line":"class that is instantiated in L3NATAgent overrides handler for SIGHUP,"},{"line_number":15,"context_line":"thus removing handler that was set in oslo.service."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da85f559_3a3165ed","line":13,"updated":"2015-11-06 22:29:41.000000000","message":"I guess I should take some of the responsibility for this.  I had suggested using a different signal while reviewing the PD code but did not follow up on it.\n\nI still think that PD should use a different signal.  I\u0027d rather not have config reset (could be expensive) mixed with loading a new prefix by PD.","commit_id":"f37be0381856ef19291d91fa992e33d2d426f5f3"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"6410d0102ba070ccbae1d455792200f0de028955","unresolved":false,"context_lines":[{"line_number":10,"context_line":"reload configuration and restart. This functionality, including"},{"line_number":11,"context_line":"defining signal handler, is defined by oslo.service."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Meanwhile, this is currently not so for l3 agent. PrefixDelegation"},{"line_number":14,"context_line":"class that is instantiated in L3NATAgent overrides handler for SIGHUP,"},{"line_number":15,"context_line":"thus removing handler that was set in oslo.service."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da85f559_ce1f295a","line":13,"in_reply_to":"da85f559_3a3165ed","updated":"2015-11-08 12:31:33.000000000","message":"@Carol -  SIGUSR1 or SIGUSR2 ?","commit_id":"f37be0381856ef19291d91fa992e33d2d426f5f3"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"a220dd97a6b3d7f27cf7177a8e89de11735625e1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"reload configuration and restart. This functionality, including"},{"line_number":11,"context_line":"defining signal handler, is defined by oslo.service."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Meanwhile, this is currently not so for l3 agent. PrefixDelegation"},{"line_number":14,"context_line":"class that is instantiated in L3NATAgent overrides handler for SIGHUP,"},{"line_number":15,"context_line":"thus removing handler that was set in oslo.service."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da85f559_191a0f6f","line":13,"in_reply_to":"da85f559_ce1f295a","updated":"2015-11-10 09:53:50.000000000","message":"Thank you for suggestion, Carl! I agree that it would be better not to mix resetting a service with loading a new prefix.\n\nAs for a signal, I think we can pick SIGUSR1 as it isn\u0027t used neither in neutron nor in oslo.service.","commit_id":"f37be0381856ef19291d91fa992e33d2d426f5f3"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a644ff3de55b162ba31341c308ec3953d9e48a8c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Elena Ezhova \u003ceezhova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-10 15:30:59 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use SIGUSR1 to notify l3 agent of changing prefix file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is common for all OpenStack services to use SIGHUP signal to"},{"line_number":10,"context_line":"reload configuration and restart. This functionality, including"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_ead626f0","line":7,"updated":"2015-11-10 21:09:02.000000000","message":"If we decide to neutron-l3-agent with apache + mod_wsgi, USR1 signal will by default never reach the l3-agent application[1] ... is it a good idea to use this signal?\n\n[1] https://code.google.com/p/modwsgi/wiki/ApplicationIssues#Registration_Of_Signal_Handlers","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"9814e7d3b2b941225af7993730bbab0d0cd9ac28","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Elena Ezhova \u003ceezhova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-10 15:30:59 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use SIGUSR1 to notify l3 agent of changing prefix file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is common for all OpenStack services to use SIGHUP signal to"},{"line_number":10,"context_line":"reload configuration and restart. This functionality, including"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_0c54d4c7","line":7,"updated":"2015-11-11 09:08:19.000000000","message":"In fact I would question Carl\u0027s idea of using separate signal for PD change.\nWhy is it necessary?","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"82986cf3e405e5a79b3b40a5dc516f6b666a3f1f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Elena Ezhova \u003ceezhova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-10 15:30:59 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use SIGUSR1 to notify l3 agent of changing prefix file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is common for all OpenStack services to use SIGHUP signal to"},{"line_number":10,"context_line":"reload configuration and restart. This functionality, including"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_6202493f","line":7,"in_reply_to":"da85f559_0c54d4c7","updated":"2015-11-11 10:20:50.000000000","message":"AFAIK, mod_wsgi is commonly used to run API services, so I second Eugene\u0027s question.","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"a4c43fa0a9b597b3f9544e049682fde1dae54fcb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Elena Ezhova \u003ceezhova@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-10 15:30:59 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use SIGUSR1 to notify l3 agent of changing prefix file"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It is common for all OpenStack services to use SIGHUP signal to"},{"line_number":10,"context_line":"reload configuration and restart. This functionality, including"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_2c8c387e","line":7,"in_reply_to":"da85f559_ead626f0","updated":"2015-11-11 09:07:18.000000000","message":"how does mod_wsgi relate to an agent?","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"}],"neutron/agent/linux/pd.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a644ff3de55b162ba31341c308ec3953d9e48a8c","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        signal.signal(signal.SIGUSR1, self._handle_sigusr1)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def _handle_sigusr1(self, signum, frame):"},{"line_number":286,"context_line":"        # The external DHCPv6 client uses SIGUSR1 to notify agent"},{"line_number":287,"context_line":"        #  of prefix changes."},{"line_number":288,"context_line":"        self.pd_update_cb()"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_0afb6a7a","line":286,"updated":"2015-11-10 21:09:02.000000000","message":"Prefer a docstring over a comment","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"82986cf3e405e5a79b3b40a5dc516f6b666a3f1f","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        signal.signal(signal.SIGUSR1, self._handle_sigusr1)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def _handle_sigusr1(self, signum, frame):"},{"line_number":286,"context_line":"        # The external DHCPv6 client uses SIGUSR1 to notify agent"},{"line_number":287,"context_line":"        #  of prefix changes."},{"line_number":288,"context_line":"        self.pd_update_cb()"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_1d196079","line":286,"in_reply_to":"da85f559_0afb6a7a","updated":"2015-11-11 10:20:50.000000000","message":"You pointed out that amending a condition in test_server is unrelated and should be done in a separate patch, so how is the case with changing comment to docstring different?","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"},{"author":{"_account_id":14591,"name":"Lubosz Kosnik (diltram)","email":"lubosz.kosnik@intel.com","username":"diltram"},"change_message_id":"0e825352049a9ea758a44c5ac8dd25215e4ca590","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        signal.signal(signal.SIGUSR1, self._handle_sigusr1)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def _handle_sigusr1(self, signum, frame):"},{"line_number":286,"context_line":"        # The external DHCPv6 client uses SIGUSR1 to notify agent"},{"line_number":287,"context_line":"        #  of prefix changes."},{"line_number":288,"context_line":"        self.pd_update_cb()"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_59fe9206","line":286,"updated":"2015-11-13 13:51:32.000000000","message":"You changed that code and using docstring is better idea because it\u0027s visible when you use it thru IDE","commit_id":"1c2a3978f3deaaee6c26b393be2d6e476da2e498"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"7c2d6ecb7669b4526ea2f2417c18fd7a3c37640d","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        signal.signal(signal.SIGUSR1, self._handle_sigusr1)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def _handle_sigusr1(self, signum, frame):"},{"line_number":286,"context_line":"        # The external DHCPv6 client uses SIGUSR1 to notify agent"},{"line_number":287,"context_line":"        #  of prefix changes."},{"line_number":288,"context_line":"        self.pd_update_cb()"},{"line_number":289,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_05f659d7","line":286,"in_reply_to":"da85f559_59fe9206","updated":"2015-11-13 14:58:06.000000000","message":"Done","commit_id":"1c2a3978f3deaaee6c26b393be2d6e476da2e498"}],"neutron/service.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"75b76e34b1b224652c7ae50edeab419b39e6ec4d","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def reset(self):"},{"line_number":350,"context_line":"        config.reset_service()"},{"line_number":351,"context_line":"        if hasattr(self.manager, \u0027reset\u0027):"},{"line_number":352,"context_line":"            self.manager.reset()"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def periodic_tasks(self, raise_on_error\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_1bde723f","line":351,"updated":"2015-11-05 18:30:27.000000000","message":"We could avoid this test by defining a dummy neutron.manager.Manager.reset?","commit_id":"44d87558466b24b570605c6a9136d59532944d53"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"500228d7842109f70dd401546c1058bfa53d4e21","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def reset(self):"},{"line_number":350,"context_line":"        config.reset_service()"},{"line_number":351,"context_line":"        if hasattr(self.manager, \u0027reset\u0027):"},{"line_number":352,"context_line":"            self.manager.reset()"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def periodic_tasks(self, raise_on_error\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_bdce282c","line":351,"in_reply_to":"fa80f949_1bde723f","updated":"2015-11-06 07:45:40.000000000","message":"Good idea, thanks.","commit_id":"44d87558466b24b570605c6a9136d59532944d53"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"e7caa32a26df1dc38e0d75f597a58f790374855e","unresolved":false,"context_lines":[{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def reset(self):"},{"line_number":350,"context_line":"        config.reset_service()"},{"line_number":351,"context_line":"        self.manager.reset()"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"    def periodic_tasks(self, raise_on_error\u003dFalse):"},{"line_number":354,"context_line":"        \"\"\"Tasks to be run at a periodic interval.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_5aaf89e3","line":351,"updated":"2015-11-06 22:29:41.000000000","message":"I\u0027d really rather these two not be mixed.  I\u0027d much rather PD use a different signal or a different channel even.","commit_id":"f37be0381856ef19291d91fa992e33d2d426f5f3"}],"neutron/tests/functional/agent/test_l3_agent.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a644ff3de55b162ba31341c308ec3953d9e48a8c","unresolved":false,"context_lines":[{"line_number":927,"context_line":"class TestL3AgentRestart(test_service.TestServiceRestart,"},{"line_number":928,"context_line":"                         L3AgentTestFramework):"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    def setUp(self):"},{"line_number":931,"context_line":"        super(TestL3AgentRestart, self).setUp()"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"    def _start_l3_agent(self, workers\u003d1):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_0a428aae","line":930,"updated":"2015-11-10 21:09:02.000000000","message":"useless","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"82986cf3e405e5a79b3b40a5dc516f6b666a3f1f","unresolved":false,"context_lines":[{"line_number":927,"context_line":"class TestL3AgentRestart(test_service.TestServiceRestart,"},{"line_number":928,"context_line":"                         L3AgentTestFramework):"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    def setUp(self):"},{"line_number":931,"context_line":"        super(TestL3AgentRestart, self).setUp()"},{"line_number":932,"context_line":""},{"line_number":933,"context_line":"    def _start_l3_agent(self, workers\u003d1):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_bd4ff469","line":930,"in_reply_to":"da85f559_0a428aae","updated":"2015-11-11 10:20:50.000000000","message":"Thanks, will remove","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"}],"neutron/tests/functional/test_server.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a644ff3de55b162ba31341c308ec3953d9e48a8c","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.service_pid \u003d pid"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # If number of workers is 0 or 1 it is assumed that we run"},{"line_number":86,"context_line":"        # a service in a current process."},{"line_number":87,"context_line":"        if self.workers \u003e 1:"},{"line_number":88,"context_line":"            # Wait at most 10 seconds to spawn workers"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_aa801ec1","line":85,"updated":"2015-11-10 21:09:02.000000000","message":"It seems this should be corrected in a parent change?","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"82986cf3e405e5a79b3b40a5dc516f6b666a3f1f","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        self.service_pid \u003d pid"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # If number of workers is 0 or 1 it is assumed that we run"},{"line_number":86,"context_line":"        # a service in a current process."},{"line_number":87,"context_line":"        if self.workers \u003e 1:"},{"line_number":88,"context_line":"            # Wait at most 10 seconds to spawn workers"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_3de0e428","line":85,"in_reply_to":"da85f559_aa801ec1","updated":"2015-11-11 10:20:50.000000000","message":"OK, let\u0027s make it a separate change","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"}],"neutron/tests/functional/test_service.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"a644ff3de55b162ba31341c308ec3953d9e48a8c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class TestServiceRestart(test_server.TestNeutronServer):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(TestServiceRestart, self).setUp()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _start_service(self, host, binary, topic, manager, workers,"},{"line_number":42,"context_line":"                       *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_aacede2b","line":39,"updated":"2015-11-10 21:09:02.000000000","message":"useless","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"82986cf3e405e5a79b3b40a5dc516f6b666a3f1f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class TestServiceRestart(test_server.TestNeutronServer):"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def setUp(self):"},{"line_number":39,"context_line":"        super(TestServiceRestart, self).setUp()"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _start_service(self, host, binary, topic, manager, workers,"},{"line_number":42,"context_line":"                       *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_bdd2945a","line":39,"in_reply_to":"da85f559_aacede2b","updated":"2015-11-11 10:20:50.000000000","message":"Thanks, will fix","commit_id":"b6615ad9c940e2093835c657fc978c50121ed7d9"}]}
