)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"cdeea39afbeb0f9a2406a28b7b1bbbb19712b1ee","unresolved":false,"context_lines":[{"line_number":11,"context_line":"will be removed as the last step of the workflow."},{"line_number":12,"context_line":"Comparing the slopes of the least squares fit of delete"},{"line_number":13,"context_line":"execution time shows that this optimization decreases that"},{"line_number":14,"context_line":"slope by over half."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic425ab1f8c3afe882c9deaa72a814ac0d2053f3b"},{"line_number":17,"context_line":"Signed-off-by: Ryan Moats \u003crmoats@us.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"ba8a016a_a22a918e","line":14,"updated":"2015-11-24 07:38:04.000000000","message":"can you show the graph?","commit_id":"526dac467ba869284dd096c7a9e8251fb1bd4e85"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"66ebf3a1180ae94d0a11e3b6e2d488093872b96e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"will be removed as the last step of the workflow."},{"line_number":12,"context_line":"Comparing the slopes of the least squares fit of delete"},{"line_number":13,"context_line":"execution time shows that this optimization decreases that"},{"line_number":14,"context_line":"slope by over half."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic425ab1f8c3afe882c9deaa72a814ac0d2053f3b"},{"line_number":17,"context_line":"Signed-off-by: Ryan Moats \u003crmoats@us.ibm.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"9a8ffd7b_2c9a8a15","line":14,"in_reply_to":"ba8a016a_a22a918e","updated":"2015-11-24 14:22:31.000000000","message":"Please see the bottom of [1] for detailed numbers\n\n[1] https://etherpad.openstack.org/p/hyper-scale","commit_id":"526dac467ba869284dd096c7a9e8251fb1bd4e85"}],"neutron/agent/l3/router_info.py":[{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"935ff2714452973d70db55f4b2ce07f32cb4c502","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    def delete(self, agent):"},{"line_number":265,"context_line":"        if self.router_namespace:"},{"line_number":266,"context_line":"            self.disable_radvd()"},{"line_number":267,"context_line":"            self.router_namespace.delete()"},{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            self.router[\u0027gw_port\u0027] \u003d None"},{"line_number":270,"context_line":"            self.router[l3_constants.INTERFACE_KEY] \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa80f949_d989b976","line":267,"updated":"2015-11-06 10:20:43.000000000","message":"+1, AFAIK, router namespace deletion won\u0027t perform old port deletion. This question needs to be clarified.","commit_id":"df846269110a0c712dc2c44dd70259e0a5c68f15"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"31cdd940b8c34e317be4ec24f39fe51ab849c225","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    def delete(self, agent):"},{"line_number":265,"context_line":"        if self.router_namespace:"},{"line_number":266,"context_line":"            self.disable_radvd()"},{"line_number":267,"context_line":"            self.router_namespace.delete()"},{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            self.router[\u0027gw_port\u0027] \u003d None"},{"line_number":270,"context_line":"            self.router[l3_constants.INTERFACE_KEY] \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa80f949_33f8277b","line":267,"updated":"2015-11-06 08:33:03.000000000","message":"are you sure this won\u0027t leave orphaned interfaces?","commit_id":"df846269110a0c712dc2c44dd70259e0a5c68f15"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"c32ac45f52a5a5c85c82e07501482908ef9e228a","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    def delete(self, agent):"},{"line_number":265,"context_line":"        if self.router_namespace:"},{"line_number":266,"context_line":"            self.disable_radvd()"},{"line_number":267,"context_line":"            self.router_namespace.delete()"},{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            self.router[\u0027gw_port\u0027] \u003d None"},{"line_number":270,"context_line":"            self.router[l3_constants.INTERFACE_KEY] \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_6ff4bb86","line":267,"in_reply_to":"fa80f949_d989b976","updated":"2015-11-17 16:36:56.000000000","message":"in fact, the failures in the test cases are orphans not being cleaned up, so I\u0027m completely sure this simple \"meataxe\" approach won\u0027t work - I\u0027ll look at respinning this to try and use a scapel","commit_id":"df846269110a0c712dc2c44dd70259e0a5c68f15"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"bb62b226b61f6781865efa5a63228ae930990b26","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            # configure their addresses on the external gateway port"},{"line_number":668,"context_line":"            interface_name \u003d self.get_external_device_interface_name("},{"line_number":669,"context_line":"                ex_gw_port)"},{"line_number":670,"context_line":"            fip_statuses \u003d self.configure_fip_addresses(interface_name)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        except (n_exc.FloatingIpSetupException,"},{"line_number":673,"context_line":"                n_exc.IpTablesApplyException):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba8a016a_9c781f91","side":"PARENT","line":670,"updated":"2015-11-18 02:18:16.000000000","message":"You dropped the FIPs configuration, check out the functional tests failures.","commit_id":"29f84d66a97ffbb69063c3995b4145f682986704"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"dc8715b9f45e2a50aaaa7dd582b6ed175f0989b1","unresolved":false,"context_lines":[{"line_number":667,"context_line":"            # configure their addresses on the external gateway port"},{"line_number":668,"context_line":"            interface_name \u003d self.get_external_device_interface_name("},{"line_number":669,"context_line":"                ex_gw_port)"},{"line_number":670,"context_line":"            fip_statuses \u003d self.configure_fip_addresses(interface_name)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        except (n_exc.FloatingIpSetupException,"},{"line_number":673,"context_line":"                n_exc.IpTablesApplyException):"}],"source_content_type":"text/x-python","patch_set":12,"id":"ba8a016a_bfe635b2","side":"PARENT","line":670,"in_reply_to":"ba8a016a_9c781f91","updated":"2015-11-18 03:30:10.000000000","message":"yeah, that\u0027s an oopsy :)","commit_id":"29f84d66a97ffbb69063c3995b4145f682986704"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"1ce5511a038e4e56768a18890793bbb108ace707","unresolved":false,"context_lines":[{"line_number":699,"context_line":"        This method is the point where the agent requests that updates be"},{"line_number":700,"context_line":"        applied to this router."},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        :param agent: Passes the agent in order to send RPC messages."},{"line_number":703,"context_line":"        \"\"\""},{"line_number":704,"context_line":"        LOG.debug(\"process router updates\")"},{"line_number":705,"context_line":"        self._process_internal_ports(agent.pd)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_0e9507e3","line":702,"updated":"2015-11-23 08:28:48.000000000","message":"please describe \u0027delete\u0027 parameter","commit_id":"3fd44838b36220c0ca166a6298b489c5a838457e"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"a9294b3c9f1a12c0124eebb0b96228703cb322bf","unresolved":false,"context_lines":[{"line_number":699,"context_line":"        This method is the point where the agent requests that updates be"},{"line_number":700,"context_line":"        applied to this router."},{"line_number":701,"context_line":""},{"line_number":702,"context_line":"        :param agent: Passes the agent in order to send RPC messages."},{"line_number":703,"context_line":"        \"\"\""},{"line_number":704,"context_line":"        LOG.debug(\"process router updates\")"},{"line_number":705,"context_line":"        self._process_internal_ports(agent.pd)"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba8a016a_b1718146","line":702,"in_reply_to":"ba8a016a_0e9507e3","updated":"2015-11-24 05:49:44.000000000","message":"Done","commit_id":"3fd44838b36220c0ca166a6298b489c5a838457e"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a92f2f30dcf93db34ec0b83983a9e38d33375285","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                             self.iptables_manager,"},{"line_number":647,"context_line":"                             interface_name)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def process_external(self, agent, delete\u003dFalse):"},{"line_number":650,"context_line":"        fip_statuses \u003d {}"},{"line_number":651,"context_line":"        if not delete:"},{"line_number":652,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_60c2b287","line":649,"updated":"2015-11-25 03:36:03.000000000","message":"This is now two methods for the price of one, being controlled by a parameter. We\u0027d be better off splitting this to two separate methods and calling the appropriate one from self.process. It looks like this method is only called from a single place so this shouldn\u0027t be too difficult of a change.","commit_id":"526dac467ba869284dd096c7a9e8251fb1bd4e85"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fca30417f8e1c5c17f01633489582711af4b4937","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                             self.iptables_manager,"},{"line_number":647,"context_line":"                             interface_name)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def process_external(self, agent, delete\u003dFalse):"},{"line_number":650,"context_line":"        fip_statuses \u003d {}"},{"line_number":651,"context_line":"        if not delete:"},{"line_number":652,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_d9eed98a","line":649,"in_reply_to":"9a8ffd7b_60c2b287","updated":"2015-11-25 14:48:40.000000000","message":"As I believe that would require additional testing code, I\u0027d rather see that be in a follow-on patch (which I am willing to sign up for)","commit_id":"526dac467ba869284dd096c7a9e8251fb1bd4e85"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"eebabb499df16f22f4ea850cd9e45a46643d7460","unresolved":false,"context_lines":[{"line_number":646,"context_line":"                             self.iptables_manager,"},{"line_number":647,"context_line":"                             interface_name)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def process_external(self, agent, delete\u003dFalse):"},{"line_number":650,"context_line":"        fip_statuses \u003d {}"},{"line_number":651,"context_line":"        if not delete:"},{"line_number":652,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_dc37a7ae","line":649,"in_reply_to":"9a8ffd7b_d9eed98a","updated":"2015-11-25 14:51:09.000000000","message":"That\u0027s fine.","commit_id":"526dac467ba869284dd096c7a9e8251fb1bd4e85"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a92f2f30dcf93db34ec0b83983a9e38d33375285","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                    fip_statuses \u003d self.put_fips_in_error_state()"},{"line_number":673,"context_line":"            finally:"},{"line_number":674,"context_line":"                self.update_fip_statuses(agent, fip_statuses)"},{"line_number":675,"context_line":"        else:"},{"line_number":676,"context_line":"            ex_gw_port \u003d self.get_ex_gw_port()"},{"line_number":677,"context_line":"            self._process_external_gateway(ex_gw_port, agent.pd)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_60707273","line":675,"updated":"2015-11-25 03:36:03.000000000","message":"Do you think a note would be appropriate, saying that since we\u0027re now deleting the router, that means that all FIPs have already been disassociated and so it\u0027s safe not to call any of the lines above? (Took me a bit to understand that).","commit_id":"526dac467ba869284dd096c7a9e8251fb1bd4e85"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fca30417f8e1c5c17f01633489582711af4b4937","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                    fip_statuses \u003d self.put_fips_in_error_state()"},{"line_number":673,"context_line":"            finally:"},{"line_number":674,"context_line":"                self.update_fip_statuses(agent, fip_statuses)"},{"line_number":675,"context_line":"        else:"},{"line_number":676,"context_line":"            ex_gw_port \u003d self.get_ex_gw_port()"},{"line_number":677,"context_line":"            self._process_external_gateway(ex_gw_port, agent.pd)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_f9bf1d5e","line":675,"in_reply_to":"9a8ffd7b_60707273","updated":"2015-11-25 14:48:40.000000000","message":"Yes, that is an excellent idea - I\u0027ll add it to a respin","commit_id":"526dac467ba869284dd096c7a9e8251fb1bd4e85"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"eebabb499df16f22f4ea850cd9e45a46643d7460","unresolved":false,"context_lines":[{"line_number":672,"context_line":"                    fip_statuses \u003d self.put_fips_in_error_state()"},{"line_number":673,"context_line":"            finally:"},{"line_number":674,"context_line":"                self.update_fip_statuses(agent, fip_statuses)"},{"line_number":675,"context_line":"        else:"},{"line_number":676,"context_line":"            ex_gw_port \u003d self.get_ex_gw_port()"},{"line_number":677,"context_line":"            self._process_external_gateway(ex_gw_port, agent.pd)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_9c583ffc","line":675,"in_reply_to":"9a8ffd7b_f9bf1d5e","updated":"2015-11-25 14:51:09.000000000","message":"You can add this in the follow up.","commit_id":"526dac467ba869284dd096c7a9e8251fb1bd4e85"}],"neutron/agent/metadata/driver.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a92f2f30dcf93db34ec0b83983a9e38d33375285","unresolved":false,"context_lines":[{"line_number":167,"context_line":"def before_router_removed(resource, event, l3_agent, **kwargs):"},{"line_number":168,"context_line":"    router \u003d kwargs[\u0027router\u0027]"},{"line_number":169,"context_line":"    proxy \u003d l3_agent.metadata_driver"},{"line_number":170,"context_line":"    for c, r in proxy.metadata_filter_rules(proxy.metadata_port,"},{"line_number":171,"context_line":"                                           proxy.metadata_access_mark):"},{"line_number":172,"context_line":"        router.iptables_manager.ipv4[\u0027filter\u0027].remove_rule(c, r)"},{"line_number":173,"context_line":"    for c, r in proxy.metadata_mangle_rules(proxy.metadata_access_mark):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_20010aaf","side":"PARENT","line":170,"updated":"2015-11-25 03:36:03.000000000","message":"Cedric could there be any implications of not removing these rules and just relying on the namespace being deleted to clean it up?","commit_id":"830c2e30fd716a34e1aa3f37a6e8f59fd8cc3824"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fca30417f8e1c5c17f01633489582711af4b4937","unresolved":false,"context_lines":[{"line_number":167,"context_line":"def before_router_removed(resource, event, l3_agent, **kwargs):"},{"line_number":168,"context_line":"    router \u003d kwargs[\u0027router\u0027]"},{"line_number":169,"context_line":"    proxy \u003d l3_agent.metadata_driver"},{"line_number":170,"context_line":"    for c, r in proxy.metadata_filter_rules(proxy.metadata_port,"},{"line_number":171,"context_line":"                                           proxy.metadata_access_mark):"},{"line_number":172,"context_line":"        router.iptables_manager.ipv4[\u0027filter\u0027].remove_rule(c, r)"},{"line_number":173,"context_line":"    for c, r in proxy.metadata_mangle_rules(proxy.metadata_access_mark):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_3902850c","side":"PARENT","line":170,"in_reply_to":"9a8ffd7b_20010aaf","updated":"2015-11-25 14:48:40.000000000","message":"Assaf, I checked with Carl before going this route, but further feedback from Cedric would be good.","commit_id":"830c2e30fd716a34e1aa3f37a6e8f59fd8cc3824"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"646ca3ee1c2e16ebd59899d8b67e401ec58b3637","unresolved":false,"context_lines":[{"line_number":167,"context_line":"def before_router_removed(resource, event, l3_agent, **kwargs):"},{"line_number":168,"context_line":"    router \u003d kwargs[\u0027router\u0027]"},{"line_number":169,"context_line":"    proxy \u003d l3_agent.metadata_driver"},{"line_number":170,"context_line":"    for c, r in proxy.metadata_filter_rules(proxy.metadata_port,"},{"line_number":171,"context_line":"                                           proxy.metadata_access_mark):"},{"line_number":172,"context_line":"        router.iptables_manager.ipv4[\u0027filter\u0027].remove_rule(c, r)"},{"line_number":173,"context_line":"    for c, r in proxy.metadata_mangle_rules(proxy.metadata_access_mark):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9a8ffd7b_c299fd6f","side":"PARENT","line":170,"in_reply_to":"9a8ffd7b_3902850c","updated":"2015-11-25 16:18:18.000000000","message":"IMO, It\u0027s fine to do this way even if there is a little delay between before_router_removed and router removed as the metadata proxy is deleted which (seems to) avoids potential security exploits.","commit_id":"830c2e30fd716a34e1aa3f37a6e8f59fd8cc3824"}]}
