)]}'
{"quantum/db/loadbalancer/loadbalancer_db.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":428,"context_line":"                    self.assert_modification_allowed(new_pool)"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"                    # check that the pool matches the tenant_id"},{"line_number":431,"context_line":"                    if new_pool[\u0027tenant_id\u0027] !\u003d vip_db[\u0027tenant_id\u0027]:"},{"line_number":432,"context_line":"                        raise q_exc.NotAuthorized()"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"                    if vip_db[\u0027pool_id\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2FuXM%3D","line":431,"updated":"2013-03-14 22:07:39.000000000","message":"Protocol needs to be checked here too.","commit_id":"a46b83676a05c3ed0c9310626f659f3dac5369e7"}],"quantum/extensions/loadbalancer.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"54759b2f6a6bea742e5d058d76e358ff355f09ea","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class ProtocolMismatch(qexception.BadRequest):"},{"line_number":61,"context_line":"    message \u003d _(\"Protocol %(proto)s does not match pool protocol\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"RESOURCE_ATTRIBUTE_MAP \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FyDA%3D","line":61,"updated":"2013-03-12 18:30:55.000000000","message":"Does it make sense to log another protocol as well?","commit_id":"dcd06188afa37b5029102bb22264288f710ab8aa"}],"quantum/tests/unit/db/loadbalancer/test_db_loadbalancer.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":"import itertools"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from oslo.config import cfg"},{"line_number":24,"context_line":"import webob.exc"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2FwHI%3D","line":21,"updated":"2013-03-13 20:08:33.000000000","message":"please look at the HACKING.rst. these should be alphabetically ordered\n\nit should be on line 17","commit_id":"b51074627939dcd1f19d4804215fba3621fe6a9c"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":343,"context_line":"        with testtools.ExpectedException(webob.exc.HTTPClientError):"},{"line_number":344,"context_line":"            self.test_create_vip(session_persistence\u003dsp)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def test_create_vip_with_protocol_mismatch(self):"},{"line_number":347,"context_line":"        proto \u003d [\u0027TCP\u0027, \u0027HTTP\u0027, \u0027HTTPS\u0027]"},{"line_number":348,"context_line":"        for p, v in itertools.permutations(proto, 2):"},{"line_number":349,"context_line":"            with self.pool(protocol\u003dp) as pool:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2FuXU%3D","line":346,"updated":"2013-03-14 22:07:39.000000000","message":"I\u0027m not sure we have to check all of the permutations of protocols.  I think that checking one mismatch (ie TCP \u0026 HTTP) will be acceptable.","commit_id":"a46b83676a05c3ed0c9310626f659f3dac5369e7"}]}
