)]}'
{"neutron/agent/linux/bridge_lib.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"98e63f0d7579a30fff2d5dbb7ddd101430d5dc7a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        except OSError:"},{"line_number":58,"context_line":"            return None"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            name \u003d path.rpartition(\u0027/\u0027)[-1]"},{"line_number":61,"context_line":"            return cls(name)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def delbr(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_6c0c943b","line":60,"updated":"2015-11-06 04:53:13.000000000","message":"Why not just use os.path.basename here?","commit_id":"d81c553396a6d1fa06944149457c1a1f836a3b42"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fe56d0b57ff37beab1f9fcc06d4f5e0bfc3c8ccc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            path \u003d os.readlink(BRIDGE_PATH_FOR_DEVICE % interface)"},{"line_number":57,"context_line":"        except OSError:"},{"line_number":58,"context_line":"            return None"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            name \u003d path.rpartition(\u0027/\u0027)[-1]"},{"line_number":61,"context_line":"            return cls(name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_8e20414b","line":58,"updated":"2015-11-08 12:57:09.000000000","message":"you could do return","commit_id":"9408fb63fab93b6033591d35fcbd8b55e171f1fd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"46594c7cca7ad3e2bedf6b227ff052cb9ea9fe4e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            path \u003d os.readlink(BRIDGE_PATH_FOR_DEVICE % interface)"},{"line_number":57,"context_line":"        except OSError:"},{"line_number":58,"context_line":"            return None"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            name \u003d path.rpartition(\u0027/\u0027)[-1]"},{"line_number":61,"context_line":"            return cls(name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_4141be0a","line":58,"updated":"2015-11-09 08:23:53.000000000","message":"you do not need the return None here. It can just be return","commit_id":"a710e0476bc780d007c2f8009e3b38f342d00f62"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"ca4d0bd865c9b8600957970d904f4d52991c78fc","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            path \u003d os.readlink(BRIDGE_PATH_FOR_DEVICE % interface)"},{"line_number":57,"context_line":"        except OSError:"},{"line_number":58,"context_line":"            return None"},{"line_number":59,"context_line":"        else:"},{"line_number":60,"context_line":"            name \u003d path.rpartition(\u0027/\u0027)[-1]"},{"line_number":61,"context_line":"            return cls(name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_a173a114","line":58,"in_reply_to":"da85f559_4141be0a","updated":"2015-11-09 21:29:49.000000000","message":"I prefer an explicit return None which highlights that the except case is not forgotten","commit_id":"a710e0476bc780d007c2f8009e3b38f342d00f62"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"ae9e68326320e64939acec90ce0210dfaad5b14f","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def get_bridge_for_tap_device(self, tap_device_name):"},{"line_number":186,"context_line":"        bridge \u003d bridge_lib.BridgeDevice.get_interface_bridge(tap_device_name)"},{"line_number":187,"context_line":"        if (bridge and (bridge.name.startswith(BRIDGE_NAME_PREFIX)"},{"line_number":188,"context_line":"                        or bridge.name in self.bridge_mappings.values()):"},{"line_number":189,"context_line":"            return bridge"},{"line_number":190,"context_line":"        return None"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_dcbf75a8","line":188,"updated":"2015-11-06 02:38:46.000000000","message":"Missing a parenthesis here?","commit_id":"d81c553396a6d1fa06944149457c1a1f836a3b42"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fe56d0b57ff37beab1f9fcc06d4f5e0bfc3c8ccc","unresolved":false,"context_lines":[{"line_number":186,"context_line":"        if (bridge and (bridge.name.startswith(BRIDGE_NAME_PREFIX)"},{"line_number":187,"context_line":"                        or bridge.name in self.bridge_mappings.values())):"},{"line_number":188,"context_line":"            return bridge"},{"line_number":189,"context_line":"        return None"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def ensure_vlan_bridge(self, network_id, phy_bridge_name,"},{"line_number":192,"context_line":"                           physical_interface, vlan_id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_0e0531c1","line":189,"updated":"2015-11-08 12:57:09.000000000","message":"can we drop this return None?\n\nBy default a method returns None","commit_id":"9408fb63fab93b6033591d35fcbd8b55e171f1fd"}],"neutron/tests/functional/agent/test_l2_lb_agent.py":[{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"06faae3a9b190cdb278ca0f3ff91cfb115b2a930","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import testtools"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.plugins.ml2.drivers.linuxbridge.agent import \\"},{"line_number":21,"context_line":"    linuxbridge_neutron_agent"},{"line_number":22,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":23,"context_line":"from neutron.tests.functional.agent.linux import test_ip_lib"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_34040814","line":21,"updated":"2015-11-08 15:30:44.000000000","message":"unused import","commit_id":"9408fb63fab93b6033591d35fcbd8b55e171f1fd"}]}
