)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8d30aade483792670b16bc38772192fe5c27bb70","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This needs some more work.  For example, I think I\u0027ll add association"},{"line_number":10,"context_line":"with a Network and possibly even IpNetwork hierarchy in this patch"},{"line_number":11,"context_line":"set."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I77ac9e492ec18cc8b25156f5f4ff8a955bfe9b7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa80f949_488663dc","line":11,"updated":"2015-11-05 23:54:23.000000000","message":"Maybe I should write a TODO here for the items I plan to add to this patch set.","commit_id":"4c3ce16b330151ab58b5dc63b861e374deddaec0"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8d30aade483792670b16bc38772192fe5c27bb70","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This needs some more work.  For example, I think I\u0027ll add association"},{"line_number":10,"context_line":"with a Network and possibly even IpNetwork hierarchy in this patch"},{"line_number":11,"context_line":"set."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I77ac9e492ec18cc8b25156f5f4ff8a955bfe9b7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa80f949_687b27f6","line":12,"updated":"2015-11-05 23:54:23.000000000","message":"Need blueprint.","commit_id":"4c3ce16b330151ab58b5dc63b861e374deddaec0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"48a3f6bbf2a1397a8c46874d4681091dccb2a0f5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Basic extension and CRUD for IP network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An IpNetwork can associate 1-1 with a Network.  This patch set"},{"line_number":10,"context_line":"attempts to enforce this invariant at the DB layer by a two-way"},{"line_number":11,"context_line":"association.  I\u0027m not sure if that is overkill or not."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a8ffd7b_99bc9bbc","line":9,"updated":"2015-12-02 13:27:16.000000000","message":"only network? how about ports?","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"eeee6d8c9932879ecec7ec36b0b853667b284709","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Basic extension and CRUD for IP network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"An IpNetwork can associate 1-1 with a Network.  This patch set"},{"line_number":10,"context_line":"attempts to enforce this invariant at the DB layer by a two-way"},{"line_number":11,"context_line":"association.  I\u0027m not sure if that is overkill or not."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a8ffd7b_a8502a33","line":9,"in_reply_to":"9a8ffd7b_99bc9bbc","updated":"2015-12-02 13:48:34.000000000","message":"FWIW my feeling after working a bit with this code is that the relationships between IpNetworks and Networks feel a bit clumsy.  I need to think a bit more about that, and will then comment further in the spec.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c87f057b05ee54732a44cbbd4f605d480954a66d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"association.  I\u0027m not sure if that is overkill or not."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"An IpNetwork can be a parent to another IpNetwork.  But, only if it is"},{"line_number":14,"context_line":"not bound to a Network.  This is somewhat intuitive if you think of an"},{"line_number":15,"context_line":"IpNetwork used on an L2 broadcast domain.  The IpNetwork stretches at"},{"line_number":16,"context_line":"least throughout the L2 and can stetch beyond by routing."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ba8a016a_1e7431fb","line":14,"updated":"2015-11-17 21:17:04.000000000","message":"I\u0027m not sure this makes sense.  It isn\u0027t quite what I wanted to say.  I\u0027ll revise.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"48a3f6bbf2a1397a8c46874d4681091dccb2a0f5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"An IpNetwork can be a parent to another IpNetwork.  But, only if it is"},{"line_number":14,"context_line":"not bound to a Network.  This is somewhat intuitive if you think of an"},{"line_number":15,"context_line":"IpNetwork used on an L2 broadcast domain.  The IpNetwork stretches at"},{"line_number":16,"context_line":"least throughout the L2 and can stetch beyond by routing."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially-Implements: blueprint routed-networks"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9a8ffd7b_99a7bbbc","line":16,"updated":"2015-12-02 13:27:16.000000000","message":"stetch \u003d\u003d\u003e stretch","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"6563a15246e2d06c99745d9e5fe25542afd3390d","unresolved":false,"context_lines":[{"line_number":21,"context_line":" - Add applicable API tests."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partially-Implements: blueprint routed-networks"},{"line_number":24,"context_line":"Co-Authored-By: vikram.choudhary \u003cvikram.choudhary@huawei.com\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I77ac9e492ec18cc8b25156f5f4ff8a955bfe9b7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_450a3ed4","line":24,"updated":"2015-12-03 20:15:55.000000000","message":"same Author and co-author ?","commit_id":"7de196d47eb960344597e8818e0003f9d42af133"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d15fabc4637aed5029745fdde1a647a5290c173","unresolved":false,"context_lines":[{"line_number":21,"context_line":" - Add applicable API tests."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partially-Implements: blueprint routed-networks"},{"line_number":24,"context_line":"Co-Authored-By: vikram.choudhary \u003cvikram.choudhary@huawei.com\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I77ac9e492ec18cc8b25156f5f4ff8a955bfe9b7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_c1e5b0a8","line":24,"in_reply_to":"7a740942_450a3ed4","updated":"2015-12-04 04:01:21.000000000","message":"Ooopppss.. This patch was started by Carl, I think I got him removed him accidentally. Thanks for pointing this out. Will add him!","commit_id":"7de196d47eb960344597e8818e0003f9d42af133"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0d7b2d6d2e8e51b7727e350b07243d1be6b0685b","unresolved":false,"context_lines":[{"line_number":21,"context_line":" - Add applicable API tests."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partially-Implements: blueprint routed-networks"},{"line_number":24,"context_line":"Co-Authored-By: vikram.choudhary \u003cvikram.choudhary@huawei.com\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I77ac9e492ec18cc8b25156f5f4ff8a955bfe9b7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_8b3dbbc5","line":24,"in_reply_to":"7a740942_598b491f","updated":"2015-12-09 05:35:10.000000000","message":"Sure I will check that Carl!","commit_id":"7de196d47eb960344597e8818e0003f9d42af133"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c04b8374513be24e3e5ab6b963d1e0e9f19abc8c","unresolved":false,"context_lines":[{"line_number":21,"context_line":" - Add applicable API tests."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Partially-Implements: blueprint routed-networks"},{"line_number":24,"context_line":"Co-Authored-By: vikram.choudhary \u003cvikram.choudhary@huawei.com\u003e"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I77ac9e492ec18cc8b25156f5f4ff8a955bfe9b7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_598b491f","line":24,"in_reply_to":"7a740942_c1e5b0a8","updated":"2015-12-08 17:42:25.000000000","message":"Vikram.  You might see how you\u0027re using git.  Typically, without the \u0027--reset-author\u0027 argument to \u0027git commit\u0027 it won\u0027t reset the author in the commit.  This is how it works for me all the time.  You might check to see what you\u0027re doing differently that causes the author to be set to you.","commit_id":"7de196d47eb960344597e8818e0003f9d42af133"}],"etc/policy.json":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"48a3f6bbf2a1397a8c46874d4681091dccb2a0f5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"update_ip_network\": \"rule:admin_or_owner\","},{"line_number":68,"context_line":"    \"update_ip_network:shared\": \"rule:admin_only\","},{"line_number":69,"context_line":"    \"update_ip_network:router:external\": \"rule:admin_only\","},{"line_number":70,"context_line":"    \"delete_ip_network\": \"rule:admin_or_owner\","},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    \"network_device\": \"field:port:device_owner\u003d~^network:\","},{"line_number":73,"context_line":"    \"create_port\": \"\","}],"source_content_type":"application/json","patch_set":7,"id":"9a8ffd7b_39800fbf","line":70,"updated":"2015-12-02 13:27:16.000000000","message":"Why we don\u0027t have \"\"delete_ip_network:shared\"?","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"}],"neutron/db/ip_network_db.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"10bacdccd894fdc1fef46c751732888fef7b3398","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def _make_ip_network_dict(self, ip_network, fields\u003dNone):"},{"line_number":50,"context_line":"        res \u003d {\u0027id\u0027: ip_network[\u0027id\u0027],"},{"line_number":51,"context_line":"               \u0027name\u0027: ip_network[\u0027name\u0027],"},{"line_number":52,"context_line":"               \u0027tenant_id\u0027: ip_network[\u0027tenant_id\u0027],"},{"line_number":53,"context_line":"               \u0027shared\u0027: ip_network[\u0027shared\u0027]}"},{"line_number":54,"context_line":"        return self._fields(res, fields)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_5f5db477","line":52,"updated":"2015-11-06 06:31:20.000000000","message":"tenant_id may be changed to project_id ( I guess) when keystone v3 is enabled.\nIf that is so, need to ensure the proper mapping.","commit_id":"4c3ce16b330151ab58b5dc63b861e374deddaec0"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0391eddce1d4123d3e461c86113378b8d90d43af","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def _make_ip_network_dict(self, ip_network, fields\u003dNone):"},{"line_number":50,"context_line":"        res \u003d {\u0027id\u0027: ip_network[\u0027id\u0027],"},{"line_number":51,"context_line":"               \u0027name\u0027: ip_network[\u0027name\u0027],"},{"line_number":52,"context_line":"               \u0027tenant_id\u0027: ip_network[\u0027tenant_id\u0027],"},{"line_number":53,"context_line":"               \u0027shared\u0027: ip_network[\u0027shared\u0027]}"},{"line_number":54,"context_line":"        return self._fields(res, fields)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_14e79a41","line":52,"in_reply_to":"fa80f949_5f5db477","updated":"2015-11-06 21:18:11.000000000","message":"Does anything in Neutron use project_id?  Honestly, I think Neutron has been oblivious to the change from tenant to project in keystone and I\u0027m not sure why we need to pay much attention.","commit_id":"4c3ce16b330151ab58b5dc63b861e374deddaec0"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c1eee354bf18b08718ae0688d5687313fc52d93","unresolved":false,"context_lines":[{"line_number":26,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class IpNetwork(model_base.BASEV2, models_v2.HasId, models_v2.HasTenant):"},{"line_number":30,"context_line":"    \"\"\"Represents a v2 neutron ip network.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    __tablename__ \u003d \"ip_networks\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_df083230","line":29,"updated":"2015-11-20 18:41:58.000000000","message":"See https://review.openstack.org/#/c/222079.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"7b8f9e127c0a6f79efee3dbebf60c2f0897f3616","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":35,"context_line":"                           sa.ForeignKey(\"networks.id\", ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":36,"context_line":"                           nullable\u003dTrue)"},{"line_number":37,"context_line":"    parent_id \u003d sa.Column(sa.String(36),"},{"line_number":38,"context_line":"                          sa.ForeignKey(\"ip_networks.id\", ondelete\u003d\u0027SET NULL\u0027),"},{"line_number":39,"context_line":"                          nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_12061d1d","line":36,"updated":"2015-11-19 01:08:10.000000000","message":"I\u0027m curious why we track a network_id here.  I thought the point was that an IpNetwork is composed of multiple Neutron networks.  It appears that you\u0027ve modeled that by adding an ip_network_id to Network.  I\u0027m not seeing why this is needed. Is this for backward compatibility?","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6290651e6936dd7449b13446781220f3a6799f52","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":35,"context_line":"                           sa.ForeignKey(\"networks.id\", ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":36,"context_line":"                           nullable\u003dTrue)"},{"line_number":37,"context_line":"    parent_id \u003d sa.Column(sa.String(36),"},{"line_number":38,"context_line":"                          sa.ForeignKey(\"ip_networks.id\", ondelete\u003d\u0027SET NULL\u0027),"},{"line_number":39,"context_line":"                          nullable\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_9dd50be6","line":36,"in_reply_to":"ba8a016a_12061d1d","updated":"2015-11-19 20:26:28.000000000","message":"I have what I think is a better picture of this relationship coming in the next spec update.  Let me go finish that and you can take a look.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6c1eee354bf18b08718ae0688d5687313fc52d93","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    ports \u003d orm.relationship(models_v2.Port, backref\u003d\u0027ip_networks\u0027)"},{"line_number":42,"context_line":"    shared \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"},{"line_number":43,"context_line":"    status \u003d sa.Column(sa.String(16))"},{"line_number":44,"context_line":"    # TODO(Carl) Use RBAC for IpNetwork"},{"line_number":45,"context_line":"    # rbac_entries \u003d orm.relationship(rbac_db_models.IpNetworkRBAC,"},{"line_number":46,"context_line":"    #                                 backref\u003d\u0027ip_network\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":47,"context_line":"    #                                 cascade\u003d\u0027all, delete, delete-orphan\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_7fa90624","line":44,"updated":"2015-11-20 18:41:58.000000000","message":"I\u0027d like to figure out how to work with RBAC before this patch merges.  @Ryan, how much do you know about this?","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6290651e6936dd7449b13446781220f3a6799f52","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            raise ext_ip_network.NetworkAlreadyBound("},{"line_number":96,"context_line":"                network_id\u003dnetwork_id)"},{"line_number":97,"context_line":"        # TODO(Carl) Is there a race here?"},{"line_number":98,"context_line":"        # Could I do an update where here to ensure that only I can?"},{"line_number":99,"context_line":"        network.ip_network_id \u003d ip_network_id"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def _check_parent(self, context, parent_id):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_fd421767","line":98,"updated":"2015-11-19 20:26:28.000000000","message":"This isn\u0027t a very good sentence.  What I\u0027m wondering is if I can implement this with an \"UPDATE ... WHERE\" so that the update fails if it has been concurrently to avoid any kind of race.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"7b8f9e127c0a6f79efee3dbebf60c2f0897f3616","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        if not parent_id:"},{"line_number":108,"context_line":"            return"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # TODO(Carl) Is there a race here?"},{"line_number":111,"context_line":"        parent \u003d self._get_ip_network(context, parent_id)"},{"line_number":112,"context_line":"        if not parent.network_id:"},{"line_number":113,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_92952d88","line":110,"updated":"2015-11-19 01:08:10.000000000","message":"Strikes me as not being Galera-compliant as written...","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6290651e6936dd7449b13446781220f3a6799f52","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        if not parent_id:"},{"line_number":108,"context_line":"            return"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        # TODO(Carl) Is there a race here?"},{"line_number":111,"context_line":"        parent \u003d self._get_ip_network(context, parent_id)"},{"line_number":112,"context_line":"        if not parent.network_id:"},{"line_number":113,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_fdb45782","line":110,"in_reply_to":"ba8a016a_92952d88","updated":"2015-11-19 20:26:28.000000000","message":"Yeah, this needs a bit more thought like the one on L98.  I did it the naive way to begin with because I wanted to get a few of the other details worked out first.  We should definitely circle back on this.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ff85b0ecdaf0048aa00f642cfb2a5640a8bde3a3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    shared \u003d sa.Column(sa.Boolean, nullable\u003dFalse)"},{"line_number":43,"context_line":"    status \u003d sa.Column(sa.String(16))"},{"line_number":44,"context_line":"    # TODO(Carl) Use RBAC for IpNetwork"},{"line_number":45,"context_line":"    # rbac_entries \u003d orm.relationship(rbac_db_models.IpNetworkRBAC,"},{"line_number":46,"context_line":"    #                                 backref\u003d\u0027ip_network\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":47,"context_line":"    #                                 cascade\u003d\u0027all, delete, delete-orphan\u0027)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_8311e25f","line":45,"updated":"2015-12-10 05:57:21.000000000","message":"This can be defined as a separate rbac-object but should this also inherit the same from the Network? What I mean is if the Network object is shared via RBAC should we need to inherit the same as done for Subnet?\n\nhttps://github.com/openstack/neutron/blob/master/neutron/db/models_v2.py#L210-L215","commit_id":"7de196d47eb960344597e8818e0003f9d42af133"}],"neutron/db/migration/alembic_migrations/versions/mitaka/expand/4bb00ef884ea_add_ipnetwork_model.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"162ebe7924968e3daecfd15d87fea2eeca0941d1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                          [\u0027id\u0027])"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    op.add_column(\u0027ports\u0027,"},{"line_number":56,"context_line":"                  sa.Column(\u0027ip_network_id\u0027, sa.String(length\u003d36),"},{"line_number":57,"context_line":"                  nullable\u003dTrue))"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    op.create_foreign_key(None,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_33284ee2","line":56,"updated":"2015-11-17 20:54:34.000000000","message":"This indentation is wrong.","commit_id":"d7eba05c6744d0af25d2459432d4645a94d24351"}],"neutron/db/models_v2.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"6111045c947f0f89c95d4e66bf85b61155caf0bc","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"},{"line_number":124,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_60036e43","line":121,"updated":"2015-11-10 00:27:44.000000000","message":"Do you really want to take the step of allowing a port to be created directly on an IpNetwork at this juncture?  Would you still have to specify a network_id as well, or is the intent to determine the network_id in this phase?","commit_id":"138e83a4c222c37178a41cb6444bc0587385f32e"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d6af2f3731ab629bc1a835723e2102d5c152e7f5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"},{"line_number":124,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_9339fa43","line":121,"in_reply_to":"da85f559_60036e43","updated":"2015-11-17 20:52:31.000000000","message":"This is the next big thing that needs some discussion.  I am currently thinking that we need the ability to create a port with an IpNetwork and then bind it to a Network and assign an IP address later when Nova has done scheduling.  This has to do with John Garbutt\u0027s comment in the spec [1] about the workflow to create a port and then pass it to Nova (which should be a supported workflow anyway).\n\nGiven this workflow, we can\u0027t know which Network to create the port on until \nscheduling is done.  Yet, we need a port to pass to Nova.  I don\u0027t see any other way except to allow the Network to be null until a binding to a host is done.\n\n [1] https://review.openstack.org/#/c/225384/9/specs/mitaka/booting-vms-to-routed-networks.rst","commit_id":"138e83a4c222c37178a41cb6444bc0587385f32e"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"7b8f9e127c0a6f79efee3dbebf60c2f0897f3616","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_b76aa3eb","line":119,"updated":"2015-11-19 01:08:10.000000000","message":"To support something along the lines of Calico, I assume we would want to make network_id nullable at some point? To be clear, I\u0027m not suggesting we change the behavior in this patch.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6290651e6936dd7449b13446781220f3a6799f52","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_3d341ffa","line":119,"in_reply_to":"ba8a016a_b76aa3eb","updated":"2015-11-19 20:26:28.000000000","message":"Yes, that is exactly what I have in mind.  Probably in a patch to follow this but very very soon.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5c4feacd6d9f7ea515f2be8d06e38a2773187daf","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_4aa9748f","line":120,"updated":"2015-11-18 13:03:29.000000000","message":"why is this not as part of an extension?","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6290651e6936dd7449b13446781220f3a6799f52","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_5d1ec370","line":120,"in_reply_to":"ba8a016a_4aa9748f","updated":"2015-11-19 20:26:28.000000000","message":"Indeed, will look in to this.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ba697dae2bd6f118dd360ae81e36505dfe5040c6","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"},{"line_number":124,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_82cc5a62","line":121,"updated":"2015-12-01 17:06:40.000000000","message":"Setting the extension question aside for a moment...\n\nNeil mentioned in channel that these foreign key constraints may be causing the UTs to fail.  I didn\u0027t think that would be the case since the column should allow null and a column with a FK should allow null meaning that an IpNetwork isn\u0027t required for a Network to exist.\n\nI wonder if the problem is that there is no default value for the column.  Would adding default\u003dNone to the Column do it?\n\nAlso, I think nullable\u003dTrue is not required.  I added it just to be clear of the intention but True is the default.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"7efd5a3c9a78643bac6d4639eb0ccdd89bf8cd5e","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"},{"line_number":124,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_33a5be46","line":121,"in_reply_to":"9a8ffd7b_0ddbbb1c","updated":"2015-12-01 17:54:33.000000000","message":"Adding \u0027default\u003dNone\u0027 everywhere doesn\u0027t work as an alternative fix.\n\nSome quick searches seem to indicate that you can\u0027t have bidirectional ForeignKeys between two tables; e.g. http://stackoverflow.com/questions/1607916/bidirectional-foreign-key-constraint http://stackoverflow.com/questions/21202541/insert-data-into-two-table-with-foreign-key-dependencies?lq\u003d1\n\nFor a 1:1 relationship, http://docs.sqlalchemy.org/en/latest/orm/basic_relationships.html#one-to-one suggests to instead use a ForeignKey on one side and a relationship(..., uselist\u003dFalse, ...) on the other.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0e2d8071efd112946c28b9c8f0ac2ba4f4992c74","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"},{"line_number":124,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_9652f733","line":121,"in_reply_to":"9a8ffd7b_30500232","updated":"2015-12-03 06:20:12.000000000","message":"Yup, I will.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"48a3f6bbf2a1397a8c46874d4681091dccb2a0f5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"},{"line_number":124,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_393ecf8b","line":121,"in_reply_to":"9a8ffd7b_33a5be46","updated":"2015-12-02 13:27:16.000000000","message":"@Neil: Thanks for digging up the issue.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ce618130ce77418feee4f4fae8c3cca4b147c0e0","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"},{"line_number":124,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_30500232","line":121,"in_reply_to":"9a8ffd7b_393ecf8b","updated":"2015-12-02 21:46:14.000000000","message":"@Neil, great work!  Thanks for finding that information.  Vikram, can you take care of this?","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"dd4a6c45320f58d221c4e4701d479c03b004ba42","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":119,"context_line":"                           nullable\u003dFalse)"},{"line_number":120,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":121,"context_line":"                              nullable\u003dTrue)"},{"line_number":122,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":123,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"},{"line_number":124,"context_line":"    mac_address \u003d sa.Column(sa.String(32), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_0ddbbb1c","line":121,"in_reply_to":"9a8ffd7b_82cc5a62","updated":"2015-12-01 17:19:44.000000000","message":"It seems the simplest UT fix is to comment out the lines defining the ip_network_id field in the Network table, i.e. lines 262-3 below.  So the problem definitely seems related to having a ForeignKey in both directions between IpNetwork and Network.\n\nBut perhaps it can also be solved by adding a default value as you suggest - I\u0027ll try.","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"48a3f6bbf2a1397a8c46874d4681091dccb2a0f5","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    # TODO(Carl) Primarily, the ip_networks.network_id sets up this"},{"line_number":260,"context_line":"    # relationship.  But, the relationship must be 1-1 (at least for now)."},{"line_number":261,"context_line":"    # Linked it both ways is an easy way to guarantee this.  Is it needed?"},{"line_number":262,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":263,"context_line":"                              nullable\u003dTrue)"},{"line_number":264,"context_line":"    status \u003d sa.Column(sa.String(16))"},{"line_number":265,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a8ffd7b_d94f8332","line":262,"updated":"2015-12-02 13:27:16.000000000","message":"Do we really need this?","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5c4feacd6d9f7ea515f2be8d06e38a2773187daf","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    # TODO(Carl) Primarily, the ip_networks.network_id sets up this"},{"line_number":260,"context_line":"    # relationship.  But, the relationship must be 1-1 (at least for now)."},{"line_number":261,"context_line":"    # Linked it both ways is an easy way to guarantee this.  Is it needed?"},{"line_number":262,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":263,"context_line":"                              nullable\u003dTrue)"},{"line_number":264,"context_line":"    status \u003d sa.Column(sa.String(16))"},{"line_number":265,"context_line":"    admin_state_up \u003d sa.Column(sa.Boolean)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_0a984c77","line":262,"updated":"2015-11-18 13:03:29.000000000","message":"ditto","commit_id":"1abdff4831a907472023230d773fcdb9647d8b4f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0d7b2d6d2e8e51b7727e350b07243d1be6b0685b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":119,"context_line":"    network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"networks.id\"),"},{"line_number":120,"context_line":"                           nullable\u003dFalse)"},{"line_number":121,"context_line":"    ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"},{"line_number":122,"context_line":"                              nullable\u003dTrue)"},{"line_number":123,"context_line":"    fixed_ips \u003d orm.relationship(IPAllocation, backref\u003d\u0027port\u0027, lazy\u003d\u0027joined\u0027,"},{"line_number":124,"context_line":"                                 passive_deletes\u003d\u0027all\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_cbdbc34d","line":121,"updated":"2015-12-09 05:35:10.000000000","message":"Is the ForeignKey association really needed? To me it\u0027s not required as we ensure 1:1 mapping for the network.","commit_id":"7de196d47eb960344597e8818e0003f9d42af133"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"0d7b2d6d2e8e51b7727e350b07243d1be6b0685b","unresolved":false,"context_lines":[{"line_number":261,"context_line":"    subnets \u003d orm.relationship("},{"line_number":262,"context_line":"        Subnet, backref\u003dorm.backref(\u0027networks\u0027, lazy\u003d\u0027joined\u0027),"},{"line_number":263,"context_line":"        lazy\u003d\"joined\")"},{"line_number":264,"context_line":"    # TODO(Carl) Primarily, the ip_networks.network_id sets up this"},{"line_number":265,"context_line":"    # relationship.  But, the relationship must be 1-1 (at least for now)."},{"line_number":266,"context_line":"    # Linked it both ways is an easy way to guarantee this.  Is it needed?"},{"line_number":267,"context_line":"    # ip_network_id \u003d sa.Column(sa.String(36), sa.ForeignKey(\"ip_networks.id\"),"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_6bb88f11","line":264,"updated":"2015-12-09 05:35:10.000000000","message":"I think this might not be need. IMO, just throwing an error when the ip-network association to a network which is already bound to an ip-network would be fine. Any thoughts?","commit_id":"7de196d47eb960344597e8818e0003f9d42af133"}],"neutron/extensions/ip_network.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8d30aade483792670b16bc38772192fe5c27bb70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Huawei Technologies Co.,LTD."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_88676b4c","line":1,"updated":"2015-11-05 23:54:23.000000000","message":"Oops, copied this header from another file.","commit_id":"4c3ce16b330151ab58b5dc63b861e374deddaec0"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"ea1e463b4b5f043ec97dceb772de08fb16045966","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                extradhcpopt_db.ExtraDhcpOptMixin,"},{"line_number":97,"context_line":"                netmtu_db.Netmtu_db_mixin,"},{"line_number":98,"context_line":"                address_scope_db.AddressScopeDbMixin,"},{"line_number":99,"context_line":"                ip_network_db.IpNetworkDbMixin):"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    \"\"\"Implement the Neutron L2 abstractions using modules."},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_6c6bf7f1","line":99,"updated":"2015-12-03 11:25:26.000000000","message":"With ML2, I think the Extension Driver is a way to go. In deployments where  IPNetworks is not relevant, this extension won\u0027t be enabled.","commit_id":"7de196d47eb960344597e8818e0003f9d42af133"}],"neutron/tests/unit/extensions/test_ip_network.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8d30aade483792670b16bc38772192fe5c27bb70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_0854db50","line":1,"updated":"2015-11-05 23:54:23.000000000","message":"Oops, copied this header from another file.","commit_id":"4c3ce16b330151ab58b5dc63b861e374deddaec0"}]}
