)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"8762fbb58a8eb7589e5e197524f42168abd371d1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Replace get_all_neutron_bridges by get_deletable_bridges"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently LinuxBridge L2-agent[1] defines get_all_neutron_bridges which"},{"line_number":10,"context_line":"lists all neutron managed by the agent including user-defined ones BUT"},{"line_number":11,"context_line":"this method is only used by neutron-linuxbridge-cleanup[2] in order to"},{"line_number":12,"context_line":"remove empty non-user-defined bridges returned get_all_neutron_bridges."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_93bcc56d","line":10,"updated":"2015-11-09 16:24:36.000000000","message":"nit: should be \"lists all neutron bridges managed...\"","commit_id":"3e0234ffc376253e51ef6bb0aad901a83288072d"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e08f682454726558f02116b743840fa10ccd9d4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Replace get_all_neutron_bridges by get_deletable_bridges"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently LinuxBridge L2-agent[1] defines get_all_neutron_bridges which"},{"line_number":10,"context_line":"lists all neutron managed by the agent including user-defined ones BUT"},{"line_number":11,"context_line":"this method is only used by neutron-linuxbridge-cleanup[2] in order to"},{"line_number":12,"context_line":"remove empty non-user-defined bridges returned get_all_neutron_bridges."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_5830b101","line":10,"in_reply_to":"da85f559_93bcc56d","updated":"2015-11-09 18:37:36.000000000","message":"Done","commit_id":"3e0234ffc376253e51ef6bb0aad901a83288072d"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"8762fbb58a8eb7589e5e197524f42168abd371d1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"remove empty non-user-defined bridges returned get_all_neutron_bridges."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change replaces this method by get_deletable_bridges which returns"},{"line_number":15,"context_line":"bridgs managed by LB agent which are \"deletable\" (ie: non user-defined)."},{"line_number":16,"context_line":"This allows to simplify code and move the computation of \"deletable\""},{"line_number":17,"context_line":"bridges to LB agent code."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_135f7542","line":15,"updated":"2015-11-09 16:24:36.000000000","message":"typo: bridgs -\u003e bridges","commit_id":"3e0234ffc376253e51ef6bb0aad901a83288072d"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e08f682454726558f02116b743840fa10ccd9d4f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"remove empty non-user-defined bridges returned get_all_neutron_bridges."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This change replaces this method by get_deletable_bridges which returns"},{"line_number":15,"context_line":"bridgs managed by LB agent which are \"deletable\" (ie: non user-defined)."},{"line_number":16,"context_line":"This allows to simplify code and move the computation of \"deletable\""},{"line_number":17,"context_line":"bridges to LB agent code."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_f83e45d9","line":15,"in_reply_to":"da85f559_135f7542","updated":"2015-11-09 18:37:36.000000000","message":"Done","commit_id":"3e0234ffc376253e51ef6bb0aad901a83288072d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"eddfbf8f67d1e5f790c8297b583cb858632302b8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"bridges to LB agent code."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"[1] neutron.plugins.ml2.drivers.linuxbridge.agent.linuxbridge_neutron_agent"},{"line_number":20,"context_line":"[2] neutronc.cmd.linuxbridge_cleanup"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Partial-Bug: #1514548"},{"line_number":23,"context_line":"Change-Id: I2f8a9a6982ce0ce77187ae4b7a58b3ef752aab34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da85f559_839d05be","line":20,"updated":"2015-11-10 22:08:53.000000000","message":"typo: neutron instead of neutronc","commit_id":"01d923161d7bfaa12beeebc8d4c9a886db30a8a8"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ac488cc3e460759c91144e4fb5dc0caaab5daaa6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"    def get_deletable_bridges(self):"},{"line_number":167,"context_line":"        bridge_list \u003d bridge_lib.get_bridge_names()"},{"line_number":168,"context_line":"        bridges \u003d {b for b in bridge_list if b.startswith(BRIDGE_NAME_PREFIX)}"},{"line_number":169,"context_line":"        bridges.difference_update(self.bridge_mappings.values())"},{"line_number":170,"context_line":"        return bridges"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def get_tap_devices_count(self, bridge_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_80538ee1","line":169,"updated":"2015-11-11 17:51:23.000000000","message":"Note:  I\u0027m a little sad that the docs [1] claim that the following code should be equivalent but its not.  I would like it better.\n\n  bridges -\u003d self.bridge_mappings.values()\n\n [1] https://docs.python.org/2/library/sets.html","commit_id":"cc2d30eba4f7b2d0676dd308c9c9fe6328e44447"}],"neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/test_linuxbridge_neutron_agent.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"86baa0b8ce8d969d563a8cf402b035a2a3fa0f22","unresolved":false,"context_lines":[{"line_number":461,"context_line":""},{"line_number":462,"context_line":"    def test_get_deletable_bridges(self):"},{"line_number":463,"context_line":"        br_list \u003d [\"br-int\", \"brq1\", \"brq2\", \"br-ex\"]"},{"line_number":464,"context_line":"        result \u003d {\"brq1\", \"brq2\"}"},{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        with mock.patch.object(os, \u0027listdir\u0027) as listdir_fn:"},{"line_number":467,"context_line":"            listdir_fn.return_value \u003d br_list"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_5fb374e9","line":464,"updated":"2015-11-06 06:24:11.000000000","message":"Maybe add:\n\n    self.bridge_mappings[\u0027phy1\u0027] \u003d \u0027brq-eth\u0027\n\nwill be more suitable with the logic in get_deletable_bridges","commit_id":"19a937ff768121e67ab7963d661f6aa169448496"}]}
