)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"140dc1ca1e506fab8b67797be70e5e724c716c4a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make network segment table available for standalone plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some standalone plugins, such as networking-ovn, are expecting"},{"line_number":10,"context_line":"to store provider network infor in neutron database, but we have"},{"line_number":11,"context_line":"no table, like other extensions do, for provider network extension"},{"line_number":12,"context_line":"defined."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_52e16dcf","line":10,"updated":"2015-11-09 19:50:07.000000000","message":"infor \u003d\u003e info or information","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f60b265adac3bd2ede35646a13e3be7efa77df7c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Make network segment table available for standalone plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some standalone plugins, such as networking-ovn, are expecting"},{"line_number":10,"context_line":"to store provider network infor in neutron database, but we have"},{"line_number":11,"context_line":"no table, like other extensions do, for provider network extension"},{"line_number":12,"context_line":"defined."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_bd3e61d8","line":10,"in_reply_to":"da85f559_52e16dcf","updated":"2015-11-09 23:55:52.000000000","message":"Done","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cef06bfef92d01801e89f40df931a091e16b5ded","unresolved":false,"context_lines":[{"line_number":12,"context_line":"defined."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves NetworkSegment table out of ML2 code tree, but"},{"line_number":15,"context_line":"keep the table name so that we don\u0027t need to add database"},{"line_number":16,"context_line":"migration scripts."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2c4f78fce591486ded63252af13fc0c60d02a3e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_a055fbc6","line":15,"updated":"2015-11-09 12:08:22.000000000","message":"name -\u003e name for now","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f60b265adac3bd2ede35646a13e3be7efa77df7c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"defined."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves NetworkSegment table out of ML2 code tree, but"},{"line_number":15,"context_line":"keep the table name so that we don\u0027t need to add database"},{"line_number":16,"context_line":"migration scripts."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2c4f78fce591486ded63252af13fc0c60d02a3e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_5d2655cf","line":15,"in_reply_to":"da85f559_a055fbc6","updated":"2015-11-09 23:55:52.000000000","message":"Done","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b60aa28579f71cdbed02cb4ef435ce205f71b398","unresolved":false,"context_lines":[{"line_number":12,"context_line":"network extension defined."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves NetworkSegment table out of ML2 code tree, but"},{"line_number":15,"context_line":"keep the table name for now so that we don\u0027t need to add database"},{"line_number":16,"context_line":"migration scripts."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2c4f78fce591486ded63252af13fc0c60d02a3e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da85f559_e0ebd976","line":15,"updated":"2015-11-10 03:32:25.000000000","message":"I think we should do this in the same change.","commit_id":"347f5ef1423fb160eed3e3823cb5e1a9fc80abd5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a8cbc958da9a7e09162289d48b69c543c7e9ba41","unresolved":false,"context_lines":[{"line_number":12,"context_line":"network extension defined."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves NetworkSegment table out of ML2 code tree, but"},{"line_number":15,"context_line":"keep the table name for now so that we don\u0027t need to add database"},{"line_number":16,"context_line":"migration scripts."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I2c4f78fce591486ded63252af13fc0c60d02a3e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da85f559_c309ff2d","line":15,"in_reply_to":"da85f559_e0ebd976","updated":"2015-11-10 03:42:20.000000000","message":"please see\nhttps://review.openstack.org/#/c/242393/2/neutron/db/providernet_db.py\nfor the migration scripts\n\nthanks","commit_id":"347f5ef1423fb160eed3e3823cb5e1a9fc80abd5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"02a850aaadc83faf2320145d4d74657a91bafb41","unresolved":false,"context_lines":[{"line_number":12,"context_line":"network extension defined."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves NetworkSegment table out of ML2 code tree, but"},{"line_number":15,"context_line":"keep the table name for now so that we don\u0027t need to add database"},{"line_number":16,"context_line":"migration scripts."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The API methods to operate segments are also moved, but stub"},{"line_number":19,"context_line":"methods are still kept in ml2 db API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"fa0719c6_31ed548c","line":16,"range":{"start_line":15,"start_character":36,"end_line":16,"end_character":17},"updated":"2016-03-21 09:49:23.000000000","message":"why can\u0027t we add a migration script?","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b641fd0b3abfb179bb3c9d4cb3956c6d71f13be0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"network extension defined."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch moves NetworkSegment table out of ML2 code tree, but"},{"line_number":15,"context_line":"keep the table name for now so that we don\u0027t need to add database"},{"line_number":16,"context_line":"migration scripts."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The API methods to operate segments are also moved, but stub"},{"line_number":19,"context_line":"methods are still kept in ml2 db API."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"fa0719c6_56bb37e5","line":16,"range":{"start_line":15,"start_character":36,"end_line":16,"end_character":17},"in_reply_to":"fa0719c6_31ed548c","updated":"2016-03-22 23:55:30.000000000","message":"Added","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"02a850aaadc83faf2320145d4d74657a91bafb41","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The API methods to operate segments are also moved, but stub"},{"line_number":19,"context_line":"methods are still kept in ml2 db API."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I2c4f78fce591486ded63252af13fc0c60d02a3e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"fa0719c6_713cec2f","line":20,"updated":"2016-03-21 09:49:23.000000000","message":"Please add a link to the blueprint","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b641fd0b3abfb179bb3c9d4cb3956c6d71f13be0","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The API methods to operate segments are also moved, but stub"},{"line_number":19,"context_line":"methods are still kept in ml2 db API."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I2c4f78fce591486ded63252af13fc0c60d02a3e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"fa0719c6_56de9711","line":20,"in_reply_to":"fa0719c6_713cec2f","updated":"2016-03-22 23:55:30.000000000","message":"Done","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"}],"neutron/common/constants.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"22f16a14f7499a1c426d63f1e44df654bfdd1c4c","unresolved":false,"context_lines":[{"line_number":220,"context_line":"# agent has just returned to alive after being dead"},{"line_number":221,"context_line":"AGENT_REVIVED \u003d \u0027revived\u0027"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"ID \u003d \u0027id\u0027"},{"line_number":224,"context_line":"NETWORK_TYPE \u003d \u0027network_type\u0027"},{"line_number":225,"context_line":"PHYSICAL_NETWORK \u003d \u0027physical_network\u0027"},{"line_number":226,"context_line":"SEGMENTATION_ID \u003d \u0027segmentation_id\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_ba6b2bf0","line":223,"range":{"start_line":223,"start_character":0,"end_line":223,"end_character":2},"updated":"2016-01-15 16:20:50.000000000","message":"Can you provide a comment on this magic grouping of constants, and why they\u0027re all together?","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0e932adf3049e2ce0d5eba21a95fb5ca6ccc6d25","unresolved":false,"context_lines":[{"line_number":220,"context_line":"# agent has just returned to alive after being dead"},{"line_number":221,"context_line":"AGENT_REVIVED \u003d \u0027revived\u0027"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"ID \u003d \u0027id\u0027"},{"line_number":224,"context_line":"NETWORK_TYPE \u003d \u0027network_type\u0027"},{"line_number":225,"context_line":"PHYSICAL_NETWORK \u003d \u0027physical_network\u0027"},{"line_number":226,"context_line":"SEGMENTATION_ID \u003d \u0027segmentation_id\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba63e191_ed96a193","line":223,"range":{"start_line":223,"start_character":0,"end_line":223,"end_character":2},"in_reply_to":"da6ed579_ba6b2bf0","updated":"2016-01-19 08:22:23.000000000","message":"Done","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5a1ff6aaabd114169d4b9c77c60be20a0d29c347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"da6ed579_9f709973","line":228,"updated":"2016-01-15 16:20:19.000000000","message":"Nit: I would prefer to have this change done in a follow-up review, where all references are updated together with the creation of the constants.","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"722d0bb1c448144640493b7d986f0d9bba3ba1b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ba63e191_f83addcc","line":228,"in_reply_to":"ba63e191_2d7cb971","updated":"2016-01-19 08:42:00.000000000","message":"Henry Gessau, I have to do it in this review since both providernet_db and ml2 driver_api are using it.\n\nOriginally, they are defined in ml2 driver_api, but the providernet_db is a general feature, which should not depend on ML2 codes.","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0e932adf3049e2ce0d5eba21a95fb5ca6ccc6d25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ba63e191_2d7cb971","line":228,"in_reply_to":"da6ed579_9f709973","updated":"2016-01-19 08:22:23.000000000","message":"Done","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8bae8f4e03beb03e81d57316da96924f321d7449","unresolved":false,"context_lines":[{"line_number":231,"context_line":"NETWORK_TYPE \u003d \u0027network_type\u0027"},{"line_number":232,"context_line":"PHYSICAL_NETWORK \u003d \u0027physical_network\u0027"},{"line_number":233,"context_line":"SEGMENTATION_ID \u003d \u0027segmentation_id\u0027"},{"line_number":234,"context_line":"MTU \u003d \u0027mtu\u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_5d73a215","line":234,"updated":"2016-01-20 02:18:21.000000000","message":"I feel that \u0027id\u0027 and \u0027mtu\u0027 do not belong to this set of keys.\n- \u0027id\u0027 is used in thousands of places without the help of a constant\n- \u0027mtu\u0027 is defined in neutron/extensions/netmtu.py and has nothing to do with providernet\n\nI feel that DB constants like key names might be better placed in neutron/db/constants or something.\n\nHowever, now I am picking on details that are not important to the change you are trying to make. That is why I suggest that you skip the using/changing of these constants to a follow-up patch where these nits can be argued at leisure.","commit_id":"f400e3df41311f9b7f49d96e85b59c49689bd4e4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a33608090fbb678f9b45054fa1523847faf0d858","unresolved":false,"context_lines":[{"line_number":214,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":215,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":216,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), lib_constants)"},{"line_number":217,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"# The following keys are used in the segment dictionaries"},{"line_number":220,"context_line":"# which are defined separately from similar keys in"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aed3d3a_a92ff73c","line":217,"range":{"start_line":217,"start_character":0,"end_line":217,"end_character":58},"updated":"2016-02-26 18:25:27.000000000","message":"I did a trivial conflict resolution when I rebased this patch but it left this problem.  Basically, the introduction of neutron-lib has made it a little bit harder to introduce new global constants.  I think we should rethink whether these new constants below really need to be global constants or if they can be scoped differently.\n\nThe lines below are sure to break at least some check jobs on this patch.  And this has to be cleaned up before merging.","commit_id":"924fc7dc2544846aa8c0c2562452b3ce37f25f2c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f775ea600f458330f8527348a5837498a812850c","unresolved":false,"context_lines":[{"line_number":216,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":217,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":218,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), lib_constants)"},{"line_number":219,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"# The following keys are used in the segment dictionaries"},{"line_number":222,"context_line":"# which are defined separately from similar keys in"}],"source_content_type":"text/x-python","patch_set":13,"id":"7af24918_6a04d5bf","line":219,"range":{"start_line":219,"start_character":2,"end_line":219,"end_character":58},"updated":"2016-03-02 00:32:27.000000000","message":"Since I kind of created this mess by rebasing and doing a trivial conflict resolution, I\u0027ll at least clean this up so that these aren\u0027t added before this line.","commit_id":"dd4c1ed771158c1ff62a2243f1ec77a4c6e2b760"}],"neutron/db/migration/alembic_migrations/versions/EXPAND_HEAD":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"93e63fce65aee8e4506a6ce9795348a2afbb77a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fa0719c6_acd9a285","updated":"2016-03-23 01:14:07.000000000","message":"This must go in CONTRACT_HEAD","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ed99d7a562c371433ba54d90de3275c0d4f804f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fa0719c6_cc64af23","in_reply_to":"fa0719c6_acd9a285","updated":"2016-03-23 15:44:23.000000000","message":"Done","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"}],"neutron/db/migration/alembic_migrations/versions/newton/contract/89ab9a816d70_rename_ml2_network_segments.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6047071f2d611d9b83e9ccaef03870b08c884535","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        constraint_name\u003dfk_name,"},{"line_number":42,"context_line":"        source_table\u003dTABLE_NAME,"},{"line_number":43,"context_line":"        referent_table\u003dNEW_REFERRED_TABLE_NAME,"},{"line_number":44,"context_line":"        local_cols\u003d\u0027segment_id\u0027,"},{"line_number":45,"context_line":"        remote_cols\u003d\u0027id\u0027,"},{"line_number":46,"context_line":"        ondelete\u003d\"SET NULL\""},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"da0c15f0_2daa17d5","line":45,"range":{"start_line":44,"start_character":8,"end_line":45,"end_character":25},"updated":"2016-03-24 23:50:36.000000000","message":"These should be arrays:\n\n        local_cols\u003d\u0027segment_id\u0027,\n        remote_cols\u003d\u0027id\u0027,","commit_id":"4bb36a1db804fcdbe5df0ae2dea1632493714602"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c33c9b5e68e0488ae5a2fb8c17a4bbd14f09760e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        constraint_name\u003dfk_name,"},{"line_number":42,"context_line":"        source_table\u003dTABLE_NAME,"},{"line_number":43,"context_line":"        referent_table\u003dNEW_REFERRED_TABLE_NAME,"},{"line_number":44,"context_line":"        local_cols\u003d\u0027segment_id\u0027,"},{"line_number":45,"context_line":"        remote_cols\u003d\u0027id\u0027,"},{"line_number":46,"context_line":"        ondelete\u003d\"SET NULL\""},{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"da0c15f0_1082cc52","line":45,"range":{"start_line":44,"start_character":8,"end_line":45,"end_character":25},"in_reply_to":"da0c15f0_2daa17d5","updated":"2016-03-25 00:24:40.000000000","message":"Done","commit_id":"4bb36a1db804fcdbe5df0ae2dea1632493714602"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"31c6148cda726f65a0e8038861df7a04037724b9","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def delete_foreign_key_constraint():"},{"line_number":51,"context_line":"    inspector \u003d reflection.Inspector.from_engine(op.get_bind())"},{"line_number":52,"context_line":"    fk_constraints \u003d inspector.get_foreign_keys(TABLE_NAME)"},{"line_number":53,"context_line":"    for fk in fk_constraints:"}],"source_content_type":"text/x-python","patch_set":20,"id":"da0c15f0_4cf5d281","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":33},"updated":"2016-03-24 22:07:55.000000000","message":"I wonder if we should call this \"retarget_foreign_key_constraint\", include the create_foreign_key call, and make it a utility or something.  That could be another patch though.  It would be tricky because you\u0027ve got to drop the FK, then rename the table, and then create it.  That could be done with a simple context manager.  I\u0027m just rambling now.  Don\u0027t do this in this patch.","commit_id":"4bb36a1db804fcdbe5df0ae2dea1632493714602"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"c33c9b5e68e0488ae5a2fb8c17a4bbd14f09760e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    )"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def delete_foreign_key_constraint():"},{"line_number":51,"context_line":"    inspector \u003d reflection.Inspector.from_engine(op.get_bind())"},{"line_number":52,"context_line":"    fk_constraints \u003d inspector.get_foreign_keys(TABLE_NAME)"},{"line_number":53,"context_line":"    for fk in fk_constraints:"}],"source_content_type":"text/x-python","patch_set":20,"id":"da0c15f0_507c4472","line":50,"range":{"start_line":50,"start_character":4,"end_line":50,"end_character":33},"in_reply_to":"da0c15f0_4cf5d281","updated":"2016-03-25 00:24:40.000000000","message":"Ignored this","commit_id":"4bb36a1db804fcdbe5df0ae2dea1632493714602"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d5762db0f035fa5e0db5309dcd8a9e2393db6d6d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"TABLE_NAME \u003d \u0027ml2_port_binding_levels\u0027"},{"line_number":30,"context_line":"OLD_REFERRED_TABLE_NAME \u003d \u0027ml2_network_segments\u0027"},{"line_number":31,"context_line":"NEW_REFERRED_TABLE_NAME \u003d \u0027networksegments\u0027"},{"line_number":32,"context_line":"FK_NAME_FORMAT \u003d \u0027fk_%(table_name)s_segment_id_%(referred_table_name)s\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":21,"id":"da0c15f0_571423f4","line":32,"updated":"2016-03-25 14:27:41.000000000","message":"This is not the name generated by the backend. I am not sure if it really makes a difference, but it\u0027s easy to preserve the name so let\u0027s do it.","commit_id":"41b2e264369bf39091980ad80b5e4aebf0f1ba8d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81bcb80ef96e320ae505c5f9b8ee44fc43a44d91","unresolved":false,"context_lines":[{"line_number":29,"context_line":"TABLE_NAME \u003d \u0027ml2_port_binding_levels\u0027"},{"line_number":30,"context_line":"OLD_REFERRED_TABLE_NAME \u003d \u0027ml2_network_segments\u0027"},{"line_number":31,"context_line":"NEW_REFERRED_TABLE_NAME \u003d \u0027networksegments\u0027"},{"line_number":32,"context_line":"FK_NAME_FORMAT \u003d \u0027fk_%(table_name)s_segment_id_%(referred_table_name)s\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"}],"source_content_type":"text/x-python","patch_set":21,"id":"da0c15f0_0d4f38be","line":32,"in_reply_to":"da0c15f0_571423f4","updated":"2016-03-25 15:05:00.000000000","message":"Done","commit_id":"41b2e264369bf39091980ad80b5e4aebf0f1ba8d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d5762db0f035fa5e0db5309dcd8a9e2393db6d6d","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    delete_foreign_key_constraint()"},{"line_number":37,"context_line":"    op.rename_table(OLD_REFERRED_TABLE_NAME, NEW_REFERRED_TABLE_NAME)"},{"line_number":38,"context_line":"    fk_name \u003d FK_NAME_FORMAT % {\u0027table_name\u0027: TABLE_NAME,"},{"line_number":39,"context_line":"                                \u0027referred_table_name\u0027: NEW_REFERRED_TABLE_NAME}"}],"source_content_type":"text/x-python","patch_set":21,"id":"da0c15f0_f7f1f7ce","line":36,"updated":"2016-03-25 14:27:41.000000000","message":"fk_name \u003d delete_foreign_key_constraint()","commit_id":"41b2e264369bf39091980ad80b5e4aebf0f1ba8d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81bcb80ef96e320ae505c5f9b8ee44fc43a44d91","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    delete_foreign_key_constraint()"},{"line_number":37,"context_line":"    op.rename_table(OLD_REFERRED_TABLE_NAME, NEW_REFERRED_TABLE_NAME)"},{"line_number":38,"context_line":"    fk_name \u003d FK_NAME_FORMAT % {\u0027table_name\u0027: TABLE_NAME,"},{"line_number":39,"context_line":"                                \u0027referred_table_name\u0027: NEW_REFERRED_TABLE_NAME}"}],"source_content_type":"text/x-python","patch_set":21,"id":"da0c15f0_ed9004ef","line":36,"in_reply_to":"da0c15f0_f7f1f7ce","updated":"2016-03-25 15:05:00.000000000","message":"Done","commit_id":"41b2e264369bf39091980ad80b5e4aebf0f1ba8d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d5762db0f035fa5e0db5309dcd8a9e2393db6d6d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    delete_foreign_key_constraint()"},{"line_number":37,"context_line":"    op.rename_table(OLD_REFERRED_TABLE_NAME, NEW_REFERRED_TABLE_NAME)"},{"line_number":38,"context_line":"    fk_name \u003d FK_NAME_FORMAT % {\u0027table_name\u0027: TABLE_NAME,"},{"line_number":39,"context_line":"                                \u0027referred_table_name\u0027: NEW_REFERRED_TABLE_NAME}"},{"line_number":40,"context_line":"    op.create_foreign_key("},{"line_number":41,"context_line":"        constraint_name\u003dfk_name,"},{"line_number":42,"context_line":"        source_table\u003dTABLE_NAME,"}],"source_content_type":"text/x-python","patch_set":21,"id":"da0c15f0_77b4c7f1","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":79},"updated":"2016-03-25 14:27:41.000000000","message":"remove","commit_id":"41b2e264369bf39091980ad80b5e4aebf0f1ba8d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81bcb80ef96e320ae505c5f9b8ee44fc43a44d91","unresolved":false,"context_lines":[{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    delete_foreign_key_constraint()"},{"line_number":37,"context_line":"    op.rename_table(OLD_REFERRED_TABLE_NAME, NEW_REFERRED_TABLE_NAME)"},{"line_number":38,"context_line":"    fk_name \u003d FK_NAME_FORMAT % {\u0027table_name\u0027: TABLE_NAME,"},{"line_number":39,"context_line":"                                \u0027referred_table_name\u0027: NEW_REFERRED_TABLE_NAME}"},{"line_number":40,"context_line":"    op.create_foreign_key("},{"line_number":41,"context_line":"        constraint_name\u003dfk_name,"},{"line_number":42,"context_line":"        source_table\u003dTABLE_NAME,"}],"source_content_type":"text/x-python","patch_set":21,"id":"da0c15f0_cd7700d3","line":39,"range":{"start_line":38,"start_character":0,"end_line":39,"end_character":79},"in_reply_to":"da0c15f0_77b4c7f1","updated":"2016-03-25 15:05:00.000000000","message":"Done","commit_id":"41b2e264369bf39091980ad80b5e4aebf0f1ba8d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d5762db0f035fa5e0db5309dcd8a9e2393db6d6d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    for fk in fk_constraints:"},{"line_number":54,"context_line":"        if fk[\u0027referred_table\u0027] \u003d\u003d OLD_REFERRED_TABLE_NAME:"},{"line_number":55,"context_line":"            op.drop_constraint("},{"line_number":56,"context_line":"                constraint_name\u003dfk[\u0027name\u0027],"},{"line_number":57,"context_line":"                table_name\u003dTABLE_NAME,"},{"line_number":58,"context_line":"                type_\u003d\u0027foreignkey\u0027"},{"line_number":59,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":21,"id":"da0c15f0_77268769","line":56,"updated":"2016-03-25 14:27:41.000000000","message":"Save this name and return it from this method.","commit_id":"41b2e264369bf39091980ad80b5e4aebf0f1ba8d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"81bcb80ef96e320ae505c5f9b8ee44fc43a44d91","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    for fk in fk_constraints:"},{"line_number":54,"context_line":"        if fk[\u0027referred_table\u0027] \u003d\u003d OLD_REFERRED_TABLE_NAME:"},{"line_number":55,"context_line":"            op.drop_constraint("},{"line_number":56,"context_line":"                constraint_name\u003dfk[\u0027name\u0027],"},{"line_number":57,"context_line":"                table_name\u003dTABLE_NAME,"},{"line_number":58,"context_line":"                type_\u003d\u0027foreignkey\u0027"},{"line_number":59,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":21,"id":"da0c15f0_8d3b48eb","line":56,"in_reply_to":"da0c15f0_77268769","updated":"2016-03-25 15:05:00.000000000","message":"Done","commit_id":"41b2e264369bf39091980ad80b5e4aebf0f1ba8d"}],"neutron/db/migration/alembic_migrations/versions/newton/expand/89ab9a816d70_rename_ml2_network_segments.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"93e63fce65aee8e4506a6ce9795348a2afbb77a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fa0719c6_2cd47245","updated":"2016-03-23 01:14:07.000000000","message":"This migration must be run offline. Please move it to the contract sub-directory.","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ed99d7a562c371433ba54d90de3275c0d4f804f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"fa0719c6_0ca98790","in_reply_to":"fa0719c6_2cd47245","updated":"2016-03-23 15:44:23.000000000","message":"Done","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"93e63fce65aee8e4506a6ce9795348a2afbb77a8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"Add tables and attributes to support external DNS integration"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 89ab9a816d70"},{"line_number":16,"context_line":"Revises: 45f8dd33480b"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa0719c6_acc0827d","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":64},"updated":"2016-03-23 01:14:07.000000000","message":"\"Rename ml2_network_segments table\"","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ed99d7a562c371433ba54d90de3275c0d4f804f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"\"\"\"Add tables and attributes to support external DNS integration"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 89ab9a816d70"},{"line_number":16,"context_line":"Revises: 45f8dd33480b"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa0719c6_ace33bd8","line":13,"range":{"start_line":13,"start_character":3,"end_line":13,"end_character":64},"in_reply_to":"fa0719c6_acc0827d","updated":"2016-03-23 15:44:23.000000000","message":"Done","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"93e63fce65aee8e4506a6ce9795348a2afbb77a8","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"Add tables and attributes to support external DNS integration"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 89ab9a816d70"},{"line_number":16,"context_line":"Revises: 45f8dd33480b"},{"line_number":17,"context_line":"Create Date: 2016-03-22 00:22:47.618593"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa0719c6_2c3bd29d","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"updated":"2016-03-23 01:14:07.000000000","message":"You\u0027ll need to change this to the current contract head.","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ed99d7a562c371433ba54d90de3275c0d4f804f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"\"\"\"Add tables and attributes to support external DNS integration"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Revision ID: 89ab9a816d70"},{"line_number":16,"context_line":"Revises: 45f8dd33480b"},{"line_number":17,"context_line":"Create Date: 2016-03-22 00:22:47.618593"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa0719c6_ac185bd4","line":16,"range":{"start_line":16,"start_character":9,"end_line":16,"end_character":21},"in_reply_to":"fa0719c6_2c3bd29d","updated":"2016-03-23 15:44:23.000000000","message":"Done","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"93e63fce65aee8e4506a6ce9795348a2afbb77a8","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# revision identifiers, used by Alembic."},{"line_number":22,"context_line":"revision \u003d \u002789ab9a816d70\u0027"},{"line_number":23,"context_line":"down_revision \u003d \u002745f8dd33480b\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa0719c6_8c42de0e","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":29},"updated":"2016-03-23 01:14:07.000000000","message":"You\u0027ll need to change this to the current contract head.","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"6ed99d7a562c371433ba54d90de3275c0d4f804f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# revision identifiers, used by Alembic."},{"line_number":22,"context_line":"revision \u003d \u002789ab9a816d70\u0027"},{"line_number":23,"context_line":"down_revision \u003d \u002745f8dd33480b\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"fa0719c6_4cdd3fdf","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":29},"in_reply_to":"fa0719c6_8c42de0e","updated":"2016-03-23 15:44:23.000000000","message":"Done","commit_id":"016b8e572d46fbc114bde06e8df58d52c4812ab0"}],"neutron/db/migration/models/head.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7a731f61857f004347e1944666b5ce914688b437","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from neutron.db import models_v2  # noqa"},{"line_number":45,"context_line":"from neutron.db import portbindings_db  # noqa"},{"line_number":46,"context_line":"from neutron.db import portsecurity_db  # noqa"},{"line_number":47,"context_line":"from neutron.db import providernet_db  # noqa"},{"line_number":48,"context_line":"from neutron.db.qos import models as qos_models  # noqa"},{"line_number":49,"context_line":"from neutron.db.quota import models  # noqa"},{"line_number":50,"context_line":"from neutron.db import rbac_db_models  # noqa"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_aa8ffd21","line":47,"range":{"start_line":47,"start_character":23,"end_line":47,"end_character":37},"updated":"2016-03-02 00:37:24.000000000","message":"In my patch that I rebased on top of this one, I add a segment_db file.  Now we\u0027ll have three interfaces on top of this DB model:  provider net, multi-provider net, and the new segments API that I\u0027m created.  They are all working on the same model.  I kind of think that they should be combined.\n\nWhat do others think?","commit_id":"21e1ed12950792574f9a272de2d87228cf34ea7c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6211e88787981492c12b5088e0caa07b38511c30","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from neutron.db import models_v2  # noqa"},{"line_number":45,"context_line":"from neutron.db import portbindings_db  # noqa"},{"line_number":46,"context_line":"from neutron.db import portsecurity_db  # noqa"},{"line_number":47,"context_line":"from neutron.db import providernet_db  # noqa"},{"line_number":48,"context_line":"from neutron.db.qos import models as qos_models  # noqa"},{"line_number":49,"context_line":"from neutron.db.quota import models  # noqa"},{"line_number":50,"context_line":"from neutron.db import rbac_db_models  # noqa"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_d75831fd","line":47,"range":{"start_line":47,"start_character":23,"end_line":47,"end_character":37},"in_reply_to":"7af24918_aa8ffd21","updated":"2016-03-02 01:24:57.000000000","message":"I tend to agree. I would leave it for a follow-up though.","commit_id":"21e1ed12950792574f9a272de2d87228cf34ea7c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"07477041119e3f40006de0ee171f4a5b4cb57ee9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from neutron.db import models_v2  # noqa"},{"line_number":45,"context_line":"from neutron.db import portbindings_db  # noqa"},{"line_number":46,"context_line":"from neutron.db import portsecurity_db  # noqa"},{"line_number":47,"context_line":"from neutron.db import providernet_db  # noqa"},{"line_number":48,"context_line":"from neutron.db.qos import models as qos_models  # noqa"},{"line_number":49,"context_line":"from neutron.db.quota import models  # noqa"},{"line_number":50,"context_line":"from neutron.db import rbac_db_models  # noqa"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_68ebef78","line":47,"range":{"start_line":47,"start_character":23,"end_line":47,"end_character":37},"in_reply_to":"7af24918_c83cc3ca","updated":"2016-03-02 23:42:00.000000000","message":"That is what I understood you were saying.","commit_id":"21e1ed12950792574f9a272de2d87228cf34ea7c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2d7100883dcff34cf329746df592fd1b97aa1081","unresolved":false,"context_lines":[{"line_number":44,"context_line":"from neutron.db import models_v2  # noqa"},{"line_number":45,"context_line":"from neutron.db import portbindings_db  # noqa"},{"line_number":46,"context_line":"from neutron.db import portsecurity_db  # noqa"},{"line_number":47,"context_line":"from neutron.db import providernet_db  # noqa"},{"line_number":48,"context_line":"from neutron.db.qos import models as qos_models  # noqa"},{"line_number":49,"context_line":"from neutron.db.quota import models  # noqa"},{"line_number":50,"context_line":"from neutron.db import rbac_db_models  # noqa"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_c83cc3ca","line":47,"range":{"start_line":47,"start_character":23,"end_line":47,"end_character":37},"in_reply_to":"7af24918_d75831fd","updated":"2016-03-02 23:24:48.000000000","message":"I just realized I may not have been clear.  I didn\u0027t mean to combine the extenisons.  I just meant to combine the db model files in to segment_db.","commit_id":"21e1ed12950792574f9a272de2d87228cf34ea7c"}],"neutron/db/providernet_db.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b3cb450b354537c6c4b4dc423f77bf4ce519dba4","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    one or more segments."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":47,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_c892c157","line":44,"updated":"2015-11-08 09:17:29.000000000","message":"if tis is moved out of the ml2 for a more generic purpose then why does it still have the ml2_ prefix?","commit_id":"4eea52a9eb8342e5ee9565ffefc302af82500203"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"056e9fc2464bdd0e6b61d7da144c45021057c7d8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    one or more segments."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":47,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_0849a98b","line":44,"in_reply_to":"da85f559_c892c157","updated":"2015-11-08 10:25:04.000000000","message":"In this case there should be sent migration that will rename table in db.","commit_id":"4eea52a9eb8342e5ee9565ffefc302af82500203"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cef06bfef92d01801e89f40df931a091e16b5ded","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\"\"\""},{"line_number":26,"context_line":"Some standalone plugins, such as networking-ovn, are expecting"},{"line_number":27,"context_line":"the db table to save provider network information. But we have"},{"line_number":28,"context_line":"no such table here like other extensions."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This model is from ML2 plugin, to keep the table name"},{"line_number":31,"context_line":"so that we don\u0027t need to change migration script."}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_20990b6f","line":28,"updated":"2015-11-09 12:08:22.000000000","message":"This comment makes sense during this review, but will look a bit strange after the code is committed. How about:\n\nSome standalone plugins need a DB table to store provider network information. Initially there was no such table, but in Mitaka the ML2 NetworkSegment table was promoted here.","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"140dc1ca1e506fab8b67797be70e5e724c716c4a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\"\"\""},{"line_number":26,"context_line":"Some standalone plugins, such as networking-ovn, are expecting"},{"line_number":27,"context_line":"the db table to save provider network information. But we have"},{"line_number":28,"context_line":"no such table here like other extensions."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This model is from ML2 plugin, to keep the table name"},{"line_number":31,"context_line":"so that we don\u0027t need to change migration script."}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_52f2cd70","line":28,"in_reply_to":"da85f559_20990b6f","updated":"2015-11-09 19:50:07.000000000","message":"+1","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f60b265adac3bd2ede35646a13e3be7efa77df7c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"\"\"\""},{"line_number":26,"context_line":"Some standalone plugins, such as networking-ovn, are expecting"},{"line_number":27,"context_line":"the db table to save provider network information. But we have"},{"line_number":28,"context_line":"no such table here like other extensions."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This model is from ML2 plugin, to keep the table name"},{"line_number":31,"context_line":"so that we don\u0027t need to change migration script."}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_bdebc177","line":28,"in_reply_to":"da85f559_20990b6f","updated":"2015-11-09 23:55:52.000000000","message":"Done","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cef06bfef92d01801e89f40df931a091e16b5ded","unresolved":false,"context_lines":[{"line_number":28,"context_line":"no such table here like other extensions."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This model is from ML2 plugin, to keep the table name"},{"line_number":31,"context_line":"so that we don\u0027t need to change migration script."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_80bb17c4","line":31,"updated":"2015-11-09 12:08:22.000000000","message":"I would move this paragraph to a comment at line 44.","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"f60b265adac3bd2ede35646a13e3be7efa77df7c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"no such table here like other extensions."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This model is from ML2 plugin, to keep the table name"},{"line_number":31,"context_line":"so that we don\u0027t need to change migration script."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_5d03b542","line":31,"in_reply_to":"da85f559_80bb17c4","updated":"2015-11-09 23:55:52.000000000","message":"Done","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"0aaf2b193b1db0593b1f2e61d21864ae0d7d1def","unresolved":false,"context_lines":[{"line_number":28,"context_line":"no such table here like other extensions."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This model is from ML2 plugin, to keep the table name"},{"line_number":31,"context_line":"so that we don\u0027t need to change migration script."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_dbeef121","line":31,"in_reply_to":"da85f559_80bb17c4","updated":"2015-11-09 12:41:12.000000000","message":"Yes, that is a good suggestion. If so then I am good with this.","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"140dc1ca1e506fab8b67797be70e5e724c716c4a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"no such table here like other extensions."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"This model is from ML2 plugin, to keep the table name"},{"line_number":31,"context_line":"so that we don\u0027t need to change migration script."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"\"\"\""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_f5572b00","line":31,"in_reply_to":"da85f559_dbeef121","updated":"2015-11-09 19:50:07.000000000","message":"Me too","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a58c4ffe8a97541f7c21cbf5fdbcad4983a79503","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    one or more segments."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":47,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_41dd3e41","line":44,"updated":"2015-11-09 08:28:18.000000000","message":"i have an issue with the table name. It may just be cosmetic. For example if we are using ovn why would we have to see a table rhat has ml2_network_segments populated. The OVN plugin does not use the ml2 interface and it is a monolithic one now (or so I understood a few months ago)","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cef06bfef92d01801e89f40df931a091e16b5ded","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    one or more segments."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":47,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_20358b45","line":44,"in_reply_to":"da85f559_0c7c4671","updated":"2015-11-09 12:08:22.000000000","message":"I suggest doing a follow-up review for this, where we can discuss the pros/cons of renaming.","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"137b103d3556e44b3406743b1569ac003ea2a3ec","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    one or more segments."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":47,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_f5c41e41","line":44,"in_reply_to":"da85f559_20358b45","updated":"2015-11-09 14:40:46.000000000","message":"I agree with Henry, also I assume that renaming should be contract and we are trying to reduce number of such migrations, so I doubt that it really needed.","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"ee5cd7dc94c02e5e72dc404a465bb7f1ebd87fed","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    one or more segments."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":47,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_8c1d9668","line":44,"in_reply_to":"da85f559_41dd3e41","updated":"2015-11-09 10:25:32.000000000","message":"Yes, it is a monolithic one now. To keep the table name is for the purpose not to create a new table and introduce migration scripts.","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"0d7c6861a2eed17b376d2e6c34b557d0f297db41","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    one or more segments."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":47,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_0c7c4671","line":44,"in_reply_to":"da85f559_8c1d9668","updated":"2015-11-09 10:27:19.000000000","message":"so what is your suggust? we change this table name?","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"c870929a8f1287a3141d2ceadc2b1e4ac995e9a9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    one or more segments."},{"line_number":42,"context_line":"    \"\"\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":47,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_70091c2c","line":44,"in_reply_to":"da85f559_f5c41e41","updated":"2015-11-09 14:45:40.000000000","message":"I agree.  I think as long as the code is well commented to explain why it has the ml2 prefix but that it\u0027s not limited to ml2 anymore, it\u0027s OK.  It\u0027s probably worth dealing with an ugly name to avoid a db migration if it\u0027s not *really* needed.","commit_id":"b9fa4ae60a2df44024aa902e9c0e8c546a1a8e87"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"88a2b9f105e258e32c8ed24200935615c578ab78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_2b7d47b1","line":2,"updated":"2015-11-10 00:56:11.000000000","message":"We don\u0027t need Copyright for OpenStack Foundation.","commit_id":"5f3119cbc894e98d4df5e0a0a3d2436fd2b6c149"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"764d17885f5e5f1b6d19b35bf6113adbf2713824","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_c0ca55a1","line":2,"in_reply_to":"da85f559_2b7d47b1","updated":"2015-11-10 03:02:54.000000000","message":"Done","commit_id":"5f3119cbc894e98d4df5e0a0a3d2436fd2b6c149"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b60aa28579f71cdbed02cb4ef435ce205f71b398","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":"Some standalone plugins need a DB table to store provider"},{"line_number":24,"context_line":"network information. Initially there was no such table,"},{"line_number":25,"context_line":"but in Mitaka the ML2 NetworkSegment table was promoted here."},{"line_number":26,"context_line":"\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_80552d51","line":25,"updated":"2015-11-10 03:32:25.000000000","message":"nit: I think this should just be in the commit message.","commit_id":"347f5ef1423fb160eed3e3823cb5e1a9fc80abd5"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b1605a277b6339af132ba669617288febdbbd212","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":"Some standalone plugins need a DB table to store provider"},{"line_number":24,"context_line":"network information. Initially there was no such table,"},{"line_number":25,"context_line":"but in Mitaka the ML2 NetworkSegment table was promoted here."},{"line_number":26,"context_line":"\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_7022aebb","line":25,"in_reply_to":"7a740942_1702570a","updated":"2015-12-14 17:50:00.000000000","message":"okay","commit_id":"347f5ef1423fb160eed3e3823cb5e1a9fc80abd5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"5e0bd701cf8357e77f536b389c4c069f15722560","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":"Some standalone plugins need a DB table to store provider"},{"line_number":24,"context_line":"network information. Initially there was no such table,"},{"line_number":25,"context_line":"but in Mitaka the ML2 NetworkSegment table was promoted here."},{"line_number":26,"context_line":"\"\"\""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_1702570a","line":25,"in_reply_to":"da85f559_80552d51","updated":"2015-12-09 00:59:21.000000000","message":"I prefer to leave some message in the code, otherwise some guys which do not get this message from the commit msg will be confused.","commit_id":"347f5ef1423fb160eed3e3823cb5e1a9fc80abd5"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"aac1613e248511bbc8e09d2c9aa933e880e57e91","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                      {\u0027network_id\u0027: network_id,"},{"line_number":134,"context_line":"                       \u0027physnet\u0027: physical_network,"},{"line_number":135,"context_line":"                       \u0027segmentation_id\u0027: segmentation_id})"},{"line_number":136,"context_line":"            return None"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def delete_network_segment(session, segment_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_dddcbd48","line":136,"updated":"2016-01-12 08:55:23.000000000","message":"nit none not needed.","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"3e6ce6f9b46a41f94adcd2b78411a78c87c01409","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                      {\u0027network_id\u0027: network_id,"},{"line_number":134,"context_line":"                       \u0027physnet\u0027: physical_network,"},{"line_number":135,"context_line":"                       \u0027segmentation_id\u0027: segmentation_id})"},{"line_number":136,"context_line":"            return None"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"def delete_network_segment(session, segment_id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_af6d0234","line":136,"in_reply_to":"da6ed579_dddcbd48","updated":"2016-01-12 11:53:48.000000000","message":"yes","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8bae8f4e03beb03e81d57316da96924f321d7449","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron._i18n import _LI"},{"line_number":20,"context_line":"from neutron.common import constants as n_const"},{"line_number":21,"context_line":"from neutron.db import model_base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_f882a451","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":47},"updated":"2016-01-20 02:18:21.000000000","message":"I would skip this and just use the raw strings for keys for now.","commit_id":"f400e3df41311f9b7f49d96e85b59c49689bd4e4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"cd785d8abf7f99f873241d2985952e5467746f44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"9aed3d3a_8907931b","updated":"2016-02-26 18:35:22.000000000","message":"I\u0027m actually starting the process of promoting Segments to be a first class object with a new extension and API.  It will share the DB backend with the provider and multi-provider extensions which is why I got interested in this patch set.\n\nWould you be open to renaming this from providernet_db.py to segment_db.py to reflect what its new role will be?","commit_id":"924fc7dc2544846aa8c0c2562452b3ce37f25f2c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"a33608090fbb678f9b45054fa1523847faf0d858","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    one or more segments."},{"line_number":40,"context_line":"    \"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":45,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aed3d3a_c9e99b1c","line":42,"range":{"start_line":42,"start_character":21,"end_line":42,"end_character":25},"updated":"2016-02-26 18:25:27.000000000","message":"How about renaming the table?  I think that a migration can rename tables, right?  Anyway, the ml2_ prefix is misleading now that this is intended to be used by other plugins.","commit_id":"924fc7dc2544846aa8c0c2562452b3ce37f25f2c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1ba74babc05297b27a4ad82703b9288faac2baae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7af24918_d21ce66c","updated":"2016-03-04 23:58:27.000000000","message":"Rename to segment_db","commit_id":"65cac733c34edc4e309832d871a2ef3a25a0c9b2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8d5c88ce14eb849d3d5a404642caa679819cd444","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fa0719c6_c6f25f6f","in_reply_to":"7af24918_d21ce66c","updated":"2016-03-21 08:48:54.000000000","message":"+1 with the renaming, it will be more clear.","commit_id":"65cac733c34edc4e309832d871a2ef3a25a0c9b2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8d5c88ce14eb849d3d5a404642caa679819cd444","unresolved":false,"context_lines":[{"line_number":26,"context_line":"\"\"\""},{"line_number":27,"context_line":"Some standalone plugins need a DB table to store provider"},{"line_number":28,"context_line":"network information. Initially there was no such table,"},{"line_number":29,"context_line":"but in Mitaka the ML2 NetworkSegment table was promoted here."},{"line_number":30,"context_line":"\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_86f98750","line":29,"range":{"start_line":29,"start_character":7,"end_line":29,"end_character":13},"updated":"2016-03-21 08:48:54.000000000","message":"Should this update to Newton?","commit_id":"65cac733c34edc4e309832d871a2ef3a25a0c9b2"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1ba74babc05297b27a4ad82703b9288faac2baae","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    one or more segments."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":15,"id":"7af24918_92125e57","line":41,"range":{"start_line":41,"start_character":21,"end_line":41,"end_character":41},"updated":"2016-03-04 23:58:27.000000000","message":"Rename to network_segments","commit_id":"65cac733c34edc4e309832d871a2ef3a25a0c9b2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8d5c88ce14eb849d3d5a404642caa679819cd444","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    one or more segments."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_a6812b92","line":41,"range":{"start_line":41,"start_character":21,"end_line":41,"end_character":41},"in_reply_to":"7af24918_92125e57","updated":"2016-03-21 08:48:54.000000000","message":"It should be updated to remove the ml2 heading. For the standalone plugin, for example networking-ovn, it will be confused to use segment with table name with ml2 heading.\n\nCheck the comment in PS2, it is suggested to rename the table in a follow up patch, to restrict the scope of this patch.","commit_id":"65cac733c34edc4e309832d871a2ef3a25a0c9b2"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"3dbef6466a50a99c7c3c38a1d6fa35bcdd231144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"fa0719c6_612dd645","updated":"2016-03-22 22:20:19.000000000","message":"What would you think about renaming providernet_db to segment_db?  I think it fits a little better and since we\u0027re creating the file new anyway, it should be trivial to rename it before merge.","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b641fd0b3abfb179bb3c9d4cb3956c6d71f13be0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"fa0719c6_f34a5dab","in_reply_to":"fa0719c6_612dd645","updated":"2016-03-22 23:55:30.000000000","message":"Done","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"852800d5e3fa02b7b5d2af21fd386781e9a66d93","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from oslo_utils import uuidutils"},{"line_number":15,"context_line":"import sqlalchemy as sa"},{"line_number":16,"context_line":"from sqlalchemy.orm import exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron._i18n import _LI"},{"line_number":20,"context_line":"from neutron.db import model_base"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa0719c6_4ee785e4","line":17,"updated":"2016-03-21 09:21:27.000000000","message":"one to many new lines","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b641fd0b3abfb179bb3c9d4cb3956c6d71f13be0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"from oslo_utils import uuidutils"},{"line_number":15,"context_line":"import sqlalchemy as sa"},{"line_number":16,"context_line":"from sqlalchemy.orm import exc"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron._i18n import _LI"},{"line_number":20,"context_line":"from neutron.db import model_base"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa0719c6_564e976f","line":17,"in_reply_to":"fa0719c6_4ee785e4","updated":"2016-03-22 23:55:30.000000000","message":"Done","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"852800d5e3fa02b7b5d2af21fd386781e9a66d93","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron._i18n import _LI"},{"line_number":20,"context_line":"from neutron.db import model_base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa0719c6_4efe656c","line":21,"updated":"2016-03-21 09:21:27.000000000","message":"ditto","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b641fd0b3abfb179bb3c9d4cb3956c6d71f13be0","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron._i18n import _LI"},{"line_number":20,"context_line":"from neutron.db import model_base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"fa0719c6_96582f34","line":21,"in_reply_to":"fa0719c6_4efe656c","updated":"2016-03-22 23:55:30.000000000","message":"Done","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"852800d5e3fa02b7b5d2af21fd386781e9a66d93","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    one or more segments."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa0719c6_0e2bcdec","line":41,"updated":"2016-03-21 09:21:27.000000000","message":"why do we have the ml2 prefix?","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"02a850aaadc83faf2320145d4d74657a91bafb41","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    one or more segments."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa0719c6_71d86cf0","line":41,"in_reply_to":"fa0719c6_0e2bcdec","updated":"2016-03-21 09:49:23.000000000","message":"commit message says it is to avoid db migration scripts.","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b641fd0b3abfb179bb3c9d4cb3956c6d71f13be0","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    one or more segments."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":44,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa0719c6_b63d73bd","line":41,"in_reply_to":"fa0719c6_71d86cf0","updated":"2016-03-22 23:55:30.000000000","message":"This has been removed. It is \u0027networksegments\u0027 now","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"852800d5e3fa02b7b5d2af21fd386781e9a66d93","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        session.add(record)"},{"line_number":80,"context_line":"        segment[\u0027id\u0027] \u003d record.id"},{"line_number":81,"context_line":"    LOG.info(_LI(\"Added segment %(id)s of type %(network_type)s for network\""},{"line_number":82,"context_line":"                 \" %(network_id)s\"),"},{"line_number":83,"context_line":"             {\u0027id\u0027: record.id,"},{"line_number":84,"context_line":"              \u0027network_type\u0027: record.network_type,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa0719c6_6e3c0930","line":81,"updated":"2016-03-21 09:21:27.000000000","message":"nit - please have the space at the end of the line","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b641fd0b3abfb179bb3c9d4cb3956c6d71f13be0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        session.add(record)"},{"line_number":80,"context_line":"        segment[\u0027id\u0027] \u003d record.id"},{"line_number":81,"context_line":"    LOG.info(_LI(\"Added segment %(id)s of type %(network_type)s for network\""},{"line_number":82,"context_line":"                 \" %(network_id)s\"),"},{"line_number":83,"context_line":"             {\u0027id\u0027: record.id,"},{"line_number":84,"context_line":"              \u0027network_type\u0027: record.network_type,"}],"source_content_type":"text/x-python","patch_set":16,"id":"fa0719c6_f647eb48","line":81,"in_reply_to":"fa0719c6_6e3c0930","updated":"2016-03-22 23:55:30.000000000","message":"Done","commit_id":"39e02dafde96956aa71cec930ea78a64e98254f8"}],"neutron/plugins/ml2/db.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"0937760a8c00222a2ed8d7b67d6a5f4e1c3bd3d9","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            api.SEGMENTATION_ID: record.segmentation_id}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def add_network_segment(session, network_id, segment, segment_index\u003d0,"},{"line_number":48,"context_line":"                        is_dynamic\u003dFalse):"},{"line_number":49,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":50,"context_line":"        record \u003d providernet_db.NetworkSegment("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_090af826","line":47,"range":{"start_line":47,"start_character":4,"end_line":47,"end_character":23},"updated":"2015-12-15 11:28:19.000000000","message":"why don\u0027t you move these functions along with the models?","commit_id":"347f5ef1423fb160eed3e3823cb5e1a9fc80abd5"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"290e73defbb20394b5755ac54a3481d2ffc1db22","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            api.SEGMENTATION_ID: record.segmentation_id}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def add_network_segment(session, network_id, segment, segment_index\u003d0,"},{"line_number":48,"context_line":"                        is_dynamic\u003dFalse):"},{"line_number":49,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":50,"context_line":"        record \u003d providernet_db.NetworkSegment("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_6b26066a","line":47,"in_reply_to":"5a710552_090af826","updated":"2015-12-15 14:39:49.000000000","message":"Good point.","commit_id":"347f5ef1423fb160eed3e3823cb5e1a9fc80abd5"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"48233bb29e309a6908488239f87b02270d5eb09b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            api.SEGMENTATION_ID: record.segmentation_id}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def add_network_segment(session, network_id, segment, segment_index\u003d0,"},{"line_number":48,"context_line":"                        is_dynamic\u003dFalse):"},{"line_number":49,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":50,"context_line":"        record \u003d providernet_db.NetworkSegment("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a710552_71634bdd","line":47,"in_reply_to":"5a710552_6b26066a","updated":"2015-12-15 18:58:26.000000000","message":"+1","commit_id":"347f5ef1423fb160eed3e3823cb5e1a9fc80abd5"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"3f3b5ec5f2f3dfe1863a9d770667e0f1a889a2b1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            api.SEGMENTATION_ID: record.segmentation_id}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def add_network_segment(session, network_id, segment, segment_index\u003d0,"},{"line_number":48,"context_line":"                        is_dynamic\u003dFalse):"},{"line_number":49,"context_line":"    with session.begin(subtransactions\u003dTrue):"},{"line_number":50,"context_line":"        record \u003d providernet_db.NetworkSegment("}],"source_content_type":"text/x-python","patch_set":5,"id":"3a7e1126_73d14ffb","line":47,"in_reply_to":"5a710552_71634bdd","updated":"2015-12-17 00:34:01.000000000","message":"Done","commit_id":"347f5ef1423fb160eed3e3823cb5e1a9fc80abd5"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"aac1613e248511bbc8e09d2c9aa933e880e57e91","unresolved":false,"context_lines":[{"line_number":35,"context_line":"MAX_PORTS_PER_QUERY \u003d 500"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The API methods from providernet_db"},{"line_number":38,"context_line":"add_network_segment \u003d providernet_db.add_network_segment"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"get_network_segments \u003d providernet_db.get_network_segments"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_eba9b7e0","line":38,"updated":"2016-01-12 08:55:23.000000000","message":"Can\u0027t we just update the code that uses this file to use providernet_db instead (this way we don\u0027t need to have these mappings here at all). I don\u0027t think anything outside of neutron uses ml2/db.py.","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b007bef4484be4883484d5bb332371ac2eadf240","unresolved":false,"context_lines":[{"line_number":35,"context_line":"MAX_PORTS_PER_QUERY \u003d 500"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The API methods from providernet_db"},{"line_number":38,"context_line":"add_network_segment \u003d providernet_db.add_network_segment"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"get_network_segments \u003d providernet_db.get_network_segments"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_b28d4f33","line":38,"in_reply_to":"da6ed579_0f03ee74","updated":"2016-01-12 19:20:16.000000000","message":"okay.","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"3e6ce6f9b46a41f94adcd2b78411a78c87c01409","unresolved":false,"context_lines":[{"line_number":35,"context_line":"MAX_PORTS_PER_QUERY \u003d 500"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The API methods from providernet_db"},{"line_number":38,"context_line":"add_network_segment \u003d providernet_db.add_network_segment"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"get_network_segments \u003d providernet_db.get_network_segments"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_0f03ee74","line":38,"in_reply_to":"da6ed579_eba9b7e0","updated":"2016-01-12 11:53:48.000000000","message":"can we do it step by step? This will change some codes.\nI mean I can upload one new patch to remove this function references.","commit_id":"4698236436fdd6d01f3d5fcb8b7e25e692c7b00b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8bae8f4e03beb03e81d57316da96924f321d7449","unresolved":false,"context_lines":[{"line_number":35,"context_line":"MAX_PORTS_PER_QUERY \u003d 500"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The API methods from providernet_db"},{"line_number":38,"context_line":"add_network_segment \u003d providernet_db.add_network_segment"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"get_network_segments \u003d providernet_db.get_network_segments"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"get_networks_segments \u003d providernet_db.get_networks_segments"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"get_segment_by_id \u003d providernet_db.get_segment_by_id"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"get_dynamic_segment \u003d providernet_db.get_dynamic_segment"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"delete_network_segment \u003d providernet_db.delete_network_segment"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def add_port_binding(session, port_id):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_d8f6c0f8","line":48,"range":{"start_line":38,"start_character":0,"end_line":48,"end_character":62},"updated":"2016-01-20 02:18:21.000000000","message":"Please use debtcollector.moves.moved_function for these.","commit_id":"f400e3df41311f9b7f49d96e85b59c49689bd4e4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1ba74babc05297b27a4ad82703b9288faac2baae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"MAX_PORTS_PER_QUERY \u003d 500"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The API methods from providernet_db"},{"line_number":38,"context_line":"add_network_segment \u003d providernet_db.add_network_segment"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"get_network_segments \u003d providernet_db.get_network_segments"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7af24918_526d76cb","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":19},"updated":"2016-03-04 23:58:27.000000000","message":"Should we remove these mappings in this patch set or do a follow-up?  I could go either way but it would be nice to have a patch set up to take care of it.","commit_id":"65cac733c34edc4e309832d871a2ef3a25a0c9b2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"8d5c88ce14eb849d3d5a404642caa679819cd444","unresolved":false,"context_lines":[{"line_number":35,"context_line":"MAX_PORTS_PER_QUERY \u003d 500"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The API methods from providernet_db"},{"line_number":38,"context_line":"add_network_segment \u003d providernet_db.add_network_segment"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"get_network_segments \u003d providernet_db.get_network_segments"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_e8e131d2","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":19},"in_reply_to":"7af24918_526d76cb","updated":"2016-03-21 08:48:54.000000000","message":"Removing the mapping will involve much code change. I think a follow-up is good.","commit_id":"65cac733c34edc4e309832d871a2ef3a25a0c9b2"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"adb982c38784a5d3f010e85cfbca94741c73430c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"MAX_PORTS_PER_QUERY \u003d 500"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"# The API methods from providernet_db"},{"line_number":38,"context_line":"add_network_segment \u003d providernet_db.add_network_segment"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"get_network_segments \u003d providernet_db.get_network_segments"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"fa0719c6_7c54c353","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":19},"in_reply_to":"fa0719c6_e8e131d2","updated":"2016-03-21 10:05:06.000000000","message":"I made a patch to address this issue.\n\nhttps://review.openstack.org/#/c/295173","commit_id":"65cac733c34edc4e309832d871a2ef3a25a0c9b2"}],"neutron/plugins/ml2/driver_api.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8bae8f4e03beb03e81d57316da96924f321d7449","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import abc"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.common import constants as n_const"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"ID \u003d n_const.ID"},{"line_number":22,"context_line":"NETWORK_TYPE \u003d n_const.NETWORK_TYPE"},{"line_number":23,"context_line":"PHYSICAL_NETWORK \u003d n_const.PHYSICAL_NETWORK"},{"line_number":24,"context_line":"SEGMENTATION_ID \u003d n_const.SEGMENTATION_ID"},{"line_number":25,"context_line":"MTU \u003d n_const.MTU"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# The following keys are used in the binding level dictionaries"},{"line_number":28,"context_line":"# available via the binding_levels and original_binding_levels"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_9847e81c","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":17},"updated":"2016-01-20 02:18:21.000000000","message":"Suggest to leave unchanged for now.","commit_id":"f400e3df41311f9b7f49d96e85b59c49689bd4e4"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"bc42f5b039f4bad06e8c2a0a2e5a16b185521129","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import abc"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.common import constants as n_const"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"ID \u003d n_const.ID"},{"line_number":22,"context_line":"NETWORK_TYPE \u003d n_const.NETWORK_TYPE"},{"line_number":23,"context_line":"PHYSICAL_NETWORK \u003d n_const.PHYSICAL_NETWORK"},{"line_number":24,"context_line":"SEGMENTATION_ID \u003d n_const.SEGMENTATION_ID"},{"line_number":25,"context_line":"MTU \u003d n_const.MTU"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"# The following keys are used in the binding level dictionaries"},{"line_number":28,"context_line":"# available via the binding_levels and original_binding_levels"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_6ec58e8c","line":25,"range":{"start_line":19,"start_character":0,"end_line":25,"end_character":17},"in_reply_to":"ba63e191_9847e81c","updated":"2016-01-25 08:26:00.000000000","message":"ok","commit_id":"f400e3df41311f9b7f49d96e85b59c49689bd4e4"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"d80dff6ffb8880d696abaa03814f9d8f5685616b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.common import constants as n_const"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ID \u003d n_const.ID"},{"line_number":23,"context_line":"NETWORK_TYPE \u003d n_const.NETWORK_TYPE"},{"line_number":24,"context_line":"PHYSICAL_NETWORK \u003d n_const.PHYSICAL_NETWORK"},{"line_number":25,"context_line":"SEGMENTATION_ID \u003d n_const.SEGMENTATION_ID"},{"line_number":26,"context_line":"MTU \u003d n_const.MTU"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The following keys are used in the binding level dictionaries"},{"line_number":29,"context_line":"# available via the binding_levels and original_binding_levels"}],"source_content_type":"text/x-python","patch_set":12,"id":"9aed3d3a_687de01b","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":17},"updated":"2016-02-26 22:07:02.000000000","message":"should this go in neutron-lib?","commit_id":"924fc7dc2544846aa8c0c2562452b3ce37f25f2c"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"a17abec2227de3822803e71391c3a534cf290d2a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.common import constants as n_const"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ID \u003d n_const.ID"},{"line_number":23,"context_line":"NETWORK_TYPE \u003d n_const.NETWORK_TYPE"},{"line_number":24,"context_line":"PHYSICAL_NETWORK \u003d n_const.PHYSICAL_NETWORK"},{"line_number":25,"context_line":"SEGMENTATION_ID \u003d n_const.SEGMENTATION_ID"},{"line_number":26,"context_line":"MTU \u003d n_const.MTU"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The following keys are used in the binding level dictionaries"},{"line_number":29,"context_line":"# available via the binding_levels and original_binding_levels"}],"source_content_type":"text/x-python","patch_set":12,"id":"7af24918_394071a5","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":17},"in_reply_to":"7af24918_b905a1c3","updated":"2016-03-01 23:29:44.000000000","message":"Agreed. ID and mtu can be followed up later and scoped appropriately","commit_id":"924fc7dc2544846aa8c0c2562452b3ce37f25f2c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4181b6f0c5d740995d69e1a5f84d5768cb887730","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.common import constants as n_const"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ID \u003d n_const.ID"},{"line_number":23,"context_line":"NETWORK_TYPE \u003d n_const.NETWORK_TYPE"},{"line_number":24,"context_line":"PHYSICAL_NETWORK \u003d n_const.PHYSICAL_NETWORK"},{"line_number":25,"context_line":"SEGMENTATION_ID \u003d n_const.SEGMENTATION_ID"},{"line_number":26,"context_line":"MTU \u003d n_const.MTU"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The following keys are used in the binding level dictionaries"},{"line_number":29,"context_line":"# available via the binding_levels and original_binding_levels"}],"source_content_type":"text/x-python","patch_set":12,"id":"7af24918_b905a1c3","line":26,"range":{"start_line":20,"start_character":0,"end_line":26,"end_character":17},"in_reply_to":"9aed3d3a_687de01b","updated":"2016-03-01 23:25:38.000000000","message":"Honestly, I\u0027m not sure how useful they\u0027ll be there.  Maybe ID and MTU belong there but the other three are really provider/multi-provider specific constants.  I tend to think they should go in the extension.\n\nIn my opinion not all constants should be thrown in a project global namespace.  Constants, like anything else, should be scoped appropriately.","commit_id":"924fc7dc2544846aa8c0c2562452b3ce37f25f2c"}],"neutron/plugins/ml2/models.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8bae8f4e03beb03e81d57316da96924f321d7449","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BINDING_PROFILE_LEN \u003d 4095"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class PortBinding(model_base.BASEV2):"},{"line_number":27,"context_line":"    \"\"\"Represent binding-related state of a port."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_3804bcbe","line":25,"updated":"2016-01-20 02:18:21.000000000","message":"Please use debtcollector.moves.moved_class here.","commit_id":"f400e3df41311f9b7f49d96e85b59c49689bd4e4"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"bc42f5b039f4bad06e8c2a0a2e5a16b185521129","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BINDING_PROFILE_LEN \u003d 4095"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class PortBinding(model_base.BASEV2):"},{"line_number":27,"context_line":"    \"\"\"Represent binding-related state of a port."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_ce44ba1c","line":25,"in_reply_to":"ba63e191_3804bcbe","updated":"2016-01-25 08:26:00.000000000","message":"http://docs.openstack.org/developer/debtcollector/api.html\nThis creates a ‘new-old’ type that can be used for a deprecation period that can be inherited from. This will emit warnings when the old locations class is initialized, telling where the new and improved location for the old class now is\n\nI don\u0027t think it is a deprecation case.","commit_id":"f400e3df41311f9b7f49d96e85b59c49689bd4e4"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"90802ba81f112358f5375bcdff359e0e5138b61d","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"BINDING_PROFILE_LEN \u003d 4095"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class PortBinding(model_base.BASEV2):"},{"line_number":27,"context_line":"    \"\"\"Represent binding-related state of a port."},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a68dd71_eec26052","line":25,"in_reply_to":"ba63e191_ce44ba1c","updated":"2016-01-25 14:04:12.000000000","message":"Do you mean that no 3rd-party project is using this class? How do you know?","commit_id":"f400e3df41311f9b7f49d96e85b59c49689bd4e4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7a731f61857f004347e1944666b5ce914688b437","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    one or more segments."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":37,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_cab529ce","side":"PARENT","line":34,"range":{"start_line":34,"start_character":21,"end_line":34,"end_character":41},"updated":"2016-03-02 00:37:24.000000000","message":"I\u0027m convinced this should be renamed.  I think the migration should be pretty trivial (but offline) because I think the table can just be renamed.","commit_id":"b380b15d4cbf3f961b828c39abac4dbc2e3499ec"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"6211e88787981492c12b5088e0caa07b38511c30","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    one or more segments."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    __tablename__ \u003d \u0027ml2_network_segments\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":37,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"7af24918_d741510d","side":"PARENT","line":34,"range":{"start_line":34,"start_character":21,"end_line":34,"end_character":41},"in_reply_to":"7af24918_cab529ce","updated":"2016-03-02 01:24:57.000000000","message":"The migration is trivial, but I am worried that it will force offline mode during the upgrade. I\u0027ll investigate some more. If a good rename strategy is found we can do it in a follow-up.","commit_id":"b380b15d4cbf3f961b828c39abac4dbc2e3499ec"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"5b318b124fddf1ab5dafcc9ee16b972bd96d3d94","unresolved":false,"context_lines":[{"line_number":736,"context_line":"                                                segments, segments]"},{"line_number":737,"context_line":"                    with self.port(subnet\u003dsubnet) as port:"},{"line_number":738,"context_line":"                        self.assertTrue(port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":739,"context_line":"                        self.assertEqual(3, get_seg_mock.call_count)"},{"line_number":740,"context_line":""},{"line_number":741,"context_line":"    def test_delete_port_tolerates_db_deadlock(self):"},{"line_number":742,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa69d971_4a569607","line":739,"range":{"start_line":739,"start_character":42,"end_line":739,"end_character":43},"updated":"2016-01-08 04:56:01.000000000","message":"reduced one call is due to db.get_network_segments is calling provider_db.get_networks_segments instead of db.get_networks_segments","commit_id":"5d3abb31b4981efdf92de2b5038560cfb2d38385"}]}
