)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"0c3d61710a9018bb5e14e0a793d9d0a17c4cf066","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from neutron.ipam import subnet_alloc"},{"line_number":50,"context_line":"from neutron import manager"},{"line_number":51,"context_line":"from neutron import neutron_plugin_base_v2"},{"line_number":52,"context_line":"from neutron.notifiers import nova as nova_notifier"},{"line_number":53,"context_line":"from neutron.plugins.common import constants as service_constants"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_bdfd4a70","line":52,"updated":"2015-11-07 06:34:50.000000000","message":"should we also check the condition wether we need to import it?\nit\u0027s not a good idea that we import a module we don\u0027t need in some condition.","commit_id":"4ae2c246dd1cc16ebffb6f9d6a64f6ba7db2c05a"},{"author":{"_account_id":9551,"name":"Martin Hickey","email":"martin.hickey@ie.ibm.com","username":"mhickey"},"change_message_id":"5e0729a7f38b73167c584300502f0f4036b8ec9e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from neutron.ipam import subnet_alloc"},{"line_number":50,"context_line":"from neutron import manager"},{"line_number":51,"context_line":"from neutron import neutron_plugin_base_v2"},{"line_number":52,"context_line":"from neutron.notifiers import nova as nova_notifier"},{"line_number":53,"context_line":"from neutron.plugins.common import constants as service_constants"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_e0b630f8","line":52,"in_reply_to":"da85f559_95301fea","updated":"2015-11-11 11:11:17.000000000","message":"+1 with Yan. I don\u0027t think he emans hiding it below, just check it is needed here or not?","commit_id":"4ae2c246dd1cc16ebffb6f9d6a64f6ba7db2c05a"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"a28a51750c04f0e55b6ab657bdd7c77ccac919af","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from neutron.ipam import subnet_alloc"},{"line_number":50,"context_line":"from neutron import manager"},{"line_number":51,"context_line":"from neutron import neutron_plugin_base_v2"},{"line_number":52,"context_line":"from neutron.notifiers import nova as nova_notifier"},{"line_number":53,"context_line":"from neutron.plugins.common import constants as service_constants"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_297f4f16","line":52,"in_reply_to":"da85f559_95301fea","updated":"2015-11-11 05:56:12.000000000","message":"maybe we can using dynamic class import in  100. To import a class that is not used in all conditions should be avoided.\n\nBy the way, when we create neutron, we have said neutron is not used by nova alone. It can be used by other software.","commit_id":"4ae2c246dd1cc16ebffb6f9d6a64f6ba7db2c05a"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"7d5d46e156f95eda94c90e794cab21143f18c5a7","unresolved":false,"context_lines":[{"line_number":49,"context_line":"from neutron.ipam import subnet_alloc"},{"line_number":50,"context_line":"from neutron import manager"},{"line_number":51,"context_line":"from neutron import neutron_plugin_base_v2"},{"line_number":52,"context_line":"from neutron.notifiers import nova as nova_notifier"},{"line_number":53,"context_line":"from neutron.plugins.common import constants as service_constants"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_95301fea","line":52,"in_reply_to":"da85f559_bdfd4a70","updated":"2015-11-09 19:49:11.000000000","message":"I don\u0027t think it\u0027s worth hiding the import down there. We don\u0027t need to do those kind of optimizations here.","commit_id":"4ae2c246dd1cc16ebffb6f9d6a64f6ba7db2c05a"}]}
