)]}'
{"neutron/api/v2/attributes.py":[{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"4f3cb3e27ec05c36425e216f16a9b8a7022a5f19","unresolved":false,"context_lines":[{"line_number":892,"context_line":"           \u0027extensions\u0027: \u0027extension\u0027}"},{"line_number":893,"context_line":"# Store singular/plural mappings. This dictionary is populated by"},{"line_number":894,"context_line":"# get_resource_info"},{"line_number":895,"context_line":"REVERSED_PLURALS \u003d {}"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"def get_collection_info(collection):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_5dc53e59","line":895,"updated":"2015-11-07 06:02:25.000000000","message":"I\u0027d use SINGLE,\nand I\u0027d hard code these mappings as PLURALS does.","commit_id":"9224139ffb1356439d30036f10b6232c30367b63"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"260d3d17b5e2ed2eec616cf604be4283ba54f12e","unresolved":false,"context_lines":[{"line_number":892,"context_line":"           \u0027extensions\u0027: \u0027extension\u0027}"},{"line_number":893,"context_line":"# Store singular/plural mappings. This dictionary is populated by"},{"line_number":894,"context_line":"# get_resource_info"},{"line_number":895,"context_line":"REVERSED_PLURALS \u003d {}"},{"line_number":896,"context_line":""},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"def get_collection_info(collection):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_561d1265","line":895,"in_reply_to":"da85f559_5dc53e59","updated":"2015-11-16 15:36:57.000000000","message":"Hardcoding in this case is not great from a maintanability perspective, as I would ask people to update not one but two dicts.\n\nFor the naming, I\u0027m happy with anything... the point is however, that if you look at plurals it maps a plural to a singuler, so that dict should be called singulars too (and not singles btw).\nI suggested this name to give a clear message this is the reverse of PLURALS.\n\nAs I do not have strong opinions, if you strongly feel it should be called SINGULARS, I\u0027ll change the name.","commit_id":"9224139ffb1356439d30036f10b6232c30367b63"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"880bb691dd84b60a91d359a7ef5ebe5d0ebe0f72","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        for (plural, singular) in PLURALS.items():"},{"line_number":936,"context_line":"            if singular \u003d\u003d resource:"},{"line_number":937,"context_line":"                plural_name \u003d plural"},{"line_number":938,"context_line":"                REVERSED_PLURALS[resource] \u003d plural_name"},{"line_number":939,"context_line":"    return RESOURCE_ATTRIBUTE_MAP.get(plural_name)"},{"line_number":940,"context_line":""},{"line_number":941,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_7e12d458","line":938,"updated":"2015-12-29 08:49:06.000000000","message":"seems odd that this method also generates the REVERSED_PLURALS dictionary, though its also constructing it like a permanent cache as well.  If I though it was a big deal I\u0027d suggest just building the entire REVERSED_PLURALS dictionary at module load and simplifying this method.  Not a big deal though.","commit_id":"d5f0175d44f1a43d280025ac1e83905bcedca864"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bab02a7f51b6446bb30ed8f5bb9f9509794b98a1","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        for (plural, singular) in PLURALS.items():"},{"line_number":936,"context_line":"            if singular \u003d\u003d resource:"},{"line_number":937,"context_line":"                plural_name \u003d plural"},{"line_number":938,"context_line":"                REVERSED_PLURALS[resource] \u003d plural_name"},{"line_number":939,"context_line":"    return RESOURCE_ATTRIBUTE_MAP.get(plural_name)"},{"line_number":940,"context_line":""},{"line_number":941,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_386fd293","line":938,"in_reply_to":"1a7b0d38_7e12d458","updated":"2016-01-04 13:26:24.000000000","message":"I have no strong opinion as well.\nI did not do the operation at module load because extensions might add stuff to PLURALS and I was not sure we are able to ensure that this module is loaded after all extension modules.","commit_id":"d5f0175d44f1a43d280025ac1e83905bcedca864"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"95d993e148a6b1828193b275ed5e5ac8847ebc21","unresolved":false,"context_lines":[{"line_number":926,"context_line":"        for (plural, singular) in PLURALS.items():"},{"line_number":927,"context_line":"            if singular \u003d\u003d resource:"},{"line_number":928,"context_line":"                plural_name \u003d plural"},{"line_number":929,"context_line":"                REVERSED_PLURALS[resource] \u003d plural_name"},{"line_number":930,"context_line":"    return RESOURCE_ATTRIBUTE_MAP.get(plural_name)"},{"line_number":931,"context_line":""},{"line_number":932,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_758dfdd1","line":929,"updated":"2016-01-11 23:17:49.000000000","message":"nit: How about the following:\n\n  plural_name \u003d REVERSED_PLURALS.get(resource)\n  if plural_name:\n      return plural_name\n  for (plural, singular) in PLURALS.items():\n      if singular \u003d\u003d resource:\n          REVERSED_PLURALS[resource] \u003d plural\n          return plural","commit_id":"0f9a607cf6eeefab5a571f517a01c50f98a3ce16"}],"neutron/pecan_wsgi/controllers/root.py":[{"author":{"_account_id":162,"name":"Bob Melander","email":"bob.melander@gmail.com","username":"bob-melander"},"change_message_id":"9a70201171eb26c5a08a7bfb795e74ebde483eb2","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return {self.collection: lister(neutron_context, filters\u003dfilters)}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @when(index, method\u003d\u0027HEAD\u0027)"},{"line_number":179,"context_line":"    @when(index, method\u003d\u0027POST\u0027)"},{"line_number":180,"context_line":"    @when(index, method\u003d\u0027PATCH\u0027)"},{"line_number":181,"context_line":"    @when(index, method\u003d\u0027PUT\u0027)"},{"line_number":182,"context_line":"    @when(index, method\u003d\u0027DELETE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_8b9361a3","line":179,"updated":"2015-11-07 00:59:40.000000000","message":"I\u0027m still largely Pecan iliterate but should the above line be here?","commit_id":"9224139ffb1356439d30036f10b6232c30367b63"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"4f3cb3e27ec05c36425e216f16a9b8a7022a5f19","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return {self.collection: lister(neutron_context, filters\u003dfilters)}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @when(index, method\u003d\u0027HEAD\u0027)"},{"line_number":179,"context_line":"    @when(index, method\u003d\u0027POST\u0027)"},{"line_number":180,"context_line":"    @when(index, method\u003d\u0027PATCH\u0027)"},{"line_number":181,"context_line":"    @when(index, method\u003d\u0027PUT\u0027)"},{"line_number":182,"context_line":"    @when(index, method\u003d\u0027DELETE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_9dac06ef","line":179,"in_reply_to":"da85f559_8b9361a3","updated":"2015-11-07 06:02:25.000000000","message":"should not be here","commit_id":"9224139ffb1356439d30036f10b6232c30367b63"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"260d3d17b5e2ed2eec616cf604be4283ba54f12e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return {self.collection: lister(neutron_context, filters\u003dfilters)}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    @when(index, method\u003d\u0027HEAD\u0027)"},{"line_number":179,"context_line":"    @when(index, method\u003d\u0027POST\u0027)"},{"line_number":180,"context_line":"    @when(index, method\u003d\u0027PATCH\u0027)"},{"line_number":181,"context_line":"    @when(index, method\u003d\u0027PUT\u0027)"},{"line_number":182,"context_line":"    @when(index, method\u003d\u0027DELETE\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_36a08ef4","line":179,"in_reply_to":"da85f559_9dac06ef","updated":"2015-11-16 15:36:57.000000000","message":"C/P fail","commit_id":"9224139ffb1356439d30036f10b6232c30367b63"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"24dda5b288ec6c8dbcb4c0e21258a841d2118489","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        # Store resource and collection names in pecan request context so that"},{"line_number":118,"context_line":"        # hooks can leverage them if necessary"},{"line_number":119,"context_line":"        request.context[\u0027resource\u0027] \u003d controller.resource"},{"line_number":120,"context_line":"        request.context[\u0027collection\u0027] \u003d collection"},{"line_number":121,"context_line":"        return controller, remainder"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_e99f67b2","line":120,"updated":"2015-12-10 06:35:06.000000000","message":"I wonder \"resource_name\" and \"colletion_name\" are better names.\nWhile we use \"resources\" to store actual data, \"resource\" and \"collection\" fields store names. I think adding \"*_name*\" makes things clearer. I am not sure this is easy or not and we can update it later even if it is a good idea.","commit_id":"d5f0175d44f1a43d280025ac1e83905bcedca864"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"14674b7e53f0bf2e7aada760efca3decc9828638","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        # Store resource and collection names in pecan request context so that"},{"line_number":118,"context_line":"        # hooks can leverage them if necessary"},{"line_number":119,"context_line":"        request.context[\u0027resource\u0027] \u003d controller.resource"},{"line_number":120,"context_line":"        request.context[\u0027collection\u0027] \u003d collection"},{"line_number":121,"context_line":"        return controller, remainder"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_af3851a1","line":120,"in_reply_to":"5a710552_ec59875b","updated":"2015-12-16 06:57:17.000000000","message":"thanks for the clarification. Your plan sounds good to me.","commit_id":"d5f0175d44f1a43d280025ac1e83905bcedca864"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"dc5cce861eb30c019cc5f6fbbfebd6390c93c285","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        # Store resource and collection names in pecan request context so that"},{"line_number":118,"context_line":"        # hooks can leverage them if necessary"},{"line_number":119,"context_line":"        request.context[\u0027resource\u0027] \u003d controller.resource"},{"line_number":120,"context_line":"        request.context[\u0027collection\u0027] \u003d collection"},{"line_number":121,"context_line":"        return controller, remainder"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_ec59875b","line":120,"in_reply_to":"7a740942_e99f67b2","updated":"2015-12-16 06:48:48.000000000","message":"You are correct, and I was considering doing something similar.\n\nAs I have several outstanding patches doing the rename here (the base one), is not going to be simple.\n\nI will do this in https://review.openstack.org/241035, if that\u0027s ok for you.","commit_id":"d5f0175d44f1a43d280025ac1e83905bcedca864"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f614710c2fe92e4ac99715df4def3aa9cf834c0d","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        # TODO(kevinbenton): bulk?"},{"line_number":238,"context_line":"        updater \u003d getattr(self.plugin, \u0027update_%s\u0027 % self.resource)"},{"line_number":239,"context_line":"        # Bulk update is not supported, \u0027resources\u0027 always contains a single"},{"line_number":240,"context_line":"        # elemenet"},{"line_number":241,"context_line":"        data \u003d {self.resource: resources[0]}"},{"line_number":242,"context_line":"        return updater(neutron_context, self.item, data)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_6a2157b4","line":240,"updated":"2016-01-07 10:21:09.000000000","message":"We are having conversations via code comments :)","commit_id":"d5f0175d44f1a43d280025ac1e83905bcedca864"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"880bb691dd84b60a91d359a7ef5ebe5d0ebe0f72","unresolved":false,"context_lines":[{"line_number":237,"context_line":"        # TODO(kevinbenton): bulk?"},{"line_number":238,"context_line":"        updater \u003d getattr(self.plugin, \u0027update_%s\u0027 % self.resource)"},{"line_number":239,"context_line":"        # Bulk update is not supported, \u0027resources\u0027 always contains a single"},{"line_number":240,"context_line":"        # elemenet"},{"line_number":241,"context_line":"        data \u003d {self.resource: resources[0]}"},{"line_number":242,"context_line":"        return updater(neutron_context, self.item, data)"},{"line_number":243,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_1e5390e3","line":240,"updated":"2015-12-29 08:49:06.000000000","message":"can you remove the TODO comment above at line 237 then?","commit_id":"d5f0175d44f1a43d280025ac1e83905bcedca864"}],"neutron/pecan_wsgi/hooks/body_validation.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"880bb691dd84b60a91d359a7ef5ebe5d0ebe0f72","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        neutron_context \u003d state.request.context[\u0027neutron_context\u0027]"},{"line_number":32,"context_line":"        is_create \u003d state.request.method \u003d\u003d \u0027POST\u0027"},{"line_number":33,"context_line":"        if not resource:"},{"line_number":34,"context_line":"            return []"},{"line_number":35,"context_line":"        # Prepare data to be passed to the plugin from request body"},{"line_number":36,"context_line":"        data \u003d v2_base.Controller.prepare_request_body("},{"line_number":37,"context_line":"            neutron_context,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a7b0d38_ded42821","line":34,"updated":"2015-12-29 08:49:06.000000000","message":"why is this returning an empty list when above it returns None?","commit_id":"d5f0175d44f1a43d280025ac1e83905bcedca864"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"bab02a7f51b6446bb30ed8f5bb9f9509794b98a1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        neutron_context \u003d state.request.context[\u0027neutron_context\u0027]"},{"line_number":32,"context_line":"        is_create \u003d state.request.method \u003d\u003d \u0027POST\u0027"},{"line_number":33,"context_line":"        if not resource:"},{"line_number":34,"context_line":"            return []"},{"line_number":35,"context_line":"        # Prepare data to be passed to the plugin from request body"},{"line_number":36,"context_line":"        data \u003d v2_base.Controller.prepare_request_body("},{"line_number":37,"context_line":"            neutron_context,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa69d971_982d9e48","line":34,"in_reply_to":"1a7b0d38_ded42821","updated":"2016-01-04 13:26:24.000000000","message":"yeah I noticed that too but since I\u0027m a bit lazy I did not bother fixing it.","commit_id":"d5f0175d44f1a43d280025ac1e83905bcedca864"}],"neutron/pecan_wsgi/hooks/ownership_validation.py":[{"author":{"_account_id":162,"name":"Bob Melander","email":"bob.melander@gmail.com","username":"bob-melander"},"change_message_id":"9a70201171eb26c5a08a7bfb795e74ebde483eb2","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def before(self, state):"},{"line_number":27,"context_line":"        if state.request.method !\u003d \u0027POST\u0027:"},{"line_number":28,"context_line":"            return"},{"line_number":29,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027, [])"},{"line_number":30,"context_line":"        for item in items:"},{"line_number":31,"context_line":"            self._validate_network_tenant_ownership(state, item)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_ab0e65e3","line":29,"updated":"2015-11-07 00:59:40.000000000","message":"Matter of taste, I\u0027d just skip the items variable.","commit_id":"9224139ffb1356439d30036f10b6232c30367b63"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"260d3d17b5e2ed2eec616cf604be4283ba54f12e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def before(self, state):"},{"line_number":27,"context_line":"        if state.request.method !\u003d \u0027POST\u0027:"},{"line_number":28,"context_line":"            return"},{"line_number":29,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027, [])"},{"line_number":30,"context_line":"        for item in items:"},{"line_number":31,"context_line":"            self._validate_network_tenant_ownership(state, item)"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_b6da3e77","line":29,"in_reply_to":"da85f559_ab0e65e3","updated":"2015-11-16 15:36:57.000000000","message":"cool by me. I just replaced the variable name, did not even look at the rest of the method.\n\nI bet $1 that then someone will point out this is an unrelated change ;)","commit_id":"9224139ffb1356439d30036f10b6232c30367b63"}],"neutron/pecan_wsgi/hooks/policy_enforcement.py":[{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"4f3cb3e27ec05c36425e216f16a9b8a7022a5f19","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def before(self, state):"},{"line_number":49,"context_line":"        # This hook should be run only for PUT,POST and DELETE methods and for"},{"line_number":50,"context_line":"        # requests targeting a neutron resource"},{"line_number":51,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027)"},{"line_number":52,"context_line":"        if state.request.method not in (\u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027) or not items:"},{"line_number":53,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_dde12e00","line":50,"updated":"2015-11-07 06:02:25.000000000","message":"do you mean that \u0027get\u0027 method don\u0027t need to check policy? a user can query others resources?","commit_id":"9224139ffb1356439d30036f10b6232c30367b63"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"260d3d17b5e2ed2eec616cf604be4283ba54f12e","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def before(self, state):"},{"line_number":49,"context_line":"        # This hook should be run only for PUT,POST and DELETE methods and for"},{"line_number":50,"context_line":"        # requests targeting a neutron resource"},{"line_number":51,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027)"},{"line_number":52,"context_line":"        if state.request.method not in (\u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027) or not items:"},{"line_number":53,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_d16d8ccd","line":50,"in_reply_to":"da85f559_dde12e00","updated":"2015-11-16 15:36:57.000000000","message":"Well, if that were true, I\u0027d be a really dumb programmer and my CLA should be immediately revoked.\n\nNevertheless, it is only fair that I provide justification for my actions to simplify that task of reviewers who might not have a thorough knowledge of the code base.\n\nThe \u0027before\u0027 hook performs verification on the request body, and there is no request body for GET operation.\nFor the pecan case we are adopting the same approach as the existing REST controller. \nFor GET operations authZ checks are instead performed on responses, ie: after the data are fetched.\nFor index operations, this happens here: http://git.openstack.org/cgit/openstack/neutron/tree/neutron/api/v2/base.py#n275\nFor show operations, this happens here:\nhttp://git.openstack.org/cgit/openstack/neutron/tree/neutron/api/v2/base.py#n316\n\nYou have a good point however about doing ownership checks in this way. The DB layer automatically scopes request by tenants, so we won\u0027t have to the expensive process of fetching resources and then denying access to them in the API layer.","commit_id":"9224139ffb1356439d30036f10b6232c30367b63"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"a86af51b8daaceb2c98063863cfc780077b8f291","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        # This hook should be run only for PUT,POST and DELETE methods and for"},{"line_number":50,"context_line":"        # requests targeting a neutron resource"},{"line_number":51,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027)"},{"line_number":52,"context_line":"        if state.request.method not in (\u0027POST\u0027, \u0027PUT\u0027, \u0027DELETE\u0027) or not items:"},{"line_number":53,"context_line":"            return"},{"line_number":54,"context_line":"        neutron_context \u003d state.request.context.get(\u0027neutron_context\u0027)"},{"line_number":55,"context_line":"        resource \u003d state.request.context.get(\u0027resource\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_a02dbf47","line":52,"updated":"2015-11-25 23:43:23.000000000","message":"ah adding DELETE here is not entirely correct... it should operate on DELETE as well, but it won\u0027t do it out of the box!","commit_id":"10cf5a1ec45ffb33c1ea9f18e42352a4de812086"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"4e58cb17860917b1a6002ac1a1e1b044377ba667","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # current logic. See LP Bug #1520180"},{"line_number":53,"context_line":"        items \u003d state.request.context.get(\u0027resources\u0027)"},{"line_number":54,"context_line":"        if state.request.method not in (\u0027POST\u0027, \u0027PUT\u0027) or not items:"},{"line_number":55,"context_line":"            return"},{"line_number":56,"context_line":"        neutron_context \u003d state.request.context.get(\u0027neutron_context\u0027)"},{"line_number":57,"context_line":"        resource \u003d state.request.context.get(\u0027resource\u0027)"},{"line_number":58,"context_line":"        collection \u003d state.request.context.get(\u0027collection\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_6090e5ed","line":55,"updated":"2015-12-03 08:54:18.000000000","message":"after seeing LP Bug #1520180, still don\u0027t know why skip DELETE","commit_id":"8810d8a3a4cd4a74548629b910c2e10f6586e0fe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"95d993e148a6b1828193b275ed5e5ac8847ebc21","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        return getter(neutron_context, resource_id, fields\u003dfield_list)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def before(self, state):"},{"line_number":47,"context_line":"        # This hook should be run only for PUT,POST and DELETE methods and for"},{"line_number":48,"context_line":"        # requests targeting a neutron resource"},{"line_number":49,"context_line":"        # FIXME(salv-orlando): DELETE support. It does not work with the"},{"line_number":50,"context_line":"        # current logic. See LP Bug #1520180"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_d2259aae","line":47,"updated":"2016-01-11 23:17:49.000000000","message":"super nit: a space before POST","commit_id":"0f9a607cf6eeefab5a571f517a01c50f98a3ce16"}],"neutron/tests/functional/pecan_wsgi/test_functional.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"780c49f8802f31473ae717c60522947d1db2c6c5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertEqual(response.status_int, 200)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_post(self):"},{"line_number":78,"context_line":"        response \u003d self.app.post_json("},{"line_number":79,"context_line":"            \u0027/v2.0/ports.json\u0027,"},{"line_number":80,"context_line":"            params\u003d{\u0027port\u0027: {\u0027network_id\u0027: self.port[\u0027network_id\u0027],"},{"line_number":81,"context_line":"                             \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_ff6d9d32","line":78,"updated":"2015-11-23 23:48:28.000000000","message":"an indendation change! this will need a new spec and blueprint and RFE :)","commit_id":"b55c20318f64b8b4da0077d0c90791b15fb65c76"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b1da7660262a8cd7d085a3d8c149617007867db5","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        self.assertEqual(response.status_int, 200)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_post(self):"},{"line_number":78,"context_line":"        response \u003d self.app.post_json("},{"line_number":79,"context_line":"            \u0027/v2.0/ports.json\u0027,"},{"line_number":80,"context_line":"            params\u003d{\u0027port\u0027: {\u0027network_id\u0027: self.port[\u0027network_id\u0027],"},{"line_number":81,"context_line":"                             \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_daf25e9a","line":78,"in_reply_to":"ba8a016a_ff6d9d32","updated":"2015-11-25 09:43:11.000000000","message":"oh noes!!1!!1!!","commit_id":"b55c20318f64b8b4da0077d0c90791b15fb65c76"}]}
