)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ea902e2fdccf0dc26c0a983a9490338dad6cba8c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove the useless l3plugin check in l3_rpc.py"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to neutron.manager.NeutronManager, it is impossible to"},{"line_number":10,"context_line":"have \"L3_ROUTER_NAT: None\" in neutron\u0027s service_plugins. And,"},{"line_number":11,"context_line":"without \"L3_ROUTER_NAT\" in neutron\u0027s service_plugins, l3_rpc will"},{"line_number":12,"context_line":"fail when getting l3plugin. So, remove the useless \"if\" block"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da85f559_6b726fe5","line":9,"updated":"2015-11-15 13:02:26.000000000","message":"I\u0027d just say that L3RpcCallback is not designed to be used without l3 plugin available","commit_id":"73766144e3d4bf06dd3c241508bd5443bdd100fe"}],"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a4e1e85ba62614115a4d28f34b4e18d75a0a65b0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        router_ids \u003d kwargs.get(\u0027router_ids\u0027)"},{"line_number":74,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":75,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":76,"context_line":"        if not self.l3plugin:"},{"line_number":77,"context_line":"            routers \u003d []"},{"line_number":78,"context_line":"            LOG.error(_LE(\u0027No plugin for L3 routing registered! Will reply \u0027"},{"line_number":79,"context_line":"                          \u0027to l3 agent with empty router list.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_799fd6b4","line":76,"updated":"2015-11-13 13:58:04.000000000","message":"seems this module currently doesn\u0027t assume l3plugin could be None, so we can safely remove 76-79. Indeed, we either get l3plugin from manager or get IndexError","commit_id":"5a218e142ad975259da30819f459597d3403a91e"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"72a96c7c653a3e5eaf41beef5fd6fd73ccec9367","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        router_ids \u003d kwargs.get(\u0027router_ids\u0027)"},{"line_number":74,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":75,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":76,"context_line":"        if not self.l3plugin:"},{"line_number":77,"context_line":"            routers \u003d []"},{"line_number":78,"context_line":"            LOG.error(_LE(\u0027No plugin for L3 routing registered! Will reply \u0027"},{"line_number":79,"context_line":"                          \u0027to l3 agent with empty router list.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_9d811dfe","line":76,"in_reply_to":"da85f559_799fd6b4","updated":"2015-11-15 07:23:53.000000000","message":"@Oleg, thanks very much for the comment. I checked the code in NeutronManager. It is impossible to have \"L3_ROUTER_NAT: None\" in neutron\u0027s service_plugins. And, without \"L3_ROUTER_NAT\" in neutron\u0027s service_plugins, the code will fail when getting l3plugin. So, removing the \"if\" block here seems reasonable.","commit_id":"5a218e142ad975259da30819f459597d3403a91e"}],"neutron/tests/unit/api/rpc/handlers/test_l3_rpc.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f29c9904d582b2e55cfca66ebf24b5ec8605ccac","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        self.assertEqual(updated_subnet[\u0027allocation_pools\u0027], allocation_pools)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def test_sync_routers_with_no_l3plugin(self):"},{"line_number":70,"context_line":"        manager.NeutronManager.get_service_plugins \u003d mock.Mock("},{"line_number":71,"context_line":"            return_value\u003d{plugin_constants.L3_ROUTER_NAT: None})"},{"line_number":72,"context_line":"        routers \u003d self.callbacks.sync_routers({})"},{"line_number":73,"context_line":"        self.assertEqual(routers, [])"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_dd822a94","line":70,"updated":"2015-11-10 13:03:21.000000000","message":"i think that this is causing problems with other tests. you need to clean things up at the tearDown level","commit_id":"ec3a07bf5a69c7befc1d1d96eab3f54703a6fd81"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"dcbeb51474cbe64f7fc513f2a88251bbe9e23387","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            manager.NeutronManager.get_service_plugins \u003d o_method"},{"line_number":76,"context_line":"        self.addCleanup(restore_method)"},{"line_number":77,"context_line":"        routers \u003d self.callbacks.sync_routers({})"},{"line_number":78,"context_line":"        self.assertEqual(routers, [])"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_9eb8f3c9","line":78,"updated":"2015-11-11 05:22:12.000000000","message":"assertEqual(expected, observed)","commit_id":"903c2135c842f746ef367b83adc6fed33dc82b29"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"a50a9f0da6e04d0ecbbdca6eb766df753c37c54a","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            manager.NeutronManager.get_service_plugins \u003d o_method"},{"line_number":76,"context_line":"        self.addCleanup(restore_method)"},{"line_number":77,"context_line":"        routers \u003d self.callbacks.sync_routers({})"},{"line_number":78,"context_line":"        self.assertEqual(routers, [])"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_4c53b3e2","line":78,"in_reply_to":"da85f559_9eb8f3c9","updated":"2015-11-11 12:39:23.000000000","message":"Done","commit_id":"903c2135c842f746ef367b83adc6fed33dc82b29"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"34334a44917d648bf8124ffddc01f6de82babd84","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEqual(updated_subnet[\u0027allocation_pools\u0027], allocation_pools)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_sync_routers_with_no_l3plugin(self):"},{"line_number":69,"context_line":"        o_method \u003d manager.NeutronManager.get_service_plugins"},{"line_number":70,"context_line":"        manager.NeutronManager.get_service_plugins \u003d mock.Mock("},{"line_number":71,"context_line":"            return_value\u003d{plugin_constants.L3_ROUTER_NAT: None})"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_e6196389","line":69,"updated":"2015-11-11 13:54:16.000000000","message":"Could you use mock.patch.object instead, which gets automatically cleaned up in teardown?","commit_id":"be733dabf4643593a0640cef80d37804542bf6e8"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"b53d61dc496fc6294663fcf9ef9f79ec197692a8","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.assertEqual(updated_subnet[\u0027allocation_pools\u0027], allocation_pools)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_sync_routers_with_no_l3plugin(self):"},{"line_number":69,"context_line":"        o_method \u003d manager.NeutronManager.get_service_plugins"},{"line_number":70,"context_line":"        manager.NeutronManager.get_service_plugins \u003d mock.Mock("},{"line_number":71,"context_line":"            return_value\u003d{plugin_constants.L3_ROUTER_NAT: None})"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_f527c7b3","line":69,"in_reply_to":"da85f559_e6196389","updated":"2015-11-11 15:01:46.000000000","message":"Thanks for your comment and done","commit_id":"be733dabf4643593a0640cef80d37804542bf6e8"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a4e1e85ba62614115a4d28f34b4e18d75a0a65b0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    def test_sync_routers_with_no_l3plugin(self):"},{"line_number":69,"context_line":"        with mock.patch.object("},{"line_number":70,"context_line":"            manager.NeutronManager, \u0027get_service_plugins\u0027,"},{"line_number":71,"context_line":"            return_value\u003d{plugin_constants.L3_ROUTER_NAT: None}):"},{"line_number":72,"context_line":"            routers \u003d self.callbacks.sync_routers({})"},{"line_number":73,"context_line":"            self.assertEqual([], routers)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_196d6acc","line":71,"updated":"2015-11-13 13:58:04.000000000","message":"how can this happen? From what I see in manager.py, NeutronManager won\u0027t have a key for l3 plugin at all if l3 plugin is not used","commit_id":"5a218e142ad975259da30819f459597d3403a91e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"ea902e2fdccf0dc26c0a983a9490338dad6cba8c","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.assertEqual(updated_subnet[\u0027cidr\u0027], data[subnet[\u0027id\u0027]])"},{"line_number":65,"context_line":"        self.assertEqual(updated_subnet[\u0027allocation_pools\u0027], allocation_pools)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_sync_routers_with_no_l3plugin(self):"},{"line_number":68,"context_line":"        with mock.patch.object("},{"line_number":69,"context_line":"            manager.NeutronManager, \u0027get_service_plugins\u0027, return_value\u003d{}):"},{"line_number":70,"context_line":"            self.assertRaises(KeyError, self.callbacks.sync_routers, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_2b7c67b4","line":67,"updated":"2015-11-15 13:02:26.000000000","message":"not sure I see any value in this test case","commit_id":"73766144e3d4bf06dd3c241508bd5443bdd100fe"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"51132ea79b8fcf465ab171112658ea4fe8436b16","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.assertEqual(updated_subnet[\u0027cidr\u0027], data[subnet[\u0027id\u0027]])"},{"line_number":65,"context_line":"        self.assertEqual(updated_subnet[\u0027allocation_pools\u0027], allocation_pools)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def test_sync_routers_with_no_l3plugin(self):"},{"line_number":68,"context_line":"        with mock.patch.object("},{"line_number":69,"context_line":"            manager.NeutronManager, \u0027get_service_plugins\u0027, return_value\u003d{}):"},{"line_number":70,"context_line":"            self.assertRaises(KeyError, self.callbacks.sync_routers, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_4620c249","line":67,"in_reply_to":"da85f559_2b7c67b4","updated":"2015-11-15 13:53:07.000000000","message":"Done","commit_id":"73766144e3d4bf06dd3c241508bd5443bdd100fe"}]}
