)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f130f56767471d8e2a3b6f1ea3b214e1d154baf1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-08 05:12:25 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DB base plugin: use {} instead of dict"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The performance of {} is far better than dict(). Please see:"},{"line_number":10,"context_line":"https://doughellmann.com/blog/2012/11/12/the-performance-impact-of-using-dict-instead-of-in-cpython-2-7-2/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_e36d3605","line":7,"updated":"2015-11-09 18:56:35.000000000","message":"Why this one and not all the other ones?\n\nA number of reviewers have asked if this is a critical path.  I doubt it is and haven\u0027t seen any response to support that it is.  Do you have performance numbers that show that this code is a real performance problem, one that is really effects users?\n\nI\u0027ll step forward and -1 this because I don\u0027t want to review a bunch of one-off patches that fix a single occurrence of this without good justification:  at least a problem that deserves a real bug report.  (And not \"Neutron should use {} instead of dict())\n\nDoug\u0027s investigation is insightful.  I think we should definitely prefer to create dicts with {} instead of dict() but I really don\u0027t think that we should go fix them one by one unless you have a good reason.","commit_id":"494624a58dc7e45022703d9f8aac64623c3dda6b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"32ffff66643c5fdc65199bb82ecd4b9dcb387f27","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-08 05:12:25 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DB base plugin: use {} instead of dict"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The performance of {} is far better than dict(). Please see:"},{"line_number":10,"context_line":"https://doughellmann.com/blog/2012/11/12/the-performance-impact-of-using-dict-instead-of-in-cpython-2-7-2/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_de824900","line":7,"in_reply_to":"da85f559_e36d3605","updated":"2015-11-09 19:09:54.000000000","message":"+1 to group dict() \u003d\u003e {} replacements\n\nEven if {} is faster than dict(), i doubt it has an impact on a overall performance.","commit_id":"494624a58dc7e45022703d9f8aac64623c3dda6b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f986cce1ed8f4217e38111314a0502ac448cbc6d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gary Kotton \u003cgkotton@vmware.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-08 05:12:25 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DB base plugin: use {} instead of dict"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The performance of {} is far better than dict(). Please see:"},{"line_number":10,"context_line":"https://doughellmann.com/blog/2012/11/12/the-performance-impact-of-using-dict-instead-of-in-cpython-2-7-2/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_eb82d193","line":7,"in_reply_to":"da85f559_e36d3605","updated":"2015-11-10 12:49:12.000000000","message":"my take is that the create port is done most frequently and the others are less frequent. having said that i will go over and update the rest.\n\na few extra cycles for the service to work always helps :)","commit_id":"494624a58dc7e45022703d9f8aac64623c3dda6b"}],"neutron/api/v2/router.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"6b70abf53abac25fdbb226cce46edd64e6dd6157","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            _map_resource(SUB_RESOURCES[resource][\u0027collection_name\u0027], resource,"},{"line_number":114,"context_line":"                          attributes.RESOURCE_ATTRIBUTE_MAP.get("},{"line_number":115,"context_line":"                              SUB_RESOURCES[resource][\u0027collection_name\u0027],"},{"line_number":116,"context_line":"                              {}),"},{"line_number":117,"context_line":"                          SUB_RESOURCES[resource][\u0027parent\u0027])"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        # Certain policy checks require that the extensions are loaded"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_dd946ae3","line":116,"updated":"2015-11-10 14:17:20.000000000","message":"nit. you can write this \u0027{}\u0027 in line 115","commit_id":"4b940d7b3d422e9717176837aba3b3cf9607a172"}]}
