)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8f96b20437c6c964f539f43c7a61953945d72504","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yalei Wang \u003cyalei.wang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-11 23:50:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the missing arg of RetryRequest exception in _lock_subnetpool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I44869c97ecd7d59d40d8793c71515067a237150b"},{"line_number":10,"context_line":"Closes-Bug: #1506818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_8edbdc4e","line":7,"updated":"2015-11-11 08:13:05.000000000","message":"Please see https://wiki.openstack.org/wiki/GitCommitMessages\n\nPlease add some useful explanation for the layman","commit_id":"773d5d295c76d9752ce32c3169220c2412838e78"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"4b24549832471a67d3ee2da4b40a9b2c8e684d04","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yalei Wang \u003cyalei.wang@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-11 23:50:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the missing arg of RetryRequest exception in _lock_subnetpool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I44869c97ecd7d59d40d8793c71515067a237150b"},{"line_number":10,"context_line":"Closes-Bug: #1506818"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_863e5726","line":7,"in_reply_to":"da85f559_8edbdc4e","updated":"2015-11-11 13:51:13.000000000","message":"Done","commit_id":"773d5d295c76d9752ce32c3169220c2412838e78"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"a6fe745869c6a2ab9659faea92a3821165c7a1ca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add the missing arg of RetryRequest exception in _lock_subnetpool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RetryRequest exception defined in oslo.db need be called with a arg"},{"line_number":10,"context_line":"which describes the inner exception. _lock_subnetpool method missed this"},{"line_number":11,"context_line":"arg, and this patch adds it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I44869c97ecd7d59d40d8793c71515067a237150b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_dace19b7","line":10,"updated":"2015-11-12 20:27:47.000000000","message":"nit: this line looks a little long, maybe wrap it if there is a respin....","commit_id":"bded5c4132f1fbd6bba5272f414769de40887ba3"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"f24e8b53ff4637822254a52a9f4caf5256c3d66f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add the missing arg of RetryRequest exception in _lock_subnetpool"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RetryRequest exception defined in oslo.db need be called with a arg"},{"line_number":10,"context_line":"which describes the inner exception. _lock_subnetpool method missed this"},{"line_number":11,"context_line":"arg, and this patch adds it."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I44869c97ecd7d59d40d8793c71515067a237150b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_c5d4fabe","line":10,"in_reply_to":"da85f559_dace19b7","updated":"2015-11-12 21:07:01.000000000","message":"it has been wrapped in 72 characters.\nrule changed?","commit_id":"bded5c4132f1fbd6bba5272f414769de40887ba3"}],"neutron/common/exceptions.py":[{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"22eebc26b20ddd960b5527b4fd9788e76abacae7","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def __init__(self, **kwargs):"},{"line_number":169,"context_line":"        if \u0027reason\u0027 not in kwargs:"},{"line_number":170,"context_line":"            kwargs[\u0027reason\u0027] \u003d _(\"Two or more concurrent subnet allocating.\")"},{"line_number":171,"context_line":"        super(SubnetPoolInUse, self).__init__(**kwargs)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_292dfca7","line":170,"updated":"2015-11-11 14:14:52.000000000","message":"subnets*","commit_id":"773d5d295c76d9752ce32c3169220c2412838e78"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"17d05712987c76b75487eeff273014099e7a5dba","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def __init__(self, **kwargs):"},{"line_number":169,"context_line":"        if \u0027reason\u0027 not in kwargs:"},{"line_number":170,"context_line":"            kwargs[\u0027reason\u0027] \u003d _(\"Two or more concurrent subnet allocating.\")"},{"line_number":171,"context_line":"        super(SubnetPoolInUse, self).__init__(**kwargs)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_a52a648e","line":170,"in_reply_to":"da85f559_292dfca7","updated":"2015-11-11 17:40:58.000000000","message":"Done","commit_id":"773d5d295c76d9752ce32c3169220c2412838e78"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7660ce41c50dc62e67ca2583c76203862ae7603d","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class SubnetPoolInUse(InUse):"},{"line_number":165,"context_line":"    message \u003d _(\"Unable to complete operation on subnet pool \""},{"line_number":166,"context_line":"                \"%(subnet_pool_id)s %(reason)s.\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def __init__(self, **kwargs):"},{"line_number":169,"context_line":"        if \u0027reason\u0027 not in kwargs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_25fb8f48","line":166,"updated":"2015-11-12 17:47:45.000000000","message":"Nit: Put a period after %(subnet_pool_id)s since %(reason)s is a separate sentence.","commit_id":"795128c3944f14134af502120f481c666567661f"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"32759516a9fc0d70b5a0b71cc8d9adabd1f0dc01","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class SubnetPoolInUse(InUse):"},{"line_number":165,"context_line":"    message \u003d _(\"Unable to complete operation on subnet pool \""},{"line_number":166,"context_line":"                \"%(subnet_pool_id)s %(reason)s.\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def __init__(self, **kwargs):"},{"line_number":169,"context_line":"        if \u0027reason\u0027 not in kwargs:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_76494f30","line":166,"in_reply_to":"da85f559_25fb8f48","updated":"2015-11-12 18:50:24.000000000","message":"Done","commit_id":"795128c3944f14134af502120f481c666567661f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"7660ce41c50dc62e67ca2583c76203862ae7603d","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def __init__(self, **kwargs):"},{"line_number":169,"context_line":"        if \u0027reason\u0027 not in kwargs:"},{"line_number":170,"context_line":"            kwargs[\u0027reason\u0027] \u003d _(\"Two or more concurrent subnets allocating.\")"},{"line_number":171,"context_line":"        super(SubnetPoolInUse, self).__init__(**kwargs)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_eac7d495","line":170,"updated":"2015-11-12 17:47:45.000000000","message":"allocating -\u003e allocated","commit_id":"795128c3944f14134af502120f481c666567661f"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"32759516a9fc0d70b5a0b71cc8d9adabd1f0dc01","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def __init__(self, **kwargs):"},{"line_number":169,"context_line":"        if \u0027reason\u0027 not in kwargs:"},{"line_number":170,"context_line":"            kwargs[\u0027reason\u0027] \u003d _(\"Two or more concurrent subnets allocating.\")"},{"line_number":171,"context_line":"        super(SubnetPoolInUse, self).__init__(**kwargs)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_f60a1fd1","line":170,"in_reply_to":"da85f559_eac7d495","updated":"2015-11-12 18:50:24.000000000","message":"I mean two are being allocated concurrently, but Done.","commit_id":"795128c3944f14134af502120f481c666567661f"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"a6fe745869c6a2ab9659faea92a3821165c7a1ca","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class SubnetPoolInUse(InUse):"},{"line_number":165,"context_line":"    message \u003d _(\"Unable to complete operation on subnet pool \""},{"line_number":166,"context_line":"                \"%(subnet_pool_id)s since %(reason)s.\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def __init__(self, **kwargs):"},{"line_number":169,"context_line":"        if \u0027reason\u0027 not in kwargs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_da35b9a8","line":166,"updated":"2015-11-12 20:27:47.000000000","message":"Henry\u0027s suggestion of \"%(subnet_pool_id)s. %(reason)s.\") is better grammatically.","commit_id":"bded5c4132f1fbd6bba5272f414769de40887ba3"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"f24e8b53ff4637822254a52a9f4caf5256c3d66f","unresolved":false,"context_lines":[{"line_number":163,"context_line":""},{"line_number":164,"context_line":"class SubnetPoolInUse(InUse):"},{"line_number":165,"context_line":"    message \u003d _(\"Unable to complete operation on subnet pool \""},{"line_number":166,"context_line":"                \"%(subnet_pool_id)s since %(reason)s.\")"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def __init__(self, **kwargs):"},{"line_number":169,"context_line":"        if \u0027reason\u0027 not in kwargs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_05f20270","line":166,"in_reply_to":"da85f559_da35b9a8","updated":"2015-11-12 21:07:01.000000000","message":"oh, thanks, I understand wrong.","commit_id":"bded5c4132f1fbd6bba5272f414769de40887ba3"}],"neutron/ipam/subnet_alloc.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8f96b20437c6c964f539f43c7a61953945d72504","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            id\u003dself._subnetpool[\u0027id\u0027], hash\u003dcurrent_hash)"},{"line_number":64,"context_line":"        count \u003d query.update({\u0027hash\u0027: new_hash})"},{"line_number":65,"context_line":"        if not count:"},{"line_number":66,"context_line":"            raise db_exc.RetryRequest(n_exc.SubnetPoolInUse(subnet_pool_id\u003d"},{"line_number":67,"context_line":"                                      self._subnetpool[\u0027id\u0027]))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _get_allocated_cidrs(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_2e1670f1","line":66,"updated":"2015-11-11 08:13:05.000000000","message":"do we have a unit test for this?","commit_id":"773d5d295c76d9752ce32c3169220c2412838e78"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"4b24549832471a67d3ee2da4b40a9b2c8e684d04","unresolved":false,"context_lines":[{"line_number":63,"context_line":"            id\u003dself._subnetpool[\u0027id\u0027], hash\u003dcurrent_hash)"},{"line_number":64,"context_line":"        count \u003d query.update({\u0027hash\u0027: new_hash})"},{"line_number":65,"context_line":"        if not count:"},{"line_number":66,"context_line":"            raise db_exc.RetryRequest(n_exc.SubnetPoolInUse(subnet_pool_id\u003d"},{"line_number":67,"context_line":"                                      self._subnetpool[\u0027id\u0027]))"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _get_allocated_cidrs(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_46edcfb5","line":66,"in_reply_to":"da85f559_2e1670f1","updated":"2015-11-11 13:51:13.000000000","message":"thanks garyk, yes, I am adding one, so mark it WIP now.","commit_id":"773d5d295c76d9752ce32c3169220c2412838e78"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3405a4d6acfbda6b716b79af1652fd436b410ecb","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        subnetpool, it\u0027s required to ensure non-overlapping cidrs in the same"},{"line_number":48,"context_line":"        subnetpool."},{"line_number":49,"context_line":"        \"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        current_hash \u003d (self._context.session.query(models_v2.SubnetPool.hash)"},{"line_number":52,"context_line":"                        .filter_by(id\u003dself._subnetpool[\u0027id\u0027]).scalar())"},{"line_number":53,"context_line":"        if current_hash is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_e806571f","side":"PARENT","line":50,"updated":"2015-11-16 06:45:00.000000000","message":"unrelated change","commit_id":"00f5fedab034830bfa743966d5625fa1899baee0"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"d9fbce6376312520d60c1f844451fc43f21dd862","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        subnetpool, it\u0027s required to ensure non-overlapping cidrs in the same"},{"line_number":48,"context_line":"        subnetpool."},{"line_number":49,"context_line":"        \"\"\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        current_hash \u003d (self._context.session.query(models_v2.SubnetPool.hash)"},{"line_number":52,"context_line":"                        .filter_by(id\u003dself._subnetpool[\u0027id\u0027]).scalar())"},{"line_number":53,"context_line":"        if current_hash is None:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_9caf1be3","side":"PARENT","line":50,"in_reply_to":"da85f559_e806571f","updated":"2015-11-16 15:57:32.000000000","message":"Done","commit_id":"00f5fedab034830bfa743966d5625fa1899baee0"}]}
