)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"e087340039647bb61e8f87b39241b442edc26580","unresolved":false,"context_lines":[{"line_number":14,"context_line":"it."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I860ee3522275f62f393e66853e53ef387598983d"},{"line_number":17,"context_line":"CLoses-Bug: #1515341"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da85f559_a9aab5d0","line":17,"updated":"2015-11-13 22:08:59.000000000","message":"I\u0027m not sure if this affects anything, but you could fix this if you do another PS:\n\nCLoses -\u003e Closes","commit_id":"da3de52c507544c84463a037acac3b2b24a37fe0"}],"neutron/agent/l3/dvr_local_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2c1aeee08830610412d4038f929eac5fd5440688","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":92,"context_line":"        if self.rtr_fip_subnet is None:"},{"line_number":93,"context_line":"            self.rtr_fip_subnet \u003d self.fip_ns.local_subnets.allocate("},{"line_number":94,"context_line":"                self.router_id)"},{"line_number":95,"context_line":"        rtr_2_fip, _ \u003d self.rtr_fip_subnet.get_pair()"},{"line_number":96,"context_line":"        device \u003d ip_lib.IPDevice(fip_2_rtr_name, namespace\u003dfip_ns_name)"},{"line_number":97,"context_line":"        device.route.add_route(fip_cidr, str(rtr_2_fip.ip))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_3784695c","line":94,"updated":"2015-11-11 18:23:58.000000000","message":"A tweak of test_floating_ip_added_dist() and test_floating_ip_removed_dist() would be great so we verify the allocator was called.  ri.rtr_fip_subnet is currently hard-coded.","commit_id":"f76c5ba2f02ddfb9c82199d9338d267c75b8ad0d"},{"author":{"_account_id":10652,"name":"Erik Colnick","email":"erikcolnick@gmail.com","username":"ecolnick"},"change_message_id":"e62ccaba2e45b850afc3bce91d300eb7c60abd15","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":92,"context_line":"        if self.rtr_fip_subnet is None:"},{"line_number":93,"context_line":"            self.rtr_fip_subnet \u003d self.fip_ns.local_subnets.allocate("},{"line_number":94,"context_line":"                self.router_id)"},{"line_number":95,"context_line":"        rtr_2_fip, _ \u003d self.rtr_fip_subnet.get_pair()"},{"line_number":96,"context_line":"        device \u003d ip_lib.IPDevice(fip_2_rtr_name, namespace\u003dfip_ns_name)"},{"line_number":97,"context_line":"        device.route.add_route(fip_cidr, str(rtr_2_fip.ip))"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_a828f4e2","line":94,"in_reply_to":"da85f559_3784695c","updated":"2015-11-11 19:35:32.000000000","message":"Done","commit_id":"f76c5ba2f02ddfb9c82199d9338d267c75b8ad0d"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"76d11ea049a284838b3acb1ca4a9d35d97568a0c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                         priority\u003drule_pr)"},{"line_number":90,"context_line":"        #Add routing rule in fip namespace"},{"line_number":91,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":92,"context_line":"        if self.rtr_fip_subnet is None:"},{"line_number":93,"context_line":"            self.rtr_fip_subnet \u003d self.fip_ns.local_subnets.allocate("},{"line_number":94,"context_line":"                self.router_id)"},{"line_number":95,"context_line":"        rtr_2_fip, _ \u003d self.rtr_fip_subnet.get_pair()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_73a2b39c","line":92,"updated":"2015-11-12 23:58:53.000000000","message":"Did you consider removing ri.rtr_fip_subnet initialization from FipNamespace.create_rtr_2_fip_link and moving it up to create_dvr_fip_interfaces, out of the conditional? Isn\u0027t that the bug really, that self.rtr_fip_subnet is being initialized only when \u0027self.dist_fip_count \u003d\u003d 0 or is_first\u0027 but you wanna initialize it in case the router is connected to an external network? (Which is a broader, less strict conditional).","commit_id":"da3de52c507544c84463a037acac3b2b24a37fe0"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e83b6a91d9b6e4b1021902b707e62b8ad05d1406","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                         priority\u003drule_pr)"},{"line_number":90,"context_line":"        #Add routing rule in fip namespace"},{"line_number":91,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":92,"context_line":"        if self.rtr_fip_subnet is None:"},{"line_number":93,"context_line":"            self.rtr_fip_subnet \u003d self.fip_ns.local_subnets.allocate("},{"line_number":94,"context_line":"                self.router_id)"},{"line_number":95,"context_line":"        rtr_2_fip, _ \u003d self.rtr_fip_subnet.get_pair()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_225da5e9","line":92,"in_reply_to":"ba8a016a_1f147af3","updated":"2015-11-16 17:15:08.000000000","message":"If you keep this change then my suggestion doesn\u0027t make sense. It\u0027s about making sure that self.rtr_fip_subnet is initialized exactly once.","commit_id":"da3de52c507544c84463a037acac3b2b24a37fe0"},{"author":{"_account_id":10652,"name":"Erik Colnick","email":"erikcolnick@gmail.com","username":"ecolnick"},"change_message_id":"916ee9d0dfc0e0dc989546296e4e7e10ec839710","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                         priority\u003drule_pr)"},{"line_number":90,"context_line":"        #Add routing rule in fip namespace"},{"line_number":91,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":92,"context_line":"        if self.rtr_fip_subnet is None:"},{"line_number":93,"context_line":"            self.rtr_fip_subnet \u003d self.fip_ns.local_subnets.allocate("},{"line_number":94,"context_line":"                self.router_id)"},{"line_number":95,"context_line":"        rtr_2_fip, _ \u003d self.rtr_fip_subnet.get_pair()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_42dd4913","line":92,"in_reply_to":"ba8a016a_225da5e9","updated":"2015-11-16 17:19:27.000000000","message":"Okay.","commit_id":"da3de52c507544c84463a037acac3b2b24a37fe0"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"cd619ddd915bbf88e1d2a32c1802008563657253","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                         priority\u003drule_pr)"},{"line_number":90,"context_line":"        #Add routing rule in fip namespace"},{"line_number":91,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":92,"context_line":"        if self.rtr_fip_subnet is None:"},{"line_number":93,"context_line":"            self.rtr_fip_subnet \u003d self.fip_ns.local_subnets.allocate("},{"line_number":94,"context_line":"                self.router_id)"},{"line_number":95,"context_line":"        rtr_2_fip, _ \u003d self.rtr_fip_subnet.get_pair()"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_7ee6d3e9","line":92,"in_reply_to":"da85f559_73a2b39c","updated":"2015-11-13 16:15:22.000000000","message":"I agree with Assaf\u0027s reasoning","commit_id":"da3de52c507544c84463a037acac3b2b24a37fe0"},{"author":{"_account_id":10652,"name":"Erik Colnick","email":"erikcolnick@gmail.com","username":"ecolnick"},"change_message_id":"f1224efdb516b32670914a8a648e91578dacf98d","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                         priority\u003drule_pr)"},{"line_number":90,"context_line":"        #Add routing rule in fip namespace"},{"line_number":91,"context_line":"        fip_ns_name \u003d self.fip_ns.get_name()"},{"line_number":92,"context_line":"        if self.rtr_fip_subnet is None:"},{"line_number":93,"context_line":"            self.rtr_fip_subnet \u003d self.fip_ns.local_subnets.allocate("},{"line_number":94,"context_line":"                self.router_id)"},{"line_number":95,"context_line":"        rtr_2_fip, _ \u003d self.rtr_fip_subnet.get_pair()"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_1f147af3","line":92,"in_reply_to":"da85f559_7ee6d3e9","updated":"2015-11-16 16:58:03.000000000","message":"I am happy to pursue your suggested change as part of this patch.  Do you feel that it would at the same time be prudent to keep this check as well?  In general, it is my opinion that prior to calling a method on an object it is generally a good idea to make sure the object exists.","commit_id":"da3de52c507544c84463a037acac3b2b24a37fe0"}],"neutron/tests/unit/agent/l3/test_dvr_local_router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"714430f76166d40020c9882b07c4a7bf4d54aa89","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        s \u003d lla.LinkLocalAddressPair(\u0027169.254.30.42/31\u0027)"},{"line_number":247,"context_line":"        ri.rtr_fip_subnet \u003d s"},{"line_number":248,"context_line":"        ri.fip_ns.local_subnets \u003d mock.Mock()"},{"line_number":249,"context_line":"        ri.fip_ns.local_subnets.allocate.return_value \u003d s"},{"line_number":250,"context_line":"        ri.floating_ip_removed_dist(fip_cidr)"},{"line_number":251,"context_line":"        mIPRule().rule.delete.assert_called_with("},{"line_number":252,"context_line":"            ip\u003dstr(netaddr.IPNetwork(fip_cidr).ip), table\u003d16, priority\u003dFIP_PRI)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_f9281035","line":249,"updated":"2015-11-11 20:37:17.000000000","message":"nit: you don\u0027t need this as the allocator isn\u0027t being called in this first test","commit_id":"dabbf4bed359533b3ccf01c6ec23e63ba1a2e6e2"},{"author":{"_account_id":10652,"name":"Erik Colnick","email":"erikcolnick@gmail.com","username":"ecolnick"},"change_message_id":"98b49f310a129cb506b252fdb85f1929be396877","unresolved":false,"context_lines":[{"line_number":246,"context_line":"        s \u003d lla.LinkLocalAddressPair(\u0027169.254.30.42/31\u0027)"},{"line_number":247,"context_line":"        ri.rtr_fip_subnet \u003d s"},{"line_number":248,"context_line":"        ri.fip_ns.local_subnets \u003d mock.Mock()"},{"line_number":249,"context_line":"        ri.fip_ns.local_subnets.allocate.return_value \u003d s"},{"line_number":250,"context_line":"        ri.floating_ip_removed_dist(fip_cidr)"},{"line_number":251,"context_line":"        mIPRule().rule.delete.assert_called_with("},{"line_number":252,"context_line":"            ip\u003dstr(netaddr.IPNetwork(fip_cidr).ip), table\u003d16, priority\u003dFIP_PRI)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_f937b04a","line":249,"in_reply_to":"da85f559_f9281035","updated":"2015-11-11 20:43:13.000000000","message":"You are correct.  Will remove.","commit_id":"dabbf4bed359533b3ccf01c6ec23e63ba1a2e6e2"}]}
