)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"0eccfefc3aef0e5c8c0b989cf7b920499d5b554c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes internal server error when updating bandwidth-limit-rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When calling qos-bandwidth-limit-rule-update as a member user,"},{"line_number":10,"context_line":"an internal server error will be raised."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6cd816dbeddab15d4289f6ae44d6a31c15397cbb"},{"line_number":13,"context_line":"Closes-bug: #1515564"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_c3240861","line":10,"updated":"2015-11-12 14:57:53.000000000","message":"I guess that the issue can happen in other cases as far as I see this patch.\n\nCan you elaborate and add UT related to the issue?","commit_id":"f86eeb09ac3c0d135510a44b2dec3525a2c068ba"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"aad6db36c0d445d90aac9291adc7d960ec169ab7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes internal server error when updating bandwidth-limit-rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When calling qos-bandwidth-limit-rule-update as a member user,"},{"line_number":10,"context_line":"an internal server error will be raised."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6cd816dbeddab15d4289f6ae44d6a31c15397cbb"},{"line_number":13,"context_line":"Closes-bug: #1515564"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_48a571b3","line":10,"updated":"2015-11-13 05:16:00.000000000","message":"This is a bug of policy management rather than qos so this commit message may confuse reviewer. Can you improve the message so that reviewer easily understand that this patch fixes policy issue?","commit_id":"ff36d18d1f399217795471bf5c1ba1a1e85b3884"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7c09e7991522c240977c31b1842a71d02d51ee23","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixes internal server error when updating bandwidth-limit-rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When calling qos-bandwidth-limit-rule-update as a member user,"},{"line_number":10,"context_line":"an internal server error will be raised."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6cd816dbeddab15d4289f6ae44d6a31c15397cbb"},{"line_number":13,"context_line":"Closes-bug: #1515564"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_6e8cfd7f","line":10,"in_reply_to":"da85f559_48a571b3","updated":"2015-11-13 05:56:29.000000000","message":"Done","commit_id":"ff36d18d1f399217795471bf5c1ba1a1e85b3884"}],"neutron/api/v2/base.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"ab7be7cdb801b445e21323610898454719702dd8","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                # If a tenant is modifying it\u0027s own object, it\u0027s safe to return"},{"line_number":602,"context_line":"                # a 403. Otherwise, pretend that it doesn\u0027t exist to avoid"},{"line_number":603,"context_line":"                # giving away information."},{"line_number":604,"context_line":"                if request.context.tenant_id !\u003d orig_obj.get(\u0027tenant_id\u0027):"},{"line_number":605,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":606,"context_line":"            msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":607,"context_line":"            raise webob.exc.HTTPNotFound(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_7d3db5c2","line":604,"updated":"2015-11-12 16:47:47.000000000","message":"As I understand from this code, if Alice tries to access Bob\u0027s resources and she shouldn\u0027t be able to because of a tenant_id mismatch, she should *always* get a 4004 HTTPNotFound.\n\nIf I\u0027m correct, then I believe that this fix introduces a (minor) security issue: If Alice tries to update Bob\u0027s qos rule and she uses tenant_id\u003dNone, a 403 (PolicyNotAuthorized) will be thrown, instead of the intended 404 HTTPNotFound. Alice can then conclude that the qos rule id she used exists (which she shouldn\u0027t be able to).\n\n@Ihar, @Salvatore, what do you guys think?","commit_id":"f86eeb09ac3c0d135510a44b2dec3525a2c068ba"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c66ab6035d9c7dc303e12b9ee4ea55328f4f25a2","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                # If a tenant is modifying it\u0027s own object, it\u0027s safe to return"},{"line_number":602,"context_line":"                # a 403. Otherwise, pretend that it doesn\u0027t exist to avoid"},{"line_number":603,"context_line":"                # giving away information."},{"line_number":604,"context_line":"                if request.context.tenant_id !\u003d orig_obj.get(\u0027tenant_id\u0027):"},{"line_number":605,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":606,"context_line":"            msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":607,"context_line":"            raise webob.exc.HTTPNotFound(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_c0acf1a0","line":604,"in_reply_to":"da85f559_7d3db5c2","updated":"2015-11-12 18:01:20.000000000","message":"I think we always assumed that if a scenario involves guessing the id, it\u0027s not really possible to use it for an attack IRL.","commit_id":"f86eeb09ac3c0d135510a44b2dec3525a2c068ba"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"11127a7b64a5aa8d2c83c0ce1e4d8d050e2245f7","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                # If a tenant is modifying it\u0027s own object, it\u0027s safe to return"},{"line_number":602,"context_line":"                # a 403. Otherwise, pretend that it doesn\u0027t exist to avoid"},{"line_number":603,"context_line":"                # giving away information."},{"line_number":604,"context_line":"                if request.context.tenant_id !\u003d orig_obj.get(\u0027tenant_id\u0027):"},{"line_number":605,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":606,"context_line":"            msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":607,"context_line":"            raise webob.exc.HTTPNotFound(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_dcd7debd","line":604,"in_reply_to":"da85f559_c0acf1a0","updated":"2015-11-13 09:57:45.000000000","message":"Actually, now that I look at it more closely, I think we may be consistent here. If we hide resource existence from unauthorized tenants, and if we are capable of operating on a specific rule thru API, it is probably worth to handle it as any other type.\n\nWhich would probably mean adding tenant_id field to rules, even if not exposing them into API (because it\u0027s not really needed since it duplicates tenant_id from the policy).\n\nAnother alternative would be adding a hooking mechanism to extract tenant_id for a resource, that would behave differently for resources known not to have tenant_id. But that seems a bit hacky.\n\nI want to hear from Kevin and Salvatore on the matter.","commit_id":"f86eeb09ac3c0d135510a44b2dec3525a2c068ba"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"84cb10d86c44346757f4307202d8c037d9568357","unresolved":false,"context_lines":[{"line_number":601,"context_line":"                # If a tenant is modifying it\u0027s own object, it\u0027s safe to return"},{"line_number":602,"context_line":"                # a 403. Otherwise, pretend that it doesn\u0027t exist to avoid"},{"line_number":603,"context_line":"                # giving away information."},{"line_number":604,"context_line":"                if request.context.tenant_id !\u003d orig_obj.get(\u0027tenant_id\u0027):"},{"line_number":605,"context_line":"                    ctxt.reraise \u003d False"},{"line_number":606,"context_line":"            msg \u003d _(\u0027The resource could not be found.\u0027)"},{"line_number":607,"context_line":"            raise webob.exc.HTTPNotFound(msg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_6325bac0","line":604,"in_reply_to":"da85f559_dcd7debd","updated":"2015-11-23 13:48:18.000000000","message":"@John - I think people should have listened all the times I asked to refrain from creating resources without tenant_id...\n\nThat said, the change proposed here makes sense from what I gather.\nI do not understand what do you mean by \"Alice uses tenant_id\u003dNone\". If Alice is making the request context.tenant_id will always be Alice\u0027s tenant_id. Alice does not have control over it.\n\n@Ihar - I am not sure we can add the tenant_id to qos rules, but if that\u0027s not too difficult I\u0027d go for that, unless it creates complications in the API user workflow. From what John writes there is a concept of ownership for qos rules, and that should be probably represented in the model.\n\nExtracting the tenant_id from the parent resource would lead to resource-specfic behaviour in the API controller. This is not as bad as it seems after all. In particular it should be easier to implement as we move to Pecan. In the current controller framework it\u0027s a bit hackish (but I\u0027d keep it hackish rather than thinking about how to add features to a framework which is probably going to be eventually deprecated*)\n\n* on the other hand the fact that I had to use \u0027probably\u0027 and \u0027eventually\u0027 constitute a compelling reason for adding a feature to the current framework!","commit_id":"f86eeb09ac3c0d135510a44b2dec3525a2c068ba"}],"neutron/db/migration/alembic_migrations/versions/mitaka/contract/4ab44c6c9e0b_add_tenant_to_qos_rule.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5116338a39fc8c91fd400cd8b2f268e4b0b2c50b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_7c8e507a","line":1,"updated":"2015-12-21 05:39:34.000000000","message":"Plz provide your company details.","commit_id":"ee52e400561dfc917aa506e730a4fe6cdf94e094"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"118019f94753985d2bcf0a0a84625ff2bd2f7224","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_1c5dcc78","line":1,"in_reply_to":"3a7e1126_7c8e507a","updated":"2015-12-21 06:53:39.000000000","message":"Done","commit_id":"ee52e400561dfc917aa506e730a4fe6cdf94e094"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5116338a39fc8c91fd400cd8b2f268e4b0b2c50b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                            index\u003dTrue, nullable\u003dFalse))"},{"line_number":49,"context_line":"    bind \u003d op.get_bind()"},{"line_number":50,"context_line":"    rules \u003d bind.execute(select([\u0027qos_policy_id\u0027], from_obj\u003dqos_rule))"},{"line_number":51,"context_line":"    rules \u003d [dict(r) for r in rules]"},{"line_number":52,"context_line":"    for rule in rules:"},{"line_number":53,"context_line":"        policies \u003d bind.execute("},{"line_number":54,"context_line":"            select([\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_7ce5f035","line":51,"updated":"2015-12-21 05:39:34.000000000","message":"Why we got to do this conversion? Can\u0027t we directly use rules as returned by bind.execute?","commit_id":"ee52e400561dfc917aa506e730a4fe6cdf94e094"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"118019f94753985d2bcf0a0a84625ff2bd2f7224","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                            index\u003dTrue, nullable\u003dFalse))"},{"line_number":49,"context_line":"    bind \u003d op.get_bind()"},{"line_number":50,"context_line":"    rules \u003d bind.execute(select([\u0027qos_policy_id\u0027], from_obj\u003dqos_rule))"},{"line_number":51,"context_line":"    rules \u003d [dict(r) for r in rules]"},{"line_number":52,"context_line":"    for rule in rules:"},{"line_number":53,"context_line":"        policies \u003d bind.execute("},{"line_number":54,"context_line":"            select([\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_bc603802","line":51,"in_reply_to":"3a7e1126_7ce5f035","updated":"2015-12-21 06:53:39.000000000","message":"Done","commit_id":"ee52e400561dfc917aa506e730a4fe6cdf94e094"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5116338a39fc8c91fd400cd8b2f268e4b0b2c50b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            select([\u0027tenant_id\u0027],"},{"line_number":55,"context_line":"            from_obj\u003dqos_policy).where("},{"line_number":56,"context_line":"                qos_policy.c.id \u003d\u003d rule[\u0027qos_policy_id\u0027]))"},{"line_number":57,"context_line":"        policies \u003d [dict(p) for p in policies]"},{"line_number":58,"context_line":"        for p in policies:"},{"line_number":59,"context_line":"            bind.execute("},{"line_number":60,"context_line":"                qos_rule.update().where("}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_3cd2085d","line":57,"updated":"2015-12-21 05:39:34.000000000","message":"ditto","commit_id":"ee52e400561dfc917aa506e730a4fe6cdf94e094"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"118019f94753985d2bcf0a0a84625ff2bd2f7224","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            select([\u0027tenant_id\u0027],"},{"line_number":55,"context_line":"            from_obj\u003dqos_policy).where("},{"line_number":56,"context_line":"                qos_policy.c.id \u003d\u003d rule[\u0027qos_policy_id\u0027]))"},{"line_number":57,"context_line":"        policies \u003d [dict(p) for p in policies]"},{"line_number":58,"context_line":"        for p in policies:"},{"line_number":59,"context_line":"            bind.execute("},{"line_number":60,"context_line":"                qos_rule.update().where("}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_dc5d0448","line":57,"in_reply_to":"3a7e1126_3cd2085d","updated":"2015-12-21 06:53:39.000000000","message":"Done","commit_id":"ee52e400561dfc917aa506e730a4fe6cdf94e094"}],"neutron/db/migration/alembic_migrations/versions/mitaka/expand/4ab44c6c9e0b_add_tenant_to_qos_rule.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"45dad419a5ae6abfe1bac432a3daf4f3ecfc9315","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def upgrade():"},{"line_number":46,"context_line":"    op.add_column(\u0027qos_bandwidth_limit_rules\u0027,"},{"line_number":47,"context_line":"                  sa.Column(\u0027tenant_id\u0027, sa.String(36), nullable\u003dFalse))"},{"line_number":48,"context_line":"    bind \u003d op.get_bind()"},{"line_number":49,"context_line":"    rules \u003d bind.execute(select([\u0027qos_policy_id\u0027], from_obj\u003dqos_rule))"},{"line_number":50,"context_line":"    rules \u003d [dict(r) for r in rules]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_1d22f1b9","line":47,"range":{"start_line":46,"start_character":4,"end_line":47,"end_character":72},"updated":"2015-12-18 07:48:41.000000000","message":"This will column will require index\u003dTrue.","commit_id":"652854c14cbdc2462ca4abb2518da00c4d4566e7"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a7976b28a8989332426ae8a3a530e317d3865123","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def upgrade():"},{"line_number":46,"context_line":"    op.add_column(\u0027qos_bandwidth_limit_rules\u0027,"},{"line_number":47,"context_line":"                  sa.Column(\u0027tenant_id\u0027, sa.String(36), nullable\u003dFalse))"},{"line_number":48,"context_line":"    bind \u003d op.get_bind()"},{"line_number":49,"context_line":"    rules \u003d bind.execute(select([\u0027qos_policy_id\u0027], from_obj\u003dqos_rule))"},{"line_number":50,"context_line":"    rules \u003d [dict(r) for r in rules]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_a0edb426","line":47,"range":{"start_line":46,"start_character":4,"end_line":47,"end_character":72},"in_reply_to":"3a7e1126_1d22f1b9","updated":"2015-12-18 08:01:52.000000000","message":"Done","commit_id":"652854c14cbdc2462ca4abb2518da00c4d4566e7"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"45dad419a5ae6abfe1bac432a3daf4f3ecfc9315","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        policies \u003d [dict(p) for p in policies]"},{"line_number":56,"context_line":"        for p in policies:"},{"line_number":57,"context_line":"            bind.execute("},{"line_number":58,"context_line":"                qos_rule.update().where("},{"line_number":59,"context_line":"                qos_rule.c.qos_policy_id \u003d\u003d rule[\u0027qos_policy_id\u0027]).\\"},{"line_number":60,"context_line":"                values(tenant_id\u003dp[\u0027tenant_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_ddf8e94b","line":60,"range":{"start_line":58,"start_character":15,"end_line":60,"end_character":49},"updated":"2015-12-18 07:48:41.000000000","message":"This should be contract migration. All operations with data are not allowed in expand branch. For reference: http://docs.openstack.org/developer/neutron/devref/alembic_migrations.html#offline-online-migrations","commit_id":"652854c14cbdc2462ca4abb2518da00c4d4566e7"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"a7976b28a8989332426ae8a3a530e317d3865123","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        policies \u003d [dict(p) for p in policies]"},{"line_number":56,"context_line":"        for p in policies:"},{"line_number":57,"context_line":"            bind.execute("},{"line_number":58,"context_line":"                qos_rule.update().where("},{"line_number":59,"context_line":"                qos_rule.c.qos_policy_id \u003d\u003d rule[\u0027qos_policy_id\u0027]).\\"},{"line_number":60,"context_line":"                values(tenant_id\u003dp[\u0027tenant_id\u0027]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_009848bf","line":60,"range":{"start_line":58,"start_character":15,"end_line":60,"end_character":49},"in_reply_to":"3a7e1126_ddf8e94b","updated":"2015-12-18 08:01:52.000000000","message":"Done","commit_id":"652854c14cbdc2462ca4abb2518da00c4d4566e7"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"e800f99ebd09c852e9e466d8ca12378f39b5eff3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        policies \u003d bind.execute("},{"line_number":45,"context_line":"            select([\u0027tenant_id\u0027],"},{"line_number":46,"context_line":"            from_obj\u003dqos_policy).where("},{"line_number":47,"context_line":"                qos_policy.c.id \u003d\u003d rule[0]))"},{"line_number":48,"context_line":"        for p in policies:"},{"line_number":49,"context_line":"            bind.execute("},{"line_number":50,"context_line":"                qos_rule.update().where("}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_9d08cfdb","line":47,"range":{"start_line":47,"start_character":26,"end_line":47,"end_character":27},"updated":"2015-12-21 10:15:18.000000000","message":"I feel like it should be possible for you to emit a single select statement where you join rule and policy. For each rule_id in that statement then you can emit an update statement.\n\nThis is not superimportant as this is going to be executed only once, but if you reckon too you can improve the efficiency of your data migration you should do it, don\u0027t you?","commit_id":"b31a3e9eff50f858a229f307e240aac77a1e7271"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"f4c30bef28933de9ad818b27e40143ef1b99dd4f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        policies \u003d bind.execute("},{"line_number":45,"context_line":"            select([\u0027tenant_id\u0027],"},{"line_number":46,"context_line":"            from_obj\u003dqos_policy).where("},{"line_number":47,"context_line":"                qos_policy.c.id \u003d\u003d rule[0]))"},{"line_number":48,"context_line":"        for p in policies:"},{"line_number":49,"context_line":"            bind.execute("},{"line_number":50,"context_line":"                qos_rule.update().where("}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_ff42040e","line":47,"range":{"start_line":47,"start_character":26,"end_line":47,"end_character":27},"in_reply_to":"3a7e1126_9d08cfdb","updated":"2015-12-22 02:19:42.000000000","message":"Yes, Done, Thanks","commit_id":"b31a3e9eff50f858a229f307e240aac77a1e7271"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"456715036708b862dcd938746442c020196d0b5a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    qos_rule \u003d sa.Table(\u0027qos_bandwidth_limit_rules\u0027,"},{"line_number":40,"context_line":"                        sa.MetaData(), autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":41,"context_line":"    bind.execute("},{"line_number":42,"context_line":"        qos_rule.update().where("},{"line_number":43,"context_line":"            qos_rule.c.qos_policy_id \u003d\u003d qos_policy.c.id).values("},{"line_number":44,"context_line":"                tenant_id\u003dqos_policy.c.tenant_id))"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_ea1f6859","line":42,"updated":"2016-01-12 12:03:21.000000000","message":"This is a massive nitpick... however how much this migration can be considered \"expand\"? There is a tiny tiny chance to not update all the rules...\n\nFeel free to ignore the comment","commit_id":"873b87c8d14ad8b581f7f800211bd689f2fa5000"}],"neutron/db/migration/alembic_migrations/versions/newton/contract/704162059cff_add_project_to_qos_rule.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"41a0ab85529b0380c76a43f33449837a3c9471bb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        qos_dm_rule.update().where("},{"line_number":55,"context_line":"            qos_dm_rule.c.qos_policy_id \u003d\u003d qos_policy.c.id).values("},{"line_number":56,"context_line":"                project_id\u003dqos_policy.c.tenant_id))"},{"line_number":57,"context_line":"    # Change tenant_id to project_id for policy table"},{"line_number":58,"context_line":"    op.alter_column(\u0027qos_policies\u0027, \u0027tenant_id\u0027,"},{"line_number":59,"context_line":"                    new_column_name\u003d\u0027project_id\u0027,"},{"line_number":60,"context_line":"                    existing_type\u003dsa.String(255))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def contract_creation_exceptions():"}],"source_content_type":"text/x-python","patch_set":37,"id":"1aa78d24_07ba290a","line":60,"range":{"start_line":57,"start_character":0,"end_line":60,"end_character":49},"updated":"2016-07-06 03:57:16.000000000","message":"I think it would be better to let https://review.openstack.org/335786 take care of this.","commit_id":"be0b56d3d0c245564086d618759d1166e42e97d9"}],"neutron/db/migration/alembic_migrations/versions/newton/expand/3b7a48f5f1fa_add_project_to_qos_rule.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"67f274a39b96c611c6704797f2f8746326fec226","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from alembic import op"},{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027qos_bandwidth_limit_rules\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_fd5d0516","line":30,"updated":"2016-06-29 07:31:38.000000000","message":"To add exceptions for usage add this \n\n\n    def contract_creation_exceptions():\n        return {\n        sa.Column: [\u0027qos_bandwidth_limit_rules.tenant_id\u0027]\n        sa.Column: [\u0027qos_dscp_marking_rules.tenant_id\u0027]\n    }\n\nFor reference https://github.com/openstack/neutron/blob/854e95d207b7e78b353228d10f5a86d1b2003d2e/neutron/db/migration/alembic_migrations/versions/newton/contract/c879c5e1ee90_add_segment_id_to_subnet.py#L33-L42","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"49f1d5b786f75ac0cbd26288f910159dd2a45bda","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from alembic import op"},{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027qos_bandwidth_limit_rules\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_d1c57e8e","line":30,"in_reply_to":"3aaa91ec_49d3bb38","updated":"2016-06-29 13:59:16.000000000","message":"Great, thanks, i didn\u0027t know there is a depends_on attribute before, will use it.","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a87e60181feb7ac185a0a141cc2a20591ae30e2c","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from alembic import op"},{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027qos_bandwidth_limit_rules\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_49d3bb38","line":30,"in_reply_to":"3aaa91ec_5d2c194a","updated":"2016-06-29 09:00:57.000000000","message":"Sorry, you cannot just have that code in expand branch. If you need to wait for the tables to be created, use depends_on attribute in this script to order scripts correctly.","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"51d74695f368dc60cd80cf0e74cf31a4e73f10dc","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from alembic import op"},{"line_number":29,"context_line":"import sqlalchemy as sa"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027qos_bandwidth_limit_rules\u0027,"}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_5d2c194a","line":30,"in_reply_to":"3aaa91ec_fd5d0516","updated":"2016-06-29 08:44:20.000000000","message":"thanks, but when i sync db, it failed with table qos_dscp_marking_rules not found, because qos_dscp_marking_rules table is created after all contract migrations are done, so i have to keep this in expand for now..","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"be507217cf30445de2906ab1529045989b6b2d5b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            qos_bl_rule.c.qos_policy_id \u003d\u003d qos_policy.c.id).values("},{"line_number":49,"context_line":"                project_id\u003dqos_policy.c.tenant_id))"},{"line_number":50,"context_line":"    # qos_dscp_marking_rules table is created after contract migrations, so"},{"line_number":51,"context_line":"    # we have to put this here in expand."},{"line_number":52,"context_line":"    bind.execute("},{"line_number":53,"context_line":"        qos_dm_rule.update().where("},{"line_number":54,"context_line":"            qos_dm_rule.c.qos_policy_id \u003d\u003d qos_policy.c.id).values("}],"source_content_type":"text/x-python","patch_set":36,"id":"3aaa91ec_49045b7d","line":51,"updated":"2016-06-29 09:05:57.000000000","message":"No we can\u0027t. Please read comments.","commit_id":"676f95b05d7a95aee5fdb146ad6c34a7e8dff500"}],"neutron/db/migration/alembic_migrations/versions/newton/expand/4ab44c6c9e0b_add_tenant_to_qos_rule.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"939be17c197c92c9dc7ee3ad29085144ff53345c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027qos_bandwidth_limit_rules\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027tenant_id\u0027, sa.String(255),"},{"line_number":35,"context_line":"                            index\u003dTrue, nullable\u003dTrue))"},{"line_number":36,"context_line":"    op.add_column(\u0027qos_dscp_marking_rules\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027tenant_id\u0027, sa.String(255),"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_318d347c","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":38},"updated":"2016-06-28 08:24:25.000000000","message":"weren\u0027t we going to rename all tenant_id fields in the database? If so, then probably it\u0027s better to start with a clean slate here, using project_id for the field.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"41f75d72c8869f0662a2a187406b84cc750a52fa","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027qos_bandwidth_limit_rules\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027tenant_id\u0027, sa.String(255),"},{"line_number":35,"context_line":"                            index\u003dTrue, nullable\u003dTrue))"},{"line_number":36,"context_line":"    op.add_column(\u0027qos_dscp_marking_rules\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027tenant_id\u0027, sa.String(255),"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_7164dc48","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":38},"in_reply_to":"3aaa91ec_318d347c","updated":"2016-06-28 08:33:49.000000000","message":"I agree, let\u0027s check that.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"686475bd90283424f7d009b15175331e17d337ed","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def upgrade():"},{"line_number":33,"context_line":"    op.add_column(\u0027qos_bandwidth_limit_rules\u0027,"},{"line_number":34,"context_line":"                  sa.Column(\u0027tenant_id\u0027, sa.String(255),"},{"line_number":35,"context_line":"                            index\u003dTrue, nullable\u003dTrue))"},{"line_number":36,"context_line":"    op.add_column(\u0027qos_dscp_marking_rules\u0027,"},{"line_number":37,"context_line":"                  sa.Column(\u0027tenant_id\u0027, sa.String(255),"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_dd6e53c8","line":34,"range":{"start_line":34,"start_character":29,"end_line":34,"end_character":38},"in_reply_to":"3aaa91ec_7164dc48","updated":"2016-06-29 00:57:50.000000000","message":"Yes, all the fields will be renamed tenant -\u003e project. Would be good to have this done right now, but we\u0027re missing initial pieces to handle old/new table names.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"939be17c197c92c9dc7ee3ad29085144ff53345c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                        sa.MetaData(), autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":44,"context_line":"    qos_dm_rule \u003d sa.Table(\u0027qos_dscp_marking_rules\u0027,"},{"line_number":45,"context_line":"                           sa.MetaData(), autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":46,"context_line":"    bind.execute("},{"line_number":47,"context_line":"        qos_bl_rule.update().where("},{"line_number":48,"context_line":"            qos_bl_rule.c.qos_policy_id \u003d\u003d qos_policy.c.id).values("},{"line_number":49,"context_line":"                tenant_id\u003dqos_policy.c.tenant_id))"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_315254de","line":46,"updated":"2016-06-28 08:24:25.000000000","message":"This is definitely not a job for expand migration branch since it may result in some resources created after the script is executed to miss the values.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"0de595dc8a71801f491a18564216577b3b9e3132","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                        sa.MetaData(), autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":44,"context_line":"    qos_dm_rule \u003d sa.Table(\u0027qos_dscp_marking_rules\u0027,"},{"line_number":45,"context_line":"                           sa.MetaData(), autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":46,"context_line":"    bind.execute("},{"line_number":47,"context_line":"        qos_bl_rule.update().where("},{"line_number":48,"context_line":"            qos_bl_rule.c.qos_policy_id \u003d\u003d qos_policy.c.id).values("},{"line_number":49,"context_line":"                tenant_id\u003dqos_policy.c.tenant_id))"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_7dec7f29","line":46,"in_reply_to":"3aaa91ec_315254de","updated":"2016-06-29 01:03:08.000000000","message":"Moved to contract","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7f064fa07a02c7ec1544d733f0c6ede0f7e4fe3f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                        sa.MetaData(), autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":44,"context_line":"    qos_dm_rule \u003d sa.Table(\u0027qos_dscp_marking_rules\u0027,"},{"line_number":45,"context_line":"                           sa.MetaData(), autoload\u003dTrue, autoload_with\u003dbind)"},{"line_number":46,"context_line":"    bind.execute("},{"line_number":47,"context_line":"        qos_bl_rule.update().where("},{"line_number":48,"context_line":"            qos_bl_rule.c.qos_policy_id \u003d\u003d qos_policy.c.id).values("},{"line_number":49,"context_line":"                tenant_id\u003dqos_policy.c.tenant_id))"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_e3356ddb","line":46,"in_reply_to":"3aaa91ec_315254de","updated":"2016-06-29 03:49:20.000000000","message":"Test neutron.tests.functional.db.test_migrations.TestModelsMigrationsMysql. test_branches Failed with \u0027AssertionError: Migration in contract branch contains create command\u0027 after move this to contract [1]\n\nhttp://logs.openstack.org/80/244680/32/check/gate-neutron-dsvm-functional/91aafa5/testr_results.html.gz","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"}],"neutron/db/qos/models.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"939be17c197c92c9dc7ee3ad29085144ff53345c","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class QosDscpMarkingRule(models_v2.HasId,"},{"line_number":84,"context_line":"                         model_base.BASEV2, model_base.HasTenant):"},{"line_number":85,"context_line":"    __tablename__ \u003d \u0027qos_dscp_marking_rules\u0027"},{"line_number":86,"context_line":"    qos_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":87,"context_line":"                              sa.ForeignKey(\u0027qos_policies.id\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_f1f56ccb","line":84,"range":{"start_line":84,"start_character":55,"end_line":84,"end_character":64},"updated":"2016-06-28 08:24:25.000000000","message":"We need to consult with keystone v3 folks on where we are on switching to project_id in database.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"686475bd90283424f7d009b15175331e17d337ed","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class QosDscpMarkingRule(models_v2.HasId,"},{"line_number":84,"context_line":"                         model_base.BASEV2, model_base.HasTenant):"},{"line_number":85,"context_line":"    __tablename__ \u003d \u0027qos_dscp_marking_rules\u0027"},{"line_number":86,"context_line":"    qos_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":87,"context_line":"                              sa.ForeignKey(\u0027qos_policies.id\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_a2188685","line":84,"range":{"start_line":84,"start_character":55,"end_line":84,"end_character":64},"in_reply_to":"3aaa91ec_f1f56ccb","updated":"2016-06-29 00:57:50.000000000","message":"Unfortunately, we\u0027re not there yet. It will take week or two more to add support for project_id in DB.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"0de595dc8a71801f491a18564216577b3b9e3132","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class QosDscpMarkingRule(models_v2.HasId,"},{"line_number":84,"context_line":"                         model_base.BASEV2, model_base.HasTenant):"},{"line_number":85,"context_line":"    __tablename__ \u003d \u0027qos_dscp_marking_rules\u0027"},{"line_number":86,"context_line":"    qos_policy_id \u003d sa.Column(sa.String(36),"},{"line_number":87,"context_line":"                              sa.ForeignKey(\u0027qos_policies.id\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_fd350fdb","line":84,"range":{"start_line":84,"start_character":55,"end_line":84,"end_character":64},"in_reply_to":"3aaa91ec_f1f56ccb","updated":"2016-06-29 01:03:08.000000000","message":"ok","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5a214260ed6ec78c073e4dcab5a9c8f87b5ccb16","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                              unique\u003dTrue)"},{"line_number":78,"context_line":"    max_kbps \u003d sa.Column(sa.Integer)"},{"line_number":79,"context_line":"    max_burst_kbps \u003d sa.Column(sa.Integer)"},{"line_number":80,"context_line":"    project_id \u003d sa.Column(sa.String(attrs.TENANT_ID_MAX_LEN), index\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class QosDscpMarkingRule(models_v2.HasId, model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_69b797f5","line":80,"updated":"2016-06-29 09:05:04.000000000","message":"Maybe we should already introduce a HasProjectId mixin and consume it here.","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"49f1d5b786f75ac0cbd26288f910159dd2a45bda","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                              unique\u003dTrue)"},{"line_number":78,"context_line":"    max_kbps \u003d sa.Column(sa.Integer)"},{"line_number":79,"context_line":"    max_burst_kbps \u003d sa.Column(sa.Integer)"},{"line_number":80,"context_line":"    project_id \u003d sa.Column(sa.String(attrs.TENANT_ID_MAX_LEN), index\u003dTrue)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class QosDscpMarkingRule(models_v2.HasId, model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_f1b35a4b","line":80,"in_reply_to":"3aaa91ec_69b797f5","updated":"2016-06-29 13:59:16.000000000","message":"Looks good, will add that.","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"}],"neutron/objects/qos/rule.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"e800f99ebd09c852e9e466d8ca12378f39b5eff3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    fields_no_update \u003d [\u0027id\u0027, \u0027tenant_id\u0027, \u0027qos_policy_id\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    # should be redefined in subclasses"},{"line_number":55,"context_line":"    rule_type \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_5db3470a","line":52,"range":{"start_line":52,"start_character":22,"end_line":52,"end_character":23},"updated":"2015-12-21 10:15:18.000000000","message":"I am not sure this patch is complete.\nDon\u0027t we need also to ensure, upon rule creation,  that the rule\u0027s tenant_id is set to the policy\u0027s one.\n\nI cannot find this logic in this patch","commit_id":"b31a3e9eff50f858a229f307e240aac77a1e7271"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"f4c30bef28933de9ad818b27e40143ef1b99dd4f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":50,"context_line":"    }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    fields_no_update \u003d [\u0027id\u0027, \u0027tenant_id\u0027, \u0027qos_policy_id\u0027]"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    # should be redefined in subclasses"},{"line_number":55,"context_line":"    rule_type \u003d None"}],"source_content_type":"text/x-python","patch_set":8,"id":"3a7e1126_02a7770b","line":52,"range":{"start_line":52,"start_character":22,"end_line":52,"end_character":23},"in_reply_to":"3a7e1126_5db3470a","updated":"2015-12-22 02:19:42.000000000","message":"Done","commit_id":"b31a3e9eff50f858a229f307e240aac77a1e7271"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"456715036708b862dcd938746442c020196d0b5a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":80,"context_line":"class QosBandwidthLimitRule(QosRule):"},{"line_number":81,"context_line":"    # Version 1.0: Initial version"},{"line_number":82,"context_line":"    # Version 2.0: Added tenant_id to Rule"},{"line_number":83,"context_line":"    VERSION \u003d \u00272.0\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    db_model \u003d qos_db_model.QosBandwidthLimitRule"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_0a819c4a","line":82,"updated":"2016-01-12 12:03:21.000000000","message":"Just a curiosity. Is this change the kind of change that requires a bump in the major version of an object?","commit_id":"873b87c8d14ad8b581f7f800211bd689f2fa5000"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9f93eb413138ff0ceb05d41d1a2c4505ba09be07","unresolved":false,"context_lines":[{"line_number":79,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":80,"context_line":"class QosBandwidthLimitRule(QosRule):"},{"line_number":81,"context_line":"    # Version 1.0: Initial version"},{"line_number":82,"context_line":"    # Version 2.0: Added tenant_id to Rule"},{"line_number":83,"context_line":"    VERSION \u003d \u00272.0\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    db_model \u003d qos_db_model.QosBandwidthLimitRule"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_88527312","line":82,"in_reply_to":"da6ed579_0a819c4a","updated":"2016-01-12 12:44:24.000000000","message":"Nah nah nah nah. Don\u0027t bump the version to 2.0. Overall, you need to make it 1.1, *and* provide code to be able to backport it to 1.0.\n\nOverall, I don\u0027t see why you really need to add the field to the object. Don\u0027t you just fix the issue in API layer?","commit_id":"873b87c8d14ad8b581f7f800211bd689f2fa5000"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"24e1b533f4ccf9a9a501da9c63775568281ddc15","unresolved":false,"context_lines":[{"line_number":79,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":80,"context_line":"class QosBandwidthLimitRule(QosRule):"},{"line_number":81,"context_line":"    # Version 1.0: Initial version"},{"line_number":82,"context_line":"    # Version 2.0: Added tenant_id to Rule"},{"line_number":83,"context_line":"    VERSION \u003d \u00272.0\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    db_model \u003d qos_db_model.QosBandwidthLimitRule"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_a697448f","line":82,"in_reply_to":"da6ed579_88527312","updated":"2016-01-13 02:33:07.000000000","message":"Bumped to use 1.1, the current change didn\u0027t add complications in the API user workflow, it\u0027s a `harmless` change, i\u0027m not sure if it will affect anything in api if fixing this in API layer.","commit_id":"873b87c8d14ad8b581f7f800211bd689f2fa5000"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ff6494e838b39be7cedd0e5aa769610ff464fb71","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class QosBandwidthLimitRule(QosRule):"},{"line_number":81,"context_line":"    # Version 1.0: Initial version"},{"line_number":82,"context_line":"    # Version 1.1: Added tenant_id to Rule"},{"line_number":83,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    db_model \u003d qos_db_model.QosBandwidthLimitRule"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_3c1b521d","line":83,"updated":"2016-01-13 10:48:05.000000000","message":"why the bump? there is no change for the versioned object here at all.","commit_id":"1ea6624c69b9bc2e019c8c29a9027f76fa1792e5"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"cb8d74712f7e1d5ba6d17e15cceabe11c0d89914","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class QosBandwidthLimitRule(QosRule):"},{"line_number":81,"context_line":"    # Version 1.0: Initial version"},{"line_number":82,"context_line":"    # Version 1.1: Added tenant_id to Rule"},{"line_number":83,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    db_model \u003d qos_db_model.QosBandwidthLimitRule"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_af67b9e7","line":83,"in_reply_to":"da6ed579_3849d960","updated":"2016-01-14 12:41:39.000000000","message":"Do i need to change anything else ? Because the internal server error still exists as the bug reported if no change here. I don\u0027t have any clue:(. Thanks!","commit_id":"1ea6624c69b9bc2e019c8c29a9027f76fa1792e5"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"9daeec3353cacbe181d28843b31a9cdbfd9f109c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class QosBandwidthLimitRule(QosRule):"},{"line_number":81,"context_line":"    # Version 1.0: Initial version"},{"line_number":82,"context_line":"    # Version 1.1: Added tenant_id to Rule"},{"line_number":83,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    db_model \u003d qos_db_model.QosBandwidthLimitRule"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_c5bc6d08","line":83,"in_reply_to":"da6ed579_3c1b521d","updated":"2016-01-14 00:49:56.000000000","message":"test failed with error: \u0027Some objects have changed; please make sure the versions have been bumped, and then update their hashes in the object_data map in this test module.\u0027 if no version bump, and i thought i\u0027m following your suggestion to bump to 1.1 in ps11.","commit_id":"1ea6624c69b9bc2e019c8c29a9027f76fa1792e5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f849dc770453d3d13e27eb95f789052a4ee1c365","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class QosBandwidthLimitRule(QosRule):"},{"line_number":81,"context_line":"    # Version 1.0: Initial version"},{"line_number":82,"context_line":"    # Version 1.1: Added tenant_id to Rule"},{"line_number":83,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    db_model \u003d qos_db_model.QosBandwidthLimitRule"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_8f28b5e3","line":83,"in_reply_to":"da6ed579_af67b9e7","updated":"2016-01-14 12:51:15.000000000","message":"I don\u0027t think the object API change is needed. You merely need to copy tenant_id from policy to rule, but don\u0027t expose it in fields.","commit_id":"1ea6624c69b9bc2e019c8c29a9027f76fa1792e5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"df12fa2eceb93c71a24d728bcedefb7c60e79aab","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class QosBandwidthLimitRule(QosRule):"},{"line_number":81,"context_line":"    # Version 1.0: Initial version"},{"line_number":82,"context_line":"    # Version 1.1: Added tenant_id to Rule"},{"line_number":83,"context_line":"    VERSION \u003d \u00271.1\u0027"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    db_model \u003d qos_db_model.QosBandwidthLimitRule"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"da6ed579_3849d960","line":83,"in_reply_to":"da6ed579_c5bc6d08","updated":"2016-01-14 11:16:06.000000000","message":"Yeah, but I also suggested that you don\u0027t actually need to change anything in the file. In that case, your object API does not change, and hence version bump is not needed.","commit_id":"1ea6624c69b9bc2e019c8c29a9027f76fa1792e5"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4a36dde49349e782b541d5efad4c41e048974bff","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    #NOTE(mangelajo): versions need to be handled from the top QosRule object"},{"line_number":53,"context_line":"    #                 because it\u0027s the only reference QosPolicy can make"},{"line_number":54,"context_line":"    #                 to them via obj_relationships version map"},{"line_number":55,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_e950a7d6","line":55,"updated":"2016-06-29 08:59:26.000000000","message":"BTW we probably must bump the version for policy object too since it contains the rules in its \u0027rules\u0027 field.\n\nAlso, there should be a backporting rule to convert from 1.2 to 1.1.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"686475bd90283424f7d009b15175331e17d337ed","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_e2128e61","line":59,"range":{"start_line":59,"start_character":32,"end_line":59,"end_character":41},"updated":"2016-06-29 00:57:50.000000000","message":"New field should be StringField, see: I93488701c824a51b5588093b9aba499068ba36e8\n\nIn general, I know a little about OVO, so I\u0027m leaving this part in your hands.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"939be17c197c92c9dc7ee3ad29085144ff53345c","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_f11c4c15","line":59,"updated":"2016-06-28 08:24:25.000000000","message":"This definitely should be project_id. We may want to also add tenant_id in to_dict() for compatibility (though I am not sure we need compatibility for the new field).","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"686475bd90283424f7d009b15175331e17d337ed","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_fd3cefc0","line":59,"in_reply_to":"3aaa91ec_77ba0cc2","updated":"2016-06-29 00:57:50.000000000","message":"API layer still expects tenant_id: http://developer.openstack.org/api-ref-networking-v2-ext.html\nNothing was done in this area.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"18e82da4600ca2dd48c164cfc43d613c367f7247","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_77ba0cc2","line":59,"in_reply_to":"3aaa91ec_9c2a3fe6","updated":"2016-06-28 09:03:17.000000000","message":"IIUC your patch allows to access tenant_id on the object, but won\u0027t result in tenant_id to be present in .to_dict() result. It seems that that\u0027s the end goal of the patch, though maybe API layer is already ready to receive project_id to detetmine ownership, and we are fine with project_id.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"430f108b4bc79ca6ad603d1875d00dc8fd379bf5","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_9c2a3fe6","line":59,"in_reply_to":"3aaa91ec_dc6de7cd","updated":"2016-06-28 08:48:23.000000000","message":"Ihar, Miguel, we can add tenant_id and project_id in the same time, like I did in subnet patch [1].\n\n[1] https://review.openstack.org/#/c/331009/5/neutron/objects/subnet.py@172","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"686475bd90283424f7d009b15175331e17d337ed","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_7d50ff0a","line":59,"in_reply_to":"3aaa91ec_dc6de7cd","updated":"2016-06-29 00:57:50.000000000","message":"tenant -\u003e project changes for db will be addressed in next month (or earlier). So indeed, if this will be merged before this date, it will be another brick to process. But for now on, without at least initial framework to support project_id \u003d\u003d tenant_id, we have two possible solutions:\n1. postpone this change till db migration will be addressed\n2. merge this change, and fix it in next few weeks.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"0de595dc8a71801f491a18564216577b3b9e3132","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_1d429b3e","line":59,"in_reply_to":"3aaa91ec_f11c4c15","updated":"2016-06-29 01:03:08.000000000","message":"Okay, changed to project_id","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"41f75d72c8869f0662a2a187406b84cc750a52fa","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_f1ac4c37","line":59,"in_reply_to":"3aaa91ec_f11c4c15","updated":"2016-06-28 08:33:49.000000000","message":"The main purpose of this patch I think it\u0027s making the tenant_id available to the policy engine, if the policy engine can handle both project_id or tenant_id, we shall be good with just project_id.\n\nOtherwise we may want to add the compat layer you\u0027re proposing. TODO:check that policy engine works with project_id.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"867637e0cf384c6688933f21c70b275817683587","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_dc6de7cd","line":59,"in_reply_to":"3aaa91ec_f1ac4c37","updated":"2016-06-28 08:38:54.000000000","message":"Right, we definitely need to sync with keystonev3 folks.\n\nI just want to avoid a situation where we need to introduce another version of the object in a month to rename the field.","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"686475bd90283424f7d009b15175331e17d337ed","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027tenant_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"3aaa91ec_9de96b1d","line":59,"in_reply_to":"3aaa91ec_f1ac4c37","updated":"2016-06-29 00:57:50.000000000","message":"policy engine, AFAIU, completely ignores if it\u0027s tenant or project [1]. All the rules are read from policy.json [2] where we can have both tenant and project.\n\n[1] https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L61\n[2] https://github.com/openstack/neutron/blob/master/etc/policy.json","commit_id":"6f183979c1d6e8b199706f7d09005482caec4645"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5a214260ed6ec78c073e4dcab5a9c8f87b5ccb16","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    #NOTE(mangelajo): versions need to be handled from the top QosRule object"},{"line_number":53,"context_line":"    #                 because it\u0027s the only reference QosPolicy can make"},{"line_number":54,"context_line":"    #                 to them via obj_relationships version map"},{"line_number":55,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_c995eb40","line":55,"updated":"2016-06-29 09:05:04.000000000","message":"No conversion to 1.1 implemented. Policy version should be bumped due to rules included into \u0027rules\u0027 field. And since we bump policy version anyhow, can we also rename its tenant_id field too?","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"c4e9e10f7472ede617bfc2be6d9de3a92d767106","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    #NOTE(mangelajo): versions need to be handled from the top QosRule object"},{"line_number":53,"context_line":"    #                 because it\u0027s the only reference QosPolicy can make"},{"line_number":54,"context_line":"    #                 to them via obj_relationships version map"},{"line_number":55,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_d200b604","line":55,"in_reply_to":"3aaa91ec_c995eb40","updated":"2016-06-30 08:28:53.000000000","message":"Can i do this in a separate patch, Darek is renaming tenant_id to project_id in this patch I87a8ef342ccea004731ba0192b23a8e79bc382dc. I\u0027d like to get this patch merge first, there are already 37 patch sets, i\u0027m getting tired :((","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bf6cd0d7fb4911f6859603d67cb05c7be2a33c8c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    #NOTE(mangelajo): versions need to be handled from the top QosRule object"},{"line_number":53,"context_line":"    #                 because it\u0027s the only reference QosPolicy can make"},{"line_number":54,"context_line":"    #                 to them via obj_relationships version map"},{"line_number":55,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_c770f242","line":55,"in_reply_to":"3aaa91ec_d200b604","updated":"2016-06-30 10:33:58.000000000","message":"This can\u0027t be postponed because you would break rolling upgrades without it. An easier way would be going with one of previous approaches, adding the field just before passing the dict to the API layer, that would fix the bug, and then follow up with object modification.","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"312b4fdb0c1d4f7df9f2ecbb58a3e27e9e274b52","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027project_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_1a4f37be","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":42},"updated":"2016-06-29 07:24:15.000000000","message":"Should be string field due to I93488701c824a51b5588093b9aba499068ba36e8","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"51d74695f368dc60cd80cf0e74cf31a4e73f10dc","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027project_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_a0e7d4e2","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":42},"in_reply_to":"3aaa91ec_1a4f37be","updated":"2016-06-29 08:44:20.000000000","message":"Done","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7c58ac8a089225ea3dce50ce5fd03d3b37a1d8ee","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027project_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_f1a4fa4b","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":42},"in_reply_to":"3aaa91ec_9106561a","updated":"2016-06-29 14:08:45.000000000","message":"I don\u0027t think we need to add a field. to_dict() is enough. there will be no tenant_id on rpc callbacks wire, and that\u0027s fine.","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5a214260ed6ec78c073e4dcab5a9c8f87b5ccb16","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027project_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_c97ccb22","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":42},"in_reply_to":"3aaa91ec_a0e7d4e2","updated":"2016-06-29 09:05:04.000000000","message":"We also need code to produce tenant_id to API.","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"49f1d5b786f75ac0cbd26288f910159dd2a45bda","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    fields \u003d {"},{"line_number":58,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":59,"context_line":"        \u0027project_id\u0027: obj_fields.UUIDField(),"},{"line_number":60,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField()"},{"line_number":61,"context_line":"    }"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":34,"id":"3aaa91ec_9106561a","line":59,"range":{"start_line":59,"start_character":33,"end_line":59,"end_character":42},"in_reply_to":"3aaa91ec_c97ccb22","updated":"2016-06-29 13:59:16.000000000","message":"Do i need to add tenant_id to fields ? I already added tenant_id to to_dict method in the latest patch and seems i can get the tenant_id from API correctly.","commit_id":"49b30455cc92448e4e9692f75bc1c18db6f64768"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"456715036708b862dcd938746442c020196d0b5a","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            # first, validate that we have access to the policy"},{"line_number":91,"context_line":"            policy \u003d self._get_policy_obj(context, policy_id)"},{"line_number":92,"context_line":"            # Ensure rule tenant_id is set to the policy\u0027s one."},{"line_number":93,"context_line":"            bandwidth_limit_rule[\u0027bandwidth_limit_rule\u0027][\u0027tenant_id\u0027] \u003d \\"},{"line_number":94,"context_line":"                policy.tenant_id"},{"line_number":95,"context_line":"            rule \u003d rule_object.QosBandwidthLimitRule("},{"line_number":96,"context_line":"                context, qos_policy_id\u003dpolicy_id,"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_aaddf071","line":93,"updated":"2016-01-12 12:03:21.000000000","message":"awesome!","commit_id":"873b87c8d14ad8b581f7f800211bd689f2fa5000"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5ba4d0b0ab11de4b8d4c537df690db810a830fb8","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            rule.create()"},{"line_number":96,"context_line":"            policy.reload_rules()"},{"line_number":97,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":98,"context_line":"        return rule"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":101,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id, policy_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_a34fcb69","line":98,"updated":"2016-02-29 13:37:32.000000000","message":"Shouldn\u0027t the result here also include tenant_id?","commit_id":"1c78b43fbe75abfad1a838095a84447af887bdf2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2f460361e5d61ba45fabb5b00dfd057b256ce947","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            rule.create()"},{"line_number":96,"context_line":"            policy.reload_rules()"},{"line_number":97,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":98,"context_line":"        return rule"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":101,"context_line":"    def update_policy_bandwidth_limit_rule(self, context, rule_id, policy_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_d03f0ab2","line":98,"in_reply_to":"9aed3d3a_a34fcb69","updated":"2016-03-01 03:45:13.000000000","message":"Done","commit_id":"1c78b43fbe75abfad1a838095a84447af887bdf2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5ba4d0b0ab11de4b8d4c537df690db810a830fb8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            rule.update()"},{"line_number":113,"context_line":"            policy.reload_rules()"},{"line_number":114,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":115,"context_line":"        return rule"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def delete_policy_bandwidth_limit_rule(self, context, rule_id, policy_id):"},{"line_number":118,"context_line":"        # make sure we will have a policy object to push resource update"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_633303f7","line":115,"updated":"2016-02-29 13:37:32.000000000","message":"Shouldn\u0027t the result here also include tenant_id?","commit_id":"1c78b43fbe75abfad1a838095a84447af887bdf2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2f460361e5d61ba45fabb5b00dfd057b256ce947","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            rule.update()"},{"line_number":113,"context_line":"            policy.reload_rules()"},{"line_number":114,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":115,"context_line":"        return rule"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def delete_policy_bandwidth_limit_rule(self, context, rule_id, policy_id):"},{"line_number":118,"context_line":"        # make sure we will have a policy object to push resource update"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_70d39e60","line":115,"in_reply_to":"9aed3d3a_633303f7","updated":"2016-03-01 03:45:13.000000000","message":"Done","commit_id":"1c78b43fbe75abfad1a838095a84447af887bdf2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"7791fd35be0279692cd0eddd5bb6b9c78aa2492e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            rule \u003d self._get_policy_bandwidth_limit_rule("},{"line_number":144,"context_line":"                context, rule_id, policy_id, fields\u003dfields)"},{"line_number":145,"context_line":"            # Ensure rule\u0027s tenant_id is set to policy.tenant_id"},{"line_number":146,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"},{"line_number":147,"context_line":"        return rule"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @db_base_plugin_common.filter_fields"}],"source_content_type":"text/x-python","patch_set":14,"id":"dae33548_470d743d","line":146,"updated":"2016-02-16 10:25:28.000000000","message":"What if the tenant\u0027s id is different? Should we silently ignore?","commit_id":"1c78b43fbe75abfad1a838095a84447af887bdf2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2f460361e5d61ba45fabb5b00dfd057b256ce947","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            rule \u003d self._get_policy_bandwidth_limit_rule("},{"line_number":144,"context_line":"                context, rule_id, policy_id, fields\u003dfields)"},{"line_number":145,"context_line":"            # Ensure rule\u0027s tenant_id is set to policy.tenant_id"},{"line_number":146,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"},{"line_number":147,"context_line":"        return rule"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @db_base_plugin_common.filter_fields"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_7b025f0b","line":146,"in_reply_to":"dae33548_470d743d","updated":"2016-03-01 03:45:13.000000000","message":"i think the tenant_id for rule should always be the policy one here.","commit_id":"1c78b43fbe75abfad1a838095a84447af887bdf2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5ba4d0b0ab11de4b8d4c537df690db810a830fb8","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            filters \u003d filters or dict()"},{"line_number":160,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":161,"context_line":"            return rule_object.QosBandwidthLimitRule.get_objects(context,"},{"line_number":162,"context_line":"                                                                 **filters)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # TODO(QoS): enforce rule types when accessing rule objects"},{"line_number":165,"context_line":"    @db_base_plugin_common.filter_fields"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_6005b912","line":162,"updated":"2016-02-29 13:37:32.000000000","message":"Should we apply the same here?","commit_id":"1c78b43fbe75abfad1a838095a84447af887bdf2"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"2f460361e5d61ba45fabb5b00dfd057b256ce947","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            filters \u003d filters or dict()"},{"line_number":160,"context_line":"            filters[qos_consts.QOS_POLICY_ID] \u003d policy_id"},{"line_number":161,"context_line":"            return rule_object.QosBandwidthLimitRule.get_objects(context,"},{"line_number":162,"context_line":"                                                                 **filters)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    # TODO(QoS): enforce rule types when accessing rule objects"},{"line_number":165,"context_line":"    @db_base_plugin_common.filter_fields"}],"source_content_type":"text/x-python","patch_set":14,"id":"9aed3d3a_f0284e9c","line":162,"in_reply_to":"9aed3d3a_6005b912","updated":"2016-03-01 03:45:13.000000000","message":"Done","commit_id":"1c78b43fbe75abfad1a838095a84447af887bdf2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"96bb48e68fbff28b98657ed029612c96e4251937","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            rule \u003d self._create_policy_bandwidth_limit_rule("},{"line_number":104,"context_line":"                context, policy_id, bandwidth_limit_rule)"},{"line_number":105,"context_line":"            policy.reload_rules()"},{"line_number":106,"context_line":"            rule[\u0027tenan_id\u0027] \u003d policy.tenant_id"},{"line_number":107,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":108,"context_line":"        return rule"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1af94dfe_9275aefb","line":106,"updated":"2016-03-17 20:29:54.000000000","message":"think you have a typo here... shouldn\u0027t it be \u0027tenant_id\u0027 ??","commit_id":"17498090f9fa017f90208bb1a94a796b1bb3c5b8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"def76efb5fc265e43a5fd5a91930c6f6a8e1856c","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            rule \u003d self._create_policy_bandwidth_limit_rule("},{"line_number":104,"context_line":"                context, policy_id, bandwidth_limit_rule)"},{"line_number":105,"context_line":"            policy.reload_rules()"},{"line_number":106,"context_line":"            rule[\u0027tenan_id\u0027] \u003d policy.tenant_id"},{"line_number":107,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":108,"context_line":"        return rule"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"fa0719c6_e47323b3","line":106,"in_reply_to":"1af94dfe_9275aefb","updated":"2016-03-21 01:30:38.000000000","message":"oops, thanks!","commit_id":"17498090f9fa017f90208bb1a94a796b1bb3c5b8"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cdbf53ad68c9cc1c8bfd285a46106337adfb4ed9","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            rule \u003d self._update_policy_rule("},{"line_number":212,"context_line":"                context, rule_obj, rule_id, rule_data)"},{"line_number":213,"context_line":"            policy.reload_rules()"},{"line_number":214,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"},{"line_number":215,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":216,"context_line":"        return rule"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9abb7d3a_3fb59830","line":214,"updated":"2016-05-31 16:32:49.000000000","message":"I don\u0027t see a UT for update validating the tenant_id. Should we have a test for this?","commit_id":"f0c9c752ded74618f75d9a8efa095097ed084af3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ae09ca3bca88665712723a8d2bd0f3fa7f5b1454","unresolved":false,"context_lines":[{"line_number":211,"context_line":"            rule \u003d self._update_policy_rule("},{"line_number":212,"context_line":"                context, rule_obj, rule_id, rule_data)"},{"line_number":213,"context_line":"            policy.reload_rules()"},{"line_number":214,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"},{"line_number":215,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":216,"context_line":"        return rule"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9abb7d3a_1a9e8b06","line":214,"in_reply_to":"9abb7d3a_3fb59830","updated":"2016-06-02 03:14:15.000000000","message":"Done","commit_id":"f0c9c752ded74618f75d9a8efa095097ed084af3"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"97af0110306cbb54d824e2549dab12bbf8840d44","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def _create_policy_rule(self, context, rule_obj, policy_id, rule_data):"},{"line_number":148,"context_line":"        rule \u003d rule_obj(context, qos_policy_id\u003dpolicy_id, **rule_data)"},{"line_number":149,"context_line":"        rule.create()"},{"line_number":150,"context_line":"        return rule"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def create_policy_rule(self, context, rule_obj, policy_id, rule_data):"},{"line_number":153,"context_line":"        \"\"\"Create a QoS policy rule."}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_4158defa","line":150,"updated":"2016-06-03 07:56:19.000000000","message":"Suggestion:\n\nHmm, Wouldn\u0027t it be cleaner if we provide a \n\nto_dict_with_tenant around here here: \nhttps://github.com/openstack/neutron/blob/master/neutron/objects/qos/rule.py#L66\n\nAnd that way, the only modification you need to do is: \n\n1) remove the \"convert_result_to_dict\" decorator\n2) change \"return rule\" to \"return rule.to_dict_with_tenant(tenant_id \u003d policy.tenant_id)","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b13784356a6f298b2c20fa1e0279f774a0c52b24","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def _create_policy_rule(self, context, rule_obj, policy_id, rule_data):"},{"line_number":148,"context_line":"        rule \u003d rule_obj(context, qos_policy_id\u003dpolicy_id, **rule_data)"},{"line_number":149,"context_line":"        rule.create()"},{"line_number":150,"context_line":"        return rule"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def create_policy_rule(self, context, rule_obj, policy_id, rule_data):"},{"line_number":153,"context_line":"        \"\"\"Create a QoS policy rule."}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_e6d2c35a","line":150,"in_reply_to":"9abb7d3a_4158defa","updated":"2016-06-03 09:05:39.000000000","message":"Ehm... Having such a very special case method in the object definition is not ideal. I prefer we keep this special logic out of object.","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"57b02b449b4edcb45e816a596e5be659d2a4e408","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    def _create_policy_rule(self, context, rule_obj, policy_id, rule_data):"},{"line_number":148,"context_line":"        rule \u003d rule_obj(context, qos_policy_id\u003dpolicy_id, **rule_data)"},{"line_number":149,"context_line":"        rule.create()"},{"line_number":150,"context_line":"        return rule"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def create_policy_rule(self, context, rule_obj, policy_id, rule_data):"},{"line_number":153,"context_line":"        \"\"\"Create a QoS policy rule."}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_e933b411","line":150,"in_reply_to":"9abb7d3a_e6d2c35a","updated":"2016-06-03 09:33:52.000000000","message":"So, i agree with Ihar here.","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"97af0110306cbb54d824e2549dab12bbf8840d44","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":170,"context_line":"            # Ensure that we have access to the policy."},{"line_number":171,"context_line":"            policy \u003d self._get_policy_obj(context, policy_id)"},{"line_number":172,"context_line":"            rule \u003d self._create_policy_rule("},{"line_number":173,"context_line":"                context, rule_obj, policy_id, rule_data)"},{"line_number":174,"context_line":"            policy.reload_rules()"},{"line_number":175,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_16d45abb","line":172,"updated":"2016-06-03 07:56:19.000000000","message":"supernit: can we make it clear this is now a dict by naming it rule_dict ?","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"57b02b449b4edcb45e816a596e5be659d2a4e408","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":170,"context_line":"            # Ensure that we have access to the policy."},{"line_number":171,"context_line":"            policy \u003d self._get_policy_obj(context, policy_id)"},{"line_number":172,"context_line":"            rule \u003d self._create_policy_rule("},{"line_number":173,"context_line":"                context, rule_obj, policy_id, rule_data)"},{"line_number":174,"context_line":"            policy.reload_rules()"},{"line_number":175,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_89b0288d","line":172,"in_reply_to":"9abb7d3a_16d45abb","updated":"2016-06-03 09:33:52.000000000","message":"Done","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"97af0110306cbb54d824e2549dab12bbf8840d44","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            policy \u003d self._get_policy_obj(context, policy_id)"},{"line_number":209,"context_line":"            # Ensure the rule belongs to the policy."},{"line_number":210,"context_line":"            policy.get_rule_by_id(rule_id)"},{"line_number":211,"context_line":"            rule \u003d self._update_policy_rule("},{"line_number":212,"context_line":"                context, rule_obj, rule_id, rule_data)"},{"line_number":213,"context_line":"            policy.reload_rules()"},{"line_number":214,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_96e04a98","line":211,"updated":"2016-06-03 07:56:19.000000000","message":"ditto.","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"57b02b449b4edcb45e816a596e5be659d2a4e408","unresolved":false,"context_lines":[{"line_number":208,"context_line":"            policy \u003d self._get_policy_obj(context, policy_id)"},{"line_number":209,"context_line":"            # Ensure the rule belongs to the policy."},{"line_number":210,"context_line":"            policy.get_rule_by_id(rule_id)"},{"line_number":211,"context_line":"            rule \u003d self._update_policy_rule("},{"line_number":212,"context_line":"                context, rule_obj, rule_id, rule_data)"},{"line_number":213,"context_line":"            policy.reload_rules()"},{"line_number":214,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_c99350f9","line":211,"in_reply_to":"9abb7d3a_96e04a98","updated":"2016-06-03 09:33:52.000000000","message":"Done","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"97af0110306cbb54d824e2549dab12bbf8840d44","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            policy.reload_rules()"},{"line_number":238,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":241,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":242,"context_line":"    def _get_policy_rule(self, context, rule_obj, rule_id, policy_id):"},{"line_number":243,"context_line":"        rule \u003d rule_obj.get_object(context, id\u003drule_id)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_169c5a5c","line":240,"updated":"2016-06-03 07:56:19.000000000","message":"This decorator belongs on get_policy_rule, this function accept no fields to filter while get_policy_rule does.\n\nCan we keep all the db_base_plugin.finter_fields decorators on top of the public functions?","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"57b02b449b4edcb45e816a596e5be659d2a4e408","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            policy.reload_rules()"},{"line_number":238,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    @db_base_plugin_common.filter_fields"},{"line_number":241,"context_line":"    @db_base_plugin_common.convert_result_to_dict"},{"line_number":242,"context_line":"    def _get_policy_rule(self, context, rule_obj, rule_id, policy_id):"},{"line_number":243,"context_line":"        rule \u003d rule_obj.get_object(context, id\u003drule_id)"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_49e8007d","line":240,"in_reply_to":"9abb7d3a_169c5a5c","updated":"2016-06-03 09:33:52.000000000","message":"Done","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"97af0110306cbb54d824e2549dab12bbf8840d44","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":265,"context_line":"            # Ensure we have access to the policy."},{"line_number":266,"context_line":"            policy \u003d self._get_policy_obj(context, policy_id)"},{"line_number":267,"context_line":"            rule \u003d self._get_policy_rule(context, rule_obj, rule_id, policy_id)"},{"line_number":268,"context_line":"            # Ensure rule\u0027s tenant_id is set to policy.tenant_id"},{"line_number":269,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"},{"line_number":270,"context_line":"        return rule"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_d6f01269","line":267,"updated":"2016-06-03 07:56:19.000000000","message":"ditto.","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"57b02b449b4edcb45e816a596e5be659d2a4e408","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        with db_api.autonested_transaction(context.session):"},{"line_number":265,"context_line":"            # Ensure we have access to the policy."},{"line_number":266,"context_line":"            policy \u003d self._get_policy_obj(context, policy_id)"},{"line_number":267,"context_line":"            rule \u003d self._get_policy_rule(context, rule_obj, rule_id, policy_id)"},{"line_number":268,"context_line":"            # Ensure rule\u0027s tenant_id is set to policy.tenant_id"},{"line_number":269,"context_line":"            rule[\u0027tenant_id\u0027] \u003d policy.tenant_id"},{"line_number":270,"context_line":"        return rule"}],"source_content_type":"text/x-python","patch_set":23,"id":"9abb7d3a_0979d8fc","line":267,"in_reply_to":"9abb7d3a_d6f01269","updated":"2016-06-03 09:33:52.000000000","message":"Done","commit_id":"dd027ba15eb7c26e568c7aa23546d95dfa101a2d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"411bd7894ca92695dc1a2ca999b93056b536367a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        :param rule_data: the rule data to be applied"},{"line_number":162,"context_line":"        :type rule_data: dict"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        :returns: a QoS policy rule object"},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        rule_type \u003d rule_obj.rule_type"},{"line_number":167,"context_line":"        rule_data \u003d rule_data[rule_type + \u0027_rule\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"3aaa91ec_4a94d189","line":164,"updated":"2016-06-27 06:12:47.000000000","message":"this comment here is incorrect - you are returning a dictionary below","commit_id":"ded6598f47ea9075085fb8013da15ff3177a5781"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"4728f4391c2a528259e837f8655b38979066ee09","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        :param rule_data: the rule data to be applied"},{"line_number":162,"context_line":"        :type rule_data: dict"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        :returns: a QoS policy rule object"},{"line_number":165,"context_line":"        \"\"\""},{"line_number":166,"context_line":"        rule_type \u003d rule_obj.rule_type"},{"line_number":167,"context_line":"        rule_data \u003d rule_data[rule_type + \u0027_rule\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"3aaa91ec_ad2e2fa2","line":164,"in_reply_to":"3aaa91ec_4a94d189","updated":"2016-06-27 07:09:00.000000000","message":"Done","commit_id":"ded6598f47ea9075085fb8013da15ff3177a5781"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"411bd7894ca92695dc1a2ca999b93056b536367a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            rule_dict \u003d self._create_policy_rule("},{"line_number":173,"context_line":"                context, rule_obj, policy_id, rule_data)"},{"line_number":174,"context_line":"            policy.reload_rules()"},{"line_number":175,"context_line":"            rule_dict[\u0027tenant_id\u0027] \u003d policy.tenant_id"},{"line_number":176,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":177,"context_line":"        return rule_dict"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3aaa91ec_0a112904","line":175,"updated":"2016-06-27 06:12:47.000000000","message":"i think that this is dodgy and we should consider changing the rule object to have the tenant_id.","commit_id":"ded6598f47ea9075085fb8013da15ff3177a5781"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"4728f4391c2a528259e837f8655b38979066ee09","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            rule_dict \u003d self._create_policy_rule("},{"line_number":173,"context_line":"                context, rule_obj, policy_id, rule_data)"},{"line_number":174,"context_line":"            policy.reload_rules()"},{"line_number":175,"context_line":"            rule_dict[\u0027tenant_id\u0027] \u003d policy.tenant_id"},{"line_number":176,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":177,"context_line":"        return rule_dict"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3aaa91ec_4d234bbd","line":175,"in_reply_to":"3aaa91ec_0a112904","updated":"2016-06-27 07:09:00.000000000","message":"It was suggested by Ihar, the previous patchs were changing the rule object...\nI\u0027m confused now :((","commit_id":"ded6598f47ea9075085fb8013da15ff3177a5781"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7765ddd6130c70bdc03a278c0e8c8c49bed6e471","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            rule_dict \u003d self._create_policy_rule("},{"line_number":173,"context_line":"                context, rule_obj, policy_id, rule_data)"},{"line_number":174,"context_line":"            policy.reload_rules()"},{"line_number":175,"context_line":"            rule_dict[\u0027tenant_id\u0027] \u003d policy.tenant_id"},{"line_number":176,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":177,"context_line":"        return rule_dict"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3aaa91ec_d44cdb9f","line":175,"in_reply_to":"3aaa91ec_4d234bbd","updated":"2016-06-27 10:04:52.000000000","message":"Before Mitaka final, we did not have rolling upgrade mechanism for rpc callbacks. Now that we have it implemented, we can re-consider the idea of modifying the object fields again.\n\nIf we go with it, we should probably also add the attribute to models too.","commit_id":"ded6598f47ea9075085fb8013da15ff3177a5781"}],"neutron/tests/unit/api/v2/test_base.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"bc9cf41bfdb5382054eadcf859e3f48d4af29cba","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"        self._test_update(tenant_id + \"bad\", tenant_id,"},{"line_number":1101,"context_line":"                          exc.HTTPNotFound.code, expect_errors\u003dTrue)"},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"    def test_update_not_found(self):"},{"line_number":1104,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":1105,"context_line":"        rules \u003d oslo_policy.Rules.from_dict("},{"line_number":1106,"context_line":"            {\u0027update_netork\u0027: \"rule:admin_only\"})"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_422a3280","line":1103,"updated":"2015-11-13 03:07:50.000000000","message":"nit: If there is further patch, it would be better to change the method name to something like: \"test_update_without_tenant_id\"","commit_id":"ff36d18d1f399217795471bf5c1ba1a1e85b3884"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"aad6db36c0d445d90aac9291adc7d960ec169ab7","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"        self._test_update(tenant_id + \"bad\", tenant_id,"},{"line_number":1101,"context_line":"                          exc.HTTPNotFound.code, expect_errors\u003dTrue)"},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"    def test_update_not_found(self):"},{"line_number":1104,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":1105,"context_line":"        rules \u003d oslo_policy.Rules.from_dict("},{"line_number":1106,"context_line":"            {\u0027update_netork\u0027: \"rule:admin_only\"})"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_4599dc1e","line":1103,"in_reply_to":"da85f559_422a3280","updated":"2015-11-13 05:16:00.000000000","message":"I agree with Hong because below test_update_keystone_bad_tenant tests \"Not Found\" as well.","commit_id":"ff36d18d1f399217795471bf5c1ba1a1e85b3884"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"7c09e7991522c240977c31b1842a71d02d51ee23","unresolved":false,"context_lines":[{"line_number":1100,"context_line":"        self._test_update(tenant_id + \"bad\", tenant_id,"},{"line_number":1101,"context_line":"                          exc.HTTPNotFound.code, expect_errors\u003dTrue)"},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"    def test_update_not_found(self):"},{"line_number":1104,"context_line":"        tenant_id \u003d _uuid()"},{"line_number":1105,"context_line":"        rules \u003d oslo_policy.Rules.from_dict("},{"line_number":1106,"context_line":"            {\u0027update_netork\u0027: \"rule:admin_only\"})"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_4e4a5957","line":1103,"in_reply_to":"da85f559_4599dc1e","updated":"2015-11-13 05:56:29.000000000","message":"Done","commit_id":"ff36d18d1f399217795471bf5c1ba1a1e85b3884"}],"neutron/tests/unit/services/qos/test_qos_plugin.py":[{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cdbf53ad68c9cc1c8bfd285a46106337adfb4ed9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"9abb7d3a_9fd5a41d","updated":"2016-05-31 16:32:49.000000000","message":"From the bug description: \"There should be a meaningful error such as - Updating policy is not allowed\". However I don\u0027t see anything here validating an expected exception is raised in such a condition. Should we add such a test?","commit_id":"f0c9c752ded74618f75d9a8efa095097ed084af3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ae09ca3bca88665712723a8d2bd0f3fa7f5b1454","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"9abb7d3a_7aa4f749","in_reply_to":"9abb7d3a_9fd5a41d","updated":"2016-06-02 03:14:15.000000000","message":"Reasonable, i added this to tempest api test.","commit_id":"f0c9c752ded74618f75d9a8efa095097ed084af3"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"cdbf53ad68c9cc1c8bfd285a46106337adfb4ed9","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                self.ctxt, self.rule.id, self.policy.id)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @mock.patch(\u0027neutron.objects.qos.rule.QosBandwidthLimitRule.get_object\u0027)"},{"line_number":214,"context_line":"    def test_get_policy_bandwidth_limit_rule_for_policy(self, get_object_mock):"},{"line_number":215,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy.get_object\u0027,"},{"line_number":216,"context_line":"                        return_value\u003dself.policy):"},{"line_number":217,"context_line":"            get_object_mock.return_value \u003d self.rule"}],"source_content_type":"text/x-python","patch_set":21,"id":"9abb7d3a_1f3d34c4","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":55},"updated":"2016-05-31 16:32:49.000000000","message":"I\u0027m probably missing something obvious here, but I\u0027m not even seeing this test run as part of these gate python27 gate jobs.\n\n\nMoreover when I run with neutron master + this change cherry picked atop, it fails:\n\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFailed 1 tests - output below:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n\nneutron.tests.unit.services.qos.test_qos_plugin.TestQosPlugin.test_get_policy_bandwidth_limit_rule_for_policy\n-------------------------------------------------------------------------------------------------------------\n\nCaptured traceback:\n~~~~~~~~~~~~~~~~~~~\n    Traceback (most recent call last):\n      File \"/tmp/244680/.tox/py27/local/lib/python2.7/site-packages/mock/mock.py\", line 1305, in patched\n        return func(*args, **keywargs)\n      File \"neutron/tests/unit/services/qos/test_qos_plugin.py\", line 223, in test_get_policy_bandwidth_limit_rule_for_policy\n        self.assertEqual(expected, rule)\n      File \"/tmp/244680/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py\", line 411, in assertEqual\n        self.assertThat(observed, matcher, message)\n      File \"/tmp/244680/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py\", line 498, in assertThat\n        raise mismatch_error\n    testtools.matchers._impl.MismatchError: !\u003d:\n    reference \u003d {\u0027id\u0027: \u0027c1bc9c36-0e59-4f5d-b7dd-8d0778943a15\u0027,\n     \u0027tenant_id\u0027: \u002737d1968b-c939-4e04-8174-251ca4f516c9\u0027}\n    actual    \u003d {\u0027id\u0027: \u0027c1bc9c36-0e59-4f5d-b7dd-8d0778943a15\u0027,\n     \u0027max_burst_kbps\u0027: 150,\n     \u0027max_kbps\u0027: 100,\n     \u0027tenant_id\u0027: \u002737d1968b-c939-4e04-8174-251ca4f516c9\u0027,\n     \u0027type\u0027: \u0027bandwidth_limit\u0027}","commit_id":"f0c9c752ded74618f75d9a8efa095097ed084af3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ae09ca3bca88665712723a8d2bd0f3fa7f5b1454","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                self.ctxt, self.rule.id, self.policy.id)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    @mock.patch(\u0027neutron.objects.qos.rule.QosBandwidthLimitRule.get_object\u0027)"},{"line_number":214,"context_line":"    def test_get_policy_bandwidth_limit_rule_for_policy(self, get_object_mock):"},{"line_number":215,"context_line":"        with mock.patch(\u0027neutron.objects.qos.policy.QosPolicy.get_object\u0027,"},{"line_number":216,"context_line":"                        return_value\u003dself.policy):"},{"line_number":217,"context_line":"            get_object_mock.return_value \u003d self.rule"}],"source_content_type":"text/x-python","patch_set":21,"id":"9abb7d3a_7aa7d7a6","line":214,"range":{"start_line":214,"start_character":8,"end_line":214,"end_character":55},"in_reply_to":"9abb7d3a_1f3d34c4","updated":"2016-06-02 03:14:15.000000000","message":"Fixed","commit_id":"f0c9c752ded74618f75d9a8efa095097ed084af3"}]}
