)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"777526e0e19bbb6ae22e4a72cbc40fd782e11a42","unresolved":false,"context_lines":[{"line_number":13,"context_line":"this patch deletes the latter one, leaving only the exit code to be"},{"line_number":14,"context_line":"printed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I22289f838dbc3956a777a78c882e4d5f1e725d0e"},{"line_number":17,"context_line":"Chang-Id: I37e4064d308b220ca15eb23675c6ac0f609cc837"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_499277f7","line":16,"updated":"2015-11-12 15:35:19.000000000","message":"You have two change IDs here some how. And this will be my contribution to this patch for now :)","commit_id":"f605634cc8a29371822318c9d2ffd5409abc187f"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"a98c1123243a93bcf3427dbe02eb93a7c35f940f","unresolved":false,"context_lines":[{"line_number":13,"context_line":"this patch deletes the latter one, leaving only the exit code to be"},{"line_number":14,"context_line":"printed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I22289f838dbc3956a777a78c882e4d5f1e725d0e"},{"line_number":17,"context_line":"Chang-Id: I37e4064d308b220ca15eb23675c6ac0f609cc837"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_6952db36","line":16,"in_reply_to":"da85f559_499277f7","updated":"2015-11-17 10:15:53.000000000","message":"GAH!","commit_id":"f605634cc8a29371822318c9d2ffd5409abc187f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffad2c696c6e6dede5d847ca8a2bb7f2262672a4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"this patch deletes the latter one, leaving only the exit code to be"},{"line_number":14,"context_line":"printed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch also refactors the surrounding code to make it more readable."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I22289f838dbc3956a777a78c882e4d5f1e725d0e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba8a016a_5d35ffd7","line":16,"updated":"2015-11-17 12:00:07.000000000","message":"It looks like you are dropping the log of the actual command invoked. Is that intentional","commit_id":"2abe51c76db5c68deacd1d4efe2d6369da1a100e"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"864135ca395dd7245f19166253779bf96173f85a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"this patch deletes the latter one, leaving only the exit code to be"},{"line_number":14,"context_line":"printed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch also refactors the surrounding code to make it more readable."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I22289f838dbc3956a777a78c882e4d5f1e725d0e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba8a016a_6f35aad8","line":16,"in_reply_to":"ba8a016a_5d35ffd7","updated":"2015-11-17 12:20:44.000000000","message":"Yes, since the command is logged anyway by the respective create_process()/execute_rootwrap_daemon() function which is launched just a few lines before.","commit_id":"2abe51c76db5c68deacd1d4efe2d6369da1a100e"}],"neutron/agent/linux/utils.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"191a0967272b190158ae0be23df82895dc145001","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                            \u0027stderr\u0027: _stderr}"},{"line_number":142,"context_line":"            LOG.error(log_msg)"},{"line_number":143,"context_line":"        else:"},{"line_number":144,"context_line":"            log_msg \u003d _(\"Exit code: %d\") % orig_returncode"},{"line_number":145,"context_line":"            LOG.debug(log_msg)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if returncode and check_exit_code:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_eceb3411","line":144,"updated":"2015-11-12 16:45:39.000000000","message":"_() is not needed","commit_id":"2ab840d88a625ad7f6c328bc35a20f9450c93599"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"ee92bd595ebb019904d2005f756a371ad9344843","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                            \u0027stderr\u0027: _stderr}"},{"line_number":142,"context_line":"            LOG.error(log_msg)"},{"line_number":143,"context_line":"        else:"},{"line_number":144,"context_line":"            log_msg \u003d _(\"Exit code: %d\") % orig_returncode"},{"line_number":145,"context_line":"            LOG.debug(log_msg)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if returncode and check_exit_code:"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_ec06d484","line":144,"in_reply_to":"da85f559_eceb3411","updated":"2015-11-12 16:51:48.000000000","message":"Done","commit_id":"2ab840d88a625ad7f6c328bc35a20f9450c93599"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"498ba3b9cd45c408623948a47c9be71178ce08fb","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if isinstance(_stderr, bytes):"},{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and log_fail_as_error:"},{"line_number":129,"context_line":"            log_msg \u003d _LE(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                          \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                          \"Stdout: %(stdout)s; \""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_0553eb17","line":128,"updated":"2015-11-12 17:30:46.000000000","message":"I might be wrong but I think it should be:\n\nextra_ok_codes \u003d extra_ok_codes or []\nif returncode and returncode in extra_ok_codes:\n    returncode \u003d None\n\nif returncode:\n    if log_fail_as_error:\n        [...]\n    elif check_exit_code:\n        [...]\nelse:\n    [...]\n\nlog_fail_as_error and check_exit_code are mutually exclusive I guess","commit_id":"c6ed3cdde40f0388565298f0b50545173ee904d1"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"1ed1a355c9d34f88fcfe3e35e0ac9d13d1499b7a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if isinstance(_stderr, bytes):"},{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and log_fail_as_error:"},{"line_number":129,"context_line":"            log_msg \u003d _LE(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                          \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                          \"Stdout: %(stdout)s; \""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_c5e883b5","line":128,"in_reply_to":"da85f559_0553eb17","updated":"2015-11-12 17:41:46.000000000","message":"log_fail_as_error and check_exit_code can both be True. This will lead to both LOG.error(m) and RuntimeError(m).\n\nI will refactor the code as you said.","commit_id":"c6ed3cdde40f0388565298f0b50545173ee904d1"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"beb0a59ea6c7bba06fb0fc33321bee5f7812f0fb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                              \u0027returncode\u0027: returncode,"},{"line_number":134,"context_line":"                              \u0027stdin\u0027: process_input or \u0027\u0027,"},{"line_number":135,"context_line":"                              \u0027stdout\u0027: _stdout,"},{"line_number":136,"context_line":"                              \u0027stderr\u0027: _stderr}"},{"line_number":137,"context_line":"            LOG.error(log_msg)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            log_msg \u003d \"Exit code: %d\" % returncode"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_c2839901","line":136,"updated":"2015-11-12 17:23:22.000000000","message":"There was previously a general conversion from \u0027\\n\u0027 to \u0027; \u0027, which I assume would have applied to any newlines within the stdout and stderr, as well as to those between the Stdin, Stdout and Stderr traces.  Has your change lost this by mistake?","commit_id":"c6ed3cdde40f0388565298f0b50545173ee904d1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fff606a89b6105d76e067ccc40d89c305ceb63b7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                              \u0027returncode\u0027: returncode,"},{"line_number":134,"context_line":"                              \u0027stdin\u0027: process_input or \u0027\u0027,"},{"line_number":135,"context_line":"                              \u0027stdout\u0027: _stdout,"},{"line_number":136,"context_line":"                              \u0027stderr\u0027: _stderr}"},{"line_number":137,"context_line":"            LOG.error(log_msg)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            log_msg \u003d \"Exit code: %d\" % returncode"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_73037c77","line":136,"in_reply_to":"da85f559_05d68b4e","updated":"2015-11-13 11:52:54.000000000","message":"same comment as below","commit_id":"c6ed3cdde40f0388565298f0b50545173ee904d1"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"1ed1a355c9d34f88fcfe3e35e0ac9d13d1499b7a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                              \u0027returncode\u0027: returncode,"},{"line_number":134,"context_line":"                              \u0027stdin\u0027: process_input or \u0027\u0027,"},{"line_number":135,"context_line":"                              \u0027stdout\u0027: _stdout,"},{"line_number":136,"context_line":"                              \u0027stderr\u0027: _stderr}"},{"line_number":137,"context_line":"            LOG.error(log_msg)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            log_msg \u003d \"Exit code: %d\" % returncode"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_05d68b4e","line":136,"in_reply_to":"da85f559_c2839901","updated":"2015-11-12 17:41:46.000000000","message":"Ahh, that explains it...\nI\u0027ll restore it.","commit_id":"c6ed3cdde40f0388565298f0b50545173ee904d1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fff606a89b6105d76e067ccc40d89c305ceb63b7","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                              \u0027stderr\u0027: _stderr}"},{"line_number":137,"context_line":"            LOG.error(log_msg)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            log_msg \u003d \"Exit code: %d\" % returncode"},{"line_number":140,"context_line":"            LOG.debug(log_msg)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        if returncode:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_53ebd8b0","line":139,"updated":"2015-11-13 11:52:54.000000000","message":"why do we need the variable here. Just do:\nLOG.debug(\"Exit ....\", returncode)","commit_id":"c6ed3cdde40f0388565298f0b50545173ee904d1"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"362bdf34c5b13ab47393be70784a2c568ef648bb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                              \u0027stderr\u0027: _stderr}"},{"line_number":137,"context_line":"            LOG.error(log_msg)"},{"line_number":138,"context_line":"        else:"},{"line_number":139,"context_line":"            log_msg \u003d \"Exit code: %d\" % returncode"},{"line_number":140,"context_line":"            LOG.debug(log_msg)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        if returncode:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_d7b6ae89","line":139,"in_reply_to":"da85f559_53ebd8b0","updated":"2015-11-17 11:34:34.000000000","message":"Done","commit_id":"c6ed3cdde40f0388565298f0b50545173ee904d1"},{"author":{"_account_id":13734,"name":"Nell Jerram","email":"nell@tigera.io","username":"neiljerram"},"change_message_id":"beb0a59ea6c7bba06fb0fc33321bee5f7812f0fb","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        if returncode:"},{"line_number":143,"context_line":"            extra_ok_codes \u003d extra_ok_codes or []"},{"line_number":144,"context_line":"            if returncode not in extra_ok_codes and check_exit_code:"},{"line_number":145,"context_line":"                raise RuntimeError(log_msg)"},{"line_number":146,"context_line":"    finally:"},{"line_number":147,"context_line":"        # NOTE(termie): this appears to be necessary to let the subprocess"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_42bec9ae","line":144,"updated":"2015-11-12 17:23:22.000000000","message":"Better to put check_exit_code check first, assuming Python short cuts.","commit_id":"c6ed3cdde40f0388565298f0b50545173ee904d1"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"1ed1a355c9d34f88fcfe3e35e0ac9d13d1499b7a","unresolved":false,"context_lines":[{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        if returncode:"},{"line_number":143,"context_line":"            extra_ok_codes \u003d extra_ok_codes or []"},{"line_number":144,"context_line":"            if returncode not in extra_ok_codes and check_exit_code:"},{"line_number":145,"context_line":"                raise RuntimeError(log_msg)"},{"line_number":146,"context_line":"    finally:"},{"line_number":147,"context_line":"        # NOTE(termie): this appears to be necessary to let the subprocess"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_85cfdb54","line":144,"in_reply_to":"da85f559_42bec9ae","updated":"2015-11-12 17:41:46.000000000","message":"Will do.","commit_id":"c6ed3cdde40f0388565298f0b50545173ee904d1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffad2c696c6e6dede5d847ca8a2bb7f2262672a4","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            if log_fail_as_error:"},{"line_number":130,"context_line":"                log_msg \u003d _LE(\"Exit code: %(returncode)d; \""},{"line_number":131,"context_line":"                              \"Stdin: %(stdin)s; \""},{"line_number":132,"context_line":"                              \"Stdout: %(stdout)s; \""},{"line_number":133,"context_line":"                              \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_bd0f4b2d","line":130,"updated":"2015-11-17 12:00:07.000000000","message":"this is used in line 147. Exceptions should not have log hint translations","commit_id":"2abe51c76db5c68deacd1d4efe2d6369da1a100e"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"864135ca395dd7245f19166253779bf96173f85a","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            if log_fail_as_error:"},{"line_number":130,"context_line":"                log_msg \u003d _LE(\"Exit code: %(returncode)d; \""},{"line_number":131,"context_line":"                              \"Stdin: %(stdin)s; \""},{"line_number":132,"context_line":"                              \"Stdout: %(stdout)s; \""},{"line_number":133,"context_line":"                              \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_9d0da740","line":130,"in_reply_to":"ba8a016a_bd0f4b2d","updated":"2015-11-17 12:20:44.000000000","message":"Done.","commit_id":"2abe51c76db5c68deacd1d4efe2d6369da1a100e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ffad2c696c6e6dede5d847ca8a2bb7f2262672a4","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            if check_exit_code:"},{"line_number":140,"context_line":"                raise RuntimeError(log_msg)"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            LOG.debug(\"Exit code: %d\" % returncode)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if returncode:"},{"line_number":145,"context_line":"            extra_ok_codes \u003d extra_ok_codes or []"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_3d035b0f","line":142,"updated":"2015-11-17 12:00:07.000000000","message":"please use a , instead of the %","commit_id":"2abe51c76db5c68deacd1d4efe2d6369da1a100e"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"864135ca395dd7245f19166253779bf96173f85a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            if check_exit_code:"},{"line_number":140,"context_line":"                raise RuntimeError(log_msg)"},{"line_number":141,"context_line":"        else:"},{"line_number":142,"context_line":"            LOG.debug(\"Exit code: %d\" % returncode)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if returncode:"},{"line_number":145,"context_line":"            extra_ok_codes \u003d extra_ok_codes or []"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_8f19ee7b","line":142,"in_reply_to":"ba8a016a_3d035b0f","updated":"2015-11-17 12:20:44.000000000","message":"Done","commit_id":"2abe51c76db5c68deacd1d4efe2d6369da1a100e"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"cc16215105118b47488d6c0dd68b4cc0437c21b2","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d _(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                        \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                        \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                        \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_c547d51b","line":129,"updated":"2015-11-17 13:01:45.000000000","message":"no need to use the marker function for translations here. It should be without _()","commit_id":"6f168a0698d036efd5861678255bf4aa5cc5ab7f"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"3efd58d43f1f2d778371f2af0a15f6e23556d697","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d _(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                        \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                        \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                        \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_b4275d11","line":129,"in_reply_to":"ba8a016a_453525f5","updated":"2015-11-17 14:27:03.000000000","message":"No, it should be:\n\n log_msg \u003d _(\"...\")\n LOG.error(log_msg)\n\nor:\n\n LOG.error(_LE(\"..\"))\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"6f168a0698d036efd5861678255bf4aa5cc5ab7f"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"b05cce3aebb05836ab21ebed6cb2b9ef32a3290d","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d _(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                        \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                        \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                        \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_13db631c","line":129,"in_reply_to":"ba8a016a_b4275d11","updated":"2015-11-19 14:10:39.000000000","message":"that\u0027s what I meant, see my other commit at line 139","commit_id":"6f168a0698d036efd5861678255bf4aa5cc5ab7f"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"48e1bc870b0d3e9e79a27ada3117619cf36ae8b7","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d _(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                        \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                        \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                        \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_453525f5","line":129,"in_reply_to":"ba8a016a_c547d51b","updated":"2015-11-17 13:11:53.000000000","message":"Done","commit_id":"6f168a0698d036efd5861678255bf4aa5cc5ab7f"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"cc16215105118b47488d6c0dd68b4cc0437c21b2","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                            \u0027stderr\u0027: _stderr}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            if log_fail_as_error:"},{"line_number":139,"context_line":"                LOG.error(log_msg)"},{"line_number":140,"context_line":"            if check_exit_code:"},{"line_number":141,"context_line":"                raise RuntimeError(log_msg)"},{"line_number":142,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_85c46d5f","line":139,"updated":"2015-11-17 13:01:45.000000000","message":"You can add the marker function here, something like:\nLOG.error(_LE(\"Runtime Error: %s\"), log_msg)","commit_id":"6f168a0698d036efd5861678255bf4aa5cc5ab7f"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"48e1bc870b0d3e9e79a27ada3117619cf36ae8b7","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                            \u0027stderr\u0027: _stderr}"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"            if log_fail_as_error:"},{"line_number":139,"context_line":"                LOG.error(log_msg)"},{"line_number":140,"context_line":"            if check_exit_code:"},{"line_number":141,"context_line":"                raise RuntimeError(log_msg)"},{"line_number":142,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_25326111","line":139,"in_reply_to":"ba8a016a_85c46d5f","updated":"2015-11-17 13:11:53.000000000","message":"Done","commit_id":"6f168a0698d036efd5861678255bf4aa5cc5ab7f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8987048038ad58c7a08e52131dc0d09e6f313f36","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d (\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                       \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                       \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                       \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_08b414cf","line":129,"updated":"2015-11-17 13:23:56.000000000","message":"please use msg \u003d _(...)\n\nthe reason is that this variable is use when raising the exception\n\nplease see http://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"75034c60bfc73da906aec9da113a3c53b8b2c724"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"100801b446689bd7a51761f07f5fa28b588cebc7","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d (\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                       \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                       \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                       \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_68e600b6","line":129,"in_reply_to":"ba8a016a_08b414cf","updated":"2015-11-17 13:27:10.000000000","message":"Done","commit_id":"75034c60bfc73da906aec9da113a3c53b8b2c724"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"da40f07b5a72b9e13fc541c5b255e429c62dced5","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            msg \u003d (\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                       \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                       \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                       \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_148749d8","line":129,"updated":"2015-11-17 14:27:21.000000000","message":"No, it should be:\n\n log_msg \u003d _(\"...\")\n LOG.error(log_msg)\n\nor:\n\n LOG.error(_LE(\"..\"))\n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"efa52d203642fec2b3deef6e30b46fe13a50788d"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"85d574624f8cf19138c3d101c1febb3f1491513a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            msg \u003d (\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                       \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                       \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                       \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_30304b01","line":129,"in_reply_to":"ba8a016a_148749d8","updated":"2015-11-17 18:20:28.000000000","message":"Here\u0027s me hoping that this will be the last changeset focusing on whether or not there is an underscore or not.","commit_id":"efa52d203642fec2b3deef6e30b46fe13a50788d"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"2b4dd90ff39d86d8b7ed04392356adc4790daee9","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if isinstance(_stderr, bytes):"},{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d _(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                        \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                        \"Stdout: %(stdout)s; \""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_8762f53c","line":128,"updated":"2015-11-18 12:47:05.000000000","message":"It looks like dropping L135 of the base (extra_ok_codes \u003d extra_ok_codes or []) has made the check pipeline rather unhappy...","commit_id":"53fbf68c5e975ed21812a29fc0d8733213016c7b"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"0397ae5b48d96ffd56a6b95a3f070bc59ecf598a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            if isinstance(_stderr, bytes):"},{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d _(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                        \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                        \"Stdout: %(stdout)s; \""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_fb4803b5","line":128,"in_reply_to":"ba8a016a_8762f53c","updated":"2015-11-19 14:12:01.000000000","message":"Yes, it looks like it. I didn\u0027t even notice that I dropped it.","commit_id":"53fbf68c5e975ed21812a29fc0d8733213016c7b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1c7e28e3ab0064b5e92259797f5068a7b99712bc","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d _(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                        \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                        \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                        \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_0a236c57","line":129,"updated":"2015-11-18 13:00:31.000000000","message":"why you still using log_msg? This is used in the exception raised on line 141. Why not call this m as before or msg?","commit_id":"53fbf68c5e975ed21812a29fc0d8733213016c7b"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"0397ae5b48d96ffd56a6b95a3f070bc59ecf598a","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                _stderr \u003d _stderr.decode(\u0027utf-8\u0027, \u0027surrogateescape\u0027)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if returncode and returncode not in extra_ok_codes:"},{"line_number":129,"context_line":"            log_msg \u003d _(\"Exit code: %(returncode)d; \""},{"line_number":130,"context_line":"                        \"Stdin: %(stdin)s; \""},{"line_number":131,"context_line":"                        \"Stdout: %(stdout)s; \""},{"line_number":132,"context_line":"                        \"Stderr: %(stderr)s\") % {"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_bbcd9b32","line":129,"in_reply_to":"ba8a016a_0a236c57","updated":"2015-11-19 14:12:01.000000000","message":"Done","commit_id":"53fbf68c5e975ed21812a29fc0d8733213016c7b"}]}
