)]}'
{"neutron/common/constants.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"6b4c916c824690f946ca7bb77506b89ac60bec21","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""},{"line_number":34,"context_line":"DEVICE_OWNER_NETWORK_PREFIX \u003d \"network:\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":37,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""},{"line_number":38,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d \"network:router_gateway\""},{"line_number":39,"context_line":"DEVICE_OWNER_FLOATINGIP \u003d \"network:floatingip\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_001b8281","line":36,"updated":"2015-11-15 10:56:55.000000000","message":"why not to use the new constant here as well (lines 34-43)?","commit_id":"4b9183be4d7064d5acbba16f297c6ed77c9dde2b"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"cb57b1504bff43df9e3b3e469bec701871ee7da2","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""},{"line_number":34,"context_line":"DEVICE_OWNER_NETWORK_PREFIX \u003d \"network:\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":37,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""},{"line_number":38,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d \"network:router_gateway\""},{"line_number":39,"context_line":"DEVICE_OWNER_FLOATINGIP \u003d \"network:floatingip\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_2b18e774","line":36,"in_reply_to":"da85f559_001b8281","updated":"2015-11-15 11:01:54.000000000","message":"+1","commit_id":"4b9183be4d7064d5acbba16f297c6ed77c9dde2b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"252949e967ad962d7fa0a9e6be9b8cffb602d808","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""},{"line_number":34,"context_line":"DEVICE_OWNER_NETWORK_PREFIX \u003d \"network:\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":37,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""},{"line_number":38,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d \"network:router_gateway\""},{"line_number":39,"context_line":"DEVICE_OWNER_FLOATINGIP \u003d \"network:floatingip\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_ab113706","line":36,"in_reply_to":"da85f559_2b18e774","updated":"2015-11-15 11:53:02.000000000","message":"I think that with pep8 this will be a bit of a mess and the code is pretty readable to at the moment.","commit_id":"4b9183be4d7064d5acbba16f297c6ed77c9dde2b"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"8c6d8e8015ac4e45bda68291c83768be32625e19","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""},{"line_number":34,"context_line":"DEVICE_OWNER_NETWORK_PREFIX \u003d \"network:\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":37,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""},{"line_number":38,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d \"network:router_gateway\""},{"line_number":39,"context_line":"DEVICE_OWNER_FLOATINGIP \u003d \"network:floatingip\""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_cb035b75","line":36,"in_reply_to":"da85f559_ab113706","updated":"2015-11-15 13:30:23.000000000","message":"I think its more about being error prone, not only readable","commit_id":"4b9183be4d7064d5acbba16f297c6ed77c9dde2b"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"cb57b1504bff43df9e3b3e469bec701871ee7da2","unresolved":false,"context_lines":[{"line_number":43,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d \"network:router_centralized_snat\""},{"line_number":44,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d \"neutron:LOADBALANCER\""},{"line_number":45,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d \"neutron:LOADBALANCERV2\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"DEVICE_OWNER_PREFIXES \u003d [\"network:\", \"neutron:\"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Collection used to identify devices owned by router interfaces."}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_cb259bae","line":46,"updated":"2015-11-15 11:01:54.000000000","message":"This could be updated as well.","commit_id":"4b9183be4d7064d5acbba16f297c6ed77c9dde2b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"252949e967ad962d7fa0a9e6be9b8cffb602d808","unresolved":false,"context_lines":[{"line_number":43,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d \"network:router_centralized_snat\""},{"line_number":44,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d \"neutron:LOADBALANCER\""},{"line_number":45,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d \"neutron:LOADBALANCERV2\""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"DEVICE_OWNER_PREFIXES \u003d [\"network:\", \"neutron:\"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# Collection used to identify devices owned by router interfaces."}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_4bf9abc7","line":46,"in_reply_to":"da85f559_cb259bae","updated":"2015-11-15 11:53:02.000000000","message":"Done","commit_id":"4b9183be4d7064d5acbba16f297c6ed77c9dde2b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"481f44b4551f0dfd9c8eaed91e410c93801eadc0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""},{"line_number":34,"context_line":"DEVICE_OWNER_NETWORK_PREFIX \u003d \"network:\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":37,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""},{"line_number":38,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d \"network:router_gateway\""},{"line_number":39,"context_line":"DEVICE_OWNER_FLOATINGIP \u003d \"network:floatingip\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_ba822ec7","line":36,"updated":"2015-11-16 12:15:45.000000000","message":"This change defines DEVICE_OWNER_NETWORK_PREFIX to avoid potential typos. I don\u0027t understand why this module should be the exception (as said in PS2).","commit_id":"2b8296780e45d789a4046d44c1e31d0a8368e25f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"39fbf2c1b6179b4fe636be66e763d9616f3c8e6e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""},{"line_number":34,"context_line":"DEVICE_OWNER_NETWORK_PREFIX \u003d \"network:\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":37,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""},{"line_number":38,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d \"network:router_gateway\""},{"line_number":39,"context_line":"DEVICE_OWNER_FLOATINGIP \u003d \"network:floatingip\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_37040814","line":36,"in_reply_to":"ba8a016a_61c1792e","updated":"2015-11-16 16:06:14.000000000","message":"Done","commit_id":"2b8296780e45d789a4046d44c1e31d0a8368e25f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c0461951ca7f7bd7c13bbe9b4fb1ce3d421d771e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"DEVICE_OWNER_COMPUTE_PREFIX \u003d \"compute:\""},{"line_number":34,"context_line":"DEVICE_OWNER_NETWORK_PREFIX \u003d \"network:\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":37,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""},{"line_number":38,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d \"network:router_gateway\""},{"line_number":39,"context_line":"DEVICE_OWNER_FLOATINGIP \u003d \"network:floatingip\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_61c1792e","line":36,"in_reply_to":"ba8a016a_ba822ec7","updated":"2015-11-16 13:54:31.000000000","message":"Is that not an overkill? I think that with pep8 the code will be less readable","commit_id":"2b8296780e45d789a4046d44c1e31d0a8368e25f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"96fd1cc84124e20ac1d521c47b182753f7465b5b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d (DEVICE_OWNER_NETWORK_PREFIX +"},{"line_number":47,"context_line":"                            \"router_centralized_snat\")"},{"line_number":48,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCER\""},{"line_number":49,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCERV2\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"DEVICE_OWNER_PREFIXES \u003d [DEVICE_OWNER_NETWORK_PREFIX, \"neutron:\"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_7d9fce5f","line":49,"updated":"2015-11-16 17:36:06.000000000","message":"These two were \u0027neutron\u0027 not \u0027network\u0027","commit_id":"d485bddbe09532f53e711525f18a7027d6844c76"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"12d7817615a6274aa2b36fc78e7094257b2364d7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d (DEVICE_OWNER_NETWORK_PREFIX +"},{"line_number":47,"context_line":"                            \"router_centralized_snat\")"},{"line_number":48,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCER\""},{"line_number":49,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCERV2\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"DEVICE_OWNER_PREFIXES \u003d [DEVICE_OWNER_NETWORK_PREFIX, \"neutron:\"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_985ce726","line":49,"in_reply_to":"ba8a016a_04bad823","updated":"2015-11-17 04:46:17.000000000","message":"Yeah, this is my bad. I have reverted.\nMost of the bugs are due to copy paste.","commit_id":"d485bddbe09532f53e711525f18a7027d6844c76"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1daa088d947e689a4e1f5f75af2801217af1460d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d (DEVICE_OWNER_NETWORK_PREFIX +"},{"line_number":47,"context_line":"                            \"router_centralized_snat\")"},{"line_number":48,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCER\""},{"line_number":49,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCERV2\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"DEVICE_OWNER_PREFIXES \u003d [DEVICE_OWNER_NETWORK_PREFIX, \"neutron:\"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_04bad823","line":49,"in_reply_to":"ba8a016a_4711c9ab","updated":"2015-11-17 02:27:25.000000000","message":"I was thinking of the case where a port already exists, and I apply this change and restart the agent - will everything still work?  It seems to me like is_dvr_serviced() will fail to match the lbaas ports in that case?  I must be missing something.","commit_id":"d485bddbe09532f53e711525f18a7027d6844c76"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"ee5508cf8a24c50d240355b7d27859f5d120f3e0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d (DEVICE_OWNER_NETWORK_PREFIX +"},{"line_number":47,"context_line":"                            \"router_centralized_snat\")"},{"line_number":48,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCER\""},{"line_number":49,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCERV2\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"DEVICE_OWNER_PREFIXES \u003d [DEVICE_OWNER_NETWORK_PREFIX, \"neutron:\"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_4711c9ab","line":49,"in_reply_to":"ba8a016a_72c7f412","updated":"2015-11-16 23:40:38.000000000","message":"I agree. I cannot see what the change affects.","commit_id":"d485bddbe09532f53e711525f18a7027d6844c76"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"b6887e04db10e50d8b4c1a748ae70b081da6f698","unresolved":false,"context_lines":[{"line_number":46,"context_line":"DEVICE_OWNER_ROUTER_SNAT \u003d (DEVICE_OWNER_NETWORK_PREFIX +"},{"line_number":47,"context_line":"                            \"router_centralized_snat\")"},{"line_number":48,"context_line":"DEVICE_OWNER_LOADBALANCER \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCER\""},{"line_number":49,"context_line":"DEVICE_OWNER_LOADBALANCERV2 \u003d DEVICE_OWNER_NETWORK_PREFIX + \"LOADBALANCERV2\""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"DEVICE_OWNER_PREFIXES \u003d [DEVICE_OWNER_NETWORK_PREFIX, \"neutron:\"]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_72c7f412","line":49,"in_reply_to":"ba8a016a_7d9fce5f","updated":"2015-11-16 19:56:53.000000000","message":"this one is set in neutron-lbaas : https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/db/loadbalancer/loadbalancer_db.py#L345 using this constant. I think it should work and probably align previous use of \u0027neutron\u0027 prefix to using \u0027network\u0027.","commit_id":"d485bddbe09532f53e711525f18a7027d6844c76"}],"neutron/tests/unit/test_policy.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"6b4c916c824690f946ca7bb77506b89ac60bec21","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                           oslo_policy.PolicyNotAuthorized)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def test_create_port_device_owner_regex(self):"},{"line_number":330,"context_line":"        blocked_values \u003d (\u0027network:\u0027, \u0027network:abdef\u0027, const.DEVICE_OWNER_DHCP,"},{"line_number":331,"context_line":"                          const.DEVICE_OWNER_ROUTER_INTF)"},{"line_number":332,"context_line":"        for val in blocked_values:"},{"line_number":333,"context_line":"            self._test_advsvc_action_on_attr("}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_2006c620","line":330,"updated":"2015-11-15 10:56:55.000000000","message":"\u0027network:\u0027 \u003d\u003e const.DEVICE_OWNER_NETWORK_PREFIX","commit_id":"4b9183be4d7064d5acbba16f297c6ed77c9dde2b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"252949e967ad962d7fa0a9e6be9b8cffb602d808","unresolved":false,"context_lines":[{"line_number":327,"context_line":"                                           oslo_policy.PolicyNotAuthorized)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def test_create_port_device_owner_regex(self):"},{"line_number":330,"context_line":"        blocked_values \u003d (\u0027network:\u0027, \u0027network:abdef\u0027, const.DEVICE_OWNER_DHCP,"},{"line_number":331,"context_line":"                          const.DEVICE_OWNER_ROUTER_INTF)"},{"line_number":332,"context_line":"        for val in blocked_values:"},{"line_number":333,"context_line":"            self._test_advsvc_action_on_attr("}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_0b03a3b9","line":330,"in_reply_to":"da85f559_2006c620","updated":"2015-11-15 11:53:02.000000000","message":"Done","commit_id":"4b9183be4d7064d5acbba16f297c6ed77c9dde2b"}]}