)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b60729a8bbfed1440408ce8fa6bb4f3d03943c8b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If using a host that does not support namespaces the nvp plugin did not"},{"line_number":10,"context_line":"have a way to leverage metadata unless using enable_isolated_metadata which"},{"line_number":11,"context_line":"requires a subnet to not have a gateway. This patch adds the configuartion"},{"line_number":12,"context_line":"option \u0027enable_metadata_dhcp_host_route\u0027 which when enabled adds a route"},{"line_number":13,"context_line":"to the dhcp server\u0027s ip address for 169.254.169.254/32 if the subnet has"},{"line_number":14,"context_line":"as gatway_ip. In order for a host to leverage this it requires the host\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOH%2F%2F9RE%3D","line":11,"updated":"2013-03-19 16:13:50.000000000","message":"conifguartion \u003d\u003e configuration","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"24d8e55b861508938f9cc61cb6ec378195d36ce8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If using a host that does not support namespaces the nvp plugin did not"},{"line_number":10,"context_line":"have a way to leverage metadata unless using enable_isolated_metadata which"},{"line_number":11,"context_line":"requires a subnet to not have a gateway. This patch adds the configuartion"},{"line_number":12,"context_line":"option \u0027enable_metadata_dhcp_host_route\u0027 which when enabled adds a route"},{"line_number":13,"context_line":"to the dhcp server\u0027s ip address for 169.254.169.254/32 if the subnet has"},{"line_number":14,"context_line":"as gatway_ip. In order for a host to leverage this it requires the host\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOH%2F%2F6sw%3D","line":11,"in_reply_to":"AAAAOH%2F%2F9RE%3D","updated":"2013-03-21 01:34:55.000000000","message":"Done","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b60729a8bbfed1440408ce8fa6bb4f3d03943c8b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"requires a subnet to not have a gateway. This patch adds the configuartion"},{"line_number":12,"context_line":"option \u0027enable_metadata_dhcp_host_route\u0027 which when enabled adds a route"},{"line_number":13,"context_line":"to the dhcp server\u0027s ip address for 169.254.169.254/32 if the subnet has"},{"line_number":14,"context_line":"as gatway_ip. In order for a host to leverage this it requires the host\u0027s"},{"line_number":15,"context_line":"dhcp client to support host routes (code 121)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug 1155786"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOH%2F%2F9RA%3D","line":14,"updated":"2013-03-19 16:13:50.000000000","message":"\"as gatway_ip\" \u003d\u003e \"a gateway ip\"","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"24d8e55b861508938f9cc61cb6ec378195d36ce8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"requires a subnet to not have a gateway. This patch adds the configuartion"},{"line_number":12,"context_line":"option \u0027enable_metadata_dhcp_host_route\u0027 which when enabled adds a route"},{"line_number":13,"context_line":"to the dhcp server\u0027s ip address for 169.254.169.254/32 if the subnet has"},{"line_number":14,"context_line":"as gatway_ip. In order for a host to leverage this it requires the host\u0027s"},{"line_number":15,"context_line":"dhcp client to support host routes (code 121)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug 1155786"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOH%2F%2F6ss%3D","line":14,"in_reply_to":"AAAAOH%2F%2F9RA%3D","updated":"2013-03-21 01:34:55.000000000","message":"Done","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b60729a8bbfed1440408ce8fa6bb4f3d03943c8b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"option \u0027enable_metadata_dhcp_host_route\u0027 which when enabled adds a route"},{"line_number":13,"context_line":"to the dhcp server\u0027s ip address for 169.254.169.254/32 if the subnet has"},{"line_number":14,"context_line":"as gatway_ip. In order for a host to leverage this it requires the host\u0027s"},{"line_number":15,"context_line":"dhcp client to support host routes (code 121)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug 1155786"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOH%2F%2F9Q4%3D","line":15,"updated":"2013-03-19 16:13:50.000000000","message":"Technically, this is not a restriction you\u0027re adding with your patch, as isolated metadata support also has this restriction.","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"24d8e55b861508938f9cc61cb6ec378195d36ce8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"option \u0027enable_metadata_dhcp_host_route\u0027 which when enabled adds a route"},{"line_number":13,"context_line":"to the dhcp server\u0027s ip address for 169.254.169.254/32 if the subnet has"},{"line_number":14,"context_line":"as gatway_ip. In order for a host to leverage this it requires the host\u0027s"},{"line_number":15,"context_line":"dhcp client to support host routes (code 121)."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Fixes bug 1155786"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAOH%2F%2F6so%3D","line":15,"in_reply_to":"AAAAOH%2F%2F9Q4%3D","updated":"2013-03-21 01:34:55.000000000","message":"Done","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":9,"context_line":"If using a host that does not support namespaces the nvp plugin did not have"},{"line_number":10,"context_line":"a way to leverage metadata unless using enable_isolated_metadata which"},{"line_number":11,"context_line":"requires a subnet to not have a gateway. This patch changes the metadata"},{"line_number":12,"context_line":"configuration for the NVP plugin by adding a flag meatadata_mode which can be"},{"line_number":13,"context_line":"set to access_network (which was previously enable_metadata_access_network)"},{"line_number":14,"context_line":"or dhcp_host_route. When set to dhcp_host_route when the dhcp agent creates"},{"line_number":15,"context_line":"it\u0027s port a host_route is added towards the dhcp server\u0027s ip for the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"AAAAOH%2F%2F2wo%3D","line":12,"updated":"2013-03-24 11:01:57.000000000","message":"typo - meatadata_mode","commit_id":"9c7fab9bf7f347698aad72162b3b93fc43fd953c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"24d8e55b861508938f9cc61cb6ec378195d36ce8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If using a host that does not support namespaces the nvp plugin did not have"},{"line_number":10,"context_line":"a way to leverage metadata unless using enable_isolated_metadata which"},{"line_number":11,"context_line":"requires a subnet to not have a gateway. This patch changes the metadata"},{"line_number":12,"context_line":"configuration for the NVP plugin by adding a flag meatadata_mode which can be"},{"line_number":13,"context_line":"set to access_network (which was previously enable_metadata_access_network)"},{"line_number":14,"context_line":"or dhcp_host_route. When set to dhcp_host_route when the dhcp agent creates"},{"line_number":15,"context_line":"it\u0027s port a host_route is added towards the dhcp server\u0027s ip for the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"AAAAOH%2F%2F1bc%3D","line":12,"in_reply_to":"AAAAOH%2F%2F2wo%3D","updated":"2013-03-25 18:04:07.000000000","message":"Done","commit_id":"9c7fab9bf7f347698aad72162b3b93fc43fd953c"}],"quantum/plugins/nicira/nicira_nvp_plugin/QuantumPlugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b60729a8bbfed1440408ce8fa6bb4f3d03943c8b","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        cfg.CONF.NVP.enable_metadata_access_network):"},{"line_number":104,"context_line":"        LOG.error(_(\"Both enable_metadata_dhcp_host_route and \""},{"line_number":105,"context_line":"                    \"enable_metadata_access_network are enabled. Only one can \""},{"line_number":106,"context_line":"                    \"be enabled at a time.\"))"},{"line_number":107,"context_line":"        sys.exit(1)"},{"line_number":108,"context_line":"    nvp_conf \u003d config.ClusterConfigOptions(cfg.CONF)"},{"line_number":109,"context_line":"    cluster_names \u003d config.register_cluster_groups(nvp_conf)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2F9OY%3D","line":106,"updated":"2013-03-19 16:13:50.000000000","message":"I am wondering it this actually calls for a different change in configuration:\n\nmetadata_mode \u003d {dhcp_host_route | access_network | none}","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"24d8e55b861508938f9cc61cb6ec378195d36ce8","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        cfg.CONF.NVP.enable_metadata_access_network):"},{"line_number":104,"context_line":"        LOG.error(_(\"Both enable_metadata_dhcp_host_route and \""},{"line_number":105,"context_line":"                    \"enable_metadata_access_network are enabled. Only one can \""},{"line_number":106,"context_line":"                    \"be enabled at a time.\"))"},{"line_number":107,"context_line":"        sys.exit(1)"},{"line_number":108,"context_line":"    nvp_conf \u003d config.ClusterConfigOptions(cfg.CONF)"},{"line_number":109,"context_line":"    cluster_names \u003d config.register_cluster_groups(nvp_conf)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2F6s0%3D","line":106,"in_reply_to":"AAAAOH%2F%2F9OY%3D","updated":"2013-03-21 01:34:55.000000000","message":"Ah good point.","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b60729a8bbfed1440408ce8fa6bb4f3d03943c8b","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        LOG.error(_(\"Both enable_metadata_dhcp_host_route and \""},{"line_number":105,"context_line":"                    \"enable_metadata_access_network are enabled. Only one can \""},{"line_number":106,"context_line":"                    \"be enabled at a time.\"))"},{"line_number":107,"context_line":"        sys.exit(1)"},{"line_number":108,"context_line":"    nvp_conf \u003d config.ClusterConfigOptions(cfg.CONF)"},{"line_number":109,"context_line":"    cluster_names \u003d config.register_cluster_groups(nvp_conf)"},{"line_number":110,"context_line":"    nvp_conf.log_opt_values(LOG, logging.DEBUG)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2F9Oc%3D","line":107,"updated":"2013-03-19 16:13:50.000000000","message":"instead of sys.exit you should be able to raise SystemError, which has the same effect, I believe. (this wil l also make the import unnecessary)","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"24d8e55b861508938f9cc61cb6ec378195d36ce8","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        LOG.error(_(\"Both enable_metadata_dhcp_host_route and \""},{"line_number":105,"context_line":"                    \"enable_metadata_access_network are enabled. Only one can \""},{"line_number":106,"context_line":"                    \"be enabled at a time.\"))"},{"line_number":107,"context_line":"        sys.exit(1)"},{"line_number":108,"context_line":"    nvp_conf \u003d config.ClusterConfigOptions(cfg.CONF)"},{"line_number":109,"context_line":"    cluster_names \u003d config.register_cluster_groups(nvp_conf)"},{"line_number":110,"context_line":"    nvp_conf.log_opt_values(LOG, logging.DEBUG)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2F6s4%3D","line":107,"in_reply_to":"AAAAOH%2F%2F9Oc%3D","updated":"2013-03-21 01:34:55.000000000","message":"Done","commit_id":"994933398d0d3ea372019a5185e320e7165ba08f"}],"quantum/plugins/nicira/nicira_nvp_plugin/common/metadata_access.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":174,"context_line":"                                          destination\u003dMETADATA_DHCP_ROUTE,"},{"line_number":175,"context_line":"                                          nexthop\u003dfixed_ip_data[\u0027ip_address\u0027])"},{"line_number":176,"context_line":"            context.session.add(route)"},{"line_number":177,"context_line":"        if cfg.CONF.dhcp_agent_notification:"},{"line_number":178,"context_line":"            return True"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _send_subnet_update_end(self, context, subnet_id):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOH%2F%2F3V8%3D","line":177,"updated":"2013-03-22 21:57:49.000000000","message":"what about:\n\nreturn cfg.CONG.dhcp_agent_notification\n\n?","commit_id":"4394cc6ccd270aa2612c5d92db1af29c09673ccf"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"24d8e55b861508938f9cc61cb6ec378195d36ce8","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                                          destination\u003dMETADATA_DHCP_ROUTE,"},{"line_number":175,"context_line":"                                          nexthop\u003dfixed_ip_data[\u0027ip_address\u0027])"},{"line_number":176,"context_line":"            context.session.add(route)"},{"line_number":177,"context_line":"        if cfg.CONF.dhcp_agent_notification:"},{"line_number":178,"context_line":"            return True"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def _send_subnet_update_end(self, context, subnet_id):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOH%2F%2F3UU%3D","line":177,"in_reply_to":"AAAAOH%2F%2F3V8%3D","updated":"2013-03-22 22:25:21.000000000","message":"sure","commit_id":"4394cc6ccd270aa2612c5d92db1af29c09673ccf"}]}