)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"66b44ab2e1f9b90d229aebaa11b18f99b0b7f653","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dongcan Ye \u003chellochosen@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-16 23:50:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add helper info for notification_driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In neutron.conf, notification_driver helper info is simple, that"},{"line_number":10,"context_line":"makes us confused how to configure it correctly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_9803a00f","line":7,"updated":"2015-11-16 18:09:44.000000000","message":"\"Add a better description for notification_driver\" would be more clear","commit_id":"f81652308115e41acaad6608e4ec61d108c129f7"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"80acd99dbf0a58fb266c38f169b9307eb2c7b5cb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dongcan Ye \u003chellochosen@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-16 23:50:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add helper info for notification_driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In neutron.conf, notification_driver helper info is simple, that"},{"line_number":10,"context_line":"makes us confused how to configure it correctly."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_1e56a729","line":7,"in_reply_to":"ba8a016a_9803a00f","updated":"2015-11-17 02:07:03.000000000","message":"Thanks, Brad.","commit_id":"f81652308115e41acaad6608e4ec61d108c129f7"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"66b44ab2e1f9b90d229aebaa11b18f99b0b7f653","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add helper info for notification_driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In neutron.conf, notification_driver helper info is simple, that"},{"line_number":10,"context_line":"makes us confused how to configure it correctly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib5d4c4b6eea5cabf58708d8201f9ff9c883b6c97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_d337c9e1","line":10,"updated":"2015-11-16 18:09:44.000000000","message":"\"Improve the description for the notification_driver property in neutron.conf, so users will understand how to configure it correctly.\"  would be more clear.","commit_id":"f81652308115e41acaad6608e4ec61d108c129f7"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"80acd99dbf0a58fb266c38f169b9307eb2c7b5cb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add helper info for notification_driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In neutron.conf, notification_driver helper info is simple, that"},{"line_number":10,"context_line":"makes us confused how to configure it correctly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib5d4c4b6eea5cabf58708d8201f9ff9c883b6c97"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_be319b0d","line":10,"in_reply_to":"ba8a016a_d337c9e1","updated":"2015-11-17 02:07:03.000000000","message":"Done","commit_id":"f81652308115e41acaad6608e4ec61d108c129f7"}],"etc/neutron.conf":[{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"66b44ab2e1f9b90d229aebaa11b18f99b0b7f653","unresolved":false,"context_lines":[{"line_number":543,"context_line":"# Driver(s) to handle sending notifications to be loaded from"},{"line_number":544,"context_line":"# the oslo.messaging.notify.drivers namespace. (multi valued)"},{"line_number":545,"context_line":"# See setup.cfg in oslo.messaging, default value is empty,"},{"line_number":546,"context_line":"# which means no notification driver is used."},{"line_number":547,"context_line":"# notification_driver\u003d"},{"line_number":548,"context_line":"# Possible values: messaging, messagingv2, routing, log, test, noop."},{"line_number":549,"context_line":"# Example: notification_driver \u003d messaging"}],"source_content_type":"text/plain","patch_set":1,"id":"ba8a016a_98a7204f","line":546,"updated":"2015-11-16 18:09:44.000000000","message":"This is definitely an improvement.  I\u0027m assuming the empty string and \"noop\" for this property are equivalent?  To be a bit more clear, I would say.  \"The default value is the empty string, which means notifications will be disabled, and is equivalent to specifying noop\"","commit_id":"f81652308115e41acaad6608e4ec61d108c129f7"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"80acd99dbf0a58fb266c38f169b9307eb2c7b5cb","unresolved":false,"context_lines":[{"line_number":543,"context_line":"# Driver(s) to handle sending notifications to be loaded from"},{"line_number":544,"context_line":"# the oslo.messaging.notify.drivers namespace. (multi valued)"},{"line_number":545,"context_line":"# See setup.cfg in oslo.messaging, default value is empty,"},{"line_number":546,"context_line":"# which means no notification driver is used."},{"line_number":547,"context_line":"# notification_driver\u003d"},{"line_number":548,"context_line":"# Possible values: messaging, messagingv2, routing, log, test, noop."},{"line_number":549,"context_line":"# Example: notification_driver \u003d messaging"}],"source_content_type":"text/plain","patch_set":1,"id":"ba8a016a_6194f68a","line":546,"in_reply_to":"ba8a016a_98a7204f","updated":"2015-11-17 02:07:03.000000000","message":"@Brad\nIMO, the empty string and noop may not be the same behaviour, noop means no operation, do you agree?","commit_id":"f81652308115e41acaad6608e4ec61d108c129f7"},{"author":{"_account_id":14957,"name":"Brad Behle","email":"behle@us.ibm.com","username":"behle"},"change_message_id":"66b44ab2e1f9b90d229aebaa11b18f99b0b7f653","unresolved":false,"context_lines":[{"line_number":547,"context_line":"# notification_driver\u003d"},{"line_number":548,"context_line":"# Possible values: messaging, messagingv2, routing, log, test, noop."},{"line_number":549,"context_line":"# Example: notification_driver \u003d messaging"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"# AMQP topic used for OpenStack notifications. (list value)"},{"line_number":552,"context_line":"# Deprecated group/name - [rpc_notifier2]/topics"},{"line_number":553,"context_line":"# notification_topics\u003dnotifications"}],"source_content_type":"text/plain","patch_set":1,"id":"ba8a016a_98e2c09e","line":550,"updated":"2015-11-16 18:09:44.000000000","message":"Instead of referencing setup.cfg, it would be better to point the user to http://docs.openstack.org/developer/oslo.messaging/FAQ.html.  Or reference both, and include the URL to setup.cfg (https://github.com/openstack/oslo.messaging/blob/master/setup.cfg)","commit_id":"f81652308115e41acaad6608e4ec61d108c129f7"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"80acd99dbf0a58fb266c38f169b9307eb2c7b5cb","unresolved":false,"context_lines":[{"line_number":547,"context_line":"# notification_driver\u003d"},{"line_number":548,"context_line":"# Possible values: messaging, messagingv2, routing, log, test, noop."},{"line_number":549,"context_line":"# Example: notification_driver \u003d messaging"},{"line_number":550,"context_line":""},{"line_number":551,"context_line":"# AMQP topic used for OpenStack notifications. (list value)"},{"line_number":552,"context_line":"# Deprecated group/name - [rpc_notifier2]/topics"},{"line_number":553,"context_line":"# notification_topics\u003dnotifications"}],"source_content_type":"text/plain","patch_set":1,"id":"ba8a016a_01916a99","line":550,"in_reply_to":"ba8a016a_98e2c09e","updated":"2015-11-17 02:07:03.000000000","message":"Agree","commit_id":"f81652308115e41acaad6608e4ec61d108c129f7"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"4ce5bfb6dac013ca750bcf05b98ff0b8fe04212c","unresolved":false,"context_lines":[{"line_number":548,"context_line":"# which means notifications will be disabled."},{"line_number":549,"context_line":"# notification_driver\u003d"},{"line_number":550,"context_line":"# Possible values: messaging, messagingv2, routing, log, test, noop."},{"line_number":551,"context_line":"# Example: notification_driver \u003d messaging"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# AMQP topic used for OpenStack notifications. (list value)"},{"line_number":554,"context_line":"# Deprecated group/name - [rpc_notifier2]/topics"}],"source_content_type":"text/plain","patch_set":2,"id":"ba8a016a_981147af","line":551,"updated":"2015-11-17 05:10:19.000000000","message":"Can you move these two lines above \"notification_driver\u003d \"? In neutron.conf, it\u0027s written a description and then default value in the order.","commit_id":"891e36e270b8e908f221fc5779c4b5b51a053a1a"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"d988ee514327f2fdab32f4fa5c64c5a01d4368ee","unresolved":false,"context_lines":[{"line_number":548,"context_line":"# which means notifications will be disabled."},{"line_number":549,"context_line":"# notification_driver\u003d"},{"line_number":550,"context_line":"# Possible values: messaging, messagingv2, routing, log, test, noop."},{"line_number":551,"context_line":"# Example: notification_driver \u003d messaging"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"# AMQP topic used for OpenStack notifications. (list value)"},{"line_number":554,"context_line":"# Deprecated group/name - [rpc_notifier2]/topics"}],"source_content_type":"text/plain","patch_set":2,"id":"ba8a016a_78d103cd","line":551,"in_reply_to":"ba8a016a_981147af","updated":"2015-11-17 05:14:47.000000000","message":"Done","commit_id":"891e36e270b8e908f221fc5779c4b5b51a053a1a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4443ea6a3797ff4001ed8f34094ff1d4f18ad793","unresolved":false,"context_lines":[{"line_number":541,"context_line":"# rpc_thread_pool_size\u003d64"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"# Driver(s) to handle sending notifications to be loaded from"},{"line_number":544,"context_line":"# the oslo.messaging.notify.drivers namespace. (multi valued)"},{"line_number":545,"context_line":"# See setup.cfg in oslo.messaging Repo:"},{"line_number":546,"context_line":"# https://github.com/openstack/oslo.messaging/blob/master/setup.cfg"},{"line_number":547,"context_line":"# The default value is an empty string,"}],"source_content_type":"text/plain","patch_set":3,"id":"ba8a016a_a1627a3c","line":544,"updated":"2015-11-18 16:13:40.000000000","message":"*multi-valued","commit_id":"6bcac62fc28229e433e7d0853386fe2f886daa5f"}]}