)]}'
{"neutron/agent/metadata/config.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"671cf9faf3419e990c3d016ded47fc53f22a5496","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                      \u0027metadata server socket with\u0027))"},{"line_number":136,"context_line":"]"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"cfg.CONF.set_override(\u0027use_ssl\u0027, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_80880224","line":138,"updated":"2015-11-16 20:36:20.000000000","message":"It\u0027s wrong to update the default value of an option on module load, typically it affects how unittests behave.\n\nSuch override should be done in service startup not on module load.","commit_id":"76593dae1a10e22283c2c835fb478980e54291e3"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7a299ba918771b58eb764c2134494c76c32dc284","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                      \u0027metadata server socket with\u0027))"},{"line_number":136,"context_line":"]"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"cfg.CONF.set_override(\u0027use_ssl\u0027, False)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_11bbe6e6","line":138,"range":{"start_line":138,"start_character":23,"end_line":138,"end_character":30},"updated":"2015-11-17 10:52:51.000000000","message":"This is a parameter that is relevant to the Neutron service. The fact that is is defined in the global configuration section does not mean that you should do this overwrite here. As said in the comment above that is for testing.","commit_id":"76593dae1a10e22283c2c835fb478980e54291e3"}],"neutron/tests/unit/test_wsgi.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"191632f226d997fa00f8f1d90fcb492641d020ab","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.assertEqual(greetings.encode(\u0027utf-8\u0027), response.read())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        server.stop()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_disable_ssl(self):"},{"line_number":179,"context_line":"        CONF.set_default(\u0027use_ssl\u0027, True)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_38c3ee58","line":177,"updated":"2016-01-06 11:14:21.000000000","message":"Do you think that\u0027s necessary? This test already checks that it responds using the plain http protocol.","commit_id":"7a306e2918775ebb94d9e1408aaa2b7c3ed26fc6"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"10d925f1749e678cfbc1515c0d3921e31e9160b7","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        self.assertEqual(greetings.encode(\u0027utf-8\u0027), response.read())"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        server.stop()"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def test_disable_ssl(self):"},{"line_number":179,"context_line":"        CONF.set_default(\u0027use_ssl\u0027, True)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_2071780f","line":177,"updated":"2015-11-27 14:25:12.000000000","message":"let\u0027s add an assert to verify that sslutils was not called since \"use_ssl\" is false.\nAdd before line 178:\n\n@mock.patch.object(oslo_service, \u0027sslutils\u0027)\n\nthen after line 196\nself.assertFalse(sslutils_mock.called)\n\noslo_service should be imported .","commit_id":"7a306e2918775ebb94d9e1408aaa2b7c3ed26fc6"}]}