)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"f4bdc42ea2d98a4b3f5b932b4829f65af332c766","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-11-18 17:39:13 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update HA router state if agent is not active"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If L3 agent marked dead it is still show as \u0027active\u0027 in the HA"},{"line_number":10,"context_line":"router states on that agent. Currect change add check for such"},{"line_number":11,"context_line":"case and update HA router state from \u0027active\u0027 to \u0027standby\u0027 if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_e64c18ca","line":8,"updated":"2015-11-18 16:05:40.000000000","message":"agent is marked","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2844e1ce62c356cc78ae74e756f7e45719b691b7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-11-18 17:39:13 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update HA router state if agent is not active"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If L3 agent marked dead it is still show as \u0027active\u0027 in the HA"},{"line_number":10,"context_line":"router states on that agent. Currect change add check for such"},{"line_number":11,"context_line":"case and update HA router state from \u0027active\u0027 to \u0027standby\u0027 if"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_ad779d9e","line":8,"in_reply_to":"ba8a016a_e64c18ca","updated":"2015-11-19 12:54:23.000000000","message":"Done","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":18573,"name":"Petri Kemppainen","email":"petri.kemppainen@nokia.com","username":"petrkemp"},"change_message_id":"f4bdc42ea2d98a4b3f5b932b4829f65af332c766","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update HA router state if agent is not active"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If L3 agent marked dead it is still show as \u0027active\u0027 in the HA"},{"line_number":10,"context_line":"router states on that agent. Currect change add check for such"},{"line_number":11,"context_line":"case and update HA router state from \u0027active\u0027 to \u0027standby\u0027 if"},{"line_number":12,"context_line":"agent is dead."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_0654bc1e","line":9,"updated":"2015-11-18 16:05:40.000000000","message":"Currect --\u003e Current change adds","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"2844e1ce62c356cc78ae74e756f7e45719b691b7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update HA router state if agent is not active"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If L3 agent marked dead it is still show as \u0027active\u0027 in the HA"},{"line_number":10,"context_line":"router states on that agent. Currect change add check for such"},{"line_number":11,"context_line":"case and update HA router state from \u0027active\u0027 to \u0027standby\u0027 if"},{"line_number":12,"context_line":"agent is dead."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_cd7a2188","line":9,"in_reply_to":"ba8a016a_0654bc1e","updated":"2015-11-19 12:54:23.000000000","message":"Done","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"}],"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"aef1270e561cb08c4739968aa478ff172f61b6f8","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        return query.all()"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def _check_for_active_dead_agents_for_router(self, context, router_id):"},{"line_number":494,"context_line":"        \"\"\"Return None if there was dead active agents in other case"},{"line_number":495,"context_line":"           bindings."},{"line_number":496,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0e24b95d","line":493,"updated":"2015-11-19 03:19:48.000000000","message":"nit: can we select a better method name, \"active dead agents\" seems a little confused.","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"507c3de702e944bcadbabdceb01bf49192d0442d","unresolved":false,"context_lines":[{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        return query.all()"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def _check_for_active_dead_agents_for_router(self, context, router_id):"},{"line_number":494,"context_line":"        \"\"\"Return None if there was dead active agents in other case"},{"line_number":495,"context_line":"           bindings."},{"line_number":496,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_a3b9fe16","line":493,"in_reply_to":"ba8a016a_0e24b95d","updated":"2015-11-19 12:03:30.000000000","message":"Done","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"aef1270e561cb08c4739968aa478ff172f61b6f8","unresolved":false,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        \"\"\""},{"line_number":498,"context_line":"        bindings \u003d self.get_ha_router_port_bindings(context, [router_id])"},{"line_number":499,"context_line":"        agents \u003d [(binding.agent, binding.state) for binding in bindings"},{"line_number":500,"context_line":"                  if binding.state \u003d\u003d constants.HA_ROUTER_STATE_ACTIVE]"},{"line_number":501,"context_line":"        dead_agents \u003d [a[0] for a in agents if not a[0].is_active]"},{"line_number":502,"context_line":"        for dead_agent in dead_agents:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_ae500dd5","line":499,"updated":"2015-11-19 03:19:48.000000000","message":"Seems binding.state is no longer used after this list expression complete.\n\nMaybe you can combine L499-L501 into a list-exp.","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"507c3de702e944bcadbabdceb01bf49192d0442d","unresolved":false,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"        \"\"\""},{"line_number":498,"context_line":"        bindings \u003d self.get_ha_router_port_bindings(context, [router_id])"},{"line_number":499,"context_line":"        agents \u003d [(binding.agent, binding.state) for binding in bindings"},{"line_number":500,"context_line":"                  if binding.state \u003d\u003d constants.HA_ROUTER_STATE_ACTIVE]"},{"line_number":501,"context_line":"        dead_agents \u003d [a[0] for a in agents if not a[0].is_active]"},{"line_number":502,"context_line":"        for dead_agent in dead_agents:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_43eb7213","line":499,"in_reply_to":"ba8a016a_ae500dd5","updated":"2015-11-19 12:03:30.000000000","message":"Done","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"a60a3ecbaa8db4c30b6000f1fda37254a15110be","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        agents \u003d [(binding.agent, binding.state) for binding in bindings"},{"line_number":500,"context_line":"                  if binding.state \u003d\u003d constants.HA_ROUTER_STATE_ACTIVE]"},{"line_number":501,"context_line":"        dead_agents \u003d [a[0] for a in agents if not a[0].is_active]"},{"line_number":502,"context_line":"        for dead_agent in dead_agents:"},{"line_number":503,"context_line":"            self.update_routers_states("},{"line_number":504,"context_line":"                context, {router_id: constants.HA_ROUTER_STATE_STANDBY},"},{"line_number":505,"context_line":"                dead_agent.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_2c16814c","line":502,"updated":"2015-11-18 16:18:00.000000000","message":"This is raceful in case an agent comes back up between the queries in lines 498 and 503.","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"507c3de702e944bcadbabdceb01bf49192d0442d","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        agents \u003d [(binding.agent, binding.state) for binding in bindings"},{"line_number":500,"context_line":"                  if binding.state \u003d\u003d constants.HA_ROUTER_STATE_ACTIVE]"},{"line_number":501,"context_line":"        dead_agents \u003d [a[0] for a in agents if not a[0].is_active]"},{"line_number":502,"context_line":"        for dead_agent in dead_agents:"},{"line_number":503,"context_line":"            self.update_routers_states("},{"line_number":504,"context_line":"                context, {router_id: constants.HA_ROUTER_STATE_STANDBY},"},{"line_number":505,"context_line":"                dead_agent.host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_237f4e67","line":502,"in_reply_to":"ba8a016a_2c16814c","updated":"2015-11-19 12:03:30.000000000","message":"Done","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":13667,"name":"ZongKai LI","email":"onionpiece@163.com","username":"lzklibj"},"change_message_id":"aef1270e561cb08c4739968aa478ff172f61b6f8","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        check \u003d self._check_for_active_dead_agents_for_router(context,"},{"line_number":514,"context_line":"                                                              router_id)"},{"line_number":515,"context_line":"        if check is None:"},{"line_number":516,"context_line":"            bindings \u003d self.get_ha_router_port_bindings(context, [router_id])"},{"line_number":517,"context_line":"        else:"},{"line_number":518,"context_line":"            bindings \u003d check"},{"line_number":519,"context_line":"        return [(binding.agent, binding.state) for binding in bindings"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0efcb970","line":516,"updated":"2015-11-19 03:19:48.000000000","message":"Why do we need call get_ha_router_port_bindings twice, but not make _check_* method return a binding list with dead agents have been kicked out.","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"507c3de702e944bcadbabdceb01bf49192d0442d","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        check \u003d self._check_for_active_dead_agents_for_router(context,"},{"line_number":514,"context_line":"                                                              router_id)"},{"line_number":515,"context_line":"        if check is None:"},{"line_number":516,"context_line":"            bindings \u003d self.get_ha_router_port_bindings(context, [router_id])"},{"line_number":517,"context_line":"        else:"},{"line_number":518,"context_line":"            bindings \u003d check"},{"line_number":519,"context_line":"        return [(binding.agent, binding.state) for binding in bindings"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_6389d674","line":516,"in_reply_to":"ba8a016a_0efcb970","updated":"2015-11-19 12:03:30.000000000","message":"So, it will be called twice in _check_* in that way. Will update in next patch set.","commit_id":"38b9ff676a05ec4cc90a58d8578abf6cc42b4060"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"29e2118f0d409a370ff51064dde36707bd061bb4","unresolved":false,"context_lines":[{"line_number":505,"context_line":"            for dead_agent in dead_agents:"},{"line_number":506,"context_line":"                self.update_routers_states("},{"line_number":507,"context_line":"                    context, {router_id: constants.HA_ROUTER_STATE_STANDBY},"},{"line_number":508,"context_line":"                    dead_agent.host)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        if dead_agents:"},{"line_number":511,"context_line":"            return self.get_ha_router_port_bindings(context, [router_id])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_6974d7ce","line":508,"updated":"2015-12-10 06:52:00.000000000","message":"I am afraid it will not reflect the true keepalived state","commit_id":"fc514b8e71d6ba7a1541ff925c63becf8834f6f5"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"a5ad763d09a3df3a1aa1b048dff91f6ac47ed6ea","unresolved":false,"context_lines":[{"line_number":505,"context_line":"            for dead_agent in dead_agents:"},{"line_number":506,"context_line":"                self.update_routers_states("},{"line_number":507,"context_line":"                    context, {router_id: constants.HA_ROUTER_STATE_STANDBY},"},{"line_number":508,"context_line":"                    dead_agent.host)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"        if dead_agents:"},{"line_number":511,"context_line":"            return self.get_ha_router_port_bindings(context, [router_id])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_14176aee","line":508,"in_reply_to":"7a740942_6974d7ce","updated":"2015-12-10 07:09:30.000000000","message":"True keepalived state already handled. This is more cosmetic fix, not to disturb operators, when they see two active agent when one of them is dead with l3-agent-list-hosting-router. See comments from Assaf in the bug description.","commit_id":"fc514b8e71d6ba7a1541ff925c63becf8834f6f5"}]}
