)]}'
{"neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6779be64d944f876982395a633e6412af363906a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            return True"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            return False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_vif_type(self):"},{"line_number":45,"context_line":"        return portbindings.VIF_TYPE_VHOST_USER"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1fa8738c","line":43,"updated":"2015-11-18 19:26:20.000000000","message":"ti would be cleaner to set self.vif_type\nand self.vif_details in the init. and have the base class provide a default implementation of get_vif_type and get_vif_details see my comment on the next file.","commit_id":"0995f01aba2aceb9f78567effac140c0d9b500ac"},{"author":{"_account_id":13869,"name":"Maxime Leroy","email":"maxime.leroy@6wind.com","username":"mleroy"},"change_message_id":"687f362d3e9fea4a7a4c96c5cbb1513273f0529b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            return True"},{"line_number":41,"context_line":"        else:"},{"line_number":42,"context_line":"            return False"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_vif_type(self):"},{"line_number":45,"context_line":"        return portbindings.VIF_TYPE_VHOST_USER"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_bfc90a5b","line":43,"in_reply_to":"ba8a016a_1fa8738c","updated":"2015-11-19 11:08:15.000000000","message":"Right for the vif_type.\n\nThe vif_details needs to be generated dynamically in function of the information in the agent and in the context.","commit_id":"0995f01aba2aceb9f78567effac140c0d9b500ac"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6779be64d944f876982395a633e6412af363906a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            constants.AGENT_TYPE_OVS,"},{"line_number":79,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":80,"context_line":"            vif_details)"},{"line_number":81,"context_line":"        self.add_vif_driver(DpdkOvsVIFDriver())"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def get_allowed_network_types(self, agent):"},{"line_number":84,"context_line":"        return (agent[\u0027configurations\u0027].get(\u0027tunnel_types\u0027, []) +"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_3c046516","line":81,"updated":"2015-11-18 19:26:20.000000000","message":"ovs from openvswich.org also support 2 other addtional northbound interface types dpdkvhostcuse(deprecated in favor of dpdkvhostuser but support qemu version \u003c2.0) and dpdkr(ivshmem)\n\nso the name should be something like OvsVhostUserVIFDriver as dpdkr support or some other interface type not currently implemented in ovs could be added.","commit_id":"0995f01aba2aceb9f78567effac140c0d9b500ac"},{"author":{"_account_id":13869,"name":"Maxime Leroy","email":"maxime.leroy@6wind.com","username":"mleroy"},"change_message_id":"687f362d3e9fea4a7a4c96c5cbb1513273f0529b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"            constants.AGENT_TYPE_OVS,"},{"line_number":79,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":80,"context_line":"            vif_details)"},{"line_number":81,"context_line":"        self.add_vif_driver(DpdkOvsVIFDriver())"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def get_allowed_network_types(self, agent):"},{"line_number":84,"context_line":"        return (agent[\u0027configurations\u0027].get(\u0027tunnel_types\u0027, []) +"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_ff37924a","line":81,"in_reply_to":"ba8a016a_3c046516","updated":"2015-11-19 11:08:15.000000000","message":"I would prefer OvsDPDKVhostUserVIFDriver.\n\nBecause we could need to add later the support for OvsFPVhostUserVIFDriver.","commit_id":"0995f01aba2aceb9f78567effac140c0d9b500ac"}],"neutron/plugins/ml2/drivers/vif_driver.py":[{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6779be64d944f876982395a633e6412af363906a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def __init__(self, vif_type, vif_details):"},{"line_number":41,"context_line":"        self.vif_type \u003d vif_type"},{"line_number":42,"context_line":"        self.vif_details \u003d vif_details"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_vif_type(self):"},{"line_number":45,"context_line":"        return self.vif_type"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_7f741f67","line":43,"updated":"2015-11-18 19:26:20.000000000","message":"why not have the default class return self.vif_type","commit_id":"0995f01aba2aceb9f78567effac140c0d9b500ac"},{"author":{"_account_id":13869,"name":"Maxime Leroy","email":"maxime.leroy@6wind.com","username":"mleroy"},"change_message_id":"687f362d3e9fea4a7a4c96c5cbb1513273f0529b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def __init__(self, vif_type, vif_details):"},{"line_number":41,"context_line":"        self.vif_type \u003d vif_type"},{"line_number":42,"context_line":"        self.vif_details \u003d vif_details"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_vif_type(self):"},{"line_number":45,"context_line":"        return self.vif_type"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_9fe9a6e8","line":43,"in_reply_to":"ba8a016a_7f741f67","updated":"2015-11-19 11:08:15.000000000","message":"Right. It should be move into the abstract class.","commit_id":"0995f01aba2aceb9f78567effac140c0d9b500ac"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"6779be64d944f876982395a633e6412af363906a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_vif_type(self):"},{"line_number":45,"context_line":"        return self.vif_type"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_vif_details(self, agent, context):"},{"line_number":48,"context_line":"        return self.vif_details"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1f0cf3eb","line":46,"updated":"2015-11-18 19:26:20.000000000","message":"again this could be a no op if the default class return self.vif_details","commit_id":"0995f01aba2aceb9f78567effac140c0d9b500ac"},{"author":{"_account_id":13869,"name":"Maxime Leroy","email":"maxime.leroy@6wind.com","username":"mleroy"},"change_message_id":"687f362d3e9fea4a7a4c96c5cbb1513273f0529b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_vif_type(self):"},{"line_number":45,"context_line":"        return self.vif_type"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_vif_details(self, agent, context):"},{"line_number":48,"context_line":"        return self.vif_details"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_bfe6ea12","line":46,"in_reply_to":"ba8a016a_1f0cf3eb","updated":"2015-11-19 11:08:15.000000000","message":"The get_vif_details can be generated in function of agent and context like for the dpdk vhostuser.\n\nHaving an attribute vif_details in the abstact class, mean this one is static. And can not be generated dynamically.","commit_id":"0995f01aba2aceb9f78567effac140c0d9b500ac"}]}
