)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5d2bae93dca1a0c6f368dd86108512d57edf911d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ravi Shekhar Jethani \u003cravishekar.jethani@nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-11 01:15:53 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplified boolean variable check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently \u0027flows\u0027 is being checked for empty list in"},{"line_number":10,"context_line":"a non standard way \u0027if flows \u003d\u003d []:\u0027. This patch"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa69d971_308ecc2e","line":7,"updated":"2016-01-11 12:35:04.000000000","message":"Please prefix with ML2 (when I saw the commit message i thought is was about the API validations)","commit_id":"bbeea820cc5b157e6ec65698856768dd5db39a48"},{"author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"change_message_id":"8d8cea8fd4f8d4d482582d35fa1be84ffd7519a0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ravi Shekhar Jethani \u003cravishekar.jethani@nttdata.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-01-11 01:15:53 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Simplified boolean variable check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently \u0027flows\u0027 is being checked for empty list in"},{"line_number":10,"context_line":"a non standard way \u0027if flows \u003d\u003d []:\u0027. This patch"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa69d971_40be0baf","line":7,"in_reply_to":"fa69d971_308ecc2e","updated":"2016-01-11 13:26:42.000000000","message":"Done","commit_id":"bbeea820cc5b157e6ec65698856768dd5db39a48"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_int.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"afee55432d98ce76f71ad50c0b81c8d21c436aa6","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def check_canary_table(self):"},{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            flows \u003d self.dump_flows(constants.CANARY_TABLE)"},{"line_number":51,"context_line":"        except RuntimeError:"},{"line_number":52,"context_line":"            LOG.exception(_LE(\"Failed to communicate with the switch\"))"},{"line_number":53,"context_line":"            return constants.OVS_DEAD"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_c9ec4a2c","line":50,"updated":"2016-01-06 09:07:07.000000000","message":"let\u0027s simplify this a bit more since you\u0027re changing it. right here you can put:\n\n    return constants.OVS_NORMAL if flows else constants.OVS_RESTARTED\n\nthen you can get rid of L54-56","commit_id":"57992b2bab0eecea04b877eedc48aad0d12eda01"},{"author":{"_account_id":18494,"name":"Ravi Shekhar Jethani","email":"rsjethani@gmail.com","username":"rsjethani"},"change_message_id":"2857fd7c25703f112098bd60623f094709710dd0","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def check_canary_table(self):"},{"line_number":49,"context_line":"        try:"},{"line_number":50,"context_line":"            flows \u003d self.dump_flows(constants.CANARY_TABLE)"},{"line_number":51,"context_line":"        except RuntimeError:"},{"line_number":52,"context_line":"            LOG.exception(_LE(\"Failed to communicate with the switch\"))"},{"line_number":53,"context_line":"            return constants.OVS_DEAD"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa69d971_482882e2","line":50,"in_reply_to":"fa69d971_c9ec4a2c","updated":"2016-01-11 09:11:06.000000000","message":"Thanks for the input Kevin!!!\nIMO a \u0027return\u0027 inside a \u0027try\u0027 is not OK. So I will take your simplification but its better to keep it after try-except.","commit_id":"57992b2bab0eecea04b877eedc48aad0d12eda01"}]}
