)]}'
{"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0cc2d02a16cbb5e50b10b275e7c2c53d91f17a7a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"then"},{"line_number":48,"context_line":"    # enable the devstack plugin that will enable qos service, among other things"},{"line_number":49,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d\""},{"line_number":50,"context_line":"enable_plugin neutron git://git.openstack.org/openstack/neutron"},{"line_number":51,"context_line":"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba8a016a_e5f11502","line":50,"updated":"2015-11-20 00:30:27.000000000","message":"I am fine with this change, because as I see it, it should be about enabling Neutron core functionality. However, I am disappointed to see that we polluted this hook with stuff that doesn\u0027t pertain neutron core, lbaas and vpnaas.\n\nThis creates a coupling that we are so hard trying to get rid of :\u0027(\n\nSomeone should clean that up and slap the hand of who approved it :)","commit_id":"b967b4c3ea85efddc15a9c993688995b62c79d1c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5405ac6a9210c4821847bf07ed29585bd09303c0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"then"},{"line_number":48,"context_line":"    # enable the devstack plugin that will enable qos service, among other things"},{"line_number":49,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d\""},{"line_number":50,"context_line":"enable_plugin neutron git://git.openstack.org/openstack/neutron"},{"line_number":51,"context_line":"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba8a016a_fc368001","line":50,"in_reply_to":"ba8a016a_e5f11502","updated":"2015-11-20 09:25:00.000000000","message":"You want to require explicit enable_service qos for the plugin? I am fine with that.","commit_id":"b967b4c3ea85efddc15a9c993688995b62c79d1c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"108f85dc96711669be011c6d1a105a01e079319e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"then"},{"line_number":48,"context_line":"    # enable the devstack plugin that will enable qos service, among other things"},{"line_number":49,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d\""},{"line_number":50,"context_line":"enable_plugin neutron git://git.openstack.org/openstack/neutron"},{"line_number":51,"context_line":"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    $BASE/new/devstack-gate/devstack-vm-gate.sh"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba8a016a_57a685ae","line":50,"in_reply_to":"ba8a016a_fc368001","updated":"2015-11-20 09:38:53.000000000","message":"https://review.openstack.org/247990","commit_id":"b967b4c3ea85efddc15a9c993688995b62c79d1c"}]}