)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10453,"name":"octopuszhang","email":"zhangyf@rc.inesa.com","username":"1"},"change_message_id":"befe78267f79494e14038e2a89dd84beaea8cd52","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ramu Ramamurthy \u003cramu.ramamurthy@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-19 21:02:29 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"db_get_val can return None if the port got deleted concurrently."},{"line_number":8,"context_line":"In this case there is no need to mark it dead and add drop flow for it."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I5ef9665770df3a9bbaf79049b219fadd73e20309"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_e3c90327","line":7,"updated":"2015-11-20 08:14:22.000000000","message":"There should be a new line","commit_id":"74b33850ebc3624501b8b9907548424eb6af09a6"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"7764fa5b86a8d249be0001a613031db263627bb3","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        with mock.patch.object(self.agent, \u0027int_br\u0027) as int_br:"},{"line_number":313,"context_line":"            int_br.db_get_val.return_value \u003d cur_tag"},{"line_number":314,"context_line":"            self.agent.port_dead(port)"},{"line_number":315,"context_line":"        if cur_tag is None:"},{"line_number":316,"context_line":"            self.assertFalse(int_br.set_db_attribute.called)"},{"line_number":317,"context_line":"            self.assertFalse(int_br.drop_port.called)"},{"line_number":318,"context_line":"        elif cur_tag \u003d\u003d self.mod_agent.DEAD_VLAN_TAG:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_f63458fc","line":315,"range":{"start_line":315,"start_character":11,"end_line":315,"end_character":26},"updated":"2015-11-20 11:11:35.000000000","message":"I think, in this case it\u0027s better to use:\n\n    if cur_tag is None or cur_tag \u003d\u003d self.mod_agent.DEAD_VLAN_TAG","commit_id":"74b33850ebc3624501b8b9907548424eb6af09a6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"c1eb86058cd3c71b48fff587d7be79f0123bfae7","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            self.assertFalse(int_br.set_db_attribute.called)"},{"line_number":317,"context_line":"            self.assertFalse(int_br.drop_port.called)"},{"line_number":318,"context_line":"        else:"},{"line_number":319,"context_line":"            int_br.assert_has_calls(["},{"line_number":320,"context_line":"                mock.call.set_db_attribute(\"Port\", mock.ANY, \"tag\","},{"line_number":321,"context_line":"                                           self.mod_agent.DEAD_VLAN_TAG,"},{"line_number":322,"context_line":"                                           log_errors\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_902ebef8","line":319,"updated":"2015-11-24 01:28:22.000000000","message":"We miss a test for this.","commit_id":"efd046eb754362d8916026ad0cbf8a495a69c933"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"97305d8cd096a055a95287e821af50a9aeeb9e88","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            self.assertFalse(int_br.set_db_attribute.called)"},{"line_number":317,"context_line":"            self.assertFalse(int_br.drop_port.called)"},{"line_number":318,"context_line":"        else:"},{"line_number":319,"context_line":"            int_br.assert_has_calls(["},{"line_number":320,"context_line":"                mock.call.set_db_attribute(\"Port\", mock.ANY, \"tag\","},{"line_number":321,"context_line":"                                           self.mod_agent.DEAD_VLAN_TAG,"},{"line_number":322,"context_line":"                                           log_errors\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_c1782e2e","line":319,"in_reply_to":"9a8ffd7b_9da07e92","updated":"2015-11-25 12:26:57.000000000","message":"I mean your patch loses a case which \"else\" happens because this method is called by test_port_dead and test_port_dead_with_port_already_dead. These tests passes cur_tag \u003d None or self.mod_agent.DEAD_VLAN_TAG so else case never happens.","commit_id":"efd046eb754362d8916026ad0cbf8a495a69c933"},{"author":{"_account_id":12959,"name":"Ramu Ramamurthy","email":"ramu.ramamurthy@us.ibm.com","username":"ramu.ramamurthy"},"change_message_id":"2f1437298bd386ebc9b1e627bafef3254d21a793","unresolved":false,"context_lines":[{"line_number":316,"context_line":"            self.assertFalse(int_br.set_db_attribute.called)"},{"line_number":317,"context_line":"            self.assertFalse(int_br.drop_port.called)"},{"line_number":318,"context_line":"        else:"},{"line_number":319,"context_line":"            int_br.assert_has_calls(["},{"line_number":320,"context_line":"                mock.call.set_db_attribute(\"Port\", mock.ANY, \"tag\","},{"line_number":321,"context_line":"                                           self.mod_agent.DEAD_VLAN_TAG,"},{"line_number":322,"context_line":"                                           log_errors\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_9da07e92","line":319,"in_reply_to":"ba8a016a_902ebef8","updated":"2015-11-24 15:14:02.000000000","message":"can you provide further details on whats missing, so, that can be added ? My code change only relates to the case when cur_tag is None. This else clause is code which my change does not affect.","commit_id":"efd046eb754362d8916026ad0cbf8a495a69c933"}]}
