)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f0c009a8f6ac3676d060586101248e30d77ca656","unresolved":false,"context_lines":[{"line_number":7,"context_line":"(WIP) Make MetadataProxyHandler configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make MetadataProxyHandler configurable through metadata_agent.ini."},{"line_number":10,"context_line":"Thus vendors can have their own customized MetadataProxyHandler."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also add get_subnets function in MetadataPluginAPI class."},{"line_number":13,"context_line":"So it can be used by MetadataProxyHandler to search subnets"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a8ffd7b_eb4a1527","line":10,"updated":"2015-11-30 23:14:52.000000000","message":"Would you mind specify what the motification for this is? Is there something missing in the existing code that you need a custom handler for?","commit_id":"1644755ca763efbd8af8354dbef4641000f266c8"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"8de4ca2101fcc82b7a005c01da04c4b803fe0fe7","unresolved":false,"context_lines":[{"line_number":7,"context_line":"(WIP) Make MetadataProxyHandler configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Make MetadataProxyHandler configurable through metadata_agent.ini."},{"line_number":10,"context_line":"Thus vendors can have their own customized MetadataProxyHandler."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also add get_subnets function in MetadataPluginAPI class."},{"line_number":13,"context_line":"So it can be used by MetadataProxyHandler to search subnets"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a8ffd7b_cb1631f1","line":10,"in_reply_to":"9a8ffd7b_eb4a1527","updated":"2015-11-30 23:18:50.000000000","message":"Here is an example (WIP):\n\nhttps://review.openstack.org/#/c/247298/\n\nwhere we need do extra search for DHCP-disabled subnets.","commit_id":"1644755ca763efbd8af8354dbef4641000f266c8"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"f0c009a8f6ac3676d060586101248e30d77ca656","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Make MetadataProxyHandler configurable through metadata_agent.ini."},{"line_number":10,"context_line":"Thus vendors can have their own customized MetadataProxyHandler."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also add get_subnets function in MetadataPluginAPI class."},{"line_number":13,"context_line":"So it can be used by MetadataProxyHandler to search subnets"},{"line_number":14,"context_line":"via plugin RPC."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a8ffd7b_cb5151da","line":12,"updated":"2015-11-30 23:14:52.000000000","message":"why is this needed?","commit_id":"1644755ca763efbd8af8354dbef4641000f266c8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c98ca023fc4412fd936c2a91a5e7c02953146289","unresolved":false,"context_lines":[{"line_number":13,"context_line":"associated RPC unit test. The new method can be used by extended"},{"line_number":14,"context_line":"MetadataProxyHandler classes to search subnets via plugin RPC."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact"},{"line_number":17,"context_line":"UpgradeImpact"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-bug: #1518402"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a740942_68770603","line":16,"updated":"2015-12-04 01:12:45.000000000","message":"Please follow guidelines as detailed here:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-November/080294.html","commit_id":"c002ed40b580860060da2b7b6b6c57c491275d1b"}],"neutron/agent/metadata/agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"38d912ca861a33fc444da2d1c9c46e19b730d3fa","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        cctxt \u003d self.client.prepare()"},{"line_number":71,"context_line":"        return cctxt.call(context, \u0027get_ports\u0027, filters\u003dfilters)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_subnets(self, context, filters):"},{"line_number":74,"context_line":"        cctxt \u003d self.client.prepare()"},{"line_number":75,"context_line":"        return cctxt.call(context, \u0027get_subnets\u0027, filters\u003dfilters)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_19704fa3","line":73,"updated":"2015-11-29 08:01:03.000000000","message":"i think that this requires a bump in the version number","commit_id":"a451c2a9df2b38bc5c1282ea98f5818532933f7f"}],"neutron/agent/metadata/config.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e8ae729cbc231712c5964e389e1ed0a43bde5e30","unresolved":false,"context_lines":[{"line_number":48,"context_line":"]"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"METADATA_DRIVER \u003d \u0027neutron.agent.metadata.agent.MetadataProxyHandler\u0027"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"METADATA_PROXY_HANDLER_OPTS \u003d ["},{"line_number":54,"context_line":"     cfg.StrOpt(\u0027auth_ca_cert\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_5276a906","line":51,"updated":"2015-11-30 04:37:15.000000000","message":"Call it \"DEFAULT_****\" might be better.","commit_id":"a451c2a9df2b38bc5c1282ea98f5818532933f7f"}],"neutron/tests/unit/agent/metadata/test_agent.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e8ae729cbc231712c5964e389e1ed0a43bde5e30","unresolved":false,"context_lines":[{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    @mock.patch.object(utils, \u0027ensure_dir\u0027)"},{"line_number":434,"context_line":"    def test_init_doesnot_exists(self, ensure_dir):"},{"line_number":435,"context_line":"        self._mock_metadata_proxy()"},{"line_number":436,"context_line":"        ensure_dir.assert_called_once_with(\u0027/the\u0027)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def test_init_exists(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_957abbbb","line":435,"updated":"2015-11-30 04:37:15.000000000","message":"I think you don\u0027t need to use the new method here. Just \n\nagent.UnixDomainMetadataProxy(self.cfg.CONF)\n\nwould be fine.","commit_id":"a451c2a9df2b38bc5c1282ea98f5818532933f7f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e8ae729cbc231712c5964e389e1ed0a43bde5e30","unresolved":false,"context_lines":[{"line_number":439,"context_line":"        with mock.patch(\u0027os.path.isdir\u0027) as isdir:"},{"line_number":440,"context_line":"            with mock.patch(\u0027os.unlink\u0027) as unlink:"},{"line_number":441,"context_line":"                isdir.return_value \u003d True"},{"line_number":442,"context_line":"                self._mock_metadata_proxy()"},{"line_number":443,"context_line":"                unlink.assert_called_once_with(\u0027/the/path\u0027)"},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def test_init_exists_unlink_no_file(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_b5757fcb","line":442,"updated":"2015-11-30 04:37:15.000000000","message":"ditto","commit_id":"a451c2a9df2b38bc5c1282ea98f5818532933f7f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e8ae729cbc231712c5964e389e1ed0a43bde5e30","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                    exists.return_value \u003d False"},{"line_number":451,"context_line":"                    unlink.side_effect \u003d OSError"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"                    self._mock_metadata_proxy()"},{"line_number":454,"context_line":"                    unlink.assert_called_once_with(\u0027/the/path\u0027)"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    def test_init_exists_unlink_fails_file_still_exists(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_5580d38a","line":453,"updated":"2015-11-30 04:37:15.000000000","message":"ditto","commit_id":"a451c2a9df2b38bc5c1282ea98f5818532933f7f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e8ae729cbc231712c5964e389e1ed0a43bde5e30","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                    unlink.side_effect \u003d OSError"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"                    with testtools.ExpectedException(OSError):"},{"line_number":465,"context_line":"                        self._mock_metadata_proxy()"},{"line_number":466,"context_line":"                    unlink.assert_called_once_with(\u0027/the/path\u0027)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    @mock.patch.object(agent, \u0027MetadataProxyHandler\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_154d6b99","line":465,"updated":"2015-11-30 04:37:15.000000000","message":"ditto","commit_id":"a451c2a9df2b38bc5c1282ea98f5818532933f7f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e8ae729cbc231712c5964e389e1ed0a43bde5e30","unresolved":false,"context_lines":[{"line_number":496,"context_line":""},{"line_number":497,"context_line":"    def test_init_state_reporting(self):"},{"line_number":498,"context_line":"        with mock.patch(\u0027os.makedirs\u0027):"},{"line_number":499,"context_line":"            proxy \u003d self._mock_metadata_proxy()"},{"line_number":500,"context_line":"            self.looping_mock.assert_called_once_with(proxy._report_state)"},{"line_number":501,"context_line":"            self.looping_mock.return_value.start.assert_called_once_with("},{"line_number":502,"context_line":"                interval\u003dmock.ANY)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_3550af31","line":499,"updated":"2015-11-30 04:37:15.000000000","message":"ditto","commit_id":"a451c2a9df2b38bc5c1282ea98f5818532933f7f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"e8ae729cbc231712c5964e389e1ed0a43bde5e30","unresolved":false,"context_lines":[{"line_number":504,"context_line":"    def test_report_state(self):"},{"line_number":505,"context_line":"        with mock.patch(\u0027neutron.agent.rpc.PluginReportStateAPI\u0027) as state_api:"},{"line_number":506,"context_line":"            with mock.patch(\u0027os.makedirs\u0027):"},{"line_number":507,"context_line":"                proxy \u003d self._mock_metadata_proxy()"},{"line_number":508,"context_line":"                self.assertTrue(proxy.agent_state[\u0027start_flag\u0027])"},{"line_number":509,"context_line":"                proxy._report_state()"},{"line_number":510,"context_line":"                self.assertNotIn(\u0027start_flag\u0027, proxy.agent_state)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d5428367","line":507,"updated":"2015-11-30 04:37:15.000000000","message":"ditto","commit_id":"a451c2a9df2b38bc5c1282ea98f5818532933f7f"}],"neutron/tests/unit/api/rpc/handlers/test_metadata_rpc.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"085a80fb968950f9b5cf803bdf17d6eb486b397b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def setUp(self):"},{"line_number":27,"context_line":"        super(TestMetadataRpcCallback, self).setUp()"},{"line_number":28,"context_line":"        self.setup_coreplugin(test_db_base_plugin_v2.DB_PLUGIN_KLASS)"},{"line_number":29,"context_line":"        self.plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":30,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":31,"context_line":"        self.callback \u003d metadata_rpc.MetadataRpcCallback()"},{"line_number":32,"context_line":"        self.network \u003d self._prepare_network()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_0f64efe2","line":29,"updated":"2015-12-02 08:18:00.000000000","message":"for the variable please consider using a _ prefix","commit_id":"c9a1d6dcf12890ceec26fa8d0b8ad3e617c43d2f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"085a80fb968950f9b5cf803bdf17d6eb486b397b","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def test_get_ports(self):"},{"line_number":65,"context_line":"        ports \u003d self.callback.get_ports(self.context, filters\u003dNone)"},{"line_number":66,"context_line":"        self.assertEqual(ports[0], self.port)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_get_subnets(self):"},{"line_number":69,"context_line":"        subnets \u003d self.callback.get_subnets(self.context, filters\u003dNone)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_4f5af72b","line":66,"updated":"2015-12-02 08:18:00.000000000","message":"in general the expected parameter should be the first one","commit_id":"c9a1d6dcf12890ceec26fa8d0b8ad3e617c43d2f"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"085a80fb968950f9b5cf803bdf17d6eb486b397b","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_get_subnets(self):"},{"line_number":69,"context_line":"        subnets \u003d self.callback.get_subnets(self.context, filters\u003dNone)"},{"line_number":70,"context_line":"        self.assertEqual(subnets[0], self.subnet)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_ef416b3a","line":70,"updated":"2015-12-02 08:18:00.000000000","message":"ditto","commit_id":"c9a1d6dcf12890ceec26fa8d0b8ad3e617c43d2f"}]}
