)]}'
{"neutron/common/utils.py":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6f967f7d10e4b57b13e6b1a6ec49f825761f661e","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    :param namespace: namespace where the alias is defined"},{"line_number":503,"context_line":"    :param name: alias or class name of the class to be loaded"},{"line_number":504,"context_line":"    :returns: class if calls can be loaded"},{"line_number":505,"context_line":"    :raises ImportError if class cannot be loaded"},{"line_number":506,"context_line":"    \"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    if not name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_9f42bf67","line":505,"updated":"2015-11-20 12:20:53.000000000","message":"Since you\u0027re following http://docs.openstack.org/developer/hacking/#docstrings, add the colon after :raises as well. Also add the blank line that should be between the one line summary and the body of the docstring.","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"08dd066ad4bdff27adf0e8e46245bb77b14ee719","unresolved":false,"context_lines":[{"line_number":502,"context_line":"    :param namespace: namespace where the alias is defined"},{"line_number":503,"context_line":"    :param name: alias or class name of the class to be loaded"},{"line_number":504,"context_line":"    :returns: class if calls can be loaded"},{"line_number":505,"context_line":"    :raises ImportError if class cannot be loaded"},{"line_number":506,"context_line":"    \"\"\""},{"line_number":507,"context_line":""},{"line_number":508,"context_line":"    if not name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_ddc34889","line":505,"in_reply_to":"ba8a016a_9f42bf67","updated":"2015-11-21 14:02:28.000000000","message":"Done","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"}],"neutron/db/dvr_mac_db.py":[{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"f51cc404a70b5c0a017bcc689972f65f8c57d947","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        :param context: rpc request context"},{"line_number":133,"context_line":"        :param host: host id to match and extract ports of interest"},{"line_number":134,"context_line":"        :param subnet: subnet id to match and extract ports of interest"},{"line_number":135,"context_line":"        :returns: a list of ports on the given subnet in the input host"},{"line_number":136,"context_line":"        \"\"\""},{"line_number":137,"context_line":"        # FIXME(vivek, salv-orlando): improve this query by adding the"},{"line_number":138,"context_line":"        # capability of filtering by binding:host_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1f024fb5","line":135,"updated":"2015-11-20 11:56:12.000000000","message":"It\u0027s not related change.\nFrom guidelines:\n\n    :returns: return_type -- description of the return value\n\nhere must be:\n\n    :returns: list -- Ports on the…","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"08dd066ad4bdff27adf0e8e46245bb77b14ee719","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        :param context: rpc request context"},{"line_number":133,"context_line":"        :param host: host id to match and extract ports of interest"},{"line_number":134,"context_line":"        :param subnet: subnet id to match and extract ports of interest"},{"line_number":135,"context_line":"        :returns: a list of ports on the given subnet in the input host"},{"line_number":136,"context_line":"        \"\"\""},{"line_number":137,"context_line":"        # FIXME(vivek, salv-orlando): improve this query by adding the"},{"line_number":138,"context_line":"        # capability of filtering by binding:host_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_9dbdc004","line":135,"in_reply_to":"ba8a016a_1f024fb5","updated":"2015-11-21 14:02:28.000000000","message":"Done","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6f967f7d10e4b57b13e6b1a6ec49f825761f661e","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        :param context: rpc request context"},{"line_number":133,"context_line":"        :param host: host id to match and extract ports of interest"},{"line_number":134,"context_line":"        :param subnet: subnet id to match and extract ports of interest"},{"line_number":135,"context_line":"        :returns: a list of ports on the given subnet in the input host"},{"line_number":136,"context_line":"        \"\"\""},{"line_number":137,"context_line":"        # FIXME(vivek, salv-orlando): improve this query by adding the"},{"line_number":138,"context_line":"        # capability of filtering by binding:host_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_4a8c977f","line":135,"in_reply_to":"ba8a016a_1f024fb5","updated":"2015-11-20 12:20:53.000000000","message":"It looks like either form is acceptable, the example gives two different versions of the returns line. But I agree if the return type is known, especially if there\u0027s some chance of ambiguity from reading the code, it would be nice to list it.","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"}],"neutron/ipam/drivers/neutrondb_ipam/db_api.py":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"926b6e1bc0965d296dee66986116b0754c3587ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba8a016a_5a4410b6","updated":"2015-11-23 15:34:50.000000000","message":"Did you intend to add the changes you\u0027ve made to db_api.py or did you mix commits? I think probably you should split out this change into a different commit, but if you really want to do it together you need to update your commit message. These changes go well beyond what\u0027s described in your commit message.","commit_id":"9fa6951cf0afbf912118930ecf8d0beda4625bf8"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"6a862fe23aeaf37d67585a4bd98cb6408a70aeed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba8a016a_73825602","in_reply_to":"ba8a016a_5a4410b6","updated":"2015-11-23 17:57:23.000000000","message":"I\u0027m really confused by this comment.  I only see s/:return:/:returns:/ in here.","commit_id":"9fa6951cf0afbf912118930ecf8d0beda4625bf8"}],"neutron/manager.py":[{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6f967f7d10e4b57b13e6b1a6ec49f825761f661e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        :param namespace: namespace where alias is defined"},{"line_number":136,"context_line":"        :param plugin_provider: plugin alias or class name"},{"line_number":137,"context_line":"        :returns: plugin that is loaded"},{"line_number":138,"context_line":"        :raises ImportError if fails to load plugin"},{"line_number":139,"context_line":"        \"\"\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_aa80a3f8","line":138,"updated":"2015-11-20 12:20:53.000000000","message":"Since you\u0027re following http://docs.openstack.org/developer/hacking/#docstrings, add the colon after :raises as well. Also add the blank line that should be between the one line summary and the body of the docstring.","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"08dd066ad4bdff27adf0e8e46245bb77b14ee719","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        :param namespace: namespace where alias is defined"},{"line_number":136,"context_line":"        :param plugin_provider: plugin alias or class name"},{"line_number":137,"context_line":"        :returns: plugin that is loaded"},{"line_number":138,"context_line":"        :raises ImportError if fails to load plugin"},{"line_number":139,"context_line":"        \"\"\""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_5da0b8a5","line":138,"in_reply_to":"ba8a016a_aa80a3f8","updated":"2015-11-21 14:02:28.000000000","message":"Done","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"6f967f7d10e4b57b13e6b1a6ec49f825761f661e","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def _load_service_plugins(self):"},{"line_number":165,"context_line":"        \"\"\"Loads service plugins."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        Starts from the core plugin and checks if it supports"},{"line_number":168,"context_line":"        advanced services then loads classes provided in configuration."},{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        # load services from the core plugin first"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_cab3a7e8","line":167,"updated":"2015-11-20 12:20:53.000000000","message":"Can you go ahead and add\n\n :raises: ValueError\n\nhere","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"08dd066ad4bdff27adf0e8e46245bb77b14ee719","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def _load_service_plugins(self):"},{"line_number":165,"context_line":"        \"\"\"Loads service plugins."},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        Starts from the core plugin and checks if it supports"},{"line_number":168,"context_line":"        advanced services then loads classes provided in configuration."},{"line_number":169,"context_line":"        \"\"\""},{"line_number":170,"context_line":"        # load services from the core plugin first"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_9dc70064","line":167,"in_reply_to":"ba8a016a_cab3a7e8","updated":"2015-11-21 14:02:28.000000000","message":"Done","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"}],"neutron/quota/resource_registry.py":[{"author":{"_account_id":14615,"name":"Sergey Belous","email":"belous.py@gmail.com","username":"sbelous"},"change_message_id":"f51cc404a70b5c0a017bcc689972f65f8c57d947","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \"\"\"Find out if a resource if tracked or not."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        :param resource_name: name of the resource."},{"line_number":205,"context_line":"        :returns: True if resource_name is registered and tracked, otherwise"},{"line_number":206,"context_line":"                 False. Please note that here when False it returned it"},{"line_number":207,"context_line":"                 simply means that resource_name is not a TrackedResource"},{"line_number":208,"context_line":"                 instance, it does not necessarily mean that the resource"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_ff92eb4a","line":205,"updated":"2015-11-20 11:56:12.000000000","message":"It looks like some problems with indentation in L206-L209","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"},{"author":{"_account_id":18785,"name":"Bo Chi","email":"bochi@tethrnet.com","username":"bochi"},"change_message_id":"08dd066ad4bdff27adf0e8e46245bb77b14ee719","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        \"\"\"Find out if a resource if tracked or not."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        :param resource_name: name of the resource."},{"line_number":205,"context_line":"        :returns: True if resource_name is registered and tracked, otherwise"},{"line_number":206,"context_line":"                 False. Please note that here when False it returned it"},{"line_number":207,"context_line":"                 simply means that resource_name is not a TrackedResource"},{"line_number":208,"context_line":"                 instance, it does not necessarily mean that the resource"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_fdf40c88","line":205,"in_reply_to":"ba8a016a_ff92eb4a","updated":"2015-11-21 14:02:28.000000000","message":"Done","commit_id":"fe2a6ad58a2342a27e83c1368d6b0ee1c7b974f6"}]}
