)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d4d957a37823ece1e56a8473205e639dabe0361","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Remove the dependency between arp_responder and l2_pop."},{"line_number":10,"context_line":"In this change, existing arp_responder uses port_update and"},{"line_number":11,"context_line":"port_delete notifications to update arp entries for ports,"},{"line_number":12,"context_line":"instead of l2_pop."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"arp_responder functionality remains same i.e"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_25b86b29","line":12,"updated":"2015-12-09 09:17:22.000000000","message":"can you explain the rationale of switching from l2pop to the new mechanism?","commit_id":"47a6f52b1e4e7f7f1337fe35b74e5bdd78b6b31a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"455878f72dbd15f10fc4aef5667bd24f154c5633","unresolved":false,"context_lines":[{"line_number":36,"context_line":"ARP_RESPONDER table. When ARP spoofing is disbaled, ARP packets will be"},{"line_number":37,"context_line":"resubmitted from table 0 to ARP_RESPONDER table. When no ARP entry"},{"line_number":38,"context_line":"matches in ARP_RESPONDER table, packet will be flooded through NORMAL"},{"line_number":39,"context_line":"action in integration bridge."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"flows with arp responder and arp spoofing on br-int(i.e"},{"line_number":42,"context_line":"ovs-ofctl dump-flows br-int)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_bde2352d","line":39,"range":{"start_line":39,"start_character":7,"end_line":39,"end_character":8},"updated":"2016-04-14 17:19:21.000000000","message":"Add DocImpact with explaination","commit_id":"212f42f653bd2021023a32459d656157ea673e33"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"455878f72dbd15f10fc4aef5667bd24f154c5633","unresolved":false,"context_lines":[{"line_number":52,"context_line":"table\u003d24, priority\u003d2,arp,in_port\u003d2,arp_spa\u003d30.0.0.3 actions\u003dresubmit(,21)"},{"line_number":53,"context_line":"table\u003d24, priority\u003d0 actions\u003ddrop"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Closes-bug: #1518392"},{"line_number":56,"context_line":"Change-Id: I7b0a8f5971193265fe3fd6a91190f76c788270cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_5d7a0178","line":55,"updated":"2016-04-14 17:19:21.000000000","message":"This patch alone won\u0027t close the issue, at least this needs documentation and more testing,","commit_id":"212f42f653bd2021023a32459d656157ea673e33"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"455878f72dbd15f10fc4aef5667bd24f154c5633","unresolved":false,"context_lines":[{"line_number":53,"context_line":"table\u003d24, priority\u003d0 actions\u003ddrop"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Closes-bug: #1518392"},{"line_number":56,"context_line":"Change-Id: I7b0a8f5971193265fe3fd6a91190f76c788270cd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5a18252c_fdd66d4d","line":56,"updated":"2016-04-14 17:19:21.000000000","message":"This is probably worth a release note.","commit_id":"212f42f653bd2021023a32459d656157ea673e33"}],"neutron/plugins/ml2/drivers/l2pop/rpc_manager/l2population_rpc.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d4d957a37823ece1e56a8473205e639dabe0361","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        This method assumes that methods \u0027_fdb_\u003caction\u003e\u0027 are defined in class."},{"line_number":257,"context_line":"        Currently the following actions are available."},{"line_number":258,"context_line":"            chg_ip"},{"line_number":259,"context_line":"        \u0027\u0027\u0027"},{"line_number":260,"context_line":"        for action, values in fdb_entries.items():"},{"line_number":261,"context_line":"            method \u003d \u0027_fdb_\u0027 + action"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_920ac724","side":"PARENT","line":258,"updated":"2015-12-09 09:17:22.000000000","message":"chg_ip is used by linuxbridge as well.","commit_id":"205e8e4af9bd5b8ab10ead349ddce15c199be50b"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"3d152152a31e3d4aded260057fd52709d653eece","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    @log_helpers.log_method_call"},{"line_number":268,"context_line":"    def fdb_chg_ip_tun(self, context, br, fdb_entries, local_ip,"},{"line_number":269,"context_line":"                       local_vlan_map):"},{"line_number":270,"context_line":"        \u0027\u0027\u0027fdb update when an IP of a port is updated."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        The ML2 l2-pop mechanism driver sends an fdb update rpc message when an"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_caba6423","side":"PARENT","line":269,"updated":"2015-12-06 23:06:23.000000000","message":"Currently OFAgent agent[1] uses this method. Please leave this one.\n\n[1]http://git.openstack.org/cgit/openstack/networking-ofagent/tree/networking_ofagent/plugins/ofagent/agent/ofa_neutron_agent.py#n446","commit_id":"205e8e4af9bd5b8ab10ead349ddce15c199be50b"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"5595b76838eaec80976b856461194ffc966ac559","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    @log_helpers.log_method_call"},{"line_number":268,"context_line":"    def fdb_chg_ip_tun(self, context, br, fdb_entries, local_ip,"},{"line_number":269,"context_line":"                       local_vlan_map):"},{"line_number":270,"context_line":"        \u0027\u0027\u0027fdb update when an IP of a port is updated."},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        The ML2 l2-pop mechanism driver sends an fdb update rpc message when an"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_539d8cba","side":"PARENT","line":269,"in_reply_to":"7a740942_caba6423","updated":"2015-12-08 06:30:26.000000000","message":"Thanks fumihiko kakuma. Sure, I will do that.","commit_id":"205e8e4af9bd5b8ab10ead349ddce15c199be50b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0efbbc720022911370c6418ab3dcd7a6b25726e8","unresolved":false,"context_lines":[{"line_number":261,"context_line":"            if not hasattr(self, method):"},{"line_number":262,"context_line":"                raise NotImplementedError()"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"            getattr(self, method)(context, values)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_166cb633","line":264,"updated":"2016-01-06 13:22:08.000000000","message":"we also need to ensure that the server remains compatible with the previous version of the agent for upgrades so the server side L2pop code cannot be broken.","commit_id":"47a6f52b1e4e7f7f1337fe35b74e5bdd78b6b31a"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0d778df7762572746248ac3dabea708e77f6ac0a","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        # Even if full port details might be provided to this call,"},{"line_number":415,"context_line":"        # they are not used since there is no guarantee the notifications"},{"line_number":416,"context_line":"        # are processed in the same order as the relevant API requests"},{"line_number":417,"context_line":"        self.updated_ports.add(port[\u0027id\u0027])"},{"line_number":418,"context_line":"        LOG.debug(\"port_update message processed for port %s\", port[\u0027id\u0027])"},{"line_number":419,"context_line":"        # add or update arp entries for ports on other agent"},{"line_number":420,"context_line":"        if port[\u0027binding:host_id\u0027] !\u003d self.conf.host:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_24b6fc3d","line":417,"updated":"2015-11-21 20:01:44.000000000","message":"Should this be done at all?  Seems like we should just update arp and return at the beginning of the method.","commit_id":"61707da3b951f0a0944a59c83a1b45b01ea64fe7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0efbbc720022911370c6418ab3dcd7a6b25726e8","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        self.updated_ports.add(port[\u0027id\u0027])"},{"line_number":399,"context_line":"        LOG.debug(\"port_update message processed for port %s\", port[\u0027id\u0027])"},{"line_number":400,"context_line":"        # add or update arp entries for ports on other agent"},{"line_number":401,"context_line":"        if port[\u0027binding:host_id\u0027] !\u003d self.conf.host:"},{"line_number":402,"context_line":"            self.setup_arp_reply_for_port(port, orig_port)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def port_delete(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa69d971_b6760a04","line":401,"updated":"2016-01-06 13:22:08.000000000","message":"ack","commit_id":"47a6f52b1e4e7f7f1337fe35b74e5bdd78b6b31a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8c9da1eb6526ad1c290f4f4a3056dfcb9340e9c6","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        self.updated_ports.add(port[\u0027id\u0027])"},{"line_number":399,"context_line":"        LOG.debug(\"port_update message processed for port %s\", port[\u0027id\u0027])"},{"line_number":400,"context_line":"        # add or update arp entries for ports on other agent"},{"line_number":401,"context_line":"        if port[\u0027binding:host_id\u0027] !\u003d self.conf.host:"},{"line_number":402,"context_line":"            self.setup_arp_reply_for_port(port, orig_port)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def port_delete(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_f0fe556a","line":401,"updated":"2015-12-04 17:44:32.000000000","message":"this distinction seems unnecessary. we can just offload all ARP","commit_id":"47a6f52b1e4e7f7f1337fe35b74e5bdd78b6b31a"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"5595b76838eaec80976b856461194ffc966ac559","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        self.updated_ports.add(port[\u0027id\u0027])"},{"line_number":399,"context_line":"        LOG.debug(\"port_update message processed for port %s\", port[\u0027id\u0027])"},{"line_number":400,"context_line":"        # add or update arp entries for ports on other agent"},{"line_number":401,"context_line":"        if port[\u0027binding:host_id\u0027] !\u003d self.conf.host:"},{"line_number":402,"context_line":"            self.setup_arp_reply_for_port(port, orig_port)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def port_delete(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_b36710b6","line":401,"in_reply_to":"7a740942_f0fe556a","updated":"2015-12-08 06:30:26.000000000","message":"Thanks Kevin.\n\nThen unnecessarily we will be adding ARP entries which are not needed. As you know, if the ARP request is for the vm on same host, br-int will forward ARP requests directly to attached vms. So no need to add ARP entry in br-tun for such vms.","commit_id":"47a6f52b1e4e7f7f1337fe35b74e5bdd78b6b31a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8c9da1eb6526ad1c290f4f4a3056dfcb9340e9c6","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        self.updated_ports.discard(port_id)"},{"line_number":409,"context_line":"        LOG.debug(\"port_delete message processed for port %s\", port_id)"},{"line_number":410,"context_line":"        # delete arp entries for ports on other agent"},{"line_number":411,"context_line":"        if port[\u0027binding:host_id\u0027] !\u003d self.conf.host:"},{"line_number":412,"context_line":"            self.delete_arp_reply_for_port(port)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def network_update(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_10020170","line":411,"updated":"2015-12-04 17:44:32.000000000","message":"same here","commit_id":"47a6f52b1e4e7f7f1337fe35b74e5bdd78b6b31a"}],"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8c9da1eb6526ad1c290f4f4a3056dfcb9340e9c6","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":327,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dself.topic_port_delete,"},{"line_number":328,"context_line":"                                    fanout\u003dTrue, version\u003d\u00271.5\u0027)"},{"line_number":329,"context_line":"        cctxt.cast(context, \u0027port_delete\u0027, port_id\u003dport_id, port\u003dport)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def network_update(self, context, network):"},{"line_number":332,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dself.topic_network_update,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_50088991","line":329,"updated":"2015-12-04 17:44:32.000000000","message":"we shouldn\u0027t need to do this. I would prefer a design where the agent keeps track of the port id to responder translations. That way the orig port doesn\u0027t need to be sent in the update or the delete case.","commit_id":"47a6f52b1e4e7f7f1337fe35b74e5bdd78b6b31a"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"5595b76838eaec80976b856461194ffc966ac559","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":327,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dself.topic_port_delete,"},{"line_number":328,"context_line":"                                    fanout\u003dTrue, version\u003d\u00271.5\u0027)"},{"line_number":329,"context_line":"        cctxt.cast(context, \u0027port_delete\u0027, port_id\u003dport_id, port\u003dport)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def network_update(self, context, network):"},{"line_number":332,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dself.topic_network_update,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_f3f838c5","line":329,"in_reply_to":"7a740942_50088991","updated":"2015-12-08 06:30:26.000000000","message":"sure, I will try that.","commit_id":"47a6f52b1e4e7f7f1337fe35b74e5bdd78b6b31a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"187cec888d350a1ab7ba34a3459facd17c9786e2","unresolved":false,"context_lines":[{"line_number":326,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":327,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dself.topic_port_delete,"},{"line_number":328,"context_line":"                                    fanout\u003dTrue, version\u003d\u00271.5\u0027)"},{"line_number":329,"context_line":"        cctxt.cast(context, \u0027port_delete\u0027, port_id\u003dport_id, port\u003dport)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"    def network_update(self, context, network):"},{"line_number":332,"context_line":"        cctxt \u003d self.client.prepare(topic\u003dself.topic_network_update,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_48a4ae49","line":329,"in_reply_to":"7a740942_50088991","updated":"2015-12-09 09:48:11.000000000","message":"what if the agent is rebooted? how will it keep track of the port?\n\nwhy do we need to pass the whole port down to the agent? what about just the data needed","commit_id":"47a6f52b1e4e7f7f1337fe35b74e5bdd78b6b31a"}]}
