)]}'
{"neutron/agent/ovsdb/impl_vsctl.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"42e05a8e2a70edccdea5c3b45c0e388cfaed2777","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except Exception:"},{"line_number":65,"context_line":"            with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":66,"context_line":"                if self.log_errors:"},{"line_number":67,"context_line":"                    LOG.error(_LE(\"Unable to execute %(cmd)s.\"),"},{"line_number":68,"context_line":"                              {\u0027cmd\u0027: full_args})"},{"line_number":69,"context_line":"                if not self.check_error:"},{"line_number":70,"context_line":"                    ctxt.reraise \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_038395cd","line":67,"updated":"2015-11-23 11:37:36.000000000","message":"Could you include the exception message to the log message?\nWe can know the reason of the failure.","commit_id":"e4effb9c1f8f0267c4802ad04ff308f454aa7674"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20de933e670606c1e285e0d85bc285bf520eff0d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except Exception:"},{"line_number":65,"context_line":"            with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":66,"context_line":"                if self.log_errors:"},{"line_number":67,"context_line":"                    LOG.error(_LE(\"Unable to execute %(cmd)s.\"),"},{"line_number":68,"context_line":"                              {\u0027cmd\u0027: full_args})"},{"line_number":69,"context_line":"                if not self.check_error:"},{"line_number":70,"context_line":"                    ctxt.reraise \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_c314a64e","line":67,"in_reply_to":"ba8a016a_038395cd","updated":"2015-11-23 13:50:20.000000000","message":"Done","commit_id":"e4effb9c1f8f0267c4802ad04ff308f454aa7674"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"96597541f405ba25cb4ffbfd6ec00482a8f8389d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        except (ValueError, TypeError):"},{"line_number":123,"context_line":"            # This shouldn\u0027t happen, but if it does and we check_errors"},{"line_number":124,"context_line":"            # log and raise."},{"line_number":125,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":126,"context_line":"                LOG.error(_LE(\"Could not parse: %s\"), raw_result)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        headings \u003d json[\u0027headings\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1782f652","line":125,"range":{"start_line":125,"start_character":26,"end_line":125,"end_character":52},"updated":"2015-11-23 09:16:38.000000000","message":"Why do we need save_and_reraise_exception here?","commit_id":"e4effb9c1f8f0267c4802ad04ff308f454aa7674"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"42e05a8e2a70edccdea5c3b45c0e388cfaed2777","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        except (ValueError, TypeError):"},{"line_number":123,"context_line":"            # This shouldn\u0027t happen, but if it does and we check_errors"},{"line_number":124,"context_line":"            # log and raise."},{"line_number":125,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":126,"context_line":"                LOG.error(_LE(\"Could not parse: %s\"), raw_result)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        headings \u003d json[\u0027headings\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_e33a1134","line":125,"range":{"start_line":125,"start_character":26,"end_line":125,"end_character":52},"in_reply_to":"ba8a016a_1782f652","updated":"2015-11-23 11:37:36.000000000","message":"It is because eventlet switch can happen around logging calls.","commit_id":"e4effb9c1f8f0267c4802ad04ff308f454aa7674"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"42e05a8e2a70edccdea5c3b45c0e388cfaed2777","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            # This shouldn\u0027t happen, but if it does and we check_errors"},{"line_number":124,"context_line":"            # log and raise."},{"line_number":125,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":126,"context_line":"                LOG.error(_LE(\"Could not parse: %s\"), raw_result)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        headings \u003d json[\u0027headings\u0027]"},{"line_number":129,"context_line":"        data \u003d json[\u0027data\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_e368d123","line":126,"updated":"2015-11-23 11:37:36.000000000","message":"Could you include the exception message to the log message?\nWe can know the reason of the failure.","commit_id":"e4effb9c1f8f0267c4802ad04ff308f454aa7674"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"20de933e670606c1e285e0d85bc285bf520eff0d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            # This shouldn\u0027t happen, but if it does and we check_errors"},{"line_number":124,"context_line":"            # log and raise."},{"line_number":125,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":126,"context_line":"                LOG.error(_LE(\"Could not parse: %s\"), raw_result)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        headings \u003d json[\u0027headings\u0027]"},{"line_number":129,"context_line":"        data \u003d json[\u0027data\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0ee73541","line":126,"in_reply_to":"ba8a016a_e368d123","updated":"2015-11-23 13:50:20.000000000","message":"Done","commit_id":"e4effb9c1f8f0267c4802ad04ff308f454aa7674"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"bd2908dfa4b1bbde092e390236d47d241190cb1f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":66,"context_line":"                if self.log_errors:"},{"line_number":67,"context_line":"                    LOG.error(_LE(\"Unable to execute %(cmd)s. \""},{"line_number":68,"context_line":"                                  \"Exception: %(exception)s\"),"},{"line_number":69,"context_line":"                              {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":70,"context_line":"                if not self.check_error:"},{"line_number":71,"context_line":"                    ctxt.reraise \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_c766e428","line":68,"updated":"2015-11-23 17:04:40.000000000","message":"Are you sure this is right? I remember doing LOG.error and passing in the exception was specifically what we were *not* supposed to do and instead LOG.exception was to be used. I know I\u0027ve had review comments to specifically change these to LOG.exception in the past.","commit_id":"3858846770fcb51c2302abd4e5fdba1e12e663a7"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"7d132240ff77a5e435ec3341959d18d3f724aa05","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            with excutils.save_and_reraise_exception() as ctxt:"},{"line_number":66,"context_line":"                if self.log_errors:"},{"line_number":67,"context_line":"                    LOG.error(_LE(\"Unable to execute %(cmd)s. \""},{"line_number":68,"context_line":"                                  \"Exception: %(exception)s\"),"},{"line_number":69,"context_line":"                              {\u0027cmd\u0027: full_args, \u0027exception\u0027: e})"},{"line_number":70,"context_line":"                if not self.check_error:"},{"line_number":71,"context_line":"                    ctxt.reraise \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_53ab92d6","line":68,"in_reply_to":"ba8a016a_c766e428","updated":"2015-11-23 17:47:31.000000000","message":"According to the commit message, the point is that in this particular case, the trace does not provide anything useful.  This change includes the message from the exception but not the trace.\n\nIf the trace is useful to have in the log file, then I would say continue to use LOG.exception.","commit_id":"3858846770fcb51c2302abd4e5fdba1e12e663a7"}]}
