)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"59a2a84ecb509ab0582f226af2b4bc37f5acb266","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The fix is to use the function update_stale_ofport_rules which"},{"line_number":19,"context_line":"solves this problem of tracking stale ofport flows"},{"line_number":20,"context_line":"in deleted ports, but currently only applies only to"},{"line_number":21,"context_line":"prevent_arp_spoofing."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I0d1dbe3918cc7d7b3d0cdc49d7b6ff85f9b02a17"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a5de9d1_0baccc8a","line":20,"range":{"start_line":20,"start_character":32,"end_line":20,"end_character":36},"updated":"2016-01-29 19:50:10.000000000","message":"Delete, as another \"only\" is shortly to come! :)","commit_id":"5289d9494984b7c95407ad2f9b761b2e647953b2"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"0c5aa88a0f23eb0d33a7a1ba9921ffb6d81ac757","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"        for ofport in ofports_deleted:"},{"line_number":1179,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1180,"context_line":"                self.int_br.delete_arp_spoofing_protection(port\u003dofport)"},{"line_number":1181,"context_line":"            self.int_br.delete_flows(in_port\u003dofport)"},{"line_number":1182,"context_line":"        # store map for next iteration"},{"line_number":1183,"context_line":"        self.vifname_to_ofport_map \u003d current"},{"line_number":1184,"context_line":"        return moved_ports"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_cab9f516","line":1181,"updated":"2015-12-02 10:00:52.000000000","message":"instead of modifying this method can we do the flows deletion in port_unbound?","commit_id":"8473026399c901fa8b000378e176adbb755c2618"},{"author":{"_account_id":12959,"name":"Ramu Ramamurthy","email":"ramu.ramamurthy@us.ibm.com","username":"ramu.ramamurthy"},"change_message_id":"3071149b1807669d2b700dc8398576525870973b","unresolved":false,"context_lines":[{"line_number":1178,"context_line":"        for ofport in ofports_deleted:"},{"line_number":1179,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1180,"context_line":"                self.int_br.delete_arp_spoofing_protection(port\u003dofport)"},{"line_number":1181,"context_line":"            self.int_br.delete_flows(in_port\u003dofport)"},{"line_number":1182,"context_line":"        # store map for next iteration"},{"line_number":1183,"context_line":"        self.vifname_to_ofport_map \u003d current"},{"line_number":1184,"context_line":"        return moved_ports"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_573bcd9c","line":1181,"in_reply_to":"9a8ffd7b_cab9f516","updated":"2015-12-09 19:34:34.000000000","message":"In process_deleted_ports(), port_unbound() is called right after port_dead(), port_dead() adds the drop_flow, and puts the port on a dead-vlan. So, if we remove the drop_flow() in port_unbound(), then  there is no use of adding the drop flow in the first place.\n\nThe intention of having the drop flow is to discard all traffic from a port which has been deleted from the control plane - but the data plane may not have deleted it yet","commit_id":"8473026399c901fa8b000378e176adbb755c2618"},{"author":{"_account_id":17711,"name":"Margaret Frances","email":"margaret_frances@cable.comcast.com","username":"margaret-frances"},"change_message_id":"59a2a84ecb509ab0582f226af2b4bc37f5acb266","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"        # delete any stale rules based on removed ofports"},{"line_number":1137,"context_line":"        ofports_deleted \u003d set(previous.values()) - set(current.values())"},{"line_number":1138,"context_line":"        for ofport in ofports_deleted:"},{"line_number":1139,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1140,"context_line":"                self.int_br.delete_arp_spoofing_protection(port\u003dofport)"},{"line_number":1141,"context_line":"            self.int_br.delete_flows(in_port\u003dofport)"},{"line_number":1142,"context_line":"        # store map for next iteration"},{"line_number":1143,"context_line":"        self.vifname_to_ofport_map \u003d current"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a5de9d1_8e58ca8b","line":1140,"range":{"start_line":1139,"start_character":12,"end_line":1140,"end_character":71},"updated":"2016-01-29 19:50:10.000000000","message":"Are these 2 lines necessary?  Are they doing a subset of what line 1141 would do anyway?  For instance, in neutron/plugins/ml2/drivers/openvswitch/agent/openflow/ovs_ofctl/br_int.py we have:\n\n    def delete_arp_spoofing_protection(self, port):\n        self.delete_flows(table_id\u003dconstants.LOCAL_SWITCHING,\n                          in_port\u003dport, proto\u003d\u0027arp\u0027)\n        self.delete_flows(table_id\u003dconstants.LOCAL_SWITCHING,\n                          in_port\u003dport, nw_proto\u003dconst.PROTO_NUM_ICMP_V6,\n                          icmp_type\u003dconst.ICMPV6_TYPE_NA)\n        self.delete_arp_spoofing_allow_rules(port)\n\n    def delete_arp_spoofing_allow_rules(self, port):\n        self.delete_flows(table_id\u003dconstants.ARP_SPOOF_TABLE,\n                          in_port\u003dport)\n\nApologies if I\u0027m mis-reading things here.","commit_id":"5289d9494984b7c95407ad2f9b761b2e647953b2"},{"author":{"_account_id":12959,"name":"Ramu Ramamurthy","email":"ramu.ramamurthy@us.ibm.com","username":"ramu.ramamurthy"},"change_message_id":"828877a2326c42a26c27290a7a9b73c7c5b7ca13","unresolved":false,"context_lines":[{"line_number":1136,"context_line":"        # delete any stale rules based on removed ofports"},{"line_number":1137,"context_line":"        ofports_deleted \u003d set(previous.values()) - set(current.values())"},{"line_number":1138,"context_line":"        for ofport in ofports_deleted:"},{"line_number":1139,"context_line":"            if self.prevent_arp_spoofing:"},{"line_number":1140,"context_line":"                self.int_br.delete_arp_spoofing_protection(port\u003dofport)"},{"line_number":1141,"context_line":"            self.int_br.delete_flows(in_port\u003dofport)"},{"line_number":1142,"context_line":"        # store map for next iteration"},{"line_number":1143,"context_line":"        self.vifname_to_ofport_map \u003d current"}],"source_content_type":"text/x-python","patch_set":7,"id":"dae33548_6751e6d8","line":1140,"range":{"start_line":1139,"start_character":12,"end_line":1140,"end_character":71},"in_reply_to":"7a5de9d1_8e58ca8b","updated":"2016-02-19 00:32:36.000000000","message":"They are necessary because, line #1141 only deletes flows which matches the field \"in_port\u003dofport\"\n\nline #1141 may not delete the arp_spoofing flows","commit_id":"5289d9494984b7c95407ad2f9b761b2e647953b2"}],"neutron/tests/functional/agent/test_l2_ovs_agent.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"0944b6f0d694d984750d7a359b02b34c5525671a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # call port_delete first"},{"line_number":57,"context_line":"        for port in self.ports:"},{"line_number":58,"context_line":"            port_obj \u003d {\"port_id\": port[\"id\"]}"},{"line_number":59,"context_line":"            self.agent.port_delete([], **port_obj)"},{"line_number":60,"context_line":"        portnames \u003d [port[\"vif_name\"] for port in self.ports]"},{"line_number":61,"context_line":"        ofports \u003d [port.ofport for port in self.agent.int_br.get_vif_ports()"},{"line_number":62,"context_line":"                   if port.port_name in portnames]"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa69d971_887b8cbd","line":59,"updated":"2016-01-06 22:34:54.000000000","message":"You are creating a dict and then unpacking it right away as a keyword argument. This can be shorted to:\n\nself.agent.port_delete([], port_id\u003dport[\u0027id\u0027])","commit_id":"99a3efc3a3c62ff0c2d04a95065047c4c0687b02"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9a2e2de6e334ac18c8a3181884a56e11edd5cc02","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        self.wait_until_ports_state(self.ports, up\u003dFalse)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        #verify no stale drop flows"},{"line_number":77,"context_line":"        self.assertTrue("},{"line_number":78,"context_line":"            num_ports_with_drop_flows("},{"line_number":79,"context_line":"                ofports,"},{"line_number":80,"context_line":"                self.agent.int_br.dump_flows("}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_9adacbe8","line":77,"updated":"2016-01-16 06:07:31.000000000","message":"sorry, one more nit. Use self.assertEqual(0, num_ports_with_drop_flows(...))\n\nThat way if the test fails we don\u0027t get an opaque error \"False is not True\", but instead we will get the count of remaining ports with drop flows to make it easier to debug.","commit_id":"eb5d594b5b704e1034117481e656d45b635f3b0b"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"c8f949b661e762c0c3e35ff66bdfcb4fabfcb7b4","unresolved":false,"context_lines":[{"line_number":1595,"context_line":"            mock.call(in_port\u003d1)"},{"line_number":1596,"context_line":"        ]"},{"line_number":1597,"context_line":"        self.assertEqual(expected, self.agent.int_br.delete_flows.mock_calls)"},{"line_number":1598,"context_line":"        self.assertEqual(self.agent.vifname_to_ofport_map, newmap)"},{"line_number":1599,"context_line":"        self.assertFalse("},{"line_number":1600,"context_line":"            self.agent.int_br.delete_arp_spoofing_protection.called)"},{"line_number":1601,"context_line":"        self.assertEqual([], ofport_changed_ports)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_70c79a12","line":1598,"updated":"2015-11-24 01:50:50.000000000","message":"self.assertEqual(newmap, self.agent.vifname_to_ofport_map) according with assertEqual(expected, observed) rule.","commit_id":"dbba8ef05e0d221edb06335e3e5b598462675904"}]}
