)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1a2a5f3f2123ce2a58e79bf27573b88dde16cbeb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables extra_dhcp_opts on networks and subnets, with the"},{"line_number":10,"context_line":"required models and logic added to the dhcp agent driver for dnsmasq."},{"line_number":11,"context_line":"It also adds a new field, dhcp_allow_unknown_hosts to the Subnet model"},{"line_number":12,"context_line":"so that it is possible to enable unknown devices to be served by the"},{"line_number":13,"context_line":"neutron dnsmasq instance."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_9c29ff8b","line":11,"updated":"2015-11-23 23:03:43.000000000","message":"imo, this change should be splitted in 2 as dhcp_allow_unknown_hosts is unrelated to the BP","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables extra_dhcp_opts on networks and subnets, with the"},{"line_number":10,"context_line":"required models and logic added to the dhcp agent driver for dnsmasq."},{"line_number":11,"context_line":"It also adds a new field, dhcp_allow_unknown_hosts to the Subnet model"},{"line_number":12,"context_line":"so that it is possible to enable unknown devices to be served by the"},{"line_number":13,"context_line":"neutron dnsmasq instance."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_cd25eec2","line":11,"in_reply_to":"ba8a016a_9c29ff8b","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1a2a5f3f2123ce2a58e79bf27573b88dde16cbeb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"required models and logic added to the dhcp agent driver for dnsmasq."},{"line_number":11,"context_line":"It also adds a new field, dhcp_allow_unknown_hosts to the Subnet model"},{"line_number":12,"context_line":"so that it is possible to enable unknown devices to be served by the"},{"line_number":13,"context_line":"neutron dnsmasq instance."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If0dbeb58f3b88f06e89e54e73dc14f13f20c6b80"},{"line_number":16,"context_line":"Closes-Bug: #1512666"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_fcf92bc9","line":13,"updated":"2015-11-23 23:03:43.000000000","message":"I don\u0027t understand how it could work as dnsmasq is able to allocate an ip to an unknown device without neutron knowing it ... which means neutron can allocate this ip to someone else","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables extra_dhcp_opts on networks and subnets, with the"},{"line_number":10,"context_line":"required models and logic added to the dhcp agent driver for dnsmasq."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If0dbeb58f3b88f06e89e54e73dc14f13f20c6b80"},{"line_number":13,"context_line":"Partial-Bug: #1512666"},{"line_number":14,"context_line":"Implements: blueprint dhcp-options-per-subnet"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_fcbdcbd7","line":11,"updated":"2015-11-25 14:58:50.000000000","message":"Please add DocImpact here","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"30e86e6e05eb76248cf8f05d4c9dcb66db4c4207","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch enables extra_dhcp_opts on networks and subnets, with the"},{"line_number":10,"context_line":"required models and logic added to the dhcp agent driver for dnsmasq."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If0dbeb58f3b88f06e89e54e73dc14f13f20c6b80"},{"line_number":13,"context_line":"Partial-Bug: #1512666"},{"line_number":14,"context_line":"Implements: blueprint dhcp-options-per-subnet"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_76eae875","line":11,"in_reply_to":"9a8ffd7b_fcbdcbd7","updated":"2015-12-08 14:55:49.000000000","message":"Done","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3fe7b01fd6511f424b207b85ac717c20bd313553","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch enables extra_dhcp_opts on networks and subnets, with the"},{"line_number":10,"context_line":"required models and logic added to the dhcp agent driver for dnsmasq."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Change-Id: If0dbeb58f3b88f06e89e54e73dc14f13f20c6b80"},{"line_number":14,"context_line":"Partial-Bug: #1512666"},{"line_number":15,"context_line":"Implements: blueprint dhcp-options-per-subnet"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_44c26bea","line":12,"updated":"2015-12-09 00:51:14.000000000","message":"Please review [1]:\n\nhttp://lists.openstack.org/pipermail/openstack-dev/2015-November/080294.html\n\nTL;DR: In the future, you will need to add a description whenever you add a DocImpact flag in your commit message.","commit_id":"7452f8e85795eed8a9a5bb7b2651eec3ec40ea4d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3fe7b01fd6511f424b207b85ac717c20bd313553","unresolved":false,"context_lines":[{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Change-Id: If0dbeb58f3b88f06e89e54e73dc14f13f20c6b80"},{"line_number":14,"context_line":"Partial-Bug: #1512666"},{"line_number":15,"context_line":"Implements: blueprint dhcp-options-per-subnet"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a740942_c4873bb3","line":15,"updated":"2015-12-09 00:51:14.000000000","message":"what about client side changes to support this? I am not sure this is really complete.","commit_id":"7452f8e85795eed8a9a5bb7b2651eec3ec40ea4d"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"1a2a5f3f2123ce2a58e79bf27573b88dde16cbeb","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            elif getattr(subnet, \u0027dhcp_allow_unknown_hosts\u0027, False):"},{"line_number":373,"context_line":"                if subnet.ip_version \u003d\u003d 4:"},{"line_number":374,"context_line":"                    cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s\u0027 %"},{"line_number":375,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"},{"line_number":376,"context_line":"                                cidr.network, lease))"},{"line_number":377,"context_line":"                else:"},{"line_number":378,"context_line":"                    cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%d,%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_1cabcfd7","line":375,"updated":"2015-11-23 23:03:43.000000000","message":"why not:\n\n \"--dhcp-range\u003dset:%s,%s,%s\"","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":372,"context_line":"            elif getattr(subnet, \u0027dhcp_allow_unknown_hosts\u0027, False):"},{"line_number":373,"context_line":"                if subnet.ip_version \u003d\u003d 4:"},{"line_number":374,"context_line":"                    cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%s\u0027 %"},{"line_number":375,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"},{"line_number":376,"context_line":"                                cidr.network, lease))"},{"line_number":377,"context_line":"                else:"},{"line_number":378,"context_line":"                    cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%d,%s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_2334e2dc","line":375,"in_reply_to":"ba8a016a_1cabcfd7","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2402e115c3aea133749a8b1e116d70fcce3dcc9b","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                cidr.network, lease))"},{"line_number":377,"context_line":"                else:"},{"line_number":378,"context_line":"                    cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%d,%s\u0027 %"},{"line_number":379,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"},{"line_number":380,"context_line":"                                cidr.network, cidr.prefixlen, lease))"},{"line_number":381,"context_line":"                possible_leases +\u003d cidr.size"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_fd84c2b1","line":379,"updated":"2015-11-24 03:03:32.000000000","message":"this line too","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                cidr.network, lease))"},{"line_number":377,"context_line":"                else:"},{"line_number":378,"context_line":"                    cmd.append(\u0027--dhcp-range\u003d%s%s,%s,%d,%s\u0027 %"},{"line_number":379,"context_line":"                               (\u0027set:\u0027, self._TAG_PREFIX % i,"},{"line_number":380,"context_line":"                                cidr.network, cidr.prefixlen, lease))"},{"line_number":381,"context_line":"                possible_leases +\u003d cidr.size"},{"line_number":382,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_4331e6eb","line":379,"in_reply_to":"ba8a016a_fd84c2b1","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            # if a subnet is specified to have dhcp disabled"},{"line_number":337,"context_line":"            if not subnet.enable_dhcp:"},{"line_number":338,"context_line":"                continue"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":341,"context_line":"                mode \u003d \u0027static\u0027"},{"line_number":342,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_bcae6396","line":339,"updated":"2015-11-25 14:58:50.000000000","message":"we do not need this","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":341,"context_line":"                mode \u003d \u0027static\u0027"},{"line_number":342,"context_line":"            else:"},{"line_number":343,"context_line":"                # Note(scollins) If the IPv6 attributes are not set, set"},{"line_number":344,"context_line":"                # it as static to preserve previous behavior"},{"line_number":345,"context_line":"                addr_mode \u003d getattr(subnet, \u0027ipv6_address_mode\u0027, None)"},{"line_number":346,"context_line":"                ra_mode \u003d getattr(subnet, \u0027ipv6_ra_mode\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_1ca0cf9e","line":343,"updated":"2015-11-25 14:58:50.000000000","message":"ditto","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"30e86e6e05eb76248cf8f05d4c9dcb66db4c4207","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":341,"context_line":"                mode \u003d \u0027static\u0027"},{"line_number":342,"context_line":"            else:"},{"line_number":343,"context_line":"                # Note(scollins) If the IPv6 attributes are not set, set"},{"line_number":344,"context_line":"                # it as static to preserve previous behavior"},{"line_number":345,"context_line":"                addr_mode \u003d getattr(subnet, \u0027ipv6_address_mode\u0027, None)"},{"line_number":346,"context_line":"                ra_mode \u003d getattr(subnet, \u0027ipv6_ra_mode\u0027, None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_b6505033","line":343,"in_reply_to":"9a8ffd7b_1ca0cf9e","updated":"2015-12-08 14:55:49.000000000","message":"Done","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                        subnet.ip_version, i, opt.opt_name, opt.opt_value))"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"            for opt in subnet.extra_dhcp_opts:"},{"line_number":843,"context_line":"                    options.append(self._format_option("},{"line_number":844,"context_line":"                        subnet.ip_version, i, opt.opt_name, opt.opt_value))"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"        return options, subnet_index_map"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_3cd7d3ee","line":843,"updated":"2015-11-25 14:58:50.000000000","message":"dodgy indentation should be 4 spaces and not 8","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"30e86e6e05eb76248cf8f05d4c9dcb66db4c4207","unresolved":false,"context_lines":[{"line_number":840,"context_line":"                        subnet.ip_version, i, opt.opt_name, opt.opt_value))"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"            for opt in subnet.extra_dhcp_opts:"},{"line_number":843,"context_line":"                    options.append(self._format_option("},{"line_number":844,"context_line":"                        subnet.ip_version, i, opt.opt_name, opt.opt_value))"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"        return options, subnet_index_map"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_56432c6c","line":843,"in_reply_to":"9a8ffd7b_3cd7d3ee","updated":"2015-12-08 14:55:49.000000000","message":"Done","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"}],"neutron/db/extradhcpopt_db.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2402e115c3aea133749a8b1e116d70fcce3dcc9b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    These will be written to the \u003cnetwork_id\u003e/opts files, and each option\u0027s"},{"line_number":64,"context_line":"    tag will be referenced in the \u003cnetwork_id\u003e/host file."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":67,"context_line":"                        sa.ForeignKey(\u0027subnets.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":68,"context_line":"                        nullable\u003dFalse)"},{"line_number":69,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_6074a99b","line":66,"updated":"2015-11-24 03:03:32.000000000","message":"why still use port_id?","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    These will be written to the \u003cnetwork_id\u003e/opts files, and each option\u0027s"},{"line_number":64,"context_line":"    tag will be referenced in the \u003cnetwork_id\u003e/host file."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":67,"context_line":"                        sa.ForeignKey(\u0027subnets.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":68,"context_line":"                        nullable\u003dFalse)"},{"line_number":69,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_7e3cbd2f","line":66,"in_reply_to":"ba8a016a_6074a99b","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2402e115c3aea133749a8b1e116d70fcce3dcc9b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    These will be written to the \u003cnetwork_id\u003e/opts files, and each option\u0027s"},{"line_number":92,"context_line":"    tag will be referenced in the \u003cnetwork_id\u003e/host file."},{"line_number":93,"context_line":"    \"\"\""},{"line_number":94,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":95,"context_line":"                        sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":96,"context_line":"                        nullable\u003dFalse)"},{"line_number":97,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_e06899bc","line":94,"updated":"2015-11-24 03:03:32.000000000","message":"network_id?","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    These will be written to the \u003cnetwork_id\u003e/opts files, and each option\u0027s"},{"line_number":92,"context_line":"    tag will be referenced in the \u003cnetwork_id\u003e/host file."},{"line_number":93,"context_line":"    \"\"\""},{"line_number":94,"context_line":"    port_id \u003d sa.Column(sa.String(36),"},{"line_number":95,"context_line":"                        sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":96,"context_line":"                        nullable\u003dFalse)"},{"line_number":97,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_1e49f1d0","line":94,"in_reply_to":"ba8a016a_e06899bc","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2402e115c3aea133749a8b1e116d70fcce3dcc9b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":99,"context_line":"    ip_version \u003d sa.Column(sa.Integer, server_default\u003d\u00274\u0027, nullable\u003dFalse)"},{"line_number":100,"context_line":"    __table_args__ \u003d (sa.UniqueConstraint("},{"line_number":101,"context_line":"        \u0027port_id\u0027,"},{"line_number":102,"context_line":"        \u0027opt_name\u0027,"},{"line_number":103,"context_line":"        \u0027ip_version\u0027,"},{"line_number":104,"context_line":"        name\u003d\u0027uniq_extradhcpopts0networkid0optname0ipversion\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_0064bde2","line":101,"updated":"2015-11-24 03:03:32.000000000","message":"network_id","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":99,"context_line":"    ip_version \u003d sa.Column(sa.Integer, server_default\u003d\u00274\u0027, nullable\u003dFalse)"},{"line_number":100,"context_line":"    __table_args__ \u003d (sa.UniqueConstraint("},{"line_number":101,"context_line":"        \u0027port_id\u0027,"},{"line_number":102,"context_line":"        \u0027opt_name\u0027,"},{"line_number":103,"context_line":"        \u0027ip_version\u0027,"},{"line_number":104,"context_line":"        name\u003d\u0027uniq_extradhcpopts0networkid0optname0ipversion\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_fe166da6","line":101,"in_reply_to":"ba8a016a_0064bde2","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2402e115c3aea133749a8b1e116d70fcce3dcc9b","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    def _update_extra_dhcp_opts_on_network(self, context, id, network,"},{"line_number":309,"context_line":"                                        updated_network\u003dNone):"},{"line_number":310,"context_line":"        # It is not necessary to update in a transaction, because"},{"line_number":311,"context_line":"        # its called from within one from ovs_neutron_plugin."},{"line_number":312,"context_line":"        dopts \u003d network[\u0027network\u0027].get(edo_ext.EXTRADHCPOPTS)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        if dopts:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_dd253ec2","line":311,"updated":"2015-11-24 03:03:32.000000000","message":"do we still have ovs_neutron_plugin?","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    def _update_extra_dhcp_opts_on_network(self, context, id, network,"},{"line_number":309,"context_line":"                                        updated_network\u003dNone):"},{"line_number":310,"context_line":"        # It is not necessary to update in a transaction, because"},{"line_number":311,"context_line":"        # its called from within one from ovs_neutron_plugin."},{"line_number":312,"context_line":"        dopts \u003d network[\u0027network\u0027].get(edo_ext.EXTRADHCPOPTS)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        if dopts:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c041353b","line":311,"in_reply_to":"ba8a016a_dd253ec2","updated":"2015-11-24 17:35:41.000000000","message":"Not sure what to do with this comment, I can simply remove it if its the right thing to do.","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2402e115c3aea133749a8b1e116d70fcce3dcc9b","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                                                                    id)"},{"line_number":352,"context_line":"                updated_network[edo_ext.EXTRADHCPOPTS] \u003d edolist"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        return bool(dopts)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def _extend_port_dict_extra_dhcp_opt(self, res, port):"},{"line_number":357,"context_line":"        res[edo_ext.EXTRADHCPOPTS] \u003d [{\u0027opt_name\u0027: dho.opt_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_4023a5a7","line":354,"updated":"2015-11-24 03:03:32.000000000","message":"I think we should refactor _update_extra_dhcp_opts_on_network, _update_extra_dhcp_opts_on_subnet and _update_extra_dhcp_opts_on_port so that we will not duplicate the codes","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                                                                    id)"},{"line_number":352,"context_line":"                updated_network[edo_ext.EXTRADHCPOPTS] \u003d edolist"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        return bool(dopts)"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def _extend_port_dict_extra_dhcp_opt(self, res, port):"},{"line_number":357,"context_line":"        res[edo_ext.EXTRADHCPOPTS] \u003d [{\u0027opt_name\u0027: dho.opt_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_844b4ab0","line":354,"in_reply_to":"ba8a016a_4023a5a7","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2402e115c3aea133749a8b1e116d70fcce3dcc9b","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        attributes.PORTS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":381,"context_line":"        attributes.SUBNETS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":384,"context_line":"        attributes.NETWORKS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_5d4aae84","line":381,"updated":"2015-11-24 03:03:32.000000000","message":"_extent_subnet_xxxxx","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        attributes.PORTS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":381,"context_line":"        attributes.SUBNETS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":384,"context_line":"        attributes.NETWORKS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_24c7fe13","line":381,"in_reply_to":"ba8a016a_5d4aae84","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"2402e115c3aea133749a8b1e116d70fcce3dcc9b","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        attributes.SUBNETS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":384,"context_line":"        attributes.NETWORKS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_3d47aa78","line":384,"updated":"2015-11-24 03:03:32.000000000","message":"_extend_network_xxx","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        attributes.SUBNETS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"    db_base_plugin_v2.NeutronDbPluginV2.register_dict_extend_funcs("},{"line_number":384,"context_line":"        attributes.NETWORKS, [\u0027_extend_port_dict_extra_dhcp_opt\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_e4d016cc","line":384,"in_reply_to":"ba8a016a_3d47aa78","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    tag will be referenced in the \u003cnetwork_id\u003e/host file."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    subnet_id \u003d sa.Column(sa.String(36),"},{"line_number":67,"context_line":"                        sa.ForeignKey(\u0027subnets.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":68,"context_line":"                        nullable\u003dFalse)"},{"line_number":69,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":70,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_5c55f74d","line":67,"updated":"2015-11-25 14:58:50.000000000","message":"indentation","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"30e86e6e05eb76248cf8f05d4c9dcb66db4c4207","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    tag will be referenced in the \u003cnetwork_id\u003e/host file."},{"line_number":65,"context_line":"    \"\"\""},{"line_number":66,"context_line":"    subnet_id \u003d sa.Column(sa.String(36),"},{"line_number":67,"context_line":"                        sa.ForeignKey(\u0027subnets.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":68,"context_line":"                        nullable\u003dFalse)"},{"line_number":69,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":70,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_999ea7b7","line":67,"in_reply_to":"9a8ffd7b_5c55f74d","updated":"2015-12-08 14:55:49.000000000","message":"Done","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                        nullable\u003dFalse)"},{"line_number":69,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":70,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":71,"context_line":"    ip_version \u003d sa.Column(sa.Integer, server_default\u003d\u00274\u0027, nullable\u003dFalse)"},{"line_number":72,"context_line":"    __table_args__ \u003d (sa.UniqueConstraint("},{"line_number":73,"context_line":"        \u0027subnet_id\u0027,"},{"line_number":74,"context_line":"        \u0027opt_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_5c03b742","line":71,"updated":"2015-11-25 14:58:50.000000000","message":"should this not be the integer 4?","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"30e86e6e05eb76248cf8f05d4c9dcb66db4c4207","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                        nullable\u003dFalse)"},{"line_number":69,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":70,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":71,"context_line":"    ip_version \u003d sa.Column(sa.Integer, server_default\u003d\u00274\u0027, nullable\u003dFalse)"},{"line_number":72,"context_line":"    __table_args__ \u003d (sa.UniqueConstraint("},{"line_number":73,"context_line":"        \u0027subnet_id\u0027,"},{"line_number":74,"context_line":"        \u0027opt_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_f95c8b1a","line":71,"in_reply_to":"9a8ffd7b_5c03b742","updated":"2015-12-08 14:55:49.000000000","message":"https://groups.google.com/forum/#!topic/sqlalchemy-alembic/_aMCdqQbjCY","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    tag will be referenced in the \u003cnetwork_id\u003e/host file."},{"line_number":93,"context_line":"    \"\"\""},{"line_number":94,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":95,"context_line":"                        sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":96,"context_line":"                        nullable\u003dFalse)"},{"line_number":97,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":98,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_7c855bab","line":95,"updated":"2015-11-25 14:58:50.000000000","message":"same as above","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"30e86e6e05eb76248cf8f05d4c9dcb66db4c4207","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    tag will be referenced in the \u003cnetwork_id\u003e/host file."},{"line_number":93,"context_line":"    \"\"\""},{"line_number":94,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":95,"context_line":"                        sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":96,"context_line":"                        nullable\u003dFalse)"},{"line_number":97,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":98,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d9e66f43","line":95,"in_reply_to":"9a8ffd7b_7c855bab","updated":"2015-12-08 14:55:49.000000000","message":"Done","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                        nullable\u003dFalse)"},{"line_number":97,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":98,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":99,"context_line":"    ip_version \u003d sa.Column(sa.Integer, server_default\u003d\u00274\u0027, nullable\u003dFalse)"},{"line_number":100,"context_line":"    __table_args__ \u003d (sa.UniqueConstraint("},{"line_number":101,"context_line":"        \u0027network_id\u0027,"},{"line_number":102,"context_line":"        \u0027opt_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_9cb6ff88","line":99,"updated":"2015-11-25 14:58:50.000000000","message":"ditto","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"30e86e6e05eb76248cf8f05d4c9dcb66db4c4207","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                        nullable\u003dFalse)"},{"line_number":97,"context_line":"    opt_name \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":98,"context_line":"    opt_value \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":99,"context_line":"    ip_version \u003d sa.Column(sa.Integer, server_default\u003d\u00274\u0027, nullable\u003dFalse)"},{"line_number":100,"context_line":"    __table_args__ \u003d (sa.UniqueConstraint("},{"line_number":101,"context_line":"        \u0027network_id\u0027,"},{"line_number":102,"context_line":"        \u0027opt_name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_19b39751","line":99,"in_reply_to":"9a8ffd7b_9cb6ff88","updated":"2015-12-08 14:55:49.000000000","message":"See above.","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"}],"neutron/db/migration/alembic_migrations/versions/mitaka/expand/1c4ec12b65e8_extradhcpoptsforsubnetsandnetworks.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"8ec1b6c46dbb9fc35b47391d8ba677b47eceab99","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        sa.UniqueConstraint("},{"line_number":45,"context_line":"            \u0027port_id\u0027, \u0027opt_name\u0027, \u0027ip_version\u0027,"},{"line_number":46,"context_line":"            name\u003d\u0027uniq_extradhcpopts0networkid0optname0ipversion\u0027),"},{"line_number":47,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":48,"context_line":"    )"},{"line_number":49,"context_line":"    op.create_table(\u0027subnetextradhcpopts\u0027,"},{"line_number":50,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_c2db15ec","line":47,"range":{"start_line":47,"start_character":8,"end_line":47,"end_character":28},"updated":"2015-11-24 07:33:36.000000000","message":"Not needed, InnoDB sets automatically.","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"ac58468adcdfeaf5e974df3b5179a459d016b63d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        sa.UniqueConstraint("},{"line_number":45,"context_line":"            \u0027port_id\u0027, \u0027opt_name\u0027, \u0027ip_version\u0027,"},{"line_number":46,"context_line":"            name\u003d\u0027uniq_extradhcpopts0networkid0optname0ipversion\u0027),"},{"line_number":47,"context_line":"        mysql_engine\u003d\u0027InnoDB\u0027"},{"line_number":48,"context_line":"    )"},{"line_number":49,"context_line":"    op.create_table(\u0027subnetextradhcpopts\u0027,"},{"line_number":50,"context_line":"        sa.Column(\u0027id\u0027, sa.String(length\u003d36), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a713f05b","line":47,"in_reply_to":"ba8a016a_c2db15ec","updated":"2015-11-24 17:35:41.000000000","message":"Done","commit_id":"65a4165c29f3e48459866595226a922e80fbb866"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"19d5e0f590a630d730f6138cc3b1a19aea006e03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1af94dfe_8f7c40ed","updated":"2016-03-18 14:34:27.000000000","message":"This must now go in the newton versions directory.","commit_id":"8f739e2fb803b9b852cea537ae185776bb89148e"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            self.type_manager.extend_network_dict_provider(context, result)"},{"line_number":635,"context_line":"            mech_context \u003d driver_context.NetworkContext(self, context,"},{"line_number":636,"context_line":"                                                         result)"},{"line_number":637,"context_line":"            dhcp_opts \u003d net_data.get(edo_ext.EXTRADHCPOPTS, [])"},{"line_number":638,"context_line":"            self._process_network_create_extra_dhcp_opts(context, result,"},{"line_number":639,"context_line":"                                                         dhcp_opts)"},{"line_number":640,"context_line":"            self.mechanism_manager.create_network_precommit(mech_context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_3f19057a","line":637,"updated":"2015-11-25 14:58:50.000000000","message":"where is this tested","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"30e86e6e05eb76248cf8f05d4c9dcb66db4c4207","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            self.type_manager.extend_network_dict_provider(context, result)"},{"line_number":635,"context_line":"            mech_context \u003d driver_context.NetworkContext(self, context,"},{"line_number":636,"context_line":"                                                         result)"},{"line_number":637,"context_line":"            dhcp_opts \u003d net_data.get(edo_ext.EXTRADHCPOPTS, [])"},{"line_number":638,"context_line":"            self._process_network_create_extra_dhcp_opts(context, result,"},{"line_number":639,"context_line":"                                                         dhcp_opts)"},{"line_number":640,"context_line":"            self.mechanism_manager.create_network_precommit(mech_context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_d12f1b3d","line":637,"in_reply_to":"9a8ffd7b_3f19057a","updated":"2015-12-08 14:55:49.000000000","message":"Done","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a7f7a64af344be066c65e165ab5bb73a8cd00fb9","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            self.type_manager.extend_network_dict_provider(context,"},{"line_number":679,"context_line":"                                                           updated_network)"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"            self._update_extra_dhcp_opts_on_network(context, id,"},{"line_number":682,"context_line":"                                                    network, updated_network)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_df26b9b9","line":681,"updated":"2015-11-25 14:58:50.000000000","message":"ditto","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"30e86e6e05eb76248cf8f05d4c9dcb66db4c4207","unresolved":false,"context_lines":[{"line_number":678,"context_line":"            self.type_manager.extend_network_dict_provider(context,"},{"line_number":679,"context_line":"                                                           updated_network)"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"            self._update_extra_dhcp_opts_on_network(context, id,"},{"line_number":682,"context_line":"                                                    network, updated_network)"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"            # TODO(QoS): Move out to the extension framework somehow."}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_110363b9","line":681,"in_reply_to":"9a8ffd7b_df26b9b9","updated":"2015-12-08 14:55:49.000000000","message":"Done","commit_id":"c0596ab4381dd068876e721b6d44807384d90c57"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3fe7b01fd6511f424b207b85ac717c20bd313553","unresolved":false,"context_lines":[{"line_number":630,"context_line":"            self.type_manager.extend_network_dict_provider(context, result)"},{"line_number":631,"context_line":"            mech_context \u003d driver_context.NetworkContext(self, context,"},{"line_number":632,"context_line":"                                                         result)"},{"line_number":633,"context_line":"            dhcp_opts \u003d net_data.get(edo_ext.EXTRADHCPOPTS, [])"},{"line_number":634,"context_line":"            self._process_network_create_extra_dhcp_opts(context, result,"},{"line_number":635,"context_line":"                                                         dhcp_opts)"},{"line_number":636,"context_line":"            self.mechanism_manager.create_network_precommit(mech_context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_6f3d058e","line":633,"updated":"2015-12-09 00:51:14.000000000","message":"wonder if this should be done as a MD extension?","commit_id":"7452f8e85795eed8a9a5bb7b2651eec3ec40ea4d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f222c25de91c40283883ae7011d122b70ab8e14b","unresolved":false,"context_lines":[{"line_number":630,"context_line":"            self.type_manager.extend_network_dict_provider(context, result)"},{"line_number":631,"context_line":"            mech_context \u003d driver_context.NetworkContext(self, context,"},{"line_number":632,"context_line":"                                                         result)"},{"line_number":633,"context_line":"            dhcp_opts \u003d net_data.get(edo_ext.EXTRADHCPOPTS, [])"},{"line_number":634,"context_line":"            self._process_network_create_extra_dhcp_opts(context, result,"},{"line_number":635,"context_line":"                                                         dhcp_opts)"},{"line_number":636,"context_line":"            self.mechanism_manager.create_network_precommit(mech_context)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_dd48578d","line":633,"in_reply_to":"7a740942_6f3d058e","updated":"2015-12-15 14:41:08.000000000","message":"Mech Driver Extension? I\u0027m not sure what you mean sorry.","commit_id":"7452f8e85795eed8a9a5bb7b2651eec3ec40ea4d"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3fe7b01fd6511f424b207b85ac717c20bd313553","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"                                    FakeV4NetworkWithSubnetExtraDhcpOpts(),"},{"line_number":1351,"context_line":"                                    ipm_retval\u003dipm_retval)"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"    def test_output_opts_file_subnet_and_network_extra_opts(self):"},{"line_number":1354,"context_line":"        expected \u003d ("},{"line_number":1355,"context_line":"            \u0027tag:tag0,option:dns-server,8.8.8.8\\n\u0027"},{"line_number":1356,"context_line":"            \u0027tag:tag0,option:classless-static-route,\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_a4fb0f78","line":1353,"updated":"2015-12-09 00:51:14.000000000","message":"not sure I understand how the subnet extra opts overrides the network one.\n\nIt\u0027s not clear to me from this test how the same opt specified on a subnet overrides the same opt specified on the network. Eg. I set tftp-server on subnet to be 192.168.0.4 and on network to be 192.168.0.33. I would expect .4 to win over .33.\n\nYou with me?","commit_id":"7452f8e85795eed8a9a5bb7b2651eec3ec40ea4d"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"f222c25de91c40283883ae7011d122b70ab8e14b","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"                                    FakeV4NetworkWithSubnetExtraDhcpOpts(),"},{"line_number":1351,"context_line":"                                    ipm_retval\u003dipm_retval)"},{"line_number":1352,"context_line":""},{"line_number":1353,"context_line":"    def test_output_opts_file_subnet_and_network_extra_opts(self):"},{"line_number":1354,"context_line":"        expected \u003d ("},{"line_number":1355,"context_line":"            \u0027tag:tag0,option:dns-server,8.8.8.8\\n\u0027"},{"line_number":1356,"context_line":"            \u0027tag:tag0,option:classless-static-route,\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_9e6bb0f0","line":1353,"in_reply_to":"7a740942_a4fb0f78","updated":"2015-12-15 14:41:08.000000000","message":"Thats exactly whats happening, the network has the tftp-server\u003d192.168.0.3 and the subnet has tftp-server\u003d192.168.0.4 and the expected result is 192.168.0.4","commit_id":"7452f8e85795eed8a9a5bb7b2651eec3ec40ea4d"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3fe7b01fd6511f424b207b85ac717c20bd313553","unresolved":false,"context_lines":[{"line_number":442,"context_line":"                     allocation_pools\u003dNone, ip_version\u003d4, enable_dhcp\u003dTrue,"},{"line_number":443,"context_line":"                     dns_nameservers\u003dNone, host_routes\u003dNone, shared\u003dNone,"},{"line_number":444,"context_line":"                     ipv6_ra_mode\u003dNone, ipv6_address_mode\u003dNone,"},{"line_number":445,"context_line":"                     tenant_id\u003dNone, set_context\u003dFalse, **kwargs):"},{"line_number":446,"context_line":"        res \u003d self._create_subnet(fmt,"},{"line_number":447,"context_line":"                                  net_id\u003dnetwork[\u0027network\u0027][\u0027id\u0027],"},{"line_number":448,"context_line":"                                  cidr\u003dcidr,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_c46bbb1c","line":445,"updated":"2015-12-09 00:51:14.000000000","message":"yuk!","commit_id":"7452f8e85795eed8a9a5bb7b2651eec3ec40ea4d"}]}
