)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"d6a1258e48c6578411e85c3d7bffe027e1daf855","unresolved":false,"context_lines":[{"line_number":14,"context_line":"will not be called. This will fail the UT, but it is intermittent."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic951c1b91c5a10462f548544a5e8d482c52ad665"},{"line_number":17,"context_line":"Closes-Bug: #1519160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_1d300e56","line":17,"updated":"2015-11-24 15:04:46.000000000","message":"I\u0027m not entirely sure this fixes the bug - it might be some other issue. Once this merges we should probably gather statistics and see if this fixes the problem. In the mean time, I propose to tag this as \u0027Related-Bug\u0027 and not \u0027Closes-Bug\u0027.","commit_id":"dcd0498c17ae860c55a92f9f31b3e3fa0460b78e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e3af0e13ba35791501d559e306f917e04b64e9cf","unresolved":false,"context_lines":[{"line_number":14,"context_line":"will not be called. This will fail the UT, but it is intermittent."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ic951c1b91c5a10462f548544a5e8d482c52ad665"},{"line_number":17,"context_line":"Closes-Bug: #1519160"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_23b5abcc","line":17,"in_reply_to":"9a8ffd7b_1d300e56","updated":"2015-11-24 17:59:23.000000000","message":"I\u0027d rather re-open the bug than leave it open in case we forget to close it ;)","commit_id":"dcd0498c17ae860c55a92f9f31b3e3fa0460b78e"}],"neutron/tests/unit/agent/linux/test_async_process.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e8e9ae17e3271d0843a6805b0d47426c8e8f070c","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            self.process._process.wait()"},{"line_number":294,"context_line":"            # Wait for the monitor process to complete"},{"line_number":295,"context_line":"            for thread in self.process._watchers:"},{"line_number":296,"context_line":"                thread.wait()"},{"line_number":297,"context_line":"            self.assertEqual(1, handle_error_mock.call_count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_23eccbc6","line":296,"updated":"2015-11-24 18:00:24.000000000","message":"I personally think this is not even a UT. At one point I even considered that it\u0027s best to remove it altogether.","commit_id":"dcd0498c17ae860c55a92f9f31b3e3fa0460b78e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c3bb128c4c11d8646e898bc42255c270257c2f55","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            self.process._process.wait()"},{"line_number":294,"context_line":"            # Wait for the monitor process to complete"},{"line_number":295,"context_line":"            for thread in self.process._watchers:"},{"line_number":296,"context_line":"                thread.wait()"},{"line_number":297,"context_line":"            self.assertEqual(1, handle_error_mock.call_count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c47d6eb2","line":296,"in_reply_to":"9a8ffd7b_23eccbc6","updated":"2015-11-26 05:33:12.000000000","message":"It is not a UT. It is functional. The neutron functional tests cover it already.","commit_id":"dcd0498c17ae860c55a92f9f31b3e3fa0460b78e"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"5c6da73ae5e3b18ab3d744295fba9d389dfa87ae","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            self.process._process.wait()"},{"line_number":294,"context_line":"            # Wait for the monitor process to complete"},{"line_number":295,"context_line":"            for thread in self.process._watchers:"},{"line_number":296,"context_line":"                thread.wait()"},{"line_number":297,"context_line":"            self.assertEqual(1, handle_error_mock.call_count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_e6335f60","line":296,"in_reply_to":"9a8ffd7b_90008903","updated":"2015-11-30 06:41:40.000000000","message":"Actually these tests are not identical. The (existing) functional test makes sure that the process has been respawned, whereas this test makes sure that it has been only respawned *once*.\n\nI\u0027m fine with moving this test to the functional suite, though. Merging should be done with care as the code it tests is evidently complicated and deadlock-prone.","commit_id":"dcd0498c17ae860c55a92f9f31b3e3fa0460b78e"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"892417bcca73646a0158ffd397f7bd7173290822","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            self.process._process.wait()"},{"line_number":294,"context_line":"            # Wait for the monitor process to complete"},{"line_number":295,"context_line":"            for thread in self.process._watchers:"},{"line_number":296,"context_line":"                thread.wait()"},{"line_number":297,"context_line":"            self.assertEqual(1, handle_error_mock.call_count)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_90008903","line":296,"in_reply_to":"9a8ffd7b_c47d6eb2","updated":"2015-11-30 05:12:52.000000000","message":"I checked the functional test, this UT here is the same as [1]. Looks like the original UT problem is resolved by this patch. If anyone thinks the UT here should be removed, I can do that as part of Bug 151960.\n\n@Armando Migliaccio @Henry Gessau\t @John Schwarz @Kevin Benton\n\n[1] neutron.tests.functional.agent.linux.test_async_process.test_async_process_respawns","commit_id":"dcd0498c17ae860c55a92f9f31b3e3fa0460b78e"}]}