)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4acf052e06cb1f5b5970dc28fa7ad9abdc410a52","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"TOKEN_ID\u003d\u003ckeystone token (can be retrieved with \u0027keystone token-get\u0027)\u003e"},{"line_number":28,"context_line":"curl -g -i -X POST http://172.16.75.129:9696/v2.0/ports.json -H \"X-Auth-Token: $TOKEN_ID\" -d \u0027{\"port\": {\"network_id\": \"fdc49002-e18a-462f-860f-437c86402469\", \"binding:profile\": {\"local_link_information\": [{\"switch_info\": \"HOSTNAMEOFCOMPUTE\", \"port_id\": \"mtlTEST\"}]}, \"binding:vnic_type\": \"baremetal\", \"admin_state_up\": true, \"binding:host_id\": \"HOSTNAMEOFCOMPUTE\"}}\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I3ae4111757158482dda69302d40a66b3c8468b5f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_2feeea8b","line":29,"updated":"2015-11-24 19:06:35.000000000","message":"Can you please link it to some bug/bp?","commit_id":"20f77122137167ce7e2e7045f1118bdf92ba060b"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"508214ba20345ab0dc39300bf74a9d96264d98f3","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"TOKEN_ID\u003d\u003ckeystone token (can be retrieved with \u0027keystone token-get\u0027)\u003e"},{"line_number":28,"context_line":"curl -g -i -X POST http://172.16.75.129:9696/v2.0/ports.json -H \"X-Auth-Token: $TOKEN_ID\" -d \u0027{\"port\": {\"network_id\": \"fdc49002-e18a-462f-860f-437c86402469\", \"binding:profile\": {\"local_link_information\": [{\"switch_info\": \"HOSTNAMEOFCOMPUTE\", \"port_id\": \"mtlTEST\"}]}, \"binding:vnic_type\": \"baremetal\", \"admin_state_up\": true, \"binding:host_id\": \"HOSTNAMEOFCOMPUTE\"}}\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I3ae4111757158482dda69302d40a66b3c8468b5f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_7105b4c0","line":29,"in_reply_to":"9a8ffd7b_2ea58b03","updated":"2015-11-24 20:19:44.000000000","message":"Kevin, we could potentially use https://blueprints.launchpad.net/openstack/?searchtext\u003dneutron-ironic-integration for this - as this is being developed as part of this program. Or we could file a new one. Regardless we should refer to this blueprint","commit_id":"20f77122137167ce7e2e7045f1118bdf92ba060b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"31de8beef219cd3815156b6cf2e012728c61c21e","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"TOKEN_ID\u003d\u003ckeystone token (can be retrieved with \u0027keystone token-get\u0027)\u003e"},{"line_number":28,"context_line":"curl -g -i -X POST http://172.16.75.129:9696/v2.0/ports.json -H \"X-Auth-Token: $TOKEN_ID\" -d \u0027{\"port\": {\"network_id\": \"fdc49002-e18a-462f-860f-437c86402469\", \"binding:profile\": {\"local_link_information\": [{\"switch_info\": \"HOSTNAMEOFCOMPUTE\", \"port_id\": \"mtlTEST\"}]}, \"binding:vnic_type\": \"baremetal\", \"admin_state_up\": true, \"binding:host_id\": \"HOSTNAMEOFCOMPUTE\"}}\u0027"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Change-Id: I3ae4111757158482dda69302d40a66b3c8468b5f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_2ea58b03","line":29,"in_reply_to":"9a8ffd7b_2feeea8b","updated":"2015-11-24 19:37:03.000000000","message":"yes, will do once filed.","commit_id":"20f77122137167ce7e2e7045f1118bdf92ba060b"}],"neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py":[{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"508214ba20345ab0dc39300bf74a9d96264d98f3","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        if not isinstance(lli, list):"},{"line_number":123,"context_line":"            raise RuntimeError(\u0027local_link_info should be a list\u0027)"},{"line_number":124,"context_line":"        for entry in lli:"},{"line_number":125,"context_line":"            if not entry.get(\u0027switch_info\u0027) or not entry.get(\u0027port_id\u0027):"},{"line_number":126,"context_line":"                # TODO(kevinbenton): better exception"},{"line_number":127,"context_line":"                raise RuntimeError(\u0027switch_info and port_id must be present \u0027"},{"line_number":128,"context_line":"                                   \u0027on baremetal port local link info\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_71c7f412","line":125,"updated":"2015-11-24 20:19:44.000000000","message":"We should include \u0027switch_id\u0027 as well here","commit_id":"20f77122137167ce7e2e7045f1118bdf92ba060b"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"508214ba20345ab0dc39300bf74a9d96264d98f3","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        if not isinstance(lli, list):"},{"line_number":145,"context_line":"            return False"},{"line_number":146,"context_line":"        for entry in lli:"},{"line_number":147,"context_line":"            if (entry.get(\u0027switch_info\u0027) \u003d\u003d switch_info"},{"line_number":148,"context_line":"                    and entry.get(\u0027port_id\u0027) \u003d\u003d port_id):"},{"line_number":149,"context_line":"                return True"},{"line_number":150,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_f10c4444","line":147,"updated":"2015-11-24 20:19:44.000000000","message":"Same here - lets add the switch_id as well","commit_id":"20f77122137167ce7e2e7045f1118bdf92ba060b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b1678a6278faf069f83206026026abaa4f41dade","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        if not isinstance(lli, list):"},{"line_number":145,"context_line":"            return False"},{"line_number":146,"context_line":"        for entry in lli:"},{"line_number":147,"context_line":"            if (entry.get(\u0027switch_info\u0027) \u003d\u003d switch_info"},{"line_number":148,"context_line":"                    and entry.get(\u0027port_id\u0027) \u003d\u003d port_id):"},{"line_number":149,"context_line":"                return True"},{"line_number":150,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d05a3550","line":147,"in_reply_to":"9a8ffd7b_f10c4444","updated":"2015-11-25 13:02:08.000000000","message":"Oh, i think I messed up what the expected link format is.\n\nCan you paste an example of the local_link_information that we would expect here?","commit_id":"20f77122137167ce7e2e7045f1118bdf92ba060b"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"4acf052e06cb1f5b5970dc28fa7ad9abdc410a52","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"        for prefix in const.INTERFACE_PREFIXES:"},{"line_number":1561,"context_line":"            if device.startswith(prefix):"},{"line_number":1562,"context_line":"                return device[len(prefix):]"},{"line_number":1563,"context_line":"        mech_res \u003d self.mechanism_manager.translate_device_to_port_id(context,"},{"line_number":1564,"context_line":"                                                                      device,"},{"line_number":1565,"context_line":"                                                                      host)"},{"line_number":1566,"context_line":"        if mech_res:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_cff5de83","line":1563,"updated":"2015-11-24 19:06:35.000000000","message":"I think you may remove comment in lines 1557-1559","commit_id":"20f77122137167ce7e2e7045f1118bdf92ba060b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"31de8beef219cd3815156b6cf2e012728c61c21e","unresolved":false,"context_lines":[{"line_number":1560,"context_line":"        for prefix in const.INTERFACE_PREFIXES:"},{"line_number":1561,"context_line":"            if device.startswith(prefix):"},{"line_number":1562,"context_line":"                return device[len(prefix):]"},{"line_number":1563,"context_line":"        mech_res \u003d self.mechanism_manager.translate_device_to_port_id(context,"},{"line_number":1564,"context_line":"                                                                      device,"},{"line_number":1565,"context_line":"                                                                      host)"},{"line_number":1566,"context_line":"        if mech_res:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_4e732fb2","line":1563,"in_reply_to":"9a8ffd7b_cff5de83","updated":"2015-11-24 19:37:03.000000000","message":"will do. i will move the change of creating the new mechanism interface into a separate patch that I will cleanup after I\u0027m sure this works for the Ironic testing.","commit_id":"20f77122137167ce7e2e7045f1118bdf92ba060b"}]}