)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"98488092c6f75cefea0e874f58f007d434efadb7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new field, dhcp_allow_unknown_hosts to the Subnet model"},{"line_number":10,"context_line":"so that it is possible to enable unknown devices to be served by the"},{"line_number":11,"context_line":"neutron dnsmasq instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic00f451112c69662a9e33318c3ce31f1a6776d99"},{"line_number":14,"context_line":"Closes-Bug: #1512666"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_8dc83476","line":11,"updated":"2015-11-24 23:59:42.000000000","message":"I don\u0027t understand how it could work as dnsmasq is able to allocate an ip to an unknown device without neutron knowing it ... which means neutron can allocate this ip to someone else.\n\nIMO, the right way to go is to avoid unknown devices by defining ports with the correct mac: it avoids development and ensures consistency between dnsmasq and neutron","commit_id":"2b69718db05c06532cb521e5f4514947b681de49"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"b35695c03d8172ea104a34abce3d516bc3224a84","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new field, dhcp_allow_unknown_hosts to the Subnet model"},{"line_number":10,"context_line":"so that it is possible to enable unknown devices to be served by the"},{"line_number":11,"context_line":"neutron dnsmasq instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic00f451112c69662a9e33318c3ce31f1a6776d99"},{"line_number":14,"context_line":"Closes-Bug: #1512666"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_10719de0","line":11,"in_reply_to":"9a8ffd7b_1c61b939","updated":"2015-11-25 13:08:24.000000000","message":"By default, lease time is one day not 2 minutes.\n\nWith such change, nothing ensures a new port will get its ip before a lease timeout. Which seems not acceptable even when \u003d\u003d to 2 minutes.\n\nNeutron should aware of such unallocable ips (through unknow mac ports?)","commit_id":"2b69718db05c06532cb521e5f4514947b681de49"},{"author":{"_account_id":6637,"name":"Sam Betts","email":"sam@code-smash.net","username":"sambetts"},"change_message_id":"7d09a296d92fe5b1240427f7a823e21d791c2266","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds a new field, dhcp_allow_unknown_hosts to the Subnet model"},{"line_number":10,"context_line":"so that it is possible to enable unknown devices to be served by the"},{"line_number":11,"context_line":"neutron dnsmasq instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic00f451112c69662a9e33318c3ce31f1a6776d99"},{"line_number":14,"context_line":"Closes-Bug: #1512666"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_1c61b939","line":11,"in_reply_to":"9a8ffd7b_8dc83476","updated":"2015-11-25 12:51:34.000000000","message":"This functionality is being created to solve the exact problem that we don\u0027t know the mac addresses and therefore can not create ports in neutron. If we knew the mac addresses this functionality wouldn\u0027t be required.\n\nThe way that I see this working is that neutron is always the first class citizen for DHCP. Neutron will continue to work as normal and assign its ports in the hosts file. The lease timeout should be the minimum possible for addresses given out by dnsmasq, so that after 2 minutes the client will try to renew, and for dynamically assigned machines if their address as been assigned to a neutron port in the hostsfile it will fail the renewal and then have to get a new address, and if there aren\u0027t any left tough luck your a second class citizen. The reasoning behind this is so that neutrons functionality is never affected by this functionality, but it unlocks neutrons DHCP for use with the ironic inspector, so we don\u0027t have to run our own copy of dnsmasq and manually plumb it into the neutron network we want to operate on.","commit_id":"2b69718db05c06532cb521e5f4514947b681de49"}],"neutron/db/migration/alembic_migrations/versions/mitaka/expand/5a26884fe57c_add_subnet_dhcp_allow_unknown_hosts.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0347d08db0f9c8c33b3d05a3ca6715dc7805a5f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1af94dfe_e294fb8b","updated":"2016-03-18 14:41:51.000000000","message":"This must now go in the newton versions directory.","commit_id":"2b69718db05c06532cb521e5f4514947b681de49"}]}