)]}'
{"quantum/agent/linux/iptables_manager.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ea9dd440203a7c5de863d1e997aeec0f0c258316","unresolved":false,"context_lines":[{"line_number":41,"context_line":"MAX_CHAIN_LEN_WRAP \u003d 11"},{"line_number":42,"context_line":"MAX_CHAIN_LEN_NOWRAP \u003d 28"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cfg.CONF.set_default(\u0027lock_path\u0027, \u0027$state_path/lock\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_chain_name(chain_name, wrap\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F6Vw%3D","side":"PARENT","line":44,"updated":"2013-03-21 07:30:59.000000000","message":"removing this now puts the locks in /tmp  is this what you intended? I think we could move this to quantum/common/config.py with the same settting. What do you think?","commit_id":"9683664ff35b1dd0f4cbbbdf6fc386cbcb7c7ad5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"MAX_CHAIN_LEN_WRAP \u003d 11"},{"line_number":42,"context_line":"MAX_CHAIN_LEN_NOWRAP \u003d 28"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cfg.CONF.set_default(\u0027lock_path\u0027, \u0027$state_path/lock\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_chain_name(chain_name, wrap\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F6UE%3D","side":"PARENT","line":44,"in_reply_to":"AAAAOH%2F%2F6U4%3D","updated":"2013-03-21 08:00:35.000000000","message":"I was told that we should not use the set_default as these values are read only.\nI can set the value in the quantum.conf as $state/lock\nDoes this work for you?","commit_id":"9683664ff35b1dd0f4cbbbdf6fc386cbcb7c7ad5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"MAX_CHAIN_LEN_WRAP \u003d 11"},{"line_number":42,"context_line":"MAX_CHAIN_LEN_NOWRAP \u003d 28"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cfg.CONF.set_default(\u0027lock_path\u0027, \u0027$state_path/lock\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_chain_name(chain_name, wrap\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F6TA%3D","side":"PARENT","line":44,"in_reply_to":"AAAAOH%2F%2F6UE%3D","updated":"2013-03-21 08:36:45.000000000","message":"By grepping the codes of nova or other project, it looks common not to use set_default as you say.","commit_id":"9683664ff35b1dd0f4cbbbdf6fc386cbcb7c7ad5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":41,"context_line":"MAX_CHAIN_LEN_WRAP \u003d 11"},{"line_number":42,"context_line":"MAX_CHAIN_LEN_NOWRAP \u003d 28"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cfg.CONF.set_default(\u0027lock_path\u0027, \u0027$state_path/lock\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_chain_name(chain_name, wrap\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F6U4%3D","side":"PARENT","line":44,"in_reply_to":"AAAAOH%2F%2F6Vk%3D","updated":"2013-03-21 07:52:31.000000000","message":"I agree it is better to define lock_path in common/config.\nlock_path StrOpt is defined in lock_utils, so I think we need to use set_default() instead.","commit_id":"9683664ff35b1dd0f4cbbbdf6fc386cbcb7c7ad5"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ea9dd440203a7c5de863d1e997aeec0f0c258316","unresolved":false,"context_lines":[{"line_number":41,"context_line":"MAX_CHAIN_LEN_WRAP \u003d 11"},{"line_number":42,"context_line":"MAX_CHAIN_LEN_NOWRAP \u003d 28"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cfg.CONF.set_default(\u0027lock_path\u0027, \u0027$state_path/lock\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_chain_name(chain_name, wrap\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F6Vk%3D","side":"PARENT","line":44,"in_reply_to":"AAAAOH%2F%2F6Vw%3D","updated":"2013-03-21 07:32:35.000000000","message":"*using    cfg.StrOpt","commit_id":"9683664ff35b1dd0f4cbbbdf6fc386cbcb7c7ad5"}]}