)]}'
{"quantum/plugins/linuxbridge/agent/linuxbridge_quantum_agent.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"bd4980f5b567233e70994d8f5f6df14af08058e8","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                self.agent.plugin_rpc.update_device_down(self.context,"},{"line_number":445,"context_line":"                                                         tap_device_name,"},{"line_number":446,"context_line":"                                                         self.agent.agent_id)"},{"line_number":447,"context_line":"        except Exception, e:"},{"line_number":448,"context_line":"            LOG.exception(_(\"Unable to update port %(port)s: %(err)s\"),"},{"line_number":449,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F50Y%3D","line":447,"updated":"2013-03-21 15:50:52.000000000","message":"What\u0027s actually raising the errors? I\u0027m generally not a fan of wrapping blindly with try/except like this, as now when this is getting updated all sorts of programming errors won\u0027t be raised but instead logged.","commit_id":"c7f18318b98842c430843829d7fb3295c5bdae8e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"50c51159962af8a90bf16dc5fc3a0684ed569ae0","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                self.agent.plugin_rpc.update_device_down(self.context,"},{"line_number":445,"context_line":"                                                         tap_device_name,"},{"line_number":446,"context_line":"                                                         self.agent.agent_id)"},{"line_number":447,"context_line":"        except Exception, e:"},{"line_number":448,"context_line":"            LOG.exception(_(\"Unable to update port %(port)s: %(err)s\"),"},{"line_number":449,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F4GY%3D","line":447,"in_reply_to":"AAAAOH%2F%2F50Y%3D","updated":"2013-03-22 15:19:51.000000000","message":"will catch quantum.openstack.common.rpc.common.RPCException here","commit_id":"c7f18318b98842c430843829d7fb3295c5bdae8e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":445,"context_line":"                self.agent.plugin_rpc.update_device_down(self.context,"},{"line_number":446,"context_line":"                                                         tap_device_name,"},{"line_number":447,"context_line":"                                                         self.agent.agent_id)"},{"line_number":448,"context_line":"        except rpc_common.RPCException, e:"},{"line_number":449,"context_line":"            LOG.exception(_(\"RPC error while updating port %(port)s: %(err)s\"),"},{"line_number":450,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":451,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FwBU%3D","line":448,"updated":"2013-03-29 10:19:50.000000000","message":"Please use \"as e\" instead of \", e\". The comma style is an old style.","commit_id":"86b91328cac8fa8537a89b4b96d5783af82379fe"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"50c51159962af8a90bf16dc5fc3a0684ed569ae0","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                self.agent.plugin_rpc.update_device_down(self.context,"},{"line_number":446,"context_line":"                                                         tap_device_name,"},{"line_number":447,"context_line":"                                                         self.agent.agent_id)"},{"line_number":448,"context_line":"        except rpc_common.RPCException, e:"},{"line_number":449,"context_line":"            LOG.exception(_(\"RPC error while updating port %(port)s: %(err)s\"),"},{"line_number":450,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":451,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fv8E%3D","line":448,"in_reply_to":"AAAAOH%2F%2FwBU%3D","updated":"2013-03-29 10:31:50.000000000","message":"Done","commit_id":"86b91328cac8fa8537a89b4b96d5783af82379fe"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":446,"context_line":"                                                         tap_device_name,"},{"line_number":447,"context_line":"                                                         self.agent.agent_id)"},{"line_number":448,"context_line":"        except rpc_common.RPCException as e:"},{"line_number":449,"context_line":"            LOG.exception(_(\"RPC error while updating port %(port)s: %(err)s\"),"},{"line_number":450,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":451,"context_line":"            raise"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2FucY%3D","line":449,"updated":"2013-04-01 09:49:38.000000000","message":"LOG.exception will output the exception automatically.  Consider:\n\nLOG.exception(_(\"RPC error while updating port %s\"), \n                       port[\u0027id\u0027])","commit_id":"e1bb043fef6c0aa553fa9d33d4f5cad9d01f5069"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"50c51159962af8a90bf16dc5fc3a0684ed569ae0","unresolved":false,"context_lines":[{"line_number":446,"context_line":"                                                         tap_device_name,"},{"line_number":447,"context_line":"                                                         self.agent.agent_id)"},{"line_number":448,"context_line":"        except rpc_common.RPCException as e:"},{"line_number":449,"context_line":"            LOG.exception(_(\"RPC error while updating port %(port)s: %(err)s\"),"},{"line_number":450,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":451,"context_line":"            raise"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2Fubk%3D","line":449,"in_reply_to":"AAAAOH%2F%2FucY%3D","updated":"2013-04-01 10:05:59.000000000","message":"Done. Thanks for pointing!","commit_id":"e1bb043fef6c0aa553fa9d33d4f5cad9d01f5069"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"unresolved":false,"context_lines":[{"line_number":447,"context_line":"                                                         self.agent.agent_id)"},{"line_number":448,"context_line":"        except rpc_common.RPCException as e:"},{"line_number":449,"context_line":"            LOG.exception(_(\"RPC error while updating port %s\"), port[\u0027id\u0027])"},{"line_number":450,"context_line":"            raise"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":"    def create_rpc_dispatcher(self):"},{"line_number":453,"context_line":"        \u0027\u0027\u0027Get the rpc dispatcher for this manager."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2FubA%3D","line":450,"updated":"2013-04-01 10:21:15.000000000","message":"We just raise the exception means after server get back, the port status won\u0027t update on server.\n\nSo if we want to port status are same on agant and server, we can execute port-update again.\n\nAnother choice like \u0027resync\u0027 in agent loop. we send this rpc call again after server get back.\n\nBut currently solution is ok for me too.","commit_id":"8e7b04c35c455483c48aea3ebb845a8a9e33ebf4"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0b3d623b119edec92269a8f67ed055a898dbff62","unresolved":false,"context_lines":[{"line_number":444,"context_line":"                self.agent.plugin_rpc.update_device_down(self.context,"},{"line_number":445,"context_line":"                                                         tap_device_name,"},{"line_number":446,"context_line":"                                                         self.agent.agent_id)"},{"line_number":447,"context_line":"        except rpc_common.RPCException as e:"},{"line_number":448,"context_line":"            LOG.exception(_(\"RPC error while updating port %s\"), port[\u0027id\u0027])"},{"line_number":449,"context_line":"            raise"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2F814%3D","line":447,"updated":"2013-04-10 14:55:50.000000000","message":"e isn\u0027t used.","commit_id":"2a72373bff7555ea70e0cd6acbb59d46f9bbae56"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":444,"context_line":"                self.agent.plugin_rpc.update_device_down(self.context,"},{"line_number":445,"context_line":"                                                         tap_device_name,"},{"line_number":446,"context_line":"                                                         self.agent.agent_id)"},{"line_number":447,"context_line":"        except rpc_common.RPCException as e:"},{"line_number":448,"context_line":"            LOG.exception(_(\"RPC error while updating port %s\"), port[\u0027id\u0027])"},{"line_number":449,"context_line":"            raise"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2F8z8%3D","line":447,"in_reply_to":"AAAAOn%2F%2F814%3D","updated":"2013-04-10 15:11:43.000000000","message":"Done","commit_id":"2a72373bff7555ea70e0cd6acbb59d46f9bbae56"}],"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"bd4980f5b567233e70994d8f5f6df14af08058e8","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                # update plugin about port status"},{"line_number":270,"context_line":"                self.plugin_rpc.update_device_down(self.context, port[\u0027id\u0027],"},{"line_number":271,"context_line":"                                                   self.agent_id)"},{"line_number":272,"context_line":"        except Exception, e:"},{"line_number":273,"context_line":"            LOG.exception(_(\"Unable to update port %(port)s: %(err)s\"),"},{"line_number":274,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F50I%3D","line":272,"updated":"2013-03-21 15:50:52.000000000","message":"Same here, what error are we looking for, should this not fail on keyerror?","commit_id":"c7f18318b98842c430843829d7fb3295c5bdae8e"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"50c51159962af8a90bf16dc5fc3a0684ed569ae0","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                # update plugin about port status"},{"line_number":270,"context_line":"                self.plugin_rpc.update_device_down(self.context, port[\u0027id\u0027],"},{"line_number":271,"context_line":"                                                   self.agent_id)"},{"line_number":272,"context_line":"        except Exception, e:"},{"line_number":273,"context_line":"            LOG.exception(_(\"Unable to update port %(port)s: %(err)s\"),"},{"line_number":274,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOH%2F%2F4GU%3D","line":272,"in_reply_to":"AAAAOH%2F%2F50I%3D","updated":"2013-03-22 15:19:51.000000000","message":"Done","commit_id":"c7f18318b98842c430843829d7fb3295c5bdae8e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":270,"context_line":"                # update plugin about port status"},{"line_number":271,"context_line":"                self.plugin_rpc.update_device_down(self.context, port[\u0027id\u0027],"},{"line_number":272,"context_line":"                                                   self.agent_id)"},{"line_number":273,"context_line":"        except rpc_common.RPCException, e:"},{"line_number":274,"context_line":"            LOG.exception(_(\"RPC error while updating port %(port)s: %(err)s\"),"},{"line_number":275,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":276,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2FwA4%3D","line":273,"updated":"2013-03-29 10:19:50.000000000","message":"Please use \"as e\" instead of \", e\"","commit_id":"86b91328cac8fa8537a89b4b96d5783af82379fe"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"50c51159962af8a90bf16dc5fc3a0684ed569ae0","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                # update plugin about port status"},{"line_number":271,"context_line":"                self.plugin_rpc.update_device_down(self.context, port[\u0027id\u0027],"},{"line_number":272,"context_line":"                                                   self.agent_id)"},{"line_number":273,"context_line":"        except rpc_common.RPCException, e:"},{"line_number":274,"context_line":"            LOG.exception(_(\"RPC error while updating port %(port)s: %(err)s\"),"},{"line_number":275,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":276,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOH%2F%2Fv8A%3D","line":273,"in_reply_to":"AAAAOH%2F%2FwA4%3D","updated":"2013-03-29 10:31:50.000000000","message":"Done","commit_id":"86b91328cac8fa8537a89b4b96d5783af82379fe"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":271,"context_line":"                self.plugin_rpc.update_device_down(self.context, port[\u0027id\u0027],"},{"line_number":272,"context_line":"                                                   self.agent_id)"},{"line_number":273,"context_line":"        except rpc_common.RPCException as e:"},{"line_number":274,"context_line":"            LOG.exception(_(\"RPC error while updating port %(port)s: %(err)s\"),"},{"line_number":275,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":276,"context_line":"            raise"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2FucU%3D","line":274,"updated":"2013-04-01 09:49:38.000000000","message":"LOG.exception will output the exception automatically.  Consider:\n\nLOG.exception(_(\"RPC error while updating port %s\"), \n                       port[\u0027id\u0027])","commit_id":"e1bb043fef6c0aa553fa9d33d4f5cad9d01f5069"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"50c51159962af8a90bf16dc5fc3a0684ed569ae0","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                self.plugin_rpc.update_device_down(self.context, port[\u0027id\u0027],"},{"line_number":272,"context_line":"                                                   self.agent_id)"},{"line_number":273,"context_line":"        except rpc_common.RPCException as e:"},{"line_number":274,"context_line":"            LOG.exception(_(\"RPC error while updating port %(port)s: %(err)s\"),"},{"line_number":275,"context_line":"                          {\u0027port\u0027: port[\u0027id\u0027], \u0027err\u0027: e})"},{"line_number":276,"context_line":"            raise"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOH%2F%2Fubc%3D","line":274,"in_reply_to":"AAAAOH%2F%2FucU%3D","updated":"2013-04-01 10:05:59.000000000","message":"Done","commit_id":"e1bb043fef6c0aa553fa9d33d4f5cad9d01f5069"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"0b3d623b119edec92269a8f67ed055a898dbff62","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                # update plugin about port status"},{"line_number":272,"context_line":"                self.plugin_rpc.update_device_down(self.context, port[\u0027id\u0027],"},{"line_number":273,"context_line":"                                                   self.agent_id)"},{"line_number":274,"context_line":"        except rpc_common.RPCException as e:"},{"line_number":275,"context_line":"            LOG.exception(_(\"RPC error while updating port %s\"), port[\u0027id\u0027])"},{"line_number":276,"context_line":"            raise"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2F810%3D","line":274,"updated":"2013-04-10 14:55:50.000000000","message":"e isn\u0027t used.","commit_id":"2a72373bff7555ea70e0cd6acbb59d46f9bbae56"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"unresolved":false,"context_lines":[{"line_number":271,"context_line":"                # update plugin about port status"},{"line_number":272,"context_line":"                self.plugin_rpc.update_device_down(self.context, port[\u0027id\u0027],"},{"line_number":273,"context_line":"                                                   self.agent_id)"},{"line_number":274,"context_line":"        except rpc_common.RPCException as e:"},{"line_number":275,"context_line":"            LOG.exception(_(\"RPC error while updating port %s\"), port[\u0027id\u0027])"},{"line_number":276,"context_line":"            raise"},{"line_number":277,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOn%2F%2F80E%3D","line":274,"in_reply_to":"AAAAOn%2F%2F810%3D","updated":"2013-04-10 15:11:43.000000000","message":"Done","commit_id":"2a72373bff7555ea70e0cd6acbb59d46f9bbae56"}]}