)]}'
{"neutron/common/constants.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"336097a197e6eddf0b5dea74cfdbd6dfdc2f7ebf","unresolved":false,"context_lines":[{"line_number":229,"context_line":"CHANGED_SINCE \u003d \u0027changed_since\u0027"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"# standard attribute field"},{"line_number":232,"context_line":"STANDARDATTR \u003d \u0027standard_attr\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_9002566e","line":232,"updated":"2015-12-25 06:22:15.000000000","message":"suggest to rename it as \"STANDARD_ATTR\" for better readability.","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"85829b187e0a0c496731493b417cee79579a154e","unresolved":false,"context_lines":[{"line_number":229,"context_line":"CHANGED_SINCE \u003d \u0027changed_since\u0027"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"# standard attribute field"},{"line_number":232,"context_line":"STANDARDATTR \u003d \u0027standard_attr\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_9687aed6","line":232,"in_reply_to":"1a7b0d38_9002566e","updated":"2015-12-25 08:30:27.000000000","message":"Done","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"}],"neutron/db/common_db_mixin.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"504c9a416e3a18c74a32aa271edf3867026d9051","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                                              constants."},{"line_number":242,"context_line":"                                              RESOURCE_TIMESTAMP_FORMAT)))"},{"line_number":243,"context_line":"                        except Exception:"},{"line_number":244,"context_line":"                            msg \u003d _(\"The input changed_since must be like\""},{"line_number":245,"context_line":"                                    \" YYYY-MM-DDTHH:MM:SSZ\")"},{"line_number":246,"context_line":"                            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":247,"context_line":"                        changed_since_string \u003d timeutils.parse_isotime(data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d81c73c3","line":244,"updated":"2015-11-26 03:14:10.000000000","message":"possible re-wording:\n\nlike -\u003e in the following format:","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"3c4d8d6b7963214dd2cfef78679ffad4f8f66a33","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                                              constants."},{"line_number":242,"context_line":"                                              RESOURCE_TIMESTAMP_FORMAT)))"},{"line_number":243,"context_line":"                        except Exception:"},{"line_number":244,"context_line":"                            msg \u003d _(\"The input changed_since must be like\""},{"line_number":245,"context_line":"                                    \" YYYY-MM-DDTHH:MM:SSZ\")"},{"line_number":246,"context_line":"                            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":247,"context_line":"                        changed_since_string \u003d timeutils.parse_isotime(data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_b4541321","line":244,"in_reply_to":"9a8ffd7b_cf1ca7c3","updated":"2015-11-26 08:46:39.000000000","message":"@all, thanks for review. I will update it.","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":16788,"name":"Ramanjaneya Reddy Palleti","email":"ramanjaneya.palleti@huawei.com","username":"Ramanjaneya"},"change_message_id":"74442bae5746bd45f742c8d13f569fd1625664f9","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                                              constants."},{"line_number":242,"context_line":"                                              RESOURCE_TIMESTAMP_FORMAT)))"},{"line_number":243,"context_line":"                        except Exception:"},{"line_number":244,"context_line":"                            msg \u003d _(\"The input changed_since must be like\""},{"line_number":245,"context_line":"                                    \" YYYY-MM-DDTHH:MM:SSZ\")"},{"line_number":246,"context_line":"                            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":247,"context_line":"                        changed_since_string \u003d timeutils.parse_isotime(data)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_cf1ca7c3","line":244,"in_reply_to":"9a8ffd7b_d81c73c3","updated":"2015-11-26 06:01:25.000000000","message":"+1","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"504c9a416e3a18c74a32aa271edf3867026d9051","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                            msg \u003d _(\"The input changed_since must be like\""},{"line_number":245,"context_line":"                                    \" YYYY-MM-DDTHH:MM:SSZ\")"},{"line_number":246,"context_line":"                            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":247,"context_line":"                        changed_since_string \u003d timeutils.parse_isotime(data)"},{"line_number":248,"context_line":"                        changed_since \u003d (timeutils."},{"line_number":249,"context_line":"                                         normalize_time(changed_since_string))"},{"line_number":250,"context_line":"                        query \u003d query.filter(model.updated_at \u003e\u003d changed_since)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_f855b74f","line":247,"updated":"2015-11-26 03:14:10.000000000","message":"Just a query, do you need this variable?\nIt wont make it too complicated if you just keep the changed_since variable and remove its string instance\n\n\n( You can remove both the variables but that would hamper the readability, which may be another drag)","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"38a6a9507f42f09449e2a0a24fcb390bc74409c0","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                            msg \u003d _(\"The input changed_since must be like\""},{"line_number":245,"context_line":"                                    \" YYYY-MM-DDTHH:MM:SSZ\")"},{"line_number":246,"context_line":"                            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":247,"context_line":"                        changed_since_string \u003d timeutils.parse_isotime(data)"},{"line_number":248,"context_line":"                        changed_since \u003d (timeutils."},{"line_number":249,"context_line":"                                         normalize_time(changed_since_string))"},{"line_number":250,"context_line":"                        query \u003d query.filter(model.updated_at \u003e\u003d changed_since)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_edd96e84","line":247,"in_reply_to":"9a8ffd7b_d742f93d","updated":"2015-11-26 08:51:23.000000000","message":"You dont need this variable.\nIMHO, you can just move this value in the next line( saves one line, reduces one variable )","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"3c4d8d6b7963214dd2cfef78679ffad4f8f66a33","unresolved":false,"context_lines":[{"line_number":244,"context_line":"                            msg \u003d _(\"The input changed_since must be like\""},{"line_number":245,"context_line":"                                    \" YYYY-MM-DDTHH:MM:SSZ\")"},{"line_number":246,"context_line":"                            raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":247,"context_line":"                        changed_since_string \u003d timeutils.parse_isotime(data)"},{"line_number":248,"context_line":"                        changed_since \u003d (timeutils."},{"line_number":249,"context_line":"                                         normalize_time(changed_since_string))"},{"line_number":250,"context_line":"                        query \u003d query.filter(model.updated_at \u003e\u003d changed_since)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d742f93d","line":247,"in_reply_to":"9a8ffd7b_f855b74f","updated":"2015-11-26 08:46:39.000000000","message":"@Reedip\t, yeah, I had considered it before, it\u0027s true that it will confused, or I could make it clear by comments.","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"336097a197e6eddf0b5dea74cfdbd6dfdc2f7ebf","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                            filter(is_shared)"},{"line_number":241,"context_line":"                        )"},{"line_number":242,"context_line":"                    query \u003d query.filter(is_shared)"},{"line_number":243,"context_line":"                elif key \u003d\u003d constants.CHANGED_SINCE:"},{"line_number":244,"context_line":"                    if getattr(model,"},{"line_number":245,"context_line":"                               constants.STANDARDATTR, None) is not None:"},{"line_number":246,"context_line":"                        data \u003d filters[constants.CHANGED_SINCE][0]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_b02c3203","line":243,"updated":"2015-12-25 06:22:15.000000000","message":"How about keeping thr logic in the same format as done in L211.\n\nelif key \u003d\u003d constants.STANDARD_ATTR and hasattr(model, constants.STANDARDATTR):","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"85829b187e0a0c496731493b417cee79579a154e","unresolved":false,"context_lines":[{"line_number":240,"context_line":"                            filter(is_shared)"},{"line_number":241,"context_line":"                        )"},{"line_number":242,"context_line":"                    query \u003d query.filter(is_shared)"},{"line_number":243,"context_line":"                elif key \u003d\u003d constants.CHANGED_SINCE:"},{"line_number":244,"context_line":"                    if getattr(model,"},{"line_number":245,"context_line":"                               constants.STANDARDATTR, None) is not None:"},{"line_number":246,"context_line":"                        data \u003d filters[constants.CHANGED_SINCE][0]"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_161dfebc","line":243,"in_reply_to":"1a7b0d38_b02c3203","updated":"2015-12-25 08:30:27.000000000","message":"Thanks, good suggestion!","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"336097a197e6eddf0b5dea74cfdbd6dfdc2f7ebf","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                        )"},{"line_number":242,"context_line":"                    query \u003d query.filter(is_shared)"},{"line_number":243,"context_line":"                elif key \u003d\u003d constants.CHANGED_SINCE:"},{"line_number":244,"context_line":"                    if getattr(model,"},{"line_number":245,"context_line":"                               constants.STANDARDATTR, None) is not None:"},{"line_number":246,"context_line":"                        data \u003d filters[constants.CHANGED_SINCE][0]"},{"line_number":247,"context_line":"                        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_304122aa","line":244,"updated":"2015-12-25 06:22:15.000000000","message":"Let\u0027s write a detailed comment about what this block does.","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"85829b187e0a0c496731493b417cee79579a154e","unresolved":false,"context_lines":[{"line_number":241,"context_line":"                        )"},{"line_number":242,"context_line":"                    query \u003d query.filter(is_shared)"},{"line_number":243,"context_line":"                elif key \u003d\u003d constants.CHANGED_SINCE:"},{"line_number":244,"context_line":"                    if getattr(model,"},{"line_number":245,"context_line":"                               constants.STANDARDATTR, None) is not None:"},{"line_number":246,"context_line":"                        data \u003d filters[constants.CHANGED_SINCE][0]"},{"line_number":247,"context_line":"                        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_768482d3","line":244,"in_reply_to":"1a7b0d38_304122aa","updated":"2015-12-25 08:30:27.000000000","message":"Thanks, the comment should be added like below.","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"331ba9769f6a9bbf65b0f873f776b71b6979c0c7","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                    # this block is for change_since query"},{"line_number":246,"context_line":"                    # we get the changed_since string from filters."},{"line_number":247,"context_line":"                    # And translate it from string to datetime type."},{"line_number":248,"context_line":"                    # Then compare with the timestamp in db which is"},{"line_number":249,"context_line":"                    # datetime type."},{"line_number":250,"context_line":"                    data \u003d filters[constants.CHANGED_SINCE][0]"},{"line_number":251,"context_line":"                    try:"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a7b0d38_4c7a00f3","line":248,"updated":"2015-12-26 12:19:04.000000000","message":"nit: %s/is/has","commit_id":"1cbb3fe3b4ce7a12f8a9b587ea754afe279889a1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"331ba9769f6a9bbf65b0f873f776b71b6979c0c7","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                    # datetime type."},{"line_number":250,"context_line":"                    data \u003d filters[constants.CHANGED_SINCE][0]"},{"line_number":251,"context_line":"                    try:"},{"line_number":252,"context_line":"                        # This logic is for check the string whether"},{"line_number":253,"context_line":"                        # is based on the designed timestamp_format"},{"line_number":254,"context_line":"                        datetime.datetime.fromtimestamp(time.mktime("},{"line_number":255,"context_line":"                            time.strptime(data,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a7b0d38_6c649c48","line":252,"updated":"2015-12-26 12:19:04.000000000","message":"# this block checks queried timestamp format.","commit_id":"1cbb3fe3b4ce7a12f8a9b587ea754afe279889a1"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"45be9835eba9f036a8fb1d482c5d6be6705d2d20","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                    ext_attr \u003d model.standard_attr.property.mapper.class_"},{"line_number":271,"context_line":"                    query \u003d query.filter(ext_attr.updated_at"},{"line_number":272,"context_line":"                                         \u003e\u003d changed_since)"},{"line_number":273,"context_line":"            for _nam, hooks in six.iteritems(self._model_query_hooks.get(model,"},{"line_number":274,"context_line":"                                                                         {})):"},{"line_number":275,"context_line":"                result_filter \u003d hooks.get(\u0027result_filters\u0027, None)"},{"line_number":276,"context_line":"                if isinstance(result_filter, six.string_types):"}],"source_content_type":"text/x-python","patch_set":20,"id":"7af24918_0dde086d","line":273,"updated":"2016-03-02 02:10:53.000000000","message":"There should be a way to register a model_query_hook so you don\u0027t have to modify the common DB mixin here.\n\nIf not, please let me know and we need to figure out a way to fix the hook so every extension doesn\u0027t need to modify this core code.","commit_id":"5df9627a05770c3c737ee1091e29373b1d4ead45"}],"neutron/tests/unit/extensions/test_timestamp_core.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1df3cad770f34c908c9a546e331c98ba01f84a0c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            self._set_timestamp_by_show(first, resource_type)"},{"line_number":131,"context_line":"            self._set_timestamp_by_show(second, resource_type)"},{"line_number":132,"context_line":"        # update names of second"},{"line_number":133,"context_line":"        time.sleep(2)"},{"line_number":134,"context_line":"        new_second \u003d self._update_test_resource_by_name(second)"},{"line_number":135,"context_line":"        # now the queue of order by"},{"line_number":136,"context_line":"        # updated_at is first \u003c new_second"}],"source_content_type":"text/x-python","patch_set":26,"id":"7af24918_4f7312e8","line":133,"updated":"2016-03-04 22:27:49.000000000","message":"don\u0027t add artificial delays to tests, they may end up exposing/hiding concurrent issues that are difficult to troubleshoot. Consider making this test to avoid relying on the time factor. Use mocking to simulate temporal conditions if you have to.","commit_id":"1b2d549f70a542e8faa109629d8f873d985602e6"}],"neutron/tests/unit/plugins/ml2/test_plugin.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"504c9a416e3a18c74a32aa271edf3867026d9051","unresolved":false,"context_lines":[{"line_number":505,"context_line":"        return resources"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def return_by_timedelay(self, resource, timedelay):"},{"line_number":508,"context_line":"        resource_type \u003d six.next(six.iterkeys(resource))"},{"line_number":509,"context_line":"        try:"},{"line_number":510,"context_line":"            time_create \u003d datetime.datetime.strptime("},{"line_number":511,"context_line":"                resource[resource_type][\u0027updated_at\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_d82b1393","line":508,"updated":"2015-11-26 03:14:10.000000000","message":"Wondering how the next will impact the  unit tests.\nNext being an iterator and all , and the point( atleast what I saw in the Unit Testing of tempest) that UT may not always be executed in the same order as written puts this question in my mind.\nMaybe other reviewers could also help out?","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"504c9a416e3a18c74a32aa271edf3867026d9051","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                resource[resource_type][\u0027updated_at\u0027],"},{"line_number":516,"context_line":"                \u0027%Y-%m-%d %H:%M:%S.%f\u0027)"},{"line_number":517,"context_line":"        time_before \u003d datetime.timedelta(seconds\u003dtimedelay)"},{"line_number":518,"context_line":"        added_time \u003d time_create + time_before"},{"line_number":519,"context_line":"        addedtime_string \u003d (datetime.datetime."},{"line_number":520,"context_line":"                            strftime(added_time,"},{"line_number":521,"context_line":"                                     constants.RESOURCE_TIMESTAMP_FORMAT))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_18099b31","line":518,"updated":"2015-11-26 03:14:10.000000000","message":"Do you need this variable?","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"3c4d8d6b7963214dd2cfef78679ffad4f8f66a33","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                resource[resource_type][\u0027updated_at\u0027],"},{"line_number":516,"context_line":"                \u0027%Y-%m-%d %H:%M:%S.%f\u0027)"},{"line_number":517,"context_line":"        time_before \u003d datetime.timedelta(seconds\u003dtimedelay)"},{"line_number":518,"context_line":"        added_time \u003d time_create + time_before"},{"line_number":519,"context_line":"        addedtime_string \u003d (datetime.datetime."},{"line_number":520,"context_line":"                            strftime(added_time,"},{"line_number":521,"context_line":"                                     constants.RESOURCE_TIMESTAMP_FORMAT))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_b7bad508","line":518,"in_reply_to":"9a8ffd7b_18099b31","updated":"2015-11-26 08:46:39.000000000","message":"@Reedip\t, just for readable.Maybe it can be moved to L520.","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"38a6a9507f42f09449e2a0a24fcb390bc74409c0","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                resource[resource_type][\u0027updated_at\u0027],"},{"line_number":516,"context_line":"                \u0027%Y-%m-%d %H:%M:%S.%f\u0027)"},{"line_number":517,"context_line":"        time_before \u003d datetime.timedelta(seconds\u003dtimedelay)"},{"line_number":518,"context_line":"        added_time \u003d time_create + time_before"},{"line_number":519,"context_line":"        addedtime_string \u003d (datetime.datetime."},{"line_number":520,"context_line":"                            strftime(added_time,"},{"line_number":521,"context_line":"                                     constants.RESOURCE_TIMESTAMP_FORMAT))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_2dce96b4","line":518,"in_reply_to":"9a8ffd7b_b7bad508","updated":"2015-11-26 08:51:23.000000000","message":"Do that, would be great :)","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"504c9a416e3a18c74a32aa271edf3867026d9051","unresolved":false,"context_lines":[{"line_number":595,"context_line":""},{"line_number":596,"context_line":"            # late"},{"line_number":597,"context_line":"            subnetpools \u003d self.return_by_timedelay(subnetpool, 1)"},{"line_number":598,"context_line":"            self.assertEqual([], subnetpools[\u0027subnetpools\u0027])"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":"    def _update_test_resource_by_name(self, resource):"},{"line_number":601,"context_line":"        resource_type \u003d six.next(six.iterkeys(resource))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_7b2d4145","line":598,"updated":"2015-11-26 03:14:10.000000000","message":"Can we possibly use this here? And in other similar scenarios?\nhttps://docs.python.org/2/library/unittest.html#unittest.TestCase.assertListEqual","commit_id":"89dffb80c9c3dedd92d70d52f222e5f37f48e9f3"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"336097a197e6eddf0b5dea74cfdbd6dfdc2f7ebf","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                                     \u0027 after update subnetpool\u0027)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"class TestListCoreResourceWithChangedsince(Ml2PluginV2TestCase):"},{"line_number":528,"context_line":"    def setUp(self, plugin\u003dNone):"},{"line_number":529,"context_line":"        super(TestListCoreResourceWithChangedsince, self).setUp()"},{"line_number":530,"context_line":"        registry.subscribe(resourcetimestamp_db.ResourceTimeStamp_db_mixin()."}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_104666bf","line":527,"range":{"start_line":527,"start_character":6,"end_line":527,"end_character":42},"updated":"2015-12-25 06:22:15.000000000","message":"How about renaming this to \"TestListCoreResourceWithChangedSinceAttr\"","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"85829b187e0a0c496731493b417cee79579a154e","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                                     \u0027 after update subnetpool\u0027)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"class TestListCoreResourceWithChangedsince(Ml2PluginV2TestCase):"},{"line_number":528,"context_line":"    def setUp(self, plugin\u003dNone):"},{"line_number":529,"context_line":"        super(TestListCoreResourceWithChangedsince, self).setUp()"},{"line_number":530,"context_line":"        registry.subscribe(resourcetimestamp_db.ResourceTimeStamp_db_mixin()."}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_3004c248","line":527,"range":{"start_line":527,"start_character":6,"end_line":527,"end_character":42},"in_reply_to":"1a7b0d38_104666bf","updated":"2015-12-25 08:30:27.000000000","message":"Done","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"336097a197e6eddf0b5dea74cfdbd6dfdc2f7ebf","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        return self.get_resp_with_changed_since(resource_type,"},{"line_number":561,"context_line":"                                                addedtime_string)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def test_list_networks_with_changed_since(self):"},{"line_number":564,"context_line":"        with self.network(\u0027net1\u0027) as net:"},{"line_number":565,"context_line":"            # assert list results contain the net info when"},{"line_number":566,"context_line":"            # changed_since equal with the net updated time."}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_9087b6d6","line":563,"updated":"2015-12-25 06:22:15.000000000","message":"IMO a common function would be better which takes resource name and test. Why to replicate the same code everywhere.","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"},{"author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"change_message_id":"85829b187e0a0c496731493b417cee79579a154e","unresolved":false,"context_lines":[{"line_number":560,"context_line":"        return self.get_resp_with_changed_since(resource_type,"},{"line_number":561,"context_line":"                                                addedtime_string)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def test_list_networks_with_changed_since(self):"},{"line_number":564,"context_line":"        with self.network(\u0027net1\u0027) as net:"},{"line_number":565,"context_line":"            # assert list results contain the net info when"},{"line_number":566,"context_line":"            # changed_since equal with the net updated time."}],"source_content_type":"text/x-python","patch_set":7,"id":"1a7b0d38_36283ae2","line":563,"in_reply_to":"1a7b0d38_9087b6d6","updated":"2015-12-25 08:30:27.000000000","message":"Hi, thanks , the creation of different resources may be different based on exist test structure like create port until a network creation. Maybe the test logic should be common, is that OK? I will update.","commit_id":"f5ab2d65081ff1ee6a77087c49b9ae53d47b856e"}]}