)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1408902520c2ab52f306c165f9f5f4ae40d3183f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add extension_manager and support for extensions in linuxbridge agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is extensions mechanism for l2 agents already but it was implemented only"},{"line_number":10,"context_line":"for openvswitch l2 agent. This patch add support for such extensions also for"},{"line_number":11,"context_line":"linuxbridge agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_a9da4849","line":10,"updated":"2015-11-27 10:59:05.000000000","message":"adds","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add extension_manager and support for extensions in linuxbridge agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is extensions mechanism for l2 agents already but it was implemented only"},{"line_number":10,"context_line":"for openvswitch l2 agent. This patch add support for such extensions also for"},{"line_number":11,"context_line":"linuxbridge agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_0ff7b38b","line":10,"in_reply_to":"9a8ffd7b_a9da4849","updated":"2015-11-27 21:53:43.000000000","message":"Done","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1408902520c2ab52f306c165f9f5f4ae40d3183f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is extensions mechanism for l2 agents already but it was implemented only"},{"line_number":10,"context_line":"for openvswitch l2 agent. This patch add support for such extensions also for"},{"line_number":11,"context_line":"linuxbridge agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_29ef38ea","line":11,"updated":"2015-11-27 10:59:05.000000000","message":"add trailing dot.","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is extensions mechanism for l2 agents already but it was implemented only"},{"line_number":10,"context_line":"for openvswitch l2 agent. This patch add support for such extensions also for"},{"line_number":11,"context_line":"linuxbridge agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_aff1c796","line":11,"in_reply_to":"9a8ffd7b_29ef38ea","updated":"2015-11-27 21:53:43.000000000","message":"Done","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1408902520c2ab52f306c165f9f5f4ae40d3183f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is extensions mechanism for l2 agents already but it was implemented only"},{"line_number":10,"context_line":"for openvswitch l2 agent. This patch add support for such extensions also for"},{"line_number":11,"context_line":"linuxbridge agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_e26702e7","line":12,"updated":"2015-11-27 10:59:05.000000000","message":"You should add a new release note (see releasenotes/... subtree in neutron repo; also see \u0027reno\u0027 docs on how to generate release notes). The note should notify that LB agent now supports l2 agent extensions and hence can be extended by 3rd parties using pluggable mechanism.","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is extensions mechanism for l2 agents already but it was implemented only"},{"line_number":10,"context_line":"for openvswitch l2 agent. This patch add support for such extensions also for"},{"line_number":11,"context_line":"linuxbridge agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_8fc2c3e7","line":12,"in_reply_to":"9a8ffd7b_e26702e7","updated":"2015-11-27 21:53:43.000000000","message":"Done. But I\u0027m not sure if I made it correctly because I never do something like that before :)","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1408902520c2ab52f306c165f9f5f4ae40d3183f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"for openvswitch l2 agent. This patch add support for such extensions also for"},{"line_number":11,"context_line":"linuxbridge agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_69d0e01f","line":13,"updated":"2015-11-27 10:59:05.000000000","message":"Link to the rfe bug with Partial-Bug:","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"for openvswitch l2 agent. This patch add support for such extensions also for"},{"line_number":11,"context_line":"linuxbridge agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_afa9c725","line":13,"in_reply_to":"9a8ffd7b_69d0e01f","updated":"2015-11-27 21:53:43.000000000","message":"Done","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e41658acf78dbc0103eeed34cb60dc9580d4d3ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add extension_manager and support for extensions in linuxbridge agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is extensions mechanism for l2 agents already but it was implemented only"},{"line_number":10,"context_line":"for openvswitch l2 agent. This patch adds support for such extensions also for"},{"line_number":11,"context_line":"linuxbridge agent."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ie81c818d0eb817b044a6df1cbddc5864f118fe3f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3a7e1126_d3fc8d40","line":10,"updated":"2015-12-17 15:09:01.000000000","message":"(No action required) Well, it was also implemented for SR-IOV, but meh.","commit_id":"a3f4624cf2c44689571390999a768549d4828750"}],"neutron/plugins/ml2/drivers/linuxbridge/agent/linuxbridge_neutron_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1408902520c2ab52f306c165f9f5f4ae40d3183f","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        # stores received port_updates for processing by the main loop"},{"line_number":826,"context_line":"        self.updated_devices \u003d set()"},{"line_number":827,"context_line":"        # flag to do a sync after revival"},{"line_number":828,"context_line":"        self.fullsync \u003d False"},{"line_number":829,"context_line":"        self.context \u003d context.get_admin_context_without_session()"},{"line_number":830,"context_line":"        self.plugin_rpc \u003d agent_rpc.PluginApi(topics.PLUGIN)"},{"line_number":831,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_e7dcf474","side":"PARENT","line":828,"updated":"2015-11-27 10:59:05.000000000","message":"where did fullsync \u003d False go? If you think that it will be set by report_state, then note that 1) there is no guarantee that report_state will be completed before daemon_loop is started (it\u0027s spawned in a thread); 2) if report_interval \u003d\u003d 0, report_state is not executed at all.","commit_id":"0e9cd620fa60fda5a44baffab06b573e1d791178"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":825,"context_line":"        # stores received port_updates for processing by the main loop"},{"line_number":826,"context_line":"        self.updated_devices \u003d set()"},{"line_number":827,"context_line":"        # flag to do a sync after revival"},{"line_number":828,"context_line":"        self.fullsync \u003d False"},{"line_number":829,"context_line":"        self.context \u003d context.get_admin_context_without_session()"},{"line_number":830,"context_line":"        self.plugin_rpc \u003d agent_rpc.PluginApi(topics.PLUGIN)"},{"line_number":831,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_6f2f5f3f","side":"PARENT","line":828,"in_reply_to":"9a8ffd7b_e7dcf474","updated":"2015-11-27 21:53:43.000000000","message":"Yes, it was my mistake with fullsync flag missing. I added it again to start() method. Sorry","commit_id":"0e9cd620fa60fda5a44baffab06b573e1d791178"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1408902520c2ab52f306c165f9f5f4ae40d3183f","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.agent.updated_devices.add(tap_name)"},{"line_number":708,"context_line":"        LOG.debug(\"port_update RPC received for port: %s\", port_id)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def port_delete(self, context, **kwargs):"},{"line_number":711,"context_line":"        port_id \u003d kwargs[\u0027port\u0027][\u0027id\u0027]"},{"line_number":712,"context_line":"        LOG.debug(\"port_delete RPC received for port: %s\", port_id)"},{"line_number":713,"context_line":"        tap_name \u003d self.agent.br_mgr.get_tap_device_name(port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_7c2df7a6","line":710,"updated":"2015-11-27 10:59:05.000000000","message":"So I looked more closely to how LB agent detects port deletions, and I believe there is no reason to consume notifications for port deletes sent by neutron-server.\n\nIt seems that OVS and LB agent flows are different in that:\n\n- ovs agent relies on RPC notifications to detect that there are deleted ports to handle; device scans are not triggered unless we received a notification from a server;\n- lb agent relies on periodic scans for devices that are unconditionally triggered every daemon loop run.\n\nIt would make sense to consume port notifications to avoid redundant load on the backend while no changes in port devices occurred; but it does not really belong to the patch.\n\nThat said, I need someone more involved in LB agent expected workflow to comment on it.","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"a81d1b00e25c5e45136827f85dd723b4c4312755","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.agent.updated_devices.add(tap_name)"},{"line_number":708,"context_line":"        LOG.debug(\"port_update RPC received for port: %s\", port_id)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def port_delete(self, context, **kwargs):"},{"line_number":711,"context_line":"        port_id \u003d kwargs[\u0027port\u0027][\u0027id\u0027]"},{"line_number":712,"context_line":"        LOG.debug(\"port_delete RPC received for port: %s\", port_id)"},{"line_number":713,"context_line":"        tap_name \u003d self.agent.br_mgr.get_tap_device_name(port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_96598537","line":710,"in_reply_to":"9a8ffd7b_7c2df7a6","updated":"2015-11-27 16:26:14.000000000","message":"I agree. This is how it works today. I\u0027m not sure if we can go to the ovs model here. OVS has the ovsdb event stuff, which notifies the agent, when a new port has been plugged. With lb the detection of new devices only happens via the agent loop. So we can\u0027t get rid of the agent loop. \n\nI don\u0027t see a reason for introducing port_delete.","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.agent.updated_devices.add(tap_name)"},{"line_number":708,"context_line":"        LOG.debug(\"port_update RPC received for port: %s\", port_id)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def port_delete(self, context, **kwargs):"},{"line_number":711,"context_line":"        port_id \u003d kwargs[\u0027port\u0027][\u0027id\u0027]"},{"line_number":712,"context_line":"        LOG.debug(\"port_delete RPC received for port: %s\", port_id)"},{"line_number":713,"context_line":"        tap_name \u003d self.agent.br_mgr.get_tap_device_name(port_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_2c3ac5e7","line":710,"in_reply_to":"9a8ffd7b_96598537","updated":"2015-11-27 21:53:43.000000000","message":"Ok, I removed this method","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"a81d1b00e25c5e45136827f85dd723b4c4312755","unresolved":false,"context_lines":[{"line_number":722,"context_line":"                   \u0027ports\u0027: self.network_ports[network_id]})"},{"line_number":723,"context_line":"        for port_id in self.network_ports[network_id]:"},{"line_number":724,"context_line":"            tap_name \u003d self.agent.br_mgr.get_tap_device_name(port_id)"},{"line_number":725,"context_line":"            if tap_name not in self.agent.deleted_devices:"},{"line_number":726,"context_line":"                self.agent.updated_devices.add(tap_name)"},{"line_number":727,"context_line":""},{"line_number":728,"context_line":"    def fdb_add(self, context, fdb_entries):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_f6f1f195","line":725,"updated":"2015-11-27 16:26:14.000000000","message":"This is a good check. I see, this is why we need something like the deleted_devices list.","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1408902520c2ab52f306c165f9f5f4ae40d3183f","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        # processing by the main loop"},{"line_number":833,"context_line":"        self.updated_devices \u003d set()"},{"line_number":834,"context_line":"        self.deleted_devices \u003d set()"},{"line_number":835,"context_line":"        self.context \u003d context.get_admin_context_without_session()"},{"line_number":836,"context_line":"        self.plugin_rpc \u003d agent_rpc.PluginApi(topics.PLUGIN)"},{"line_number":837,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"},{"line_number":838,"context_line":"        self.sg_agent \u003d sg_rpc.SecurityGroupAgentRpc(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_879de867","line":835,"updated":"2015-11-27 10:59:05.000000000","message":"Note to reviewers: this section is moved here before we need to initialize extension manager before agent_state (it now includes the list of enabled extensions); and manager cannot be initialized before setup_rpc() is called and self.connection is set; and setup_rpc() cannot be called before all self.*_rpc pieces are initialized.\n\nI would use this opportunity to move the self.*_rpc initializations into setup_rpc() but it\u0027s not required for the goal of the patch.","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"a81d1b00e25c5e45136827f85dd723b4c4312755","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        # processing by the main loop"},{"line_number":833,"context_line":"        self.updated_devices \u003d set()"},{"line_number":834,"context_line":"        self.deleted_devices \u003d set()"},{"line_number":835,"context_line":"        self.context \u003d context.get_admin_context_without_session()"},{"line_number":836,"context_line":"        self.plugin_rpc \u003d agent_rpc.PluginApi(topics.PLUGIN)"},{"line_number":837,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"},{"line_number":838,"context_line":"        self.sg_agent \u003d sg_rpc.SecurityGroupAgentRpc(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c32e71fa","line":835,"in_reply_to":"9a8ffd7b_879de867","updated":"2015-11-27 16:26:14.000000000","message":"moving those methods into setup_rpc makes sense!","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":832,"context_line":"        # processing by the main loop"},{"line_number":833,"context_line":"        self.updated_devices \u003d set()"},{"line_number":834,"context_line":"        self.deleted_devices \u003d set()"},{"line_number":835,"context_line":"        self.context \u003d context.get_admin_context_without_session()"},{"line_number":836,"context_line":"        self.plugin_rpc \u003d agent_rpc.PluginApi(topics.PLUGIN)"},{"line_number":837,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"},{"line_number":838,"context_line":"        self.sg_agent \u003d sg_rpc.SecurityGroupAgentRpc(self.context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_cc7bf9bc","line":835,"in_reply_to":"9a8ffd7b_c32e71fa","updated":"2015-11-27 21:53:43.000000000","message":"Done. I hope You was talking about something like that :)","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"a81d1b00e25c5e45136827f85dd723b4c4312755","unresolved":false,"context_lines":[{"line_number":846,"context_line":"            configurations[\u0027tunneling_ip\u0027] \u003d self.br_mgr.local_ip"},{"line_number":847,"context_line":"            configurations[\u0027tunnel_types\u0027] \u003d [p_const.TYPE_VXLAN]"},{"line_number":848,"context_line":"            configurations[\u0027l2_population\u0027] \u003d cfg.CONF.VXLAN.l2_population"},{"line_number":849,"context_line":"        configurations[\u0027extensions\u0027] \u003d self.ext_manager.names()"},{"line_number":850,"context_line":"        self.agent_state \u003d {"},{"line_number":851,"context_line":"            \u0027binary\u0027: \u0027neutron-linuxbridge-agent\u0027,"},{"line_number":852,"context_line":"            \u0027host\u0027: cfg.CONF.host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_e39b7516","line":849,"updated":"2015-11-27 16:26:14.000000000","message":"why not add this during configuration initialisation (L 844)?","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":846,"context_line":"            configurations[\u0027tunneling_ip\u0027] \u003d self.br_mgr.local_ip"},{"line_number":847,"context_line":"            configurations[\u0027tunnel_types\u0027] \u003d [p_const.TYPE_VXLAN]"},{"line_number":848,"context_line":"            configurations[\u0027l2_population\u0027] \u003d cfg.CONF.VXLAN.l2_population"},{"line_number":849,"context_line":"        configurations[\u0027extensions\u0027] \u003d self.ext_manager.names()"},{"line_number":850,"context_line":"        self.agent_state \u003d {"},{"line_number":851,"context_line":"            \u0027binary\u0027: \u0027neutron-linuxbridge-agent\u0027,"},{"line_number":852,"context_line":"            \u0027host\u0027: cfg.CONF.host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_cca4594c","line":849,"in_reply_to":"9a8ffd7b_e39b7516","updated":"2015-11-27 21:53:43.000000000","message":"Done","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"a81d1b00e25c5e45136827f85dd723b4c4312755","unresolved":false,"context_lines":[{"line_number":908,"context_line":"                                                  self.sg_agent)]"},{"line_number":909,"context_line":"        # Define the listening consumers for the agent"},{"line_number":910,"context_line":"        consumers \u003d [[topics.PORT, topics.UPDATE],"},{"line_number":911,"context_line":"                     [topics.PORT, topics.DELETE],"},{"line_number":912,"context_line":"                     [topics.NETWORK, topics.DELETE],"},{"line_number":913,"context_line":"                     [topics.SECURITY_GROUP, topics.UPDATE],"},{"line_number":914,"context_line":"                     [topics.NETWORK, topics.UPDATE]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_d60b8dd4","line":911,"updated":"2015-11-27 16:26:14.000000000","message":"not required, if we remove the port_delete","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":908,"context_line":"                                                  self.sg_agent)]"},{"line_number":909,"context_line":"        # Define the listening consumers for the agent"},{"line_number":910,"context_line":"        consumers \u003d [[topics.PORT, topics.UPDATE],"},{"line_number":911,"context_line":"                     [topics.PORT, topics.DELETE],"},{"line_number":912,"context_line":"                     [topics.NETWORK, topics.DELETE],"},{"line_number":913,"context_line":"                     [topics.SECURITY_GROUP, topics.UPDATE],"},{"line_number":914,"context_line":"                     [topics.NETWORK, topics.UPDATE]]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_8f05e311","line":911,"in_reply_to":"9a8ffd7b_d60b8dd4","updated":"2015-11-27 21:53:43.000000000","message":"Removed","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1408902520c2ab52f306c165f9f5f4ae40d3183f","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                LOG.info(_LI(\"Port %s updated.\"), device)"},{"line_number":1026,"context_line":"            else:"},{"line_number":1027,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1028,"context_line":"            self.ext_manager.delete_port(self.context, {\u0027device_name\u0027: device})"},{"line_number":1029,"context_line":"        if self.prevent_arp_spoofing:"},{"line_number":1030,"context_line":"            arp_protect.delete_arp_spoofing_protection(devices)"},{"line_number":1031,"context_line":"        return resync"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_2770bcdb","line":1028,"updated":"2015-11-27 10:59:05.000000000","message":"The payload that you push into delete_port must be a dict with \u0027port_id\u0027: id keyval pair; and more key:vals depending on what is needed for your backend.","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                LOG.info(_LI(\"Port %s updated.\"), device)"},{"line_number":1026,"context_line":"            else:"},{"line_number":1027,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1028,"context_line":"            self.ext_manager.delete_port(self.context, {\u0027device_name\u0027: device})"},{"line_number":1029,"context_line":"        if self.prevent_arp_spoofing:"},{"line_number":1030,"context_line":"            arp_protect.delete_arp_spoofing_protection(devices)"},{"line_number":1031,"context_line":"        return resync"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_af6b0784","line":1028,"in_reply_to":"9a8ffd7b_2770bcdb","updated":"2015-11-27 21:53:43.000000000","message":"I also thought that but unfortunatelly there is no more details in this place :/\nI checked now on devstack: \"device\" is set set([\u0027tap063582b4-8f\u0027]) and details is dict: \"{u\u0027device\u0027: u\u0027tap063582b4-8f\u0027, u\u0027exists\u0027: True}\".","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.agent.updated_devices.add(tap_name)"},{"line_number":708,"context_line":"        LOG.debug(\"port_update RPC received for port: %s\", port_id)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def network_update(self, context, **kwargs):"},{"line_number":711,"context_line":"        network_id \u003d kwargs[\u0027network\u0027][\u0027id\u0027]"},{"line_number":712,"context_line":"        LOG.debug(\"network_update message processed for network \""},{"line_number":713,"context_line":"                  \"%(network_id)s, with ports: %(ports)s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_68ec19bb","line":710,"updated":"2015-11-30 09:24:53.000000000","message":"Network update is required, as some extensions should be triggered on network_update?","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e64b3c0360f16563c1abaa24f694b0b0af1324b5","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.agent.updated_devices.add(tap_name)"},{"line_number":708,"context_line":"        LOG.debug(\"port_update RPC received for port: %s\", port_id)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def network_update(self, context, **kwargs):"},{"line_number":711,"context_line":"        network_id \u003d kwargs[\u0027network\u0027][\u0027id\u0027]"},{"line_number":712,"context_line":"        LOG.debug(\"network_update message processed for network \""},{"line_number":713,"context_line":"                  \"%(network_id)s, with ports: %(ports)s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_c214a24e","line":710,"in_reply_to":"9a8ffd7b_6051690e","updated":"2015-12-01 17:12:40.000000000","message":"Yes.","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9e2f608d6eb8b198ccc26d08440a46f9bdf882fb","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.agent.updated_devices.add(tap_name)"},{"line_number":708,"context_line":"        LOG.debug(\"port_update RPC received for port: %s\", port_id)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def network_update(self, context, **kwargs):"},{"line_number":711,"context_line":"        network_id \u003d kwargs[\u0027network\u0027][\u0027id\u0027]"},{"line_number":712,"context_line":"        LOG.debug(\"network_update message processed for network \""},{"line_number":713,"context_line":"                  \"%(network_id)s, with ports: %(ports)s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_fbf5dfec","line":710,"in_reply_to":"9a8ffd7b_6051690e","updated":"2015-12-01 17:32:01.000000000","message":"yes! \n\n@Ihar: Thanks!","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25a864df670da68ff0dce86669c2b3ea0a9ce8bb","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.agent.updated_devices.add(tap_name)"},{"line_number":708,"context_line":"        LOG.debug(\"port_update RPC received for port: %s\", port_id)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def network_update(self, context, **kwargs):"},{"line_number":711,"context_line":"        network_id \u003d kwargs[\u0027network\u0027][\u0027id\u0027]"},{"line_number":712,"context_line":"        LOG.debug(\"network_update message processed for network \""},{"line_number":713,"context_line":"                  \"%(network_id)s, with ports: %(ports)s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_c2c867ab","line":710,"in_reply_to":"9a8ffd7b_68ec19bb","updated":"2015-11-30 16:20:54.000000000","message":"QoS extension supports policy inheritance, when ports inherit QoS policy from networks unless they have their own specific policy set.","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":707,"context_line":"        self.agent.updated_devices.add(tap_name)"},{"line_number":708,"context_line":"        LOG.debug(\"port_update RPC received for port: %s\", port_id)"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"    def network_update(self, context, **kwargs):"},{"line_number":711,"context_line":"        network_id \u003d kwargs[\u0027network\u0027][\u0027id\u0027]"},{"line_number":712,"context_line":"        LOG.debug(\"network_update message processed for network \""},{"line_number":713,"context_line":"                  \"%(network_id)s, with ports: %(ports)s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_6051690e","line":710,"in_reply_to":"9a8ffd7b_c2c867ab","updated":"2015-11-30 22:07:34.000000000","message":"So I think that this method should stay here because we might need to handle network_update events. Am I right?","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"6c54e5aed2b6bc3c06bd9d28ec59bd0f610ff0b7","unresolved":false,"context_lines":[{"line_number":713,"context_line":"                  \"%(network_id)s, with ports: %(ports)s\","},{"line_number":714,"context_line":"                  {\u0027network_id\u0027: network_id,"},{"line_number":715,"context_line":"                   \u0027ports\u0027: self.network_ports[network_id]})"},{"line_number":716,"context_line":"        for port_id in self.network_ports[network_id]:"},{"line_number":717,"context_line":"            tap_name \u003d self.agent.br_mgr.get_tap_device_name(port_id)"},{"line_number":718,"context_line":"            if tap_name not in self.agent.deleted_devices:"},{"line_number":719,"context_line":"                self.agent.updated_devices.add(tap_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_346bc886","line":716,"updated":"2015-11-30 09:56:22.000000000","message":"self.network_ports does not exist","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":713,"context_line":"                  \"%(network_id)s, with ports: %(ports)s\","},{"line_number":714,"context_line":"                  {\u0027network_id\u0027: network_id,"},{"line_number":715,"context_line":"                   \u0027ports\u0027: self.network_ports[network_id]})"},{"line_number":716,"context_line":"        for port_id in self.network_ports[network_id]:"},{"line_number":717,"context_line":"            tap_name \u003d self.agent.br_mgr.get_tap_device_name(port_id)"},{"line_number":718,"context_line":"            if tap_name not in self.agent.deleted_devices:"},{"line_number":719,"context_line":"                self.agent.updated_devices.add(tap_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_203fe1d7","line":716,"in_reply_to":"9a8ffd7b_346bc886","updated":"2015-11-30 22:07:34.000000000","message":"True, I added it now","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":715,"context_line":"                   \u0027ports\u0027: self.network_ports[network_id]})"},{"line_number":716,"context_line":"        for port_id in self.network_ports[network_id]:"},{"line_number":717,"context_line":"            tap_name \u003d self.agent.br_mgr.get_tap_device_name(port_id)"},{"line_number":718,"context_line":"            if tap_name not in self.agent.deleted_devices:"},{"line_number":719,"context_line":"                self.agent.updated_devices.add(tap_name)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    def fdb_add(self, context, fdb_entries):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_289b7119","line":718,"updated":"2015-11-30 09:24:53.000000000","message":"self.agent.deleted_devices will never contain an entry. We should get rid of this condition and rather do some checking in the scan_devices method right before the return. See my comment there","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":715,"context_line":"                   \u0027ports\u0027: self.network_ports[network_id]})"},{"line_number":716,"context_line":"        for port_id in self.network_ports[network_id]:"},{"line_number":717,"context_line":"            tap_name \u003d self.agent.br_mgr.get_tap_device_name(port_id)"},{"line_number":718,"context_line":"            if tap_name not in self.agent.deleted_devices:"},{"line_number":719,"context_line":"                self.agent.updated_devices.add(tap_name)"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"    def fdb_add(self, context, fdb_entries):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_43254fac","line":718,"in_reply_to":"9a8ffd7b_289b7119","updated":"2015-11-30 22:07:34.000000000","message":"I removed this check from here","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        # stores received port_updates and port_deletes for"},{"line_number":825,"context_line":"        # processing by the main loop"},{"line_number":826,"context_line":"        self.updated_devices \u003d set()"},{"line_number":827,"context_line":"        self.deleted_devices \u003d set()"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        # flag to do a sync after revival"},{"line_number":830,"context_line":"        self.fullsync \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_e85b2984","line":827,"updated":"2015-11-30 09:24:53.000000000","message":"there is never an deleted device added, so this is obosolete","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        # stores received port_updates and port_deletes for"},{"line_number":825,"context_line":"        # processing by the main loop"},{"line_number":826,"context_line":"        self.updated_devices \u003d set()"},{"line_number":827,"context_line":"        self.deleted_devices \u003d set()"},{"line_number":828,"context_line":""},{"line_number":829,"context_line":"        # flag to do a sync after revival"},{"line_number":830,"context_line":"        self.fullsync \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_2324cbad","line":827,"in_reply_to":"9a8ffd7b_e85b2984","updated":"2015-11-30 22:07:34.000000000","message":"Yes, I forgot to remove it after I removed delete_port method","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"25a864df670da68ff0dce86669c2b3ea0a9ce8bb","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"                LOG.info(_LI(\"Port %s updated.\"), device)"},{"line_number":1025,"context_line":"            else:"},{"line_number":1026,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1027,"context_line":"            self.ext_manager.delete_port(self.context, {\u0027device_name\u0027: device})"},{"line_number":1028,"context_line":"        if self.prevent_arp_spoofing:"},{"line_number":1029,"context_line":"            arp_protect.delete_arp_spoofing_protection(devices)"},{"line_number":1030,"context_line":"        return resync"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_c2db874e","line":1027,"updated":"2015-11-30 16:20:54.000000000","message":"We still need to fix the payload here. Extensions rely on the fact that we know port-id for devices. If we currently don\u0027t, we should think of where we can extract it from (I suspect ovs agent does store it in ovsdb; if needed, we may need to fetch it from neutron-server somehow).","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":1024,"context_line":"                LOG.info(_LI(\"Port %s updated.\"), device)"},{"line_number":1025,"context_line":"            else:"},{"line_number":1026,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1027,"context_line":"            self.ext_manager.delete_port(self.context, {\u0027device_name\u0027: device})"},{"line_number":1028,"context_line":"        if self.prevent_arp_spoofing:"},{"line_number":1029,"context_line":"            arp_protect.delete_arp_spoofing_protection(devices)"},{"line_number":1030,"context_line":"        return resync"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_9919647c","line":1027,"in_reply_to":"9a8ffd7b_c2db874e","updated":"2015-11-30 22:07:34.000000000","message":"I made it with \"network_ports\" dict which is now storing port_ids and device names for each configured port. It is quite similar like in ovs agent but here instead of \"set\" of port_ids for each network there is list of dicts.\nIMO this is simplest solution because it is not so easy to get it from ML2 plugin when we are sending device name (tapXXX) as port \"identifier\" in rpc call \"update_device_down\"","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":1026,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1027,"context_line":"            self.ext_manager.delete_port(self.context, {\u0027device_name\u0027: device})"},{"line_number":1028,"context_line":"        if self.prevent_arp_spoofing:"},{"line_number":1029,"context_line":"            arp_protect.delete_arp_spoofing_protection(devices)"},{"line_number":1030,"context_line":"        return resync"},{"line_number":1031,"context_line":""},{"line_number":1032,"context_line":"    def scan_devices(self, previous, sync):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_8ed14525","line":1029,"updated":"2015-11-30 09:24:53.000000000","message":"I wonder if we could make the arp spoofing stuff an extension (of course not in this patchset, but maybe in a later one)? Any thoughts?\n\nProbably the show stopper is line 1057","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"        # And same for deleted_devices"},{"line_number":1042,"context_line":"        deleted_devices \u003d self.deleted_devices"},{"line_number":1043,"context_line":"        self.deleted_devices \u003d set()"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        current_devices \u003d self.br_mgr.get_tap_devices()"},{"line_number":1046,"context_line":"        device_info[\u0027current\u0027] \u003d current_devices"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_28f4d158","line":1043,"updated":"2015-11-30 09:24:53.000000000","message":"there is never an deleted device added, so those 2 lines are obsolete","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"        # And same for deleted_devices"},{"line_number":1042,"context_line":"        deleted_devices \u003d self.deleted_devices"},{"line_number":1043,"context_line":"        self.deleted_devices \u003d set()"},{"line_number":1044,"context_line":""},{"line_number":1045,"context_line":"        current_devices \u003d self.br_mgr.get_tap_devices()"},{"line_number":1046,"context_line":"        device_info[\u0027current\u0027] \u003d current_devices"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_833337f6","line":1043,"in_reply_to":"9a8ffd7b_28f4d158","updated":"2015-11-30 22:07:34.000000000","message":"Yes, I removed it. Thx","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"            # Retry cleaning devices that may not have been cleaned properly."},{"line_number":1065,"context_line":"            # And clean any that disappeared since the previous iteration."},{"line_number":1066,"context_line":"            device_info[\u0027removed\u0027] \u003d (previous[\u0027removed\u0027] | previous[\u0027current\u0027]"},{"line_number":1067,"context_line":"                                      - current_devices) | deleted_devices"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"            # Retry updating devices that may not have been updated properly."},{"line_number":1070,"context_line":"            # And any that were updated since the previous iteration."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_c8e665af","line":1067,"updated":"2015-11-30 09:24:53.000000000","message":"see comment above","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":1064,"context_line":"            # Retry cleaning devices that may not have been cleaned properly."},{"line_number":1065,"context_line":"            # And clean any that disappeared since the previous iteration."},{"line_number":1066,"context_line":"            device_info[\u0027removed\u0027] \u003d (previous[\u0027removed\u0027] | previous[\u0027current\u0027]"},{"line_number":1067,"context_line":"                                      - current_devices) | deleted_devices"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"            # Retry updating devices that may not have been updated properly."},{"line_number":1070,"context_line":"            # And any that were updated since the previous iteration."}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_a3475b4a","line":1067,"in_reply_to":"9a8ffd7b_c8e665af","updated":"2015-11-30 22:07:34.000000000","message":"Done","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"        else:"},{"line_number":1075,"context_line":"            device_info[\u0027added\u0027] \u003d current_devices - previous[\u0027current\u0027]"},{"line_number":1076,"context_line":"            device_info[\u0027removed\u0027] \u003d (previous[\u0027current\u0027] - current_devices"},{"line_number":1077,"context_line":"                                      | deleted_devices)"},{"line_number":1078,"context_line":"            device_info[\u0027updated\u0027] \u003d updated_devices \u0026 current_devices"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"        return device_info"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_e8e9e97f","line":1077,"updated":"2015-11-30 09:24:53.000000000","message":"see comment above","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":1074,"context_line":"        else:"},{"line_number":1075,"context_line":"            device_info[\u0027added\u0027] \u003d current_devices - previous[\u0027current\u0027]"},{"line_number":1076,"context_line":"            device_info[\u0027removed\u0027] \u003d (previous[\u0027current\u0027] - current_devices"},{"line_number":1077,"context_line":"                                      | deleted_devices)"},{"line_number":1078,"context_line":"            device_info[\u0027updated\u0027] \u003d updated_devices \u0026 current_devices"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"        return device_info"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_43730fb5","line":1077,"in_reply_to":"9a8ffd7b_e8e9e97f","updated":"2015-11-30 22:07:34.000000000","message":"Done","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"            device_info[\u0027added\u0027] \u003d current_devices - previous[\u0027current\u0027]"},{"line_number":1076,"context_line":"            device_info[\u0027removed\u0027] \u003d (previous[\u0027current\u0027] - current_devices"},{"line_number":1077,"context_line":"                                      | deleted_devices)"},{"line_number":1078,"context_line":"            device_info[\u0027updated\u0027] \u003d updated_devices \u0026 current_devices"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"        return device_info"},{"line_number":1081,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_2b884b70","line":1078,"updated":"2015-11-30 09:24:53.000000000","message":"Instead of introducing and using deleted_devices, exclude the removed devices from updated list:\n\ndevice_info[\u0027updated\u0027] \u003d (updated_devices \u0026 current_devices) - device_info[\u0027removed\u0027]\n\nWill this have the same effect?","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"            device_info[\u0027added\u0027] \u003d current_devices - previous[\u0027current\u0027]"},{"line_number":1076,"context_line":"            device_info[\u0027removed\u0027] \u003d (previous[\u0027current\u0027] - current_devices"},{"line_number":1077,"context_line":"                                      | deleted_devices)"},{"line_number":1078,"context_line":"            device_info[\u0027updated\u0027] \u003d updated_devices \u0026 current_devices"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"        return device_info"},{"line_number":1081,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_03a42706","line":1078,"in_reply_to":"9a8ffd7b_2b884b70","updated":"2015-11-30 22:07:34.000000000","message":"Should be the same :) Done","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"0304e580b56ec87f491031f5bb1d7a8fcc1eed54","unresolved":false,"context_lines":[{"line_number":1075,"context_line":"            device_info[\u0027added\u0027] \u003d current_devices - previous[\u0027current\u0027]"},{"line_number":1076,"context_line":"            device_info[\u0027removed\u0027] \u003d (previous[\u0027current\u0027] - current_devices"},{"line_number":1077,"context_line":"                                      | deleted_devices)"},{"line_number":1078,"context_line":"            device_info[\u0027updated\u0027] \u003d updated_devices \u0026 current_devices"},{"line_number":1079,"context_line":""},{"line_number":1080,"context_line":"        return device_info"},{"line_number":1081,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_7e4d86c3","line":1078,"in_reply_to":"9a8ffd7b_2b884b70","updated":"2015-11-30 21:32:48.000000000","message":"agree Andress, I think it\u0027s OK","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"433aa08f2daf71794877dc8408212b2dcf53eaf7","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        tap_device_name \u003d self.br_mgr.get_tap_device_name(interface_id)"},{"line_number":936,"context_line":"        return self.br_mgr.remove_interface(bridge_name, tap_device_name)"},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"    def _clean_network_ports(self, device):"},{"line_number":939,"context_line":"        for ports_list in self.network_ports.values():"},{"line_number":940,"context_line":"            for port_data in ports_list:"},{"line_number":941,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_fc0b9522","line":938,"updated":"2015-12-01 14:28:16.000000000","message":"missing a small basic test for those 2 methods","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"202fb966300641c2f5c7358d19ad1c8dabeeb035","unresolved":false,"context_lines":[{"line_number":935,"context_line":"        tap_device_name \u003d self.br_mgr.get_tap_device_name(interface_id)"},{"line_number":936,"context_line":"        return self.br_mgr.remove_interface(bridge_name, tap_device_name)"},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"    def _clean_network_ports(self, device):"},{"line_number":939,"context_line":"        for ports_list in self.network_ports.values():"},{"line_number":940,"context_line":"            for port_data in ports_list:"},{"line_number":941,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_23e806e2","line":938,"in_reply_to":"9a8ffd7b_fc0b9522","updated":"2015-12-01 21:22:27.000000000","message":"I added it in new patchset","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"433aa08f2daf71794877dc8408212b2dcf53eaf7","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                    ports_list.remove(port_data)"},{"line_number":943,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    def _update_port_network(self, network_id, port_id, device):"},{"line_number":946,"context_line":"        self._clean_network_ports(device)"},{"line_number":947,"context_line":"        self.network_ports[network_id].append({"},{"line_number":948,"context_line":"            \"port_id\": port_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_fb287f35","line":945,"updated":"2015-12-01 14:28:16.000000000","message":"I don\u0027t like the name _update_port_network. I personally would prefer _update_network_ports along _clean_network_ports and the network_ports dict","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"202fb966300641c2f5c7358d19ad1c8dabeeb035","unresolved":false,"context_lines":[{"line_number":942,"context_line":"                    ports_list.remove(port_data)"},{"line_number":943,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":944,"context_line":""},{"line_number":945,"context_line":"    def _update_port_network(self, network_id, port_id, device):"},{"line_number":946,"context_line":"        self._clean_network_ports(device)"},{"line_number":947,"context_line":"        self.network_ports[network_id].append({"},{"line_number":948,"context_line":"            \"port_id\": port_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_0cd65427","line":945,"in_reply_to":"9a8ffd7b_fb287f35","updated":"2015-12-01 21:22:27.000000000","message":"I was never good in naming classes and functions :) thx for Your suggestions. I changed it to update_network_ports()","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"e3e96bfd47742e6dbc5070300c49813bbf180c38","unresolved":false,"context_lines":[{"line_number":898,"context_line":"        self.plugin_rpc \u003d agent_rpc.PluginApi(topics.PLUGIN)"},{"line_number":899,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"},{"line_number":900,"context_line":"        self.sg_agent \u003d sg_rpc.SecurityGroupAgentRpc(self.context,"},{"line_number":901,"context_line":"                self.sg_plugin_rpc, defer_refresh_firewall\u003dTrue)"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        self.agent_id \u003d \u0027%s%s\u0027 % (\u0027lb\u0027, (mac.replace(\":\", \"\")))"},{"line_number":904,"context_line":"        LOG.info(_LI(\"RPC agent_id: %s\"), self.agent_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_8aca0d19","line":901,"updated":"2015-12-02 09:17:12.000000000","message":"nit: fix indentation\n\n  self.sg_agent \u003d ... (\n      self.context, self.sg_plugin_rpc, ...)\n\n--\u003e 4 blanks + self.context to next line","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"445f714f40fb994709c635d8cbc4f5de5809426e","unresolved":false,"context_lines":[{"line_number":898,"context_line":"        self.plugin_rpc \u003d agent_rpc.PluginApi(topics.PLUGIN)"},{"line_number":899,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"},{"line_number":900,"context_line":"        self.sg_agent \u003d sg_rpc.SecurityGroupAgentRpc(self.context,"},{"line_number":901,"context_line":"                self.sg_plugin_rpc, defer_refresh_firewall\u003dTrue)"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"        self.agent_id \u003d \u0027%s%s\u0027 % (\u0027lb\u0027, (mac.replace(\":\", \"\")))"},{"line_number":904,"context_line":"        LOG.info(_LI(\"RPC agent_id: %s\"), self.agent_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_04326810","line":901,"in_reply_to":"9a8ffd7b_8aca0d19","updated":"2015-12-02 20:38:54.000000000","message":"Done","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"e3e96bfd47742e6dbc5070300c49813bbf180c38","unresolved":false,"context_lines":[{"line_number":941,"context_line":""},{"line_number":942,"context_line":"    def _clean_network_ports(self, device):"},{"line_number":943,"context_line":"        for ports_list in self.network_ports.values():"},{"line_number":944,"context_line":"            for port_data in ports_list:"},{"line_number":945,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":946,"context_line":"                    ports_list.remove(port_data)"},{"line_number":947,"context_line":"                    return port_data[\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_5eee268c","line":944,"updated":"2015-12-02 09:17:12.000000000","message":"My only concern with this dict in list approach is the additional complexity with the nested loop. _clean_neworrk_ports is called relatively often (on every add/update/delete of a port). Maybe using a dict (using device as key) instead of al list helps?\n  network_ports[network_id].[device] \u003d port_data   # port_data is a dict again\n\n--\u003e So would be 3 nested dicts...I\u0027m not a python performance expert, so I can\u0027t asses the impact very well. Maybe using a dict does not make sense at all. Ideas?","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"445f714f40fb994709c635d8cbc4f5de5809426e","unresolved":false,"context_lines":[{"line_number":941,"context_line":""},{"line_number":942,"context_line":"    def _clean_network_ports(self, device):"},{"line_number":943,"context_line":"        for ports_list in self.network_ports.values():"},{"line_number":944,"context_line":"            for port_data in ports_list:"},{"line_number":945,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":946,"context_line":"                    ports_list.remove(port_data)"},{"line_number":947,"context_line":"                    return port_data[\u0027port_id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_cf7eb91a","line":944,"in_reply_to":"9a8ffd7b_5eee268c","updated":"2015-12-02 20:38:54.000000000","message":"I know that this is not perfect solution but I made it like that because I have to put as payload to ext_manager.delete_port() method \"port_id\". Problem is that ML2 plugin not sends it in port_details when self.plugin_rpc.update_device_down() is called. So I could do it here in that way or patch ML2 plugin. I choose this solution because IMHO it is simplier. What do You think about it?\nAbout performance I think that it is not big problem even if it will take few miliseconds more to find proper port in list.","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"b8f111458bdb4931d9e16fe1170d1e0e401ff2cf","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"                LOG.info(_LI(\"Port %s updated.\"), device)"},{"line_number":1080,"context_line":"            else:"},{"line_number":1081,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1082,"context_line":"            port_id \u003d self._clean_network_ports(device)"},{"line_number":1083,"context_line":"            self.ext_manager.delete_port(self.context,"},{"line_number":1084,"context_line":"                                         {\u0027device_name\u0027: device,"},{"line_number":1085,"context_line":"                                          \u0027port_id\u0027: port_id})"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_06bfdaaa","line":1082,"updated":"2015-12-02 16:58:02.000000000","message":"should we verify the return value?","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"445f714f40fb994709c635d8cbc4f5de5809426e","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"                LOG.info(_LI(\"Port %s updated.\"), device)"},{"line_number":1080,"context_line":"            else:"},{"line_number":1081,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1082,"context_line":"            port_id \u003d self._clean_network_ports(device)"},{"line_number":1083,"context_line":"            self.ext_manager.delete_port(self.context,"},{"line_number":1084,"context_line":"                                         {\u0027device_name\u0027: device,"},{"line_number":1085,"context_line":"                                          \u0027port_id\u0027: port_id})"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_4fc1692e","line":1082,"in_reply_to":"9a8ffd7b_06bfdaaa","updated":"2015-12-02 20:38:54.000000000","message":"I made it like because I need port_id to pass it to ext_manager.delete_port method and I think that it is not neccessary to call two methods here (get_port_id and then clean_network_ports).","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"2f731c32f6f044eff89833557030716bca3a958e","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        self.agent \u003d agent"},{"line_number":682,"context_line":"        self.sg_agent \u003d sg_agent"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def network_delete(self, context, **kwargs):"},{"line_number":685,"context_line":"        LOG.debug(\"network_delete received\")"},{"line_number":686,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_dedb46ec","line":684,"updated":"2015-12-04 09:51:28.000000000","message":"remove the network_id from the network_ports list","commit_id":"aa03b0a7b3997c8837cf25a5729c45b5f04b0d86"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"878d1705e8c72bec0290ec16e4809bc32aef943d","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        self.agent \u003d agent"},{"line_number":682,"context_line":"        self.sg_agent \u003d sg_agent"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def network_delete(self, context, **kwargs):"},{"line_number":685,"context_line":"        LOG.debug(\"network_delete received\")"},{"line_number":686,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_5bc50f3a","line":684,"in_reply_to":"7a740942_d5d1cece","updated":"2015-12-04 17:05:44.000000000","message":"Done","commit_id":"aa03b0a7b3997c8837cf25a5729c45b5f04b0d86"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"22270cf7f4d98a306e16bf8c9220c30a42b129a0","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        self.agent \u003d agent"},{"line_number":682,"context_line":"        self.sg_agent \u003d sg_agent"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def network_delete(self, context, **kwargs):"},{"line_number":685,"context_line":"        LOG.debug(\"network_delete received\")"},{"line_number":686,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":687,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_d5d1cece","line":684,"in_reply_to":"7a740942_dedb46ec","updated":"2015-12-04 16:33:15.000000000","message":"+1","commit_id":"aa03b0a7b3997c8837cf25a5729c45b5f04b0d86"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5f5f2f7155baeae63da3de9040a38cd75dfcc244","unresolved":false,"context_lines":[{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        # stores received port_updates and port_deletes for"},{"line_number":829,"context_line":"        # processing by the main loop"},{"line_number":830,"context_line":"        self.updated_devices \u003d set()"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        # stores all configured ports on agent:"},{"line_number":833,"context_line":"        self.network_ports \u003d collections.defaultdict(list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_c3684d8a","line":830,"updated":"2015-12-10 03:42:59.000000000","message":"Why we have moved these statements up? Is this change related?","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e6b80f0f12d20c5745b06d506555b385c06d109e","unresolved":false,"context_lines":[{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        # stores received port_updates and port_deletes for"},{"line_number":829,"context_line":"        # processing by the main loop"},{"line_number":830,"context_line":"        self.updated_devices \u003d set()"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        # stores all configured ports on agent:"},{"line_number":833,"context_line":"        self.network_ports \u003d collections.defaultdict(list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_af39f1d8","line":830,"in_reply_to":"7a740942_40a8a177","updated":"2015-12-19 11:15:25.000000000","message":"Ok.","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa1fb268957a6ed2a9306f3fa0839bd52f305ead","unresolved":false,"context_lines":[{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        # stores received port_updates and port_deletes for"},{"line_number":829,"context_line":"        # processing by the main loop"},{"line_number":830,"context_line":"        self.updated_devices \u003d set()"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        # stores all configured ports on agent:"},{"line_number":833,"context_line":"        self.network_ports \u003d collections.defaultdict(list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_40a8a177","line":830,"in_reply_to":"7a740942_4a6a261c","updated":"2015-12-10 20:10:48.000000000","message":"Vikram: so is it fine for You?","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"d5e276ccaa26c812b9fd7513e074dcf8ad3c4381","unresolved":false,"context_lines":[{"line_number":827,"context_line":""},{"line_number":828,"context_line":"        # stores received port_updates and port_deletes for"},{"line_number":829,"context_line":"        # processing by the main loop"},{"line_number":830,"context_line":"        self.updated_devices \u003d set()"},{"line_number":831,"context_line":""},{"line_number":832,"context_line":"        # stores all configured ports on agent:"},{"line_number":833,"context_line":"        self.network_ports \u003d collections.defaultdict(list)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_4a6a261c","line":830,"in_reply_to":"7a740942_c3684d8a","updated":"2015-12-10 09:31:18.000000000","message":"yes, rpc must be initialized before extension manager get\u0027s initialized. And Extension manager information is contained in the agent state, so it must be placed before that","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5f5f2f7155baeae63da3de9040a38cd75dfcc244","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                              \"Agent terminated!\"))"},{"line_number":898,"context_line":"                exit(1)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        self.plugin_rpc \u003d agent_rpc.PluginApi(topics.PLUGIN)"},{"line_number":901,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"},{"line_number":902,"context_line":"        self.sg_agent \u003d sg_rpc.SecurityGroupAgentRpc("},{"line_number":903,"context_line":"            self.context, self.sg_plugin_rpc, defer_refresh_firewall\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_c3160df1","line":900,"updated":"2015-12-10 03:42:59.000000000","message":"I am not sure if these changes are related to this patch. Please explain why we have moved these from start() to reset()","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"d5e276ccaa26c812b9fd7513e074dcf8ad3c4381","unresolved":false,"context_lines":[{"line_number":897,"context_line":"                              \"Agent terminated!\"))"},{"line_number":898,"context_line":"                exit(1)"},{"line_number":899,"context_line":""},{"line_number":900,"context_line":"        self.plugin_rpc \u003d agent_rpc.PluginApi(topics.PLUGIN)"},{"line_number":901,"context_line":"        self.sg_plugin_rpc \u003d sg_rpc.SecurityGroupServerRpcApi(topics.PLUGIN)"},{"line_number":902,"context_line":"        self.sg_agent \u003d sg_rpc.SecurityGroupAgentRpc("},{"line_number":903,"context_line":"            self.context, self.sg_plugin_rpc, defer_refresh_firewall\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_8a480e89","line":900,"in_reply_to":"7a740942_c3160df1","updated":"2015-12-10 09:31:18.000000000","message":"It has been moved to setup_rpc(). The alternative would be to move these line up like described in the comment before (move before line 837). But as those calls also setup rpc stuff, we moved it directly into the setup_rpc method for better encapsulation and readability.","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5f5f2f7155baeae63da3de9040a38cd75dfcc244","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        consumers \u003d [[topics.PORT, topics.UPDATE],"},{"line_number":916,"context_line":"                     [topics.NETWORK, topics.DELETE],"},{"line_number":917,"context_line":"                     [topics.SECURITY_GROUP, topics.UPDATE],"},{"line_number":918,"context_line":"                     [topics.NETWORK, topics.UPDATE]]"},{"line_number":919,"context_line":"        if cfg.CONF.VXLAN.l2_population:"},{"line_number":920,"context_line":"            consumers.append([topics.L2POPULATION, topics.UPDATE])"},{"line_number":921,"context_line":"        self.connection \u003d agent_rpc.create_consumers(self.endpoints,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_03dad578","line":918,"updated":"2015-12-10 03:42:59.000000000","message":"Better to  put all the network related operations together. Can we put it just after L916","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"d5e276ccaa26c812b9fd7513e074dcf8ad3c4381","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        consumers \u003d [[topics.PORT, topics.UPDATE],"},{"line_number":916,"context_line":"                     [topics.NETWORK, topics.DELETE],"},{"line_number":917,"context_line":"                     [topics.SECURITY_GROUP, topics.UPDATE],"},{"line_number":918,"context_line":"                     [topics.NETWORK, topics.UPDATE]]"},{"line_number":919,"context_line":"        if cfg.CONF.VXLAN.l2_population:"},{"line_number":920,"context_line":"            consumers.append([topics.L2POPULATION, topics.UPDATE])"},{"line_number":921,"context_line":"        self.connection \u003d agent_rpc.create_consumers(self.endpoints,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_7da9eede","line":918,"in_reply_to":"7a740942_03dad578","updated":"2015-12-10 09:31:18.000000000","message":"agree, but this is a minor thing","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa1fb268957a6ed2a9306f3fa0839bd52f305ead","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        consumers \u003d [[topics.PORT, topics.UPDATE],"},{"line_number":916,"context_line":"                     [topics.NETWORK, topics.DELETE],"},{"line_number":917,"context_line":"                     [topics.SECURITY_GROUP, topics.UPDATE],"},{"line_number":918,"context_line":"                     [topics.NETWORK, topics.UPDATE]]"},{"line_number":919,"context_line":"        if cfg.CONF.VXLAN.l2_population:"},{"line_number":920,"context_line":"            consumers.append([topics.L2POPULATION, topics.UPDATE])"},{"line_number":921,"context_line":"        self.connection \u003d agent_rpc.create_consumers(self.endpoints,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_a0fdc56f","line":918,"in_reply_to":"7a740942_7da9eede","updated":"2015-12-10 20:10:48.000000000","message":"Done","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"31aa88d150e6b9e0d06563303aaa4a3657fdf06d","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        for ports_list in self.network_ports.values():"},{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"},{"line_number":949,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    def _update_network_ports(self, network_id, port_id, device):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_f129c28a","line":948,"updated":"2015-12-09 11:21:19.000000000","message":"Vikram brought this up on the sriov patchset: \n\nhttp://stackoverflow.com/questions/10665591/how-to-remove-list-elements-in-a-for-loop-in-python\n\nI think we should first clarify that we don\u0027t run into problems here! As long I\u0027m -1","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"e9af58474b65881e78ad80956ba27b7df4c1167a","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        for ports_list in self.network_ports.values():"},{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"},{"line_number":949,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    def _update_network_ports(self, network_id, port_id, device):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_a8dac015","line":948,"in_reply_to":"7a740942_089d2259","updated":"2015-12-10 03:12:07.000000000","message":"+1","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5f5f2f7155baeae63da3de9040a38cd75dfcc244","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        for ports_list in self.network_ports.values():"},{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"},{"line_number":949,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    def _update_network_ports(self, network_id, port_id, device):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_e3954988","line":948,"in_reply_to":"7a740942_a8dac015","updated":"2015-12-10 03:42:59.000000000","message":"I don\u0027t think there is an issue as Slawek correctly pointed out the return after deleting.","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"d5e276ccaa26c812b9fd7513e074dcf8ad3c4381","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        for ports_list in self.network_ports.values():"},{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"},{"line_number":949,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    def _update_network_ports(self, network_id, port_id, device):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_dd8fc273","line":948,"in_reply_to":"7a740942_e3954988","updated":"2015-12-10 09:31:18.000000000","message":"yeah now that you mention it, makes sense. Cool!","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fbed052d5125fcffcfee2afd51a908aaddd5e2e3","unresolved":false,"context_lines":[{"line_number":945,"context_line":"        for ports_list in self.network_ports.values():"},{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"},{"line_number":949,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    def _update_network_ports(self, network_id, port_id, device):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_089d2259","line":948,"in_reply_to":"7a740942_f129c28a","updated":"2015-12-09 20:41:12.000000000","message":"I\u0027m not sure if I understand it correctly but from what is said in comment http://stackoverflow.com/a/10665800/2744610 I think here it is not problem because I\u0027m not iterating after delete one element from list. Loop is then break so IMHO it is not neccessary to create any copy of list or make iteration on reversed list. What do You think about it?","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"e9af58474b65881e78ad80956ba27b7df4c1167a","unresolved":false,"context_lines":[{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"},{"line_number":949,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    def _update_network_ports(self, network_id, port_id, device):"},{"line_number":952,"context_line":"        self._clean_network_ports(device)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_b8fb727a","line":949,"updated":"2015-12-10 03:12:07.000000000","message":"could we remove the empty item in network_ports?\n\ni.e. network_ports may include many item whose key is network_id  but empty values.","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"d5e276ccaa26c812b9fd7513e074dcf8ad3c4381","unresolved":false,"context_lines":[{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"},{"line_number":949,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    def _update_network_ports(self, network_id, port_id, device):"},{"line_number":952,"context_line":"        self._clean_network_ports(device)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_ddfb4246","line":949,"in_reply_to":"7a740942_b8fb727a","updated":"2015-12-10 09:31:18.000000000","message":"see line 688. But if we focus on common code between sriov \u0026 lb agent, we should have it here, as the sriov agent is not listening to network_delete events.\n\n@Slawek, would you mind implementing the removal of the network in this method, to keep code common between sriov \u0026 lb? This makes the modular agent thing afterwards more simple.","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa1fb268957a6ed2a9306f3fa0839bd52f305ead","unresolved":false,"context_lines":[{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"},{"line_number":949,"context_line":"                    return port_data[\u0027port_id\u0027]"},{"line_number":950,"context_line":""},{"line_number":951,"context_line":"    def _update_network_ports(self, network_id, port_id, device):"},{"line_number":952,"context_line":"        self._clean_network_ports(device)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_e030ad09","line":949,"in_reply_to":"7a740942_ddfb4246","updated":"2015-12-10 20:10:48.000000000","message":"Done. But should I also remove it from line 688 now? IMHO not because if it will receive network_delete notification than it should remove this network from list also. Am I right?","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5f5f2f7155baeae63da3de9040a38cd75dfcc244","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                        self.plugin_rpc.update_device_down(self.context,"},{"line_number":1054,"context_line":"                                                           device,"},{"line_number":1055,"context_line":"                                                           self.agent_id,"},{"line_number":1056,"context_line":"                                                           cfg.CONF.host)"},{"line_number":1057,"context_line":"                self._update_network_ports(device_details[\u0027network_id\u0027],"},{"line_number":1058,"context_line":"                                           device_details[\u0027port_id\u0027],"},{"line_number":1059,"context_line":"                                           device_details[\u0027device\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_63a079a6","line":1056,"updated":"2015-12-10 03:42:59.000000000","message":"Do we want to do this even if the device is not up? Why we are placing it outside \"if device_details[\u0027admin_state_up\u0027]: statement\"","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa1fb268957a6ed2a9306f3fa0839bd52f305ead","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                        self.plugin_rpc.update_device_down(self.context,"},{"line_number":1054,"context_line":"                                                           device,"},{"line_number":1055,"context_line":"                                                           self.agent_id,"},{"line_number":1056,"context_line":"                                                           cfg.CONF.host)"},{"line_number":1057,"context_line":"                self._update_network_ports(device_details[\u0027network_id\u0027],"},{"line_number":1058,"context_line":"                                           device_details[\u0027port_id\u0027],"},{"line_number":1059,"context_line":"                                           device_details[\u0027device\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_0ab5d72f","line":1056,"in_reply_to":"7a740942_1d5eaa45","updated":"2015-12-10 20:10:48.000000000","message":"AFAIK it is in similar way in ovs agent also - extensions are called also when device is down","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"d5e276ccaa26c812b9fd7513e074dcf8ad3c4381","unresolved":false,"context_lines":[{"line_number":1053,"context_line":"                        self.plugin_rpc.update_device_down(self.context,"},{"line_number":1054,"context_line":"                                                           device,"},{"line_number":1055,"context_line":"                                                           self.agent_id,"},{"line_number":1056,"context_line":"                                                           cfg.CONF.host)"},{"line_number":1057,"context_line":"                self._update_network_ports(device_details[\u0027network_id\u0027],"},{"line_number":1058,"context_line":"                                           device_details[\u0027port_id\u0027],"},{"line_number":1059,"context_line":"                                           device_details[\u0027device\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_1d5eaa45","line":1056,"in_reply_to":"7a740942_63a079a6","updated":"2015-12-10 09:31:18.000000000","message":"What if a port with admin_state down has been added? I think you also want to add it to the network_ports list and trigger the extensions, wouldn\u0027t you?","commit_id":"577756cde8598dc8d5e148b66f88e735eeace6ec"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"2b597c02a6d085603edb547843034bba865927fa","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        LOG.debug(\"network_delete received\")"},{"line_number":687,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        self.agent.network_ports.pop(network_id, None)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        # NOTE(nick-ma-z): Don\u0027t remove pre-existing user-defined bridges"},{"line_number":692,"context_line":"        if network_id in self.agent.br_mgr.network_map:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_5f12aab5","line":689,"updated":"2015-12-11 07:46:42.000000000","message":"I think you can remove this, as a network can\u0027t be deleted as long ports exist on it. So the entry will always be removed with the last port on this node. Does that make sense? If so, please make sure you adapt the unittests accordingly.","commit_id":"99f710bde40ee1cc6dbc417abdb84f0cf2ebf72f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f5214289063e39c3e01dfa8db15454899ff27c2d","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        LOG.debug(\"network_delete received\")"},{"line_number":687,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        self.agent.network_ports.pop(network_id, None)"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"        # NOTE(nick-ma-z): Don\u0027t remove pre-existing user-defined bridges"},{"line_number":692,"context_line":"        if network_id in self.agent.br_mgr.network_map:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_624fa234","line":689,"in_reply_to":"7a740942_5f12aab5","updated":"2015-12-11 20:43:54.000000000","message":"Done","commit_id":"99f710bde40ee1cc6dbc417abdb84f0cf2ebf72f"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"c47ac2227bd6442bf5054fc3cfc273b9b6349656","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"            device_info[\u0027added\u0027] \u003d current_devices - previous[\u0027current\u0027]"},{"line_number":1134,"context_line":"            device_info[\u0027removed\u0027] \u003d previous[\u0027current\u0027] - current_devices"},{"line_number":1135,"context_line":"            device_info[\u0027updated\u0027] \u003d ((updated_devices \u0026 current_devices)"},{"line_number":1136,"context_line":"                                      - device_info[\u0027removed\u0027])"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        return device_info"},{"line_number":1139,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_186b7ff2","line":1136,"updated":"2015-12-14 10:36:10.000000000","message":"Hi Slawek, could you please have a look at Rossellas and my comment on the sriov patchset? I think it\u0027s the same thing here as well. This line is not required, as a removed device will not be in the current_devices list, and therefore never added to updated devices list due to the AND operation.\n\nhttps://review.openstack.org/#/c/233499/14/neutron/plugins/ml2/drivers/mech_sriov/agent/sriov_nic_agent.py","commit_id":"eb89a45b647d4043bb627dd47230a574ea65fe3d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d28e0bcb0b3356278a87d1be2217f9071dda3929","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"            device_info[\u0027added\u0027] \u003d current_devices - previous[\u0027current\u0027]"},{"line_number":1134,"context_line":"            device_info[\u0027removed\u0027] \u003d previous[\u0027current\u0027] - current_devices"},{"line_number":1135,"context_line":"            device_info[\u0027updated\u0027] \u003d ((updated_devices \u0026 current_devices)"},{"line_number":1136,"context_line":"                                      - device_info[\u0027removed\u0027])"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        return device_info"},{"line_number":1139,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_e71bf07e","line":1136,"in_reply_to":"5a710552_17e54008","updated":"2015-12-16 00:09:20.000000000","message":"Yes, You are right. I will remove it.","commit_id":"eb89a45b647d4043bb627dd47230a574ea65fe3d"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"1b9705098a73a917eb130ab06ba6e64c754398be","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"            device_info[\u0027added\u0027] \u003d current_devices - previous[\u0027current\u0027]"},{"line_number":1134,"context_line":"            device_info[\u0027removed\u0027] \u003d previous[\u0027current\u0027] - current_devices"},{"line_number":1135,"context_line":"            device_info[\u0027updated\u0027] \u003d ((updated_devices \u0026 current_devices)"},{"line_number":1136,"context_line":"                                      - device_info[\u0027removed\u0027])"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        return device_info"},{"line_number":1139,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_17e54008","line":1136,"in_reply_to":"5a710552_4c7ef2af","updated":"2015-12-15 08:05:48.000000000","message":"it will be removed in 1135: updated_devices \u0026 current_devices.\n\nThe \u0026 is a logical AND, that means \u0027updated\u0027 will only contain items that live in both sets. As the the removed item is not present in current devices, the AND expression will never become True for the removed device.\n\nset([1,2]) \u0026 set ([2,3]) --\u003e set([2])\n\nThe agent will only use the value in device_info and not the self.updated_devices to decide, whether treat_devices_added_updated or -removed will be called (Line 969)","commit_id":"eb89a45b647d4043bb627dd47230a574ea65fe3d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"063c98d9a985e9dadce644c99f3cb77cd4accfcd","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"            device_info[\u0027added\u0027] \u003d current_devices - previous[\u0027current\u0027]"},{"line_number":1134,"context_line":"            device_info[\u0027removed\u0027] \u003d previous[\u0027current\u0027] - current_devices"},{"line_number":1135,"context_line":"            device_info[\u0027updated\u0027] \u003d ((updated_devices \u0026 current_devices)"},{"line_number":1136,"context_line":"                                      - device_info[\u0027removed\u0027])"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"        return device_info"},{"line_number":1139,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a710552_4c7ef2af","line":1136,"in_reply_to":"7a740942_186b7ff2","updated":"2015-12-14 20:56:57.000000000","message":"I\u0027m not sure about it. If there will be in same time notification about network_update and port will be there added to self.updated_devices and it will dissappear from host because vm is deleted then in line 1100 it will be putted in \"updated_devices\", in line 1103 it will be not found by scanning ports so it will be not in \"current_devices\" (but it was in previous[\u0027current\u0027]). So it will be in:\n\ndevices_info[\u0027removed\u0027] (line 1134) and\ndevices_info[\u0027updated\u0027] (line 1135)\n\nIf my thinking is not correct anywhere here, please tell me where in such case this port will be \"removed\" from updated_devices","commit_id":"eb89a45b647d4043bb627dd47230a574ea65fe3d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e41658acf78dbc0103eeed34cb60dc9580d4d3ff","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Neutron OpenVSwitch Plugin."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import collections"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":"import time"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_737279e7","line":23,"updated":"2015-12-17 15:09:01.000000000","message":"(nit) six is third party library, so should have gone below into the section starting at line 30.","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ce9c523ec16320fe66d8503e85214356efc008e8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"# Neutron OpenVSwitch Plugin."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import collections"},{"line_number":23,"context_line":"import six"},{"line_number":24,"context_line":"import sys"},{"line_number":25,"context_line":"import time"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_dfcd645e","line":23,"in_reply_to":"3a7e1126_737279e7","updated":"2015-12-17 15:54:43.000000000","message":"+1","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e41658acf78dbc0103eeed34cb60dc9580d4d3ff","unresolved":false,"context_lines":[{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    def network_update(self, context, **kwargs):"},{"line_number":716,"context_line":"        network_id \u003d kwargs[\u0027network\u0027][\u0027id\u0027]"},{"line_number":717,"context_line":"        LOG.debug(\"network_update message processed for network \""},{"line_number":718,"context_line":"                  \"%(network_id)s, with ports: %(ports)s\","},{"line_number":719,"context_line":"                  {\u0027network_id\u0027: network_id,"},{"line_number":720,"context_line":"                   \u0027ports\u0027: self.agent.network_ports[network_id]})"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_2a30f39d","line":717,"updated":"2015-12-17 15:09:01.000000000","message":"(No action required) I would probably claim processing completed after we actually update updated_devices, but meh.","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ce9c523ec16320fe66d8503e85214356efc008e8","unresolved":false,"context_lines":[{"line_number":714,"context_line":""},{"line_number":715,"context_line":"    def network_update(self, context, **kwargs):"},{"line_number":716,"context_line":"        network_id \u003d kwargs[\u0027network\u0027][\u0027id\u0027]"},{"line_number":717,"context_line":"        LOG.debug(\"network_update message processed for network \""},{"line_number":718,"context_line":"                  \"%(network_id)s, with ports: %(ports)s\","},{"line_number":719,"context_line":"                  {\u0027network_id\u0027: network_id,"},{"line_number":720,"context_line":"                   \u0027ports\u0027: self.agent.network_ports[network_id]})"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_1fb44ccf","line":717,"in_reply_to":"3a7e1126_2a30f39d","updated":"2015-12-17 15:54:43.000000000","message":"or just say \"network_update RPC received...\" (like in port_update)","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e41658acf78dbc0103eeed34cb60dc9580d4d3ff","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        # processing by the main loop"},{"line_number":829,"context_line":"        self.updated_devices \u003d set()"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        # stores all configured ports on agent:"},{"line_number":832,"context_line":"        self.network_ports \u003d collections.defaultdict(list)"},{"line_number":833,"context_line":"        # flag to do a sync after revival"},{"line_number":834,"context_line":"        self.fullsync \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_8ad247ff","line":831,"updated":"2015-12-17 15:09:01.000000000","message":"(nitty nit) trailing \":\" is probably redundant","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c6853b6cd482641754ed794b60e54aa1b6f3ac07","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        # processing by the main loop"},{"line_number":829,"context_line":"        self.updated_devices \u003d set()"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        # stores all configured ports on agent:"},{"line_number":832,"context_line":"        self.network_ports \u003d collections.defaultdict(list)"},{"line_number":833,"context_line":"        # flag to do a sync after revival"},{"line_number":834,"context_line":"        self.fullsync \u003d False"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_d5b899ca","line":831,"in_reply_to":"3a7e1126_8ad247ff","updated":"2015-12-18 20:47:38.000000000","message":"Done","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e41658acf78dbc0103eeed34cb60dc9580d4d3ff","unresolved":false,"context_lines":[{"line_number":942,"context_line":"            ip_lib.IPDevice(tap_name).link.set_down()"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    def _clean_network_ports(self, device):"},{"line_number":945,"context_line":"        for netid, ports_list in six.iteritems(self.network_ports):"},{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_ea150b49","line":945,"updated":"2015-12-17 15:09:01.000000000","message":"(nit) They say using six.iteritems is pretty much always not needed since we don\u0027t expect millions of ports here","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c6853b6cd482641754ed794b60e54aa1b6f3ac07","unresolved":false,"context_lines":[{"line_number":942,"context_line":"            ip_lib.IPDevice(tap_name).link.set_down()"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    def _clean_network_ports(self, device):"},{"line_number":945,"context_line":"        for netid, ports_list in six.iteritems(self.network_ports):"},{"line_number":946,"context_line":"            for port_data in ports_list:"},{"line_number":947,"context_line":"                if device \u003d\u003d port_data[\u0027device\u0027]:"},{"line_number":948,"context_line":"                    ports_list.remove(port_data)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_d51419a1","line":945,"in_reply_to":"3a7e1126_ea150b49","updated":"2015-12-18 20:47:38.000000000","message":"ok, so I will use normal \"items()\" method here. Is it better?","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e41658acf78dbc0103eeed34cb60dc9580d4d3ff","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1086,"context_line":"            port_id \u003d self._clean_network_ports(device)"},{"line_number":1087,"context_line":"            self.ext_manager.delete_port(self.context,"},{"line_number":1088,"context_line":"                                         {\u0027device_name\u0027: device,"},{"line_number":1089,"context_line":"                                          \u0027port_id\u0027: port_id})"},{"line_number":1090,"context_line":"        if self.prevent_arp_spoofing:"},{"line_number":1091,"context_line":"            arp_protect.delete_arp_spoofing_protection(devices)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_2b00f200","line":1088,"updated":"2015-12-17 15:09:01.000000000","message":"it\u0027s device_name here but device in like 1061. Isn\u0027t it the same, and if so, shouldn\u0027t it have the same name for consistency?","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"ce9c523ec16320fe66d8503e85214356efc008e8","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1086,"context_line":"            port_id \u003d self._clean_network_ports(device)"},{"line_number":1087,"context_line":"            self.ext_manager.delete_port(self.context,"},{"line_number":1088,"context_line":"                                         {\u0027device_name\u0027: device,"},{"line_number":1089,"context_line":"                                          \u0027port_id\u0027: port_id})"},{"line_number":1090,"context_line":"        if self.prevent_arp_spoofing:"},{"line_number":1091,"context_line":"            arp_protect.delete_arp_spoofing_protection(devices)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_84a6b351","line":1088,"in_reply_to":"3a7e1126_2b00f200","updated":"2015-12-17 15:54:43.000000000","message":"It doesn\u0027t matter for the lb agent how this key is named. It only will be accessed from within the extension.  \n\nThe counterpart to delete_port - handle_port in line 1062 takes the device_details as argument. In the device details you on accesses the this information via the key \u0027device\u0027. So from that point of you I\u0027m totally with Ihar - Good finding!","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0219dc4299fef426f6fad3e2d49b10ccb9d263c","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1086,"context_line":"            port_id \u003d self._clean_network_ports(device)"},{"line_number":1087,"context_line":"            self.ext_manager.delete_port(self.context,"},{"line_number":1088,"context_line":"                                         {\u0027device_name\u0027: device,"},{"line_number":1089,"context_line":"                                          \u0027port_id\u0027: port_id})"},{"line_number":1090,"context_line":"        if self.prevent_arp_spoofing:"},{"line_number":1091,"context_line":"            arp_protect.delete_arp_spoofing_protection(devices)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_d536a3e6","line":1088,"in_reply_to":"3a7e1126_84a6b351","updated":"2015-12-17 16:09:13.000000000","message":"Yes, extension can handle different keys for two callbacks. I just feel that it\u0027s better if they are consistent. We may later transit to using versioned objects for the extensions payload, so having key names identical may help to avoid ugly hacks later.","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c6853b6cd482641754ed794b60e54aa1b6f3ac07","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":1086,"context_line":"            port_id \u003d self._clean_network_ports(device)"},{"line_number":1087,"context_line":"            self.ext_manager.delete_port(self.context,"},{"line_number":1088,"context_line":"                                         {\u0027device_name\u0027: device,"},{"line_number":1089,"context_line":"                                          \u0027port_id\u0027: port_id})"},{"line_number":1090,"context_line":"        if self.prevent_arp_spoofing:"},{"line_number":1091,"context_line":"            arp_protect.delete_arp_spoofing_protection(devices)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_b5d4edbc","line":1088,"in_reply_to":"3a7e1126_d536a3e6","updated":"2015-12-18 20:47:38.000000000","message":"Done","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fc366bf2f2ebf3ea30584350e9bb329d741f8df6","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    # history"},{"line_number":673,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":674,"context_line":"    #   1.3 Added param devices_to_update to security_groups_provider_updated"},{"line_number":675,"context_line":"    #   1.4 Added support for network_update"},{"line_number":676,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.4\u0027)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def __init__(self, context, agent, sg_agent):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a7e1126_9640c535","line":675,"updated":"2015-12-20 09:57:52.000000000","message":"i am sorry for the nitpicking but the commit message refers to extensions and does not refer to network updates. Is this one and the same of somehow related.","commit_id":"1861a186e99d1e1e04cac5a86a0431785770a9bd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7f7c89c7104fee1da75801e43eb1c82517a6fd2d","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    # history"},{"line_number":673,"context_line":"    #   1.1 Support Security Group RPC"},{"line_number":674,"context_line":"    #   1.3 Added param devices_to_update to security_groups_provider_updated"},{"line_number":675,"context_line":"    #   1.4 Added support for network_update"},{"line_number":676,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.4\u0027)"},{"line_number":677,"context_line":""},{"line_number":678,"context_line":"    def __init__(self, context, agent, sg_agent):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a7e1126_9891cff3","line":675,"in_reply_to":"3a7e1126_9640c535","updated":"2015-12-20 20:32:56.000000000","message":"Done","commit_id":"1861a186e99d1e1e04cac5a86a0431785770a9bd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fc366bf2f2ebf3ea30584350e9bb329d741f8df6","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        self.updated_devices \u003d set()"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        # stores all configured ports on agent"},{"line_number":831,"context_line":"        self.network_ports \u003d collections.defaultdict(list)"},{"line_number":832,"context_line":"        # flag to do a sync after revival"},{"line_number":833,"context_line":"        self.fullsync \u003d False"},{"line_number":834,"context_line":"        self.context \u003d context.get_admin_context_without_session()"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a7e1126_167b758d","line":831,"updated":"2015-12-20 09:57:52.000000000","message":"ditto","commit_id":"1861a186e99d1e1e04cac5a86a0431785770a9bd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7f7c89c7104fee1da75801e43eb1c82517a6fd2d","unresolved":false,"context_lines":[{"line_number":828,"context_line":"        self.updated_devices \u003d set()"},{"line_number":829,"context_line":""},{"line_number":830,"context_line":"        # stores all configured ports on agent"},{"line_number":831,"context_line":"        self.network_ports \u003d collections.defaultdict(list)"},{"line_number":832,"context_line":"        # flag to do a sync after revival"},{"line_number":833,"context_line":"        self.fullsync \u003d False"},{"line_number":834,"context_line":"        self.context \u003d context.get_admin_context_without_session()"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a7e1126_d87997c9","line":831,"in_reply_to":"3a7e1126_167b758d","updated":"2015-12-20 20:32:56.000000000","message":"I added in commit message info about why network_updates handling is added but do You want me to add description of any of added/changed variables and methods? What exactly You think I should write about this line?","commit_id":"1861a186e99d1e1e04cac5a86a0431785770a9bd"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"fc366bf2f2ebf3ea30584350e9bb329d741f8df6","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        configurations \u003d {"},{"line_number":839,"context_line":"            \u0027bridge_mappings\u0027: self.bridge_mappings,"},{"line_number":840,"context_line":"            \u0027interface_mappings\u0027: self.interface_mappings,"},{"line_number":841,"context_line":"            \u0027extensions\u0027: self.ext_manager.names()"},{"line_number":842,"context_line":"        }"},{"line_number":843,"context_line":"        if self.br_mgr.vxlan_mode !\u003d lconst.VXLAN_NONE:"},{"line_number":844,"context_line":"            configurations[\u0027tunneling_ip\u0027] \u003d self.br_mgr.local_ip"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a7e1126_16a295fd","line":841,"updated":"2015-12-20 09:57:52.000000000","message":"from the commit message this is the only thing that is relevant here","commit_id":"1861a186e99d1e1e04cac5a86a0431785770a9bd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7f7c89c7104fee1da75801e43eb1c82517a6fd2d","unresolved":false,"context_lines":[{"line_number":838,"context_line":"        configurations \u003d {"},{"line_number":839,"context_line":"            \u0027bridge_mappings\u0027: self.bridge_mappings,"},{"line_number":840,"context_line":"            \u0027interface_mappings\u0027: self.interface_mappings,"},{"line_number":841,"context_line":"            \u0027extensions\u0027: self.ext_manager.names()"},{"line_number":842,"context_line":"        }"},{"line_number":843,"context_line":"        if self.br_mgr.vxlan_mode !\u003d lconst.VXLAN_NONE:"},{"line_number":844,"context_line":"            configurations[\u0027tunneling_ip\u0027] \u003d self.br_mgr.local_ip"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a7e1126_18395ff2","line":841,"in_reply_to":"3a7e1126_16a295fd","updated":"2015-12-20 20:32:56.000000000","message":"should I add something about those lines also to commit message?","commit_id":"1861a186e99d1e1e04cac5a86a0431785770a9bd"}],"neutron/tests/unit/plugins/ml2/drivers/linuxbridge/agent/test_linuxbridge_neutron_agent.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1408902520c2ab52f306c165f9f5f4ae40d3183f","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"        self.lb_rpc.port_delete(context\u003dNone, port\u003dport)"},{"line_number":1066,"context_line":"        self.assertEqual(set(), self.lb_rpc.agent.updated_devices)"},{"line_number":1067,"context_line":"        self.assertEqual(set([DEVICE_1]), self.lb_rpc.agent.deleted_devices)"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"    def test_network_delete_with_existed_brq(self):"},{"line_number":1070,"context_line":"        mock_net \u003d mock.Mock()"},{"line_number":1071,"context_line":"        mock_net.physical_network \u003d \u0027physnet0\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a22fba86","line":1068,"updated":"2015-11-27 10:59:05.000000000","message":"I believe the 2nd test won\u0027t be appropriate once we delete port delete notification listening.\n\nNote that more tests are needed for the change, specifically to validate that extension manager is triggered in proper cases, on treat_devices_removed or when handling the new port.","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d6e786f9ad134c149e57140d1143c57bf37eedc0","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"        self.lb_rpc.port_delete(context\u003dNone, port\u003dport)"},{"line_number":1066,"context_line":"        self.assertEqual(set(), self.lb_rpc.agent.updated_devices)"},{"line_number":1067,"context_line":"        self.assertEqual(set([DEVICE_1]), self.lb_rpc.agent.deleted_devices)"},{"line_number":1068,"context_line":""},{"line_number":1069,"context_line":"    def test_network_delete_with_existed_brq(self):"},{"line_number":1070,"context_line":"        mock_net \u003d mock.Mock()"},{"line_number":1071,"context_line":"        mock_net.physical_network \u003d \u0027physnet0\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_efcd8f66","line":1068,"in_reply_to":"9a8ffd7b_a22fba86","updated":"2015-11-27 21:53:43.000000000","message":"I removed this one test and added checks if ext_manager methods are called in treat_devices_addded_updated and treat_devices_removed. Is it better now?","commit_id":"2de6888835eb84a8a9cfad4de356a8887ba02bbf"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                    \u0027removed\u0027: set()}"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        self._test_scan_devices(previous, updated, fake_current, expected,"},{"line_number":283,"context_line":"                                sync\u003dFalse)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_scan_devices_updated_on_sync(self):"},{"line_number":286,"context_line":"        previous \u003d {\u0027current\u0027: set([1, 2]),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_ebb7a382","line":283,"updated":"2015-11-30 09:24:53.000000000","message":"If you do the change where I proposed to get rid of agent.deleted_devices:\n\nAdd test for the case where a device should be updated (due to network_update) but has been delete concurrently:\n\ndef test_scan_devices_updated_deleted_concurrently(self):\n  previous \u003d {\u0027current\u0027: set([1, 2]),\n                      \u0027updated\u0027: set(),\n                      \u0027added\u0027: set(),\n                      \u0027removed\u0027: set()}\n  # Device 2 disappeared.\n  fake_current \u003d set([1])\n  # Device 2 got an concurrent update via network_update\n  updated \u003d set([2])\n  expected \u003d {\u0027current\u0027: set([1]),\n                        \u0027updated\u0027: set(),\n                        \u0027added\u0027: set(),\n                        \u0027removed\u0027: set([2])}\n\n  self._test_scan_devices(previous, updated, fake_current, expected,\n  sync\u003dFalse)","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                    \u0027removed\u0027: set()}"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"        self._test_scan_devices(previous, updated, fake_current, expected,"},{"line_number":283,"context_line":"                                sync\u003dFalse)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_scan_devices_updated_on_sync(self):"},{"line_number":286,"context_line":"        previous \u003d {\u0027current\u0027: set([1, 2]),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_794da0c3","line":283,"in_reply_to":"9a8ffd7b_ebb7a382","updated":"2015-11-30 22:07:34.000000000","message":"Thx. I added it now","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":1042,"context_line":"                segment.segmentation_id \u003d 1"},{"line_number":1043,"context_line":"                self.br_mgr.network_map[\u0027net_id\u0027] \u003d segment"},{"line_number":1044,"context_line":"                self.updated_devices \u003d set()"},{"line_number":1045,"context_line":"                self.deleted_devices \u003d set()"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"        self.lb_rpc \u003d linuxbridge_neutron_agent.LinuxBridgeRpcCallbacks("},{"line_number":1048,"context_line":"            object(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_8b75b764","line":1045,"updated":"2015-11-30 09:24:53.000000000","message":"deleted_devices not required","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":1042,"context_line":"                segment.segmentation_id \u003d 1"},{"line_number":1043,"context_line":"                self.br_mgr.network_map[\u0027net_id\u0027] \u003d segment"},{"line_number":1044,"context_line":"                self.updated_devices \u003d set()"},{"line_number":1045,"context_line":"                self.deleted_devices \u003d set()"},{"line_number":1046,"context_line":""},{"line_number":1047,"context_line":"        self.lb_rpc \u003d linuxbridge_neutron_agent.LinuxBridgeRpcCallbacks("},{"line_number":1048,"context_line":"            object(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_f9f19002","line":1045,"in_reply_to":"9a8ffd7b_8b75b764","updated":"2015-11-30 22:07:34.000000000","message":"Done","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"        port \u003d {\u0027id\u0027: PORT_1}"},{"line_number":1070,"context_line":"        self.lb_rpc.port_update(context\u003dNone, port\u003dport)"},{"line_number":1071,"context_line":"        self.assertEqual(set([DEVICE_1]), self.lb_rpc.agent.updated_devices)"},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"    def test_network_delete_with_existed_brq(self):"},{"line_number":1074,"context_line":"        mock_net \u003d mock.Mock()"},{"line_number":1075,"context_line":"        mock_net.physical_network \u003d \u0027physnet0\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_2b504b31","line":1072,"updated":"2015-11-30 09:24:53.000000000","message":"missing the network_update test (that\u0027s the method you introduced)","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":1069,"context_line":"        port \u003d {\u0027id\u0027: PORT_1}"},{"line_number":1070,"context_line":"        self.lb_rpc.port_update(context\u003dNone, port\u003dport)"},{"line_number":1071,"context_line":"        self.assertEqual(set([DEVICE_1]), self.lb_rpc.agent.updated_devices)"},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"    def test_network_delete_with_existed_brq(self):"},{"line_number":1074,"context_line":"        mock_net \u003d mock.Mock()"},{"line_number":1075,"context_line":"        mock_net.physical_network \u003d \u0027physnet0\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_392ab8e8","line":1072,"in_reply_to":"9a8ffd7b_2b504b31","updated":"2015-11-30 22:07:34.000000000","message":"True. I forgot it. Now it is added","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"433aa08f2daf71794877dc8408212b2dcf53eaf7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                self.assertFalse(resync)"},{"line_number":145,"context_line":"                self.assertTrue(fn_udd.called)"},{"line_number":146,"context_line":"                self.assertTrue(fn_rdf.called)"},{"line_number":147,"context_line":"                self.assertTrue(ext_mgr_delete_port.called)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_treat_devices_removed_with_not_existed_device(self):"},{"line_number":150,"context_line":"        agent \u003d self.agent"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_01b716f6","line":147,"updated":"2015-12-01 14:28:16.000000000","message":"can we add the to be removed device to the network_ports dictionary and then check that it has been removed?","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"202fb966300641c2f5c7358d19ad1c8dabeeb035","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                self.assertFalse(resync)"},{"line_number":145,"context_line":"                self.assertTrue(fn_udd.called)"},{"line_number":146,"context_line":"                self.assertTrue(fn_rdf.called)"},{"line_number":147,"context_line":"                self.assertTrue(ext_mgr_delete_port.called)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    def test_treat_devices_removed_with_not_existed_device(self):"},{"line_number":150,"context_line":"        agent \u003d self.agent"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_cc460c7b","line":147,"in_reply_to":"9a8ffd7b_01b716f6","updated":"2015-12-01 21:22:27.000000000","message":"Done","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"433aa08f2daf71794877dc8408212b2dcf53eaf7","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                self.assertFalse(resync)"},{"line_number":165,"context_line":"                self.assertTrue(fn_udd.called)"},{"line_number":166,"context_line":"                self.assertTrue(fn_rdf.called)"},{"line_number":167,"context_line":"                self.assertTrue(ext_mgr_delete_port.called)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_treat_devices_removed_failed(self):"},{"line_number":170,"context_line":"        agent \u003d self.agent"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_e198d26c","line":167,"updated":"2015-12-01 14:28:16.000000000","message":"same as above","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"202fb966300641c2f5c7358d19ad1c8dabeeb035","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                self.assertFalse(resync)"},{"line_number":165,"context_line":"                self.assertTrue(fn_udd.called)"},{"line_number":166,"context_line":"                self.assertTrue(fn_rdf.called)"},{"line_number":167,"context_line":"                self.assertTrue(ext_mgr_delete_port.called)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def test_treat_devices_removed_failed(self):"},{"line_number":170,"context_line":"        agent \u003d self.agent"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_ec30b009","line":167,"in_reply_to":"9a8ffd7b_e198d26c","updated":"2015-12-01 21:22:27.000000000","message":"Done","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"433aa08f2daf71794877dc8408212b2dcf53eaf7","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self.assertTrue(resync)"},{"line_number":181,"context_line":"            self.assertTrue(fn_udd.called)"},{"line_number":182,"context_line":"            self.assertTrue(fn_rdf.called)"},{"line_number":183,"context_line":"            self.assertTrue(ext_mgr_delete_port.called)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def _test_scan_devices(self, previous, updated,"},{"line_number":186,"context_line":"                           fake_current, expected, sync):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_21049a7c","line":183,"updated":"2015-12-01 14:28:16.000000000","message":"same like above","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"202fb966300641c2f5c7358d19ad1c8dabeeb035","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self.assertTrue(resync)"},{"line_number":181,"context_line":"            self.assertTrue(fn_udd.called)"},{"line_number":182,"context_line":"            self.assertTrue(fn_rdf.called)"},{"line_number":183,"context_line":"            self.assertTrue(ext_mgr_delete_port.called)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def _test_scan_devices(self, previous, updated,"},{"line_number":186,"context_line":"                           fake_current, expected, sync):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_8371b2aa","line":183,"in_reply_to":"9a8ffd7b_21049a7c","updated":"2015-12-01 21:22:27.000000000","message":"Done","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"433aa08f2daf71794877dc8408212b2dcf53eaf7","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                                                      \u0027physnet1\u0027, 100,"},{"line_number":361,"context_line":"                                                      \u0027port123\u0027)"},{"line_number":362,"context_line":"        self.assertTrue(agent.plugin_rpc.update_device_up.called)"},{"line_number":363,"context_line":"        self.assertTrue(agent.ext_manager.handle_port.called)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def test_treat_devices_added_updated_admin_state_up_false(self):"},{"line_number":366,"context_line":"        agent \u003d self.agent"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_41667e2a","line":363,"updated":"2015-12-01 14:28:16.000000000","message":"can we add a test that the device is now contained in the network_ports dict?","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"202fb966300641c2f5c7358d19ad1c8dabeeb035","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                                                      \u0027physnet1\u0027, 100,"},{"line_number":361,"context_line":"                                                      \u0027port123\u0027)"},{"line_number":362,"context_line":"        self.assertTrue(agent.plugin_rpc.update_device_up.called)"},{"line_number":363,"context_line":"        self.assertTrue(agent.ext_manager.handle_port.called)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    def test_treat_devices_added_updated_admin_state_up_false(self):"},{"line_number":366,"context_line":"        agent \u003d self.agent"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_8329b239","line":363,"in_reply_to":"9a8ffd7b_41667e2a","updated":"2015-12-01 21:22:27.000000000","message":"Done","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"433aa08f2daf71794877dc8408212b2dcf53eaf7","unresolved":false,"context_lines":[{"line_number":382,"context_line":"                                                     \u0027physnet1\u0027,"},{"line_number":383,"context_line":"                                                     \u0027port123\u0027)"},{"line_number":384,"context_line":"        self.assertFalse(agent.plugin_rpc.update_device_up.called)"},{"line_number":385,"context_line":"        self.assertTrue(agent.ext_manager.handle_port.called)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def test_set_rpc_timeout(self):"},{"line_number":388,"context_line":"        self.agent.stop()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_c1726ee3","line":385,"updated":"2015-12-01 14:28:16.000000000","message":"same like above","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"202fb966300641c2f5c7358d19ad1c8dabeeb035","unresolved":false,"context_lines":[{"line_number":382,"context_line":"                                                     \u0027physnet1\u0027,"},{"line_number":383,"context_line":"                                                     \u0027port123\u0027)"},{"line_number":384,"context_line":"        self.assertFalse(agent.plugin_rpc.update_device_up.called)"},{"line_number":385,"context_line":"        self.assertTrue(agent.ext_manager.handle_port.called)"},{"line_number":386,"context_line":""},{"line_number":387,"context_line":"    def test_set_rpc_timeout(self):"},{"line_number":388,"context_line":"        self.agent.stop()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_431c2a13","line":385,"in_reply_to":"9a8ffd7b_c1726ee3","updated":"2015-12-01 21:22:27.000000000","message":"after rebase my patch there is no this test anymore","commit_id":"339e5beec2697e4101f69842551bb9cb773f7914"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"e3e96bfd47742e6dbc5070300c49813bbf180c38","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        agent \u003d self.agent"},{"line_number":131,"context_line":"        agent._ensure_port_admin_state \u003d mock.Mock()"},{"line_number":132,"context_line":"        devices \u003d [DEVICE_1]"},{"line_number":133,"context_line":"        port_data \u003d {"},{"line_number":134,"context_line":"            \"port_id\": PORT_1,"},{"line_number":135,"context_line":"            \"device\": DEVICE_1"},{"line_number":136,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_4a474577","line":133,"updated":"2015-12-02 09:17:12.000000000","message":"nit: think of making this a global var, as you\u0027re using it a couple of times in other tests as well.","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"445f714f40fb994709c635d8cbc4f5de5809426e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        agent \u003d self.agent"},{"line_number":131,"context_line":"        agent._ensure_port_admin_state \u003d mock.Mock()"},{"line_number":132,"context_line":"        devices \u003d [DEVICE_1]"},{"line_number":133,"context_line":"        port_data \u003d {"},{"line_number":134,"context_line":"            \"port_id\": PORT_1,"},{"line_number":135,"context_line":"            \"device\": DEVICE_1"},{"line_number":136,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_8496584a","line":133,"in_reply_to":"9a8ffd7b_4a474577","updated":"2015-12-02 20:38:54.000000000","message":"You\u0027re right. I changed it","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"e3e96bfd47742e6dbc5070300c49813bbf180c38","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def test_ensure_port_admin_state_down(self):"},{"line_number":436,"context_line":"        self._test_ensure_port_admin_state(False)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def test_clean_network_ports(self):"},{"line_number":439,"context_line":"        port_1_data \u003d {"},{"line_number":440,"context_line":"            \u0027port_id\u0027: PORT_1,"},{"line_number":441,"context_line":"            \u0027device\u0027: DEVICE_1"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_9eb9ee30","line":438,"updated":"2015-12-02 09:17:12.000000000","message":"nit: you could think of merging those 2 tests (e.g. to test_clean_and_update_network_ports). Maybe this saves some lines.\n\n- add a port\n- add a second\n- update a port\n- delete a port","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"445f714f40fb994709c635d8cbc4f5de5809426e","unresolved":false,"context_lines":[{"line_number":435,"context_line":"    def test_ensure_port_admin_state_down(self):"},{"line_number":436,"context_line":"        self._test_ensure_port_admin_state(False)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def test_clean_network_ports(self):"},{"line_number":439,"context_line":"        port_1_data \u003d {"},{"line_number":440,"context_line":"            \u0027port_id\u0027: PORT_1,"},{"line_number":441,"context_line":"            \u0027device\u0027: DEVICE_1"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_249bec19","line":438,"in_reply_to":"9a8ffd7b_9eb9ee30","updated":"2015-12-02 20:38:54.000000000","message":"Done","commit_id":"c2c2167e9f287128e98235e0a58b8b0b68a12ee1"},{"author":{"_account_id":11114,"name":"yalei wang","email":"yalei.wang@intel.com","username":"yalie"},"change_message_id":"afcde3dda84e190fe5ef4abbf1529dab6c406f6e","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        )"},{"line_number":450,"context_line":"        self.assertTrue("},{"line_number":451,"context_line":"            port_2_data in self.agent.network_ports[NETWORK_2_ID]"},{"line_number":452,"context_line":"        )"},{"line_number":453,"context_line":"        #check removing port:"},{"line_number":454,"context_line":"        cleaned_port_id \u003d self.agent._clean_network_ports(DEVICE_1)"},{"line_number":455,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_939c4e6b","line":452,"updated":"2015-12-03 02:36:57.000000000","message":"could we use one line to cover 447~452\n\nself.assertEqual(expect_dict, self.agent.network_ports)","commit_id":"691f06de8cce464d8dfada0c05a243a94cf5dc3d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e0089fd51b579cf9c439018025005e563ee85eab","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        )"},{"line_number":450,"context_line":"        self.assertTrue("},{"line_number":451,"context_line":"            port_2_data in self.agent.network_ports[NETWORK_2_ID]"},{"line_number":452,"context_line":"        )"},{"line_number":453,"context_line":"        #check removing port:"},{"line_number":454,"context_line":"        cleaned_port_id \u003d self.agent._clean_network_ports(DEVICE_1)"},{"line_number":455,"context_line":"        self.assertTrue("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a8ffd7b_e3ee1521","line":452,"in_reply_to":"9a8ffd7b_939c4e6b","updated":"2015-12-03 11:47:32.000000000","message":"I can change it but it will be not one line because I also need to prepare expected_dict before assert. Is it really so important? I don\u0027t think it will make any real change","commit_id":"691f06de8cce464d8dfada0c05a243a94cf5dc3d"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"2b597c02a6d085603edb547843034bba865927fa","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        self.assertTrue("},{"line_number":460,"context_line":"            port_2_data in self.agent.network_ports[NETWORK_2_ID]"},{"line_number":461,"context_line":"        )"},{"line_number":462,"context_line":"        self.assertEqual(cleaned_port_id, PORT_1)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"class TestLinuxBridgeManager(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_9f4ed2bf","line":462,"updated":"2015-12-11 07:46:42.000000000","message":"remove port1 as well and make sure NETWORK_ID has been removed from the network_ports map. Yalei also did this on the sriov patchset. Cool!","commit_id":"99f710bde40ee1cc6dbc417abdb84f0cf2ebf72f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f5214289063e39c3e01dfa8db15454899ff27c2d","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        self.assertTrue("},{"line_number":460,"context_line":"            port_2_data in self.agent.network_ports[NETWORK_2_ID]"},{"line_number":461,"context_line":"        )"},{"line_number":462,"context_line":"        self.assertEqual(cleaned_port_id, PORT_1)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"class TestLinuxBridgeManager(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a740942_62dfa2d6","line":462,"in_reply_to":"7a740942_9f4ed2bf","updated":"2015-12-11 20:43:54.000000000","message":"I changed this test and splitted it to two different because in test for clean_network_ports I\u0027m checking removing not last port and then last port from network. I hope it can be like that for You :)","commit_id":"99f710bde40ee1cc6dbc417abdb84f0cf2ebf72f"},{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"2dc5c40ca59418edce4b2a6e52c2d46814ac265b","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"        mock_net.physical_network \u003d None"},{"line_number":1178,"context_line":""},{"line_number":1179,"context_line":"        self.lb_rpc.agent.br_mgr.network_map \u003d {NETWORK_ID: mock_net}"},{"line_number":1180,"context_line":"        self.lb_rpc.agent.network_ports \u003d {"},{"line_number":1181,"context_line":"            NETWORK_ID: [PORT_DATA]"},{"line_number":1182,"context_line":"        }"},{"line_number":1183,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a710552_3c925458","line":1180,"updated":"2015-12-16 10:55:48.000000000","message":"can be removed, right?","commit_id":"a3f4624cf2c44689571390999a768549d4828750"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c6853b6cd482641754ed794b60e54aa1b6f3ac07","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"        mock_net.physical_network \u003d None"},{"line_number":1178,"context_line":""},{"line_number":1179,"context_line":"        self.lb_rpc.agent.br_mgr.network_map \u003d {NETWORK_ID: mock_net}"},{"line_number":1180,"context_line":"        self.lb_rpc.agent.network_ports \u003d {"},{"line_number":1181,"context_line":"            NETWORK_ID: [PORT_DATA]"},{"line_number":1182,"context_line":"        }"},{"line_number":1183,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_35023d0c","line":1180,"in_reply_to":"5a710552_3c925458","updated":"2015-12-18 20:47:38.000000000","message":"Done","commit_id":"a3f4624cf2c44689571390999a768549d4828750"}],"releasenotes/notes/linuxbridge-agent-extensions-66bdf9feee25ef99.yaml":[{"author":{"_account_id":11307,"name":"Andreas Scheuring","email":"andreas.scheuring@de.ibm.com","username":"uniqueName"},"change_message_id":"9cbf37706e42b37588c59a1ff4910e298aeeb7f0","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The Linuxbridge agent now supports l2 agent extensions."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The Linuxbridge agent can now be extended by 3rd parties using pluggable"},{"line_number":6,"context_line":"    mechanism."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - partially close bug 1468803"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a8ffd7b_6eb3c14d","line":5,"updated":"2015-11-30 09:24:53.000000000","message":"usng a pluggable","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7cf252340bbe99ed7940039be3b84619a3ec076d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    The Linuxbridge agent now supports l2 agent extensions."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - The Linuxbridge agent can now be extended by 3rd parties using pluggable"},{"line_number":6,"context_line":"    mechanism."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - partially close bug 1468803"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a8ffd7b_79fb6048","line":5,"in_reply_to":"9a8ffd7b_6eb3c14d","updated":"2015-11-30 22:07:34.000000000","message":"Thx. Done","commit_id":"c2e7279aae1e5266c94d42bf09dca344c6668841"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f9cc920828f7cf6fca0278f6e61f8d94ca51b788","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - The Linuxbridge agent can now be extended by 3rd parties using a pluggable"},{"line_number":6,"context_line":"    mechanism."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - partially close bug 1468803"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3a7e1126_48714775","line":8,"updated":"2015-12-21 10:37:19.000000000","message":"close \u003d\u003e closes","commit_id":"49f8a0e06e7c5c8b9a90717cd42cf6988bf262c8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"61f4cbaa0a5754aae276e869f00005a3cfbbc22a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"  - The Linuxbridge agent can now be extended by 3rd parties using a pluggable"},{"line_number":6,"context_line":"    mechanism."},{"line_number":7,"context_line":"fixes:"},{"line_number":8,"context_line":"  - partially close bug 1468803"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"3a7e1126_5cb6d0f9","line":8,"in_reply_to":"3a7e1126_48714775","updated":"2015-12-21 18:57:12.000000000","message":"Done","commit_id":"49f8a0e06e7c5c8b9a90717cd42cf6988bf262c8"}]}
