)]}'
{"neutron/tests/unit/test_context.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8db6f5160f8ed2b8dd8cc5376053bedf8e84cf6d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.assertEqual(\u0027tenant_id\u0027, ctx.tenant_id)"},{"line_number":37,"context_line":"        request_id \u003d ctx.request_id"},{"line_number":38,"context_line":"        if isinstance(request_id, bytes):"},{"line_number":39,"context_line":"            request_id \u003d request_id.decode(\u0027utf-8\u0027)"},{"line_number":40,"context_line":"        self.assertThat(request_id, matchers.StartsWith(\u0027req-\u0027))"},{"line_number":41,"context_line":"        self.assertEqual(\u0027user_id\u0027, ctx.user)"},{"line_number":42,"context_line":"        self.assertEqual(\u0027tenant_id\u0027, ctx.tenant)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_69d67f29","line":39,"updated":"2015-11-27 18:57:01.000000000","message":"Not sure I follow. Seems like the test works fine with both bytes and str? So why the change?","commit_id":"d3bef0304058ce4d64fdd9316d7c855691abf283"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"ba99d6e8448d6d820aea95252779b28d64a9c277","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.assertEqual(\u0027tenant_id\u0027, ctx.tenant_id)"},{"line_number":37,"context_line":"        request_id \u003d ctx.request_id"},{"line_number":38,"context_line":"        if isinstance(request_id, bytes):"},{"line_number":39,"context_line":"            request_id \u003d request_id.decode(\u0027utf-8\u0027)"},{"line_number":40,"context_line":"        self.assertThat(request_id, matchers.StartsWith(\u0027req-\u0027))"},{"line_number":41,"context_line":"        self.assertEqual(\u0027user_id\u0027, ctx.user)"},{"line_number":42,"context_line":"        self.assertEqual(\u0027tenant_id\u0027, ctx.tenant)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_7dc07550","line":39,"in_reply_to":"9a8ffd7b_69d67f29","updated":"2015-11-27 23:10:18.000000000","message":"On Python 3, if ctx.request_id is a str, request_id.startswith(b\u0027req-\u0027) fails with a TypeError.\n\n $ python3\n \u003e\u003e\u003e \u0027req-xxx\u0027.startswith(b\u0027req-\u0027)\n ...\n TypeError: startswith first arg must be str or a tuple of str, not bytes\n\nYou can try by modifying generate_request_id() of oslo_context/context.py (of .tox/py34/ virtual environment) to return a string.","commit_id":"d3bef0304058ce4d64fdd9316d7c855691abf283"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"12a9523c62494c7eb99e55300d91165248e48aa5","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.assertEqual(\u0027tenant_id\u0027, ctx.tenant_id)"},{"line_number":37,"context_line":"        request_id \u003d ctx.request_id"},{"line_number":38,"context_line":"        if isinstance(request_id, bytes):"},{"line_number":39,"context_line":"            request_id \u003d request_id.decode(\u0027utf-8\u0027)"},{"line_number":40,"context_line":"        self.assertThat(request_id, matchers.StartsWith(\u0027req-\u0027))"},{"line_number":41,"context_line":"        self.assertEqual(\u0027user_id\u0027, ctx.user)"},{"line_number":42,"context_line":"        self.assertEqual(\u0027tenant_id\u0027, ctx.tenant)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a2fe8336","line":39,"in_reply_to":"9a8ffd7b_7dc07550","updated":"2015-11-30 16:27:09.000000000","message":"Sorry, I missed \u0027b\u0027 removed on the left side of the diff. :-|","commit_id":"d3bef0304058ce4d64fdd9316d7c855691abf283"}]}
