)]}'
{"neutron/callbacks/resources.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d8d7cc30d763dc55b204c9d638e81d0470b9a0c6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"SECURITY_GROUP_RULE \u003d \u0027security_group_rule\u0027"},{"line_number":21,"context_line":"SUBNET \u003d \u0027subnet\u0027"},{"line_number":22,"context_line":"SUBNET_GATEWAY \u003d \u0027subnet_gateway\u0027"},{"line_number":23,"context_line":"SUBNETPOOL_ADDRESS_SCOPE \u003d \u0027subnetpool_address_scope\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_630401c6","line":23,"updated":"2015-12-01 07:05:19.000000000","message":"As address scope is only associated with subnet-pool so no need to mention SUBNETPOOL explicity. IMO. ADDRESS_SCOPE \u003d \u0027address_scope\u0027  would be enough.","commit_id":"2c355a9a334d872bc9107ba95013c7ebf359b901"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"14ee2dd5419f253548680ff1b8632263e143cf33","unresolved":false,"context_lines":[{"line_number":20,"context_line":"SECURITY_GROUP_RULE \u003d \u0027security_group_rule\u0027"},{"line_number":21,"context_line":"SUBNET \u003d \u0027subnet\u0027"},{"line_number":22,"context_line":"SUBNET_GATEWAY \u003d \u0027subnet_gateway\u0027"},{"line_number":23,"context_line":"SUBNETPOOL_ADDRESS_SCOPE \u003d \u0027subnetpool_address_scope\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_d730fea0","line":23,"in_reply_to":"9a8ffd7b_630401c6","updated":"2015-12-01 10:16:15.000000000","message":"Hi, I have to say, I don\u0027t agree with you...\nrouter needs update when subnetpool\u0027s address_scope updates, not when address_scope updates.\nEven if address scope is only associated with subnet-pool now, I would call it SUBNETPOOL_ADDRESS_SCOPE here to avoid confusing.","commit_id":"2c355a9a334d872bc9107ba95013c7ebf359b901"}],"neutron/common/constants.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f82c5a71a54efd036db0ab86d6c308c39d62870c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"ROUTER_INTERFACE_OWNERS_SNAT \u003d (DEVICE_OWNER_ROUTER_INTF,"},{"line_number":60,"context_line":"                                DEVICE_OWNER_DVR_INTERFACE,"},{"line_number":61,"context_line":"                                DEVICE_OWNER_ROUTER_SNAT)"},{"line_number":62,"context_line":"ROUTER_PORT_OWNERS \u003d (DEVICE_OWNER_ROUTER_INTF,"},{"line_number":63,"context_line":"                      DEVICE_OWNER_DVR_INTERFACE,"},{"line_number":64,"context_line":"                      DEVICE_OWNER_ROUTER_SNAT,"},{"line_number":65,"context_line":"                      DEVICE_OWNER_ROUTER_GW)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_5d3d42c2","line":62,"updated":"2016-01-07 09:07:31.000000000","message":"Let\u0027s avoid too much duplication here:","commit_id":"2f828c3030c0f0d07615840db0191c51b9f7a12b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f82c5a71a54efd036db0ab86d6c308c39d62870c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"ROUTER_INTERFACE_OWNERS_SNAT \u003d (DEVICE_OWNER_ROUTER_INTF,"},{"line_number":60,"context_line":"                                DEVICE_OWNER_DVR_INTERFACE,"},{"line_number":61,"context_line":"                                DEVICE_OWNER_ROUTER_SNAT)"},{"line_number":62,"context_line":"ROUTER_PORT_OWNERS \u003d (DEVICE_OWNER_ROUTER_INTF,"},{"line_number":63,"context_line":"                      DEVICE_OWNER_DVR_INTERFACE,"},{"line_number":64,"context_line":"                      DEVICE_OWNER_ROUTER_SNAT,"},{"line_number":65,"context_line":"                      DEVICE_OWNER_ROUTER_GW)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_7d3846d3","line":62,"updated":"2016-01-07 09:07:31.000000000","message":"ROUTER_PORT_OWNERS \u003d ROUTER_INTERFACE_OWNERS_SNAT + (DEVICE_OWNER_ROUTER_GW, )","commit_id":"2f828c3030c0f0d07615840db0191c51b9f7a12b"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"cd47c036c6af67aef9bdc648844a1b578fe384c4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"ROUTER_INTERFACE_OWNERS_SNAT \u003d (DEVICE_OWNER_ROUTER_INTF,"},{"line_number":60,"context_line":"                                DEVICE_OWNER_DVR_INTERFACE,"},{"line_number":61,"context_line":"                                DEVICE_OWNER_ROUTER_SNAT)"},{"line_number":62,"context_line":"ROUTER_PORT_OWNERS \u003d (DEVICE_OWNER_ROUTER_INTF,"},{"line_number":63,"context_line":"                      DEVICE_OWNER_DVR_INTERFACE,"},{"line_number":64,"context_line":"                      DEVICE_OWNER_ROUTER_SNAT,"},{"line_number":65,"context_line":"                      DEVICE_OWNER_ROUTER_GW)"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_1002b7b4","line":62,"in_reply_to":"fa69d971_7d3846d3","updated":"2016-01-14 08:46:57.000000000","message":"Done","commit_id":"2f828c3030c0f0d07615840db0191c51b9f7a12b"}],"neutron/db/db_base_plugin_common.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"abab98fd4b37381458a4826b958b669de97259d8","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        query \u003d query.filter("},{"line_number":250,"context_line":"            models_v2.Subnet.subnetpool_id \u003d\u003d subnetpool_id,"},{"line_number":251,"context_line":"            models_v2.Port.device_owner.in_(constants.ROUTER_PORT_OWNERS))"},{"line_number":252,"context_line":"        return query.all()"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def _get_all_subnets(self, context):"},{"line_number":255,"context_line":"        # NOTE(salvatore-orlando): This query might end up putting"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_ced48421","line":252,"updated":"2015-12-02 18:10:42.000000000","message":"Consider writing a unit test or two to explicitly exercise this method.  This is an interesting enough DB query to warrant a unit test to ensure it returns the right data in different scenarios","commit_id":"2c355a9a334d872bc9107ba95013c7ebf359b901"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"fb1e1fd38ee7e89a3b4fe663eae126b55f5ef730","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        query \u003d query.filter("},{"line_number":250,"context_line":"            models_v2.Subnet.subnetpool_id \u003d\u003d subnetpool_id,"},{"line_number":251,"context_line":"            models_v2.Port.device_owner.in_(constants.ROUTER_PORT_OWNERS))"},{"line_number":252,"context_line":"        return query.all()"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def _get_all_subnets(self, context):"},{"line_number":255,"context_line":"        # NOTE(salvatore-orlando): This query might end up putting"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_8755e81e","line":252,"in_reply_to":"9a8ffd7b_ced48421","updated":"2015-12-03 05:16:27.000000000","message":"Done","commit_id":"2c355a9a334d872bc9107ba95013c7ebf359b901"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"abab98fd4b37381458a4826b958b669de97259d8","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"                router_ids \u003d {p[\u0027device_id\u0027] for p in router_ports}"},{"line_number":1049,"context_line":"                kwargs \u003d {\u0027context\u0027: context, \u0027router_ids\u0027: router_ids}"},{"line_number":1050,"context_line":"                registry.notify(resources.SUBNETPOOL_ADDRESS_SCOPE,"},{"line_number":1051,"context_line":"                                events.AFTER_UPDATE, self, **kwargs)"},{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"        for key in [\u0027min_prefixlen\u0027, \u0027max_prefixlen\u0027, \u0027default_prefixlen\u0027]:"},{"line_number":1054,"context_line":"            updated[\u0027key\u0027] \u003d str(updated[key])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_4e3c14c8","line":1051,"updated":"2015-12-02 18:10:42.000000000","message":"Consider passing self.update_subnetpool instead of self.","commit_id":"2c355a9a334d872bc9107ba95013c7ebf359b901"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"fb1e1fd38ee7e89a3b4fe663eae126b55f5ef730","unresolved":false,"context_lines":[{"line_number":1048,"context_line":"                router_ids \u003d {p[\u0027device_id\u0027] for p in router_ports}"},{"line_number":1049,"context_line":"                kwargs \u003d {\u0027context\u0027: context, \u0027router_ids\u0027: router_ids}"},{"line_number":1050,"context_line":"                registry.notify(resources.SUBNETPOOL_ADDRESS_SCOPE,"},{"line_number":1051,"context_line":"                                events.AFTER_UPDATE, self, **kwargs)"},{"line_number":1052,"context_line":""},{"line_number":1053,"context_line":"        for key in [\u0027min_prefixlen\u0027, \u0027max_prefixlen\u0027, \u0027default_prefixlen\u0027]:"},{"line_number":1054,"context_line":"            updated[\u0027key\u0027] \u003d str(updated[key])"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_073818ed","line":1051,"in_reply_to":"9a8ffd7b_4e3c14c8","updated":"2015-12-03 05:16:27.000000000","message":"Done","commit_id":"2c355a9a334d872bc9107ba95013c7ebf359b901"},{"author":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"change_message_id":"a66ae99e3779d7289ac8996112d0f8e9b30817b5","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"            if address_scope_changed:"},{"line_number":1038,"context_line":"                # Notify related router about the update of subnetpool\u0027s"},{"line_number":1039,"context_line":"                # address scope"},{"line_number":1040,"context_line":"                router_ports \u003d self._get_router_ports_by_subnetpool("},{"line_number":1041,"context_line":"                    context, id)"},{"line_number":1042,"context_line":"                router_ids \u003d {p[\u0027device_id\u0027] for p in router_ports}"},{"line_number":1043,"context_line":"                kwargs \u003d {\u0027context\u0027: context, \u0027router_ids\u0027: router_ids}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_22a40b49","line":1040,"updated":"2015-12-14 09:13:31.000000000","message":"I think you have to check whether router_ports is none, if yes, no need to send notify, right?","commit_id":"8bd65c8f2554f94b59ee2df8e29a51557a451d05"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"0f5de4b28c17ac9711f19523103647bad652c742","unresolved":false,"context_lines":[{"line_number":1037,"context_line":"            if address_scope_changed:"},{"line_number":1038,"context_line":"                # Notify related router about the update of subnetpool\u0027s"},{"line_number":1039,"context_line":"                # address scope"},{"line_number":1040,"context_line":"                router_ports \u003d self._get_router_ports_by_subnetpool("},{"line_number":1041,"context_line":"                    context, id)"},{"line_number":1042,"context_line":"                router_ids \u003d {p[\u0027device_id\u0027] for p in router_ports}"},{"line_number":1043,"context_line":"                kwargs \u003d {\u0027context\u0027: context, \u0027router_ids\u0027: router_ids}"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a710552_70dc93e4","line":1040,"in_reply_to":"7a740942_22a40b49","updated":"2015-12-16 03:51:08.000000000","message":"Right, will create a new patch to address it.","commit_id":"8bd65c8f2554f94b59ee2df8e29a51557a451d05"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f82c5a71a54efd036db0ab86d6c308c39d62870c","unresolved":false,"context_lines":[{"line_number":1046,"context_line":"                                             reader.prefixes,"},{"line_number":1047,"context_line":"                                             id)"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"            if address_scope_changed:"},{"line_number":1050,"context_line":"                # Notify related router about the update of subnetpool\u0027s"},{"line_number":1051,"context_line":"                # address scope"},{"line_number":1052,"context_line":"                router_ports \u003d self._get_router_ports_by_subnetpool("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_9d1e5a5d","line":1049,"updated":"2016-01-07 09:07:31.000000000","message":"This logic does not belong in db_base_plugin_v2. This should just fire a notification that the subnet pool has changed and then the logic of looking up router ports and whatnot should happen in a callback that lives in the l3 code.","commit_id":"2f828c3030c0f0d07615840db0191c51b9f7a12b"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"cd47c036c6af67aef9bdc648844a1b578fe384c4","unresolved":false,"context_lines":[{"line_number":1046,"context_line":"                                             reader.prefixes,"},{"line_number":1047,"context_line":"                                             id)"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"            if address_scope_changed:"},{"line_number":1050,"context_line":"                # Notify related router about the update of subnetpool\u0027s"},{"line_number":1051,"context_line":"                # address scope"},{"line_number":1052,"context_line":"                router_ports \u003d self._get_router_ports_by_subnetpool("}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_b0296b39","line":1049,"in_reply_to":"fa69d971_9d1e5a5d","updated":"2016-01-14 08:46:57.000000000","message":"Done","commit_id":"2f828c3030c0f0d07615840db0191c51b9f7a12b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f82c5a71a54efd036db0ab86d6c308c39d62870c","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"            if address_scope_changed:"},{"line_number":1050,"context_line":"                # Notify related router about the update of subnetpool\u0027s"},{"line_number":1051,"context_line":"                # address scope"},{"line_number":1052,"context_line":"                router_ports \u003d self._get_router_ports_by_subnetpool("},{"line_number":1053,"context_line":"                    context, id)"},{"line_number":1054,"context_line":"                router_ids \u003d {p[\u0027device_id\u0027] for p in router_ports}"},{"line_number":1055,"context_line":"                if router_ids:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa69d971_bd21de9f","line":1052,"updated":"2016-01-07 09:07:31.000000000","message":"if you\u0027re ultimately interested in the routers, adjust the query for this to join to the router port table and return the router IDs directly that way. You can\u0027t trust device_id anyway because the user could have change it.","commit_id":"2f828c3030c0f0d07615840db0191c51b9f7a12b"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"cd47c036c6af67aef9bdc648844a1b578fe384c4","unresolved":false,"context_lines":[{"line_number":1049,"context_line":"            if address_scope_changed:"},{"line_number":1050,"context_line":"                # Notify related router about the update of subnetpool\u0027s"},{"line_number":1051,"context_line":"                # address scope"},{"line_number":1052,"context_line":"                router_ports \u003d self._get_router_ports_by_subnetpool("},{"line_number":1053,"context_line":"                    context, id)"},{"line_number":1054,"context_line":"                router_ids \u003d {p[\u0027device_id\u0027] for p in router_ports}"},{"line_number":1055,"context_line":"                if router_ids:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_50234f56","line":1052,"in_reply_to":"fa69d971_bd21de9f","updated":"2016-01-14 08:46:57.000000000","message":"Done","commit_id":"2f828c3030c0f0d07615840db0191c51b9f7a12b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b7dd4dd4fa29fbe338e4f90ae3e306b07cb82433","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                registry.notify(resources.SUBNETPOOL_ADDRESS_SCOPE,"},{"line_number":1051,"context_line":"                                events.AFTER_UPDATE,"},{"line_number":1052,"context_line":"                                self.update_subnetpool,"},{"line_number":1053,"context_line":"                                **kwargs)"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        for key in [\u0027min_prefixlen\u0027, \u0027max_prefixlen\u0027, \u0027default_prefixlen\u0027]:"},{"line_number":1056,"context_line":"            updated[\u0027key\u0027] \u003d str(updated[key])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_de17b3a1","line":1053,"updated":"2016-01-21 06:29:19.000000000","message":"can this be out of db transaction?","commit_id":"01901837155dbc7a65ff3f1aa270446c29c9019b"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"b184b875b97d3ed29bc50cf22d5d09b2ee4b1a52","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                registry.notify(resources.SUBNETPOOL_ADDRESS_SCOPE,"},{"line_number":1051,"context_line":"                                events.AFTER_UPDATE,"},{"line_number":1052,"context_line":"                                self.update_subnetpool,"},{"line_number":1053,"context_line":"                                **kwargs)"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"        for key in [\u0027min_prefixlen\u0027, \u0027max_prefixlen\u0027, \u0027default_prefixlen\u0027]:"},{"line_number":1056,"context_line":"            updated[\u0027key\u0027] \u003d str(updated[key])"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_28277ecb","line":1053,"in_reply_to":"9a68dd71_de17b3a1","updated":"2016-01-22 02:46:05.000000000","message":"Done","commit_id":"01901837155dbc7a65ff3f1aa270446c29c9019b"}],"neutron/db/l3_db.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d8d7cc30d763dc55b204c9d638e81d0470b9a0c6","unresolved":false,"context_lines":[{"line_number":1457,"context_line":"        events.AFTER_UPDATE)"},{"line_number":1458,"context_line":"    registry.subscribe("},{"line_number":1459,"context_line":"        _notify_routers_callback, resources.SUBNETPOOL_ADDRESS_SCOPE,"},{"line_number":1460,"context_line":"        events.AFTER_UPDATE)"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"# NOTE(armax): multiple l3 service plugins (potentially out of tree) inherit"},{"line_number":1463,"context_line":"# from l3_db and may need the callbacks to be processed. Having an implicit"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_43e1bdfd","line":1460,"updated":"2015-12-01 07:05:19.000000000","message":"No need to handle AFTER_DELETE?","commit_id":"2c355a9a334d872bc9107ba95013c7ebf359b901"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"14ee2dd5419f253548680ff1b8632263e143cf33","unresolved":false,"context_lines":[{"line_number":1457,"context_line":"        events.AFTER_UPDATE)"},{"line_number":1458,"context_line":"    registry.subscribe("},{"line_number":1459,"context_line":"        _notify_routers_callback, resources.SUBNETPOOL_ADDRESS_SCOPE,"},{"line_number":1460,"context_line":"        events.AFTER_UPDATE)"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"# NOTE(armax): multiple l3 service plugins (potentially out of tree) inherit"},{"line_number":1463,"context_line":"# from l3_db and may need the callbacks to be processed. Having an implicit"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_57f5ee80","line":1460,"in_reply_to":"9a8ffd7b_43e1bdfd","updated":"2015-12-01 10:16:15.000000000","message":"Here subscribe the event of the change of one property(address scope) in subnetpool.\n\n\nI can\u0027t imagine how DELETE will need attention here. Either address_scope or subnetpool can be deleted with no association. If there is no association, router don\u0027t have to care about their deletion.","commit_id":"2c355a9a334d872bc9107ba95013c7ebf359b901"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"abab98fd4b37381458a4826b958b669de97259d8","unresolved":false,"context_lines":[{"line_number":1457,"context_line":"        events.AFTER_UPDATE)"},{"line_number":1458,"context_line":"    registry.subscribe("},{"line_number":1459,"context_line":"        _notify_routers_callback, resources.SUBNETPOOL_ADDRESS_SCOPE,"},{"line_number":1460,"context_line":"        events.AFTER_UPDATE)"},{"line_number":1461,"context_line":""},{"line_number":1462,"context_line":"# NOTE(armax): multiple l3 service plugins (potentially out of tree) inherit"},{"line_number":1463,"context_line":"# from l3_db and may need the callbacks to be processed. Having an implicit"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_2eb99015","line":1460,"in_reply_to":"9a8ffd7b_57f5ee80","updated":"2015-12-02 18:10:42.000000000","message":"I didn\u0027t see an AFTER_DELETE being generated.  We\u0027re only responding to updates, so no need to generate AFTER_DELETE or even subscribe to it.","commit_id":"2c355a9a334d872bc9107ba95013c7ebf359b901"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b7dd4dd4fa29fbe338e4f90ae3e306b07cb82433","unresolved":false,"context_lines":[{"line_number":1538,"context_line":"    router_ids \u003d [r[0] for r in query]"},{"line_number":1539,"context_line":"    l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":1540,"context_line":"        constants.L3_ROUTER_NAT)"},{"line_number":1541,"context_line":"    l3plugin.notify_routers_updated(context, router_ids)"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":""},{"line_number":1544,"context_line":"def subscribe():"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_9e14dbf5","line":1541,"updated":"2016-01-21 06:29:19.000000000","message":"i don\u0027t think it\u0027s safe to assume all l3 plugins have notify_routers_updated.  other callback methods seem to have\nthe same issue though.","commit_id":"01901837155dbc7a65ff3f1aa270446c29c9019b"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"b184b875b97d3ed29bc50cf22d5d09b2ee4b1a52","unresolved":false,"context_lines":[{"line_number":1538,"context_line":"    router_ids \u003d [r[0] for r in query]"},{"line_number":1539,"context_line":"    l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":1540,"context_line":"        constants.L3_ROUTER_NAT)"},{"line_number":1541,"context_line":"    l3plugin.notify_routers_updated(context, router_ids)"},{"line_number":1542,"context_line":""},{"line_number":1543,"context_line":""},{"line_number":1544,"context_line":"def subscribe():"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_a3007102","line":1541,"in_reply_to":"9a68dd71_9e14dbf5","updated":"2016-01-22 02:46:05.000000000","message":"yes, it is a common issue here. But I don\u0027t think it is in the scope of this patch. Maybe we can consider it later in another patch.","commit_id":"01901837155dbc7a65ff3f1aa270446c29c9019b"}],"neutron/tests/unit/db/test_db_base_plugin_v2.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"de3390adc2dabf463ebc34a9f37d8f020095171d","unresolved":false,"context_lines":[{"line_number":5316,"context_line":"        subnetpool_id \u003d subnetpool[\u0027subnetpool\u0027][\u0027id\u0027]"},{"line_number":5317,"context_line":"        with self.network() as network:"},{"line_number":5318,"context_line":"            data \u003d {\u0027subnet\u0027: {"},{"line_number":5319,"context_line":"                \u0027network_id\u0027: network[\u0027network\u0027][\u0027id\u0027],"},{"line_number":5320,"context_line":"                \u0027subnetpool_id\u0027: subnetpool_id,"},{"line_number":5321,"context_line":"                \u0027prefixlen\u0027: 24,"},{"line_number":5322,"context_line":"                \u0027ip_version\u0027: 4,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_0b74fdfa","line":5319,"updated":"2015-12-17 22:36:34.000000000","message":"nit:  These should be indented to align with \u0027subnet\u0027 on the previous line, I think.  But, if pep8 doesn\u0027t fail it then I won\u0027t insist.","commit_id":"60823edf138f40f2c33874cc12990b77e07c5558"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"495534558fbe8a3c6240adbd34d53880fa57980c","unresolved":false,"context_lines":[{"line_number":5316,"context_line":"        subnetpool_id \u003d subnetpool[\u0027subnetpool\u0027][\u0027id\u0027]"},{"line_number":5317,"context_line":"        with self.network() as network:"},{"line_number":5318,"context_line":"            data \u003d {\u0027subnet\u0027: {"},{"line_number":5319,"context_line":"                \u0027network_id\u0027: network[\u0027network\u0027][\u0027id\u0027],"},{"line_number":5320,"context_line":"                \u0027subnetpool_id\u0027: subnetpool_id,"},{"line_number":5321,"context_line":"                \u0027prefixlen\u0027: 24,"},{"line_number":5322,"context_line":"                \u0027ip_version\u0027: 4,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_896f552a","line":5319,"in_reply_to":"3a7e1126_0b74fdfa","updated":"2015-12-19 08:28:45.000000000","message":"Done","commit_id":"60823edf138f40f2c33874cc12990b77e07c5558"}],"neutron/tests/unit/extensions/test_address_scope.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"de3390adc2dabf463ebc34a9f37d8f020095171d","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                self._compare_resource(res, update_data[\u0027subnetpool\u0027],"},{"line_number":375,"context_line":"                                       \u0027subnetpool\u0027)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def test_update_subnetpool_address_scope_notify(self):"},{"line_number":378,"context_line":"        subnet \u003d netaddr.IPNetwork(\u002710.10.10.0/24\u0027)"},{"line_number":379,"context_line":"        initial_subnetpool \u003d self._test_create_subnetpool([subnet.cidr],"},{"line_number":380,"context_line":"                                                          name\u003d\u0027foo-sp\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_cb3595f7","line":377,"updated":"2015-12-17 22:36:34.000000000","message":"Should we have a negative test that it doesn\u0027t notify if the update doesn\u0027t change the address scope?  I imagine that the two tests could share code.","commit_id":"60823edf138f40f2c33874cc12990b77e07c5558"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"495534558fbe8a3c6240adbd34d53880fa57980c","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                self._compare_resource(res, update_data[\u0027subnetpool\u0027],"},{"line_number":375,"context_line":"                                       \u0027subnetpool\u0027)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def test_update_subnetpool_address_scope_notify(self):"},{"line_number":378,"context_line":"        subnet \u003d netaddr.IPNetwork(\u002710.10.10.0/24\u0027)"},{"line_number":379,"context_line":"        initial_subnetpool \u003d self._test_create_subnetpool([subnet.cidr],"},{"line_number":380,"context_line":"                                                          name\u003d\u0027foo-sp\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a7e1126_2967414e","line":377,"in_reply_to":"3a7e1126_cb3595f7","updated":"2015-12-19 08:28:45.000000000","message":"Make sense, I have added a negative test case in next patch.","commit_id":"60823edf138f40f2c33874cc12990b77e07c5558"}]}
