)]}'
{"neutron/api/v2/base.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"fb96cfae1dd03ee122564121b8b48c8f89f10177","unresolved":false,"context_lines":[{"line_number":675,"context_line":"            any_updatable \u003d False"},{"line_number":676,"context_line":"            for attr, attr_vals in six.iteritems(attr_info):"},{"line_number":677,"context_line":"                if attr_vals[\u0027allow_put\u0027]:"},{"line_number":678,"context_line":"                    any_updatable \u003d True"},{"line_number":679,"context_line":"                else:"},{"line_number":680,"context_line":"                    if attr in res_dict:"},{"line_number":681,"context_line":"                        msg \u003d _(\"Cannot update read-only attribute %s\") % attr"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_237b597d","line":678,"updated":"2015-12-01 06:59:33.000000000","message":"any_updatable will be updated to True un-necessarily every-time if attr_vals[\u0027allow_put\u0027] is True. Better to initialize it to True only once.","commit_id":"e4571872fa6e309bb55ffd0860f28a627fd65404"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"901ab78f5592c85a971af40928111cf59b9eb28a","unresolved":false,"context_lines":[{"line_number":675,"context_line":"            any_updatable \u003d False"},{"line_number":676,"context_line":"            for attr, attr_vals in six.iteritems(attr_info):"},{"line_number":677,"context_line":"                if attr_vals[\u0027allow_put\u0027]:"},{"line_number":678,"context_line":"                    any_updatable \u003d True"},{"line_number":679,"context_line":"                else:"},{"line_number":680,"context_line":"                    if attr in res_dict:"},{"line_number":681,"context_line":"                        msg \u003d _(\"Cannot update read-only attribute %s\") % attr"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_9e1cd86b","line":678,"in_reply_to":"9a8ffd7b_237b597d","updated":"2015-12-01 07:25:51.000000000","message":"sorry, i don\u0027t understand what you mean.\ncan you explain a bit?","commit_id":"e4571872fa6e309bb55ffd0860f28a627fd65404"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d3dba674177dc89ff3699f53b89a9d2e7e234590","unresolved":false,"context_lines":[{"line_number":675,"context_line":"            any_updatable \u003d False"},{"line_number":676,"context_line":"            for attr, attr_vals in six.iteritems(attr_info):"},{"line_number":677,"context_line":"                if attr_vals[\u0027allow_put\u0027]:"},{"line_number":678,"context_line":"                    any_updatable \u003d True"},{"line_number":679,"context_line":"                else:"},{"line_number":680,"context_line":"                    if attr in res_dict:"},{"line_number":681,"context_line":"                        msg \u003d _(\"Cannot update read-only attribute %s\") % attr"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_d66e442e","line":678,"in_reply_to":"9a8ffd7b_3eab278b","updated":"2015-12-03 03:13:33.000000000","message":"thank you for explanation.\n\nit doesn\u0027t make sense unless the assignment is far more expensive than the additional conditional.\nand i don\u0027t think it is.","commit_id":"e4571872fa6e309bb55ffd0860f28a627fd65404"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4324c1b5fc55c0db63c95a9573fb0d3dea3a4a80","unresolved":false,"context_lines":[{"line_number":675,"context_line":"            any_updatable \u003d False"},{"line_number":676,"context_line":"            for attr, attr_vals in six.iteritems(attr_info):"},{"line_number":677,"context_line":"                if attr_vals[\u0027allow_put\u0027]:"},{"line_number":678,"context_line":"                    any_updatable \u003d True"},{"line_number":679,"context_line":"                else:"},{"line_number":680,"context_line":"                    if attr in res_dict:"},{"line_number":681,"context_line":"                        msg \u003d _(\"Cannot update read-only attribute %s\") % attr"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_3eab278b","line":678,"in_reply_to":"9a8ffd7b_9e1cd86b","updated":"2015-12-02 06:58:16.000000000","message":"Let\u0027s say 2 attr_vals has [\u0027allow_put\u0027]. In that case any_updatable will be updated twice. My point here is why to update it twice. If the value of any_updatable is set to True for the first attribute then why to execute the assignment statement again.\n\nif any_updatable is not True and attr_vals[\u0027allow_put\u0027]:\n    any_updatable \u003d True","commit_id":"e4571872fa6e309bb55ffd0860f28a627fd65404"},{"author":{"_account_id":9459,"name":".Haifeng Yan","email":"yanheven@qq.com","username":"yan"},"change_message_id":"58f3b968f8b100af0afb6f71cf30cf068a180664","unresolved":false,"context_lines":[{"line_number":660,"context_line":"            res_dict \u003d body.get(resource)"},{"line_number":661,"context_line":"        except (AttributeError, TypeError):"},{"line_number":662,"context_line":"            msg \u003d _(\"Body contains invalid data\")"},{"line_number":663,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":664,"context_line":"        if res_dict is None:"},{"line_number":665,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":666,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_7b5eefea","line":663,"updated":"2015-12-04 02:13:38.000000000","message":"is it check for empty body?","commit_id":"9a285332b3aac4e8988684297a4e7bd2efa5ad7a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8019cda7576d8b1f4ac56d58e511389054a5b987","unresolved":false,"context_lines":[{"line_number":660,"context_line":"            res_dict \u003d body.get(resource)"},{"line_number":661,"context_line":"        except (AttributeError, TypeError):"},{"line_number":662,"context_line":"            msg \u003d _(\"Body contains invalid data\")"},{"line_number":663,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"},{"line_number":664,"context_line":"        if res_dict is None:"},{"line_number":665,"context_line":"            msg \u003d _(\"Unable to find \u0027%s\u0027 in request body\") % resource"},{"line_number":666,"context_line":"            raise webob.exc.HTTPBadRequest(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a740942_e34d229a","line":663,"in_reply_to":"7a740942_7b5eefea","updated":"2015-12-05 00:23:45.000000000","message":"no.","commit_id":"9a285332b3aac4e8988684297a4e7bd2efa5ad7a"}]}
