)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"16df1db5468c78b723e340546e901cd461d918ab","unresolved":false,"context_lines":[{"line_number":9,"context_line":"keepalived fails to respawn after crash."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"keepalived_respwans test should be skipped until bug is resolved."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ic111573e0cd5ad5bfe70b0f38ec0203c10d52e34"},{"line_number":14,"context_line":"Related-Bug: #1511311"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_2a2f973f","line":12,"updated":"2015-12-01 12:55:25.000000000","message":"You should link to keepalived bug in commit message. Please also describe as much details about which versions of keepalived are affected (which patch broke the respawn for us).\n\nI am also not so happy about unconditionally disabling the test in gate for the time being. Can we make it validate the keepalived version and skip only if it\u0027s \u003e 1.2.11 (should be the first affected version)?","commit_id":"231d413f95b1252ecb063f7662593400d5ed613e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d6c8b2dc724c5a03af1cce9e64deb216a5f9c1a8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"dies without a chance to clean up the file as part of its signal"},{"line_number":17,"context_line":"handler, respawn never works."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"keepalived_respwans test should be skipped fpr 1.2.11 version, until bug"},{"line_number":20,"context_line":"is resolved."},{"line_number":21,"context_line":"See also: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1286729"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_fb261115","line":19,"updated":"2015-12-02 06:28:58.000000000","message":"fpr\u003d\u003d\u003e for","commit_id":"dbf322e0e2c97d86f94026ebf1f1c143ba85f6d4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b6535d8bf23cadea6488926f535ca1ee14a77033","unresolved":false,"context_lines":[{"line_number":16,"context_line":"dies without a chance to clean up the file as part of its signal"},{"line_number":17,"context_line":"handler, respawn never works."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"keepalived_respwans test should be skipped until bug is resolved."},{"line_number":20,"context_line":"See also: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1286729"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: Ic111573e0cd5ad5bfe70b0f38ec0203c10d52e34"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7a740942_8203d50c","line":19,"updated":"2015-12-07 09:38:53.000000000","message":"keepalived_respwans \u003d\u003e keepalived_respawns","commit_id":"6c1124d43ba44f04b02e8b10c083c0846f300e50"}],"neutron/tests/functional/agent/linux/test_keepalived.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"314d91da8df6379d8d979fb3707cd60bda840093","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from distutils.version import LooseVersion"},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.agent.linux import external_process"},{"line_number":22,"context_line":"from neutron.agent.linux import keepalived"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_cf65301e","line":19,"updated":"2015-12-03 12:59:47.000000000","message":"re is stdlib, so should go before all imports in a separate section.","commit_id":"933a212998a800a6bda08b2f62918e058d7bb4db"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"314d91da8df6379d8d979fb3707cd60bda840093","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_keepalived_respawns(self):"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            cmd \u003d [\u0027keepalived\u0027, \u0027--version\u0027]"},{"line_number":61,"context_line":"            out \u003d utils.execute(cmd, check_error\u003dTrue)"},{"line_number":62,"context_line":"            ver \u003d re.search(r\"Keepalived (\\d+\\.\\d+\\.\\d+)\", out).group(1)"},{"line_number":63,"context_line":"            if LooseVersion(ver) \u003e LooseVersion(\"1.2.11\"):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_6fae842f","line":60,"updated":"2015-12-03 12:59:47.000000000","message":"please move the code to check the keepalived version somewhere out of the test case, we may need it later for other stuff.","commit_id":"933a212998a800a6bda08b2f62918e058d7bb4db"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"314d91da8df6379d8d979fb3707cd60bda840093","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                self.skipTest(\u0027Bug #1511311\u0027)"},{"line_number":65,"context_line":"        except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":66,"context_line":"            LOG.debug(\"Exception while checking keepalived version. \""},{"line_number":67,"context_line":"\t\t\t                      \"Exception: %s\", e)"},{"line_number":68,"context_line":"        self.skipTest(\u0027Bug #1511311\u0027)"},{"line_number":69,"context_line":"        self.manager.spawn()"},{"line_number":70,"context_line":"        process \u003d self.manager.get_process()"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_4f8ce0d9","line":67,"updated":"2015-12-03 12:59:47.000000000","message":"replace tabs with spaces. and fix indentation level for the line.","commit_id":"933a212998a800a6bda08b2f62918e058d7bb4db"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"314d91da8df6379d8d979fb3707cd60bda840093","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":66,"context_line":"            LOG.debug(\"Exception while checking keepalived version. \""},{"line_number":67,"context_line":"\t\t\t                      \"Exception: %s\", e)"},{"line_number":68,"context_line":"        self.skipTest(\u0027Bug #1511311\u0027)"},{"line_number":69,"context_line":"        self.manager.spawn()"},{"line_number":70,"context_line":"        process \u003d self.manager.get_process()"},{"line_number":71,"context_line":"        pid \u003d process.pid"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_8f9de80b","line":68,"updated":"2015-12-03 12:59:47.000000000","message":"Remove the line.","commit_id":"933a212998a800a6bda08b2f62918e058d7bb4db"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"276e8d85d0573998e1ee945393f39bf20a4ab1f7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from distutils.version import LooseVersion"},{"line_number":17,"context_line":"from oslo_config import cfg"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.agent.linux import external_process"},{"line_number":22,"context_line":"from neutron.agent.linux import keepalived"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_a55b2d85","line":19,"updated":"2015-12-03 13:27:03.000000000","message":"Some comments from PS4 are not handled. Like the need to move the import higher.","commit_id":"8d7fc68c7b8a40d046e4bc2312dbb45038ff14a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"276e8d85d0573998e1ee945393f39bf20a4ab1f7","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertEqual(self.expected_config.get_config_str(),"},{"line_number":56,"context_line":"                         self.manager.get_conf_on_disk())"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def keepalived_version_supported():"},{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            cmd \u003d [\u0027keepalived\u0027, \u0027--version\u0027]"},{"line_number":61,"context_line":"            out \u003d utils.execute(cmd, check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_452921e5","line":58,"updated":"2015-12-03 13:27:03.000000000","message":"You miss self argument.\n\nActually, there is no reason to have it as a test case object method (self is not used). Please move it into a function defined in the file.","commit_id":"8d7fc68c7b8a40d046e4bc2312dbb45038ff14a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"276e8d85d0573998e1ee945393f39bf20a4ab1f7","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            out \u003d utils.execute(cmd, check_error\u003dTrue)"},{"line_number":62,"context_line":"            ver \u003d re.search(r\"Keepalived (\\d+\\.\\d+\\.\\d+)\", out).group(1)"},{"line_number":63,"context_line":"            if LooseVersion(ver) \u003e LooseVersion(\"1.2.11\"):"},{"line_number":64,"context_line":"                return True"},{"line_number":65,"context_line":"        except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":66,"context_line":"            LOG.debug(\"Exception while checking keepalived version. \""},{"line_number":67,"context_line":"                      \"Exception: %s\", e)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_a5848dd2","line":64,"updated":"2015-12-03 13:27:03.000000000","message":"So if version is higher than 1.2.11, it\u0027s \u0027supported\u0027?.. It should be vice versa.","commit_id":"8d7fc68c7b8a40d046e4bc2312dbb45038ff14a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"276e8d85d0573998e1ee945393f39bf20a4ab1f7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        return True"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_keepalived_respawns(self):"},{"line_number":72,"context_line":"        result \u003d self.keepalived_version_supported()"},{"line_number":73,"context_line":"        if result:"},{"line_number":74,"context_line":"            self.skipTest(\u0027Bug #1511311\u0027)"},{"line_number":75,"context_line":"        self.manager.spawn()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_65f6a590","line":72,"updated":"2015-12-03 13:27:03.000000000","message":"replace with @testtools.skipIf(keepalived_version_supported(), \u0027bug/XXX\u0027)","commit_id":"8d7fc68c7b8a40d046e4bc2312dbb45038ff14a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3149851c9a2ece370e71f696490ec9d1eef1c353","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        return True"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_keepalived_respawns(self):"},{"line_number":72,"context_line":"        result \u003d self.keepalived_version_supported()"},{"line_number":73,"context_line":"        if result:"},{"line_number":74,"context_line":"            self.skipTest(\u0027Bug #1511311\u0027)"},{"line_number":75,"context_line":"        self.manager.spawn()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_a5b7ad83","line":72,"in_reply_to":"9a8ffd7b_65f6a590","updated":"2015-12-03 14:06:56.000000000","message":"Well, actually the name of the check should be different. It\u0027s weird to skip the test if version is \u0027supported\u0027. :)","commit_id":"8d7fc68c7b8a40d046e4bc2312dbb45038ff14a9"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bb375b5ede6bae7b9784da08b1a59759112eadcd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import re"},{"line_number":17,"context_line":"import testtools"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from distutils.version import LooseVersion"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a740942_c53d1c90","line":19,"updated":"2015-12-08 13:01:41.000000000","message":"Do we have a bug in pep8 job?\nhttp://docs.openstack.org/developer/hacking/#imports\n\nShould be:\n\n from distutils import version\n import re\n\n import testtools","commit_id":"6c1124d43ba44f04b02e8b10c083c0846f300e50"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2d71a778ac73249fdb41a71b31b6aa60862de729","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from distutils.version import LooseVersion"},{"line_number":17,"context_line":"import re"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a740942_b36137ab","line":16,"updated":"2015-12-08 14:29:51.000000000","message":"Still doesn\u0027t comply http://docs.openstack.org/developer/hacking/#imports\n\n from distutils import version","commit_id":"f54967b93ef3f62b2737a6c5cdf3369759d5e39d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"92dc5365e52be02a944115ac18c6e0b8874df40a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        cmd \u003d [\u0027keepalived\u0027, \u0027--version\u0027]"},{"line_number":36,"context_line":"        out \u003d utils.execute(cmd, return_stderr\u003dTrue)"},{"line_number":37,"context_line":"        ver \u003d re.search(r\"Keepalived v(\\d+\\.\\d+\\.\\d+)\", out[1]).group(1)"},{"line_number":38,"context_line":"        if version.LooseVersion(ver) \u003e\u003d version.LooseVersion(\"1.2.11\"):"},{"line_number":39,"context_line":"            return True"},{"line_number":40,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":41,"context_line":"        LOG.debug(\"Exception while checking keepalived version. \""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a740942_f166d74f","line":38,"updated":"2015-12-08 15:01:35.000000000","message":"I would just do: \n\n return version.LooseVersion(ver) \u003e\u003d version.LooseVersion(\"1.2.11\")\n\nand remove L44 but this is cool too :)","commit_id":"a0156fe476571daf2da45cfad33e5f1acddab194"},{"author":{"_account_id":16615,"name":"abregman","email":"abregman@redhat.com","username":"abregman"},"change_message_id":"9970590eeda5e785dd3302c82580cfad198b6000","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        cmd \u003d [\u0027keepalived\u0027, \u0027--version\u0027]"},{"line_number":36,"context_line":"        out \u003d utils.execute(cmd, return_stderr\u003dTrue)"},{"line_number":37,"context_line":"        ver \u003d re.search(r\"Keepalived v(\\d+\\.\\d+\\.\\d+)\", out[1]).group(1)"},{"line_number":38,"context_line":"        if version.LooseVersion(ver) \u003e\u003d version.LooseVersion(\"1.2.11\"):"},{"line_number":39,"context_line":"            return True"},{"line_number":40,"context_line":"    except (OSError, RuntimeError, IndexError, ValueError) as e:"},{"line_number":41,"context_line":"        LOG.debug(\"Exception while checking keepalived version. \""}],"source_content_type":"text/x-python","patch_set":12,"id":"7a740942_6ccd2c84","line":38,"in_reply_to":"7a740942_f166d74f","updated":"2015-12-08 15:11:29.000000000","message":"+1 \nwill do :)","commit_id":"a0156fe476571daf2da45cfad33e5f1acddab194"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b5b5fbb562c3bfb8019e75950f3f757b7c5b117d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        LOG.debug(\"Exception while checking keepalived version. \""},{"line_number":41,"context_line":"                  \"Exception: %s\", e)"},{"line_number":42,"context_line":"        return False"},{"line_number":43,"context_line":"    return False"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class KeepalivedManagerTestCase(base.BaseTestCase,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a740942_a246bb78","line":43,"updated":"2015-12-08 15:45:12.000000000","message":"So now this line is unreachable :)","commit_id":"3c854756cb5877bc2562b0a798c1101cd1139f1d"}]}
