)]}'
{"neutron/plugins/common/utils.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e7deae731acce9433db831a55af7dd21861ecfab","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return new_name"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def id_not_in_range(tun_id, tunnel_ranges):"},{"line_number":187,"context_line":"    \"\"\"Filter function to assist range de-duplication.\"\"\""},{"line_number":188,"context_line":"    not_found \u003d True"},{"line_number":189,"context_line":"    for tun_min, tun_max in tunnel_ranges:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_fc84950b","line":186,"updated":"2015-12-08 00:51:08.000000000","message":"prefer positive form:\n\n  def is_id_in_tunnel_ranges()\n\notherwise in the future we could end with: \"if not id_not_in_ranges(...)\"\n\nfaster and more readable:\n\n def is_id_in_tunnel_ranges(...)\n   return any(tun_min \u003c\u003d tun_id \u003c\u003dtun_max for tun_min, tun_max in tunnel_ranges)","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"be8b00bd6ae3ec72df7a796cf5a49ea3c501a857","unresolved":false,"context_lines":[{"line_number":183,"context_line":"    return new_name"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"def id_not_in_range(tun_id, tunnel_ranges):"},{"line_number":187,"context_line":"    \"\"\"Filter function to assist range de-duplication.\"\"\""},{"line_number":188,"context_line":"    not_found \u003d True"},{"line_number":189,"context_line":"    for tun_min, tun_max in tunnel_ranges:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_6babe475","line":186,"in_reply_to":"7a740942_fc84950b","updated":"2015-12-08 14:06:10.000000000","message":"Done","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e7deae731acce9433db831a55af7dd21861ecfab","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    return not_found"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def normalize_ranges(tunnel_ranges):"},{"line_number":197,"context_line":"    \"\"\"This function will de-duplicate and split the supplied"},{"line_number":198,"context_line":"    ranges if required. Each of the supplied range will be"},{"line_number":199,"context_line":"    checked and modified progressively as the new ranges"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1c9721ed","line":196,"updated":"2015-12-08 00:51:08.000000000","message":"remove useless braces in this method","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"be8b00bd6ae3ec72df7a796cf5a49ea3c501a857","unresolved":false,"context_lines":[{"line_number":193,"context_line":"    return not_found"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def normalize_ranges(tunnel_ranges):"},{"line_number":197,"context_line":"    \"\"\"This function will de-duplicate and split the supplied"},{"line_number":198,"context_line":"    ranges if required. Each of the supplied range will be"},{"line_number":199,"context_line":"    checked and modified progressively as the new ranges"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_6bc20436","line":196,"in_reply_to":"7a740942_1c9721ed","updated":"2015-12-08 14:06:10.000000000","message":"Done","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e7deae731acce9433db831a55af7dd21861ecfab","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def normalize_ranges(tunnel_ranges):"},{"line_number":197,"context_line":"    \"\"\"This function will de-duplicate and split the supplied"},{"line_number":198,"context_line":"    ranges if required. Each of the supplied range will be"},{"line_number":199,"context_line":"    checked and modified progressively as the new ranges"},{"line_number":200,"context_line":"    list is built up. This follows a simple algo and does"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_1cbe4165","line":197,"updated":"2015-12-08 00:51:08.000000000","message":"invalid docstring, it should be:\n\n\"\"\"\u003ctitle on one line\u003e\n\n\u003cdetails (if needed) on one/many lines\u003e\n\"\"\"","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"be8b00bd6ae3ec72df7a796cf5a49ea3c501a857","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def normalize_ranges(tunnel_ranges):"},{"line_number":197,"context_line":"    \"\"\"This function will de-duplicate and split the supplied"},{"line_number":198,"context_line":"    ranges if required. Each of the supplied range will be"},{"line_number":199,"context_line":"    checked and modified progressively as the new ranges"},{"line_number":200,"context_line":"    list is built up. This follows a simple algo and does"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_2bdf1c0e","line":197,"in_reply_to":"7a740942_1cbe4165","updated":"2015-12-08 14:06:10.000000000","message":"Done","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"be8b00bd6ae3ec72df7a796cf5a49ea3c501a857","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    return tunnel_ranges_mod"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def split_ranges(tunnel_ranges, delims):"},{"line_number":238,"context_line":"    \"\"\"This function splits the ranges in the list based on"},{"line_number":239,"context_line":"    supplied demlimiters. This is a better replacement against"},{"line_number":240,"context_line":"    using \u0027set\u0027 difference operation on simple large ranges of"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_4b8068c0","line":237,"updated":"2015-12-08 14:06:10.000000000","message":"Removed unnecessary braces.","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"be8b00bd6ae3ec72df7a796cf5a49ea3c501a857","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"def split_ranges(tunnel_ranges, delims):"},{"line_number":238,"context_line":"    \"\"\"This function splits the ranges in the list based on"},{"line_number":239,"context_line":"    supplied demlimiters. This is a better replacement against"},{"line_number":240,"context_line":"    using \u0027set\u0027 difference operation on simple large ranges of"},{"line_number":241,"context_line":"    numbers."}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_8b4410b7","line":238,"updated":"2015-12-08 14:06:10.000000000","message":"Modified doc string.","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"}],"neutron/plugins/ml2/drivers/type_tunnel.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"666b72f453265e2b408f2fc3932286a9ae16885f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        LOG.info(_LI(\"%(type)s ID ranges: %(range)s\"),"},{"line_number":136,"context_line":"                 {\u0027type\u0027: self.get_type(), \u0027range\u0027: current_range})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def range_remove_filter(self, x, tids):"},{"line_number":139,"context_line":"        # Filter function to assist range de-duplication"},{"line_number":140,"context_line":"        not_found \u003d True"},{"line_number":141,"context_line":"        for tun_min, tun_max in tids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_afdc7ee4","line":138,"updated":"2015-12-03 07:44:34.000000000","message":"I agree.\n\nAnd also \"x\" and \"tids\" confuse reviewers so please change useful name.","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6e5cdb30fbe62dca75b794da59cb161033d2fe0","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        LOG.info(_LI(\"%(type)s ID ranges: %(range)s\"),"},{"line_number":136,"context_line":"                 {\u0027type\u0027: self.get_type(), \u0027range\u0027: current_range})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def range_remove_filter(self, x, tids):"},{"line_number":139,"context_line":"        # Filter function to assist range de-duplication"},{"line_number":140,"context_line":"        not_found \u003d True"},{"line_number":141,"context_line":"        for tun_min, tun_max in tids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_6f7e96b0","line":138,"updated":"2015-12-03 07:37:41.000000000","message":"these are private methods so please use _ as a prefix","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"27a48dc802d1e2f91fc94e3590da8b17eb6a2c0e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        LOG.info(_LI(\"%(type)s ID ranges: %(range)s\"),"},{"line_number":136,"context_line":"                 {\u0027type\u0027: self.get_type(), \u0027range\u0027: current_range})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def range_remove_filter(self, x, tids):"},{"line_number":139,"context_line":"        # Filter function to assist range de-duplication"},{"line_number":140,"context_line":"        not_found \u003d True"},{"line_number":141,"context_line":"        for tun_min, tun_max in tids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_bf81b8fd","line":138,"in_reply_to":"9a8ffd7b_6f7e96b0","updated":"2015-12-03 18:25:46.000000000","message":"Done. Function name modified to be descriptive.","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"27a48dc802d1e2f91fc94e3590da8b17eb6a2c0e","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        LOG.info(_LI(\"%(type)s ID ranges: %(range)s\"),"},{"line_number":136,"context_line":"                 {\u0027type\u0027: self.get_type(), \u0027range\u0027: current_range})"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def range_remove_filter(self, x, tids):"},{"line_number":139,"context_line":"        # Filter function to assist range de-duplication"},{"line_number":140,"context_line":"        not_found \u003d True"},{"line_number":141,"context_line":"        for tun_min, tun_max in tids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_1fbb2cc6","line":138,"in_reply_to":"9a8ffd7b_afdc7ee4","updated":"2015-12-03 18:25:46.000000000","message":"Done","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"666b72f453265e2b408f2fc3932286a9ae16885f","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                break"},{"line_number":145,"context_line":"        return not_found"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def normalize_ranges(self, tunnel_ranges):"},{"line_number":148,"context_line":"        # This function will de-duplicate and split the supplied"},{"line_number":149,"context_line":"        # ranges if required. Each of the supplied range will be"},{"line_number":150,"context_line":"        # checked and modified progressively as the new ranges"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_6ff9b64d","line":147,"updated":"2015-12-03 07:44:34.000000000","message":"I agree. You should prepare UT. The test helps reviewers to understand this code.\n\nPlease add \"_\"","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c6e5cdb30fbe62dca75b794da59cb161033d2fe0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                break"},{"line_number":145,"context_line":"        return not_found"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def normalize_ranges(self, tunnel_ranges):"},{"line_number":148,"context_line":"        # This function will de-duplicate and split the supplied"},{"line_number":149,"context_line":"        # ranges if required. Each of the supplied range will be"},{"line_number":150,"context_line":"        # checked and modified progressively as the new ranges"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_2f4bae88","line":147,"updated":"2015-12-03 07:37:41.000000000","message":"where are the unit tests for the new methods?","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"27a48dc802d1e2f91fc94e3590da8b17eb6a2c0e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                break"},{"line_number":145,"context_line":"        return not_found"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def normalize_ranges(self, tunnel_ranges):"},{"line_number":148,"context_line":"        # This function will de-duplicate and split the supplied"},{"line_number":149,"context_line":"        # ranges if required. Each of the supplied range will be"},{"line_number":150,"context_line":"        # checked and modified progressively as the new ranges"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_bfaf787c","line":147,"in_reply_to":"9a8ffd7b_2f4bae88","updated":"2015-12-03 18:25:46.000000000","message":"Done. Added new unit tests to test these new range ops and compare it with the results of set ops.","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"27a48dc802d1e2f91fc94e3590da8b17eb6a2c0e","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                break"},{"line_number":145,"context_line":"        return not_found"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def normalize_ranges(self, tunnel_ranges):"},{"line_number":148,"context_line":"        # This function will de-duplicate and split the supplied"},{"line_number":149,"context_line":"        # ranges if required. Each of the supplied range will be"},{"line_number":150,"context_line":"        # checked and modified progressively as the new ranges"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_7fd110fb","line":147,"in_reply_to":"9a8ffd7b_6ff9b64d","updated":"2015-12-03 18:25:46.000000000","message":"Done","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"666b72f453265e2b408f2fc3932286a9ae16885f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                                 in tunnel_ranges_mod if rng !\u003d (-1, -1)]"},{"line_number":182,"context_line":"        return tunnel_ranges_mod"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def split_ranges(self, tunnel_ranges, delims):"},{"line_number":185,"context_line":"        # This function splits the ranges in the list based on"},{"line_number":186,"context_line":"        # supplied demlimiters."},{"line_number":187,"context_line":"        for delim in delims:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_8ff65a5b","line":184,"updated":"2015-12-03 07:44:34.000000000","message":"Please add \"_\"","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"27a48dc802d1e2f91fc94e3590da8b17eb6a2c0e","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                                 in tunnel_ranges_mod if rng !\u003d (-1, -1)]"},{"line_number":182,"context_line":"        return tunnel_ranges_mod"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def split_ranges(self, tunnel_ranges, delims):"},{"line_number":185,"context_line":"        # This function splits the ranges in the list based on"},{"line_number":186,"context_line":"        # supplied demlimiters."},{"line_number":187,"context_line":"        for delim in delims:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a740942_3fdb881d","line":184,"in_reply_to":"9a8ffd7b_8ff65a5b","updated":"2015-12-03 18:25:46.000000000","message":"Done","commit_id":"c2287d15c420e7b525c2e540a2aa0d27c3db9534"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e7deae731acce9433db831a55af7dd21861ecfab","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            unallocateds \u003d ("},{"line_number":158,"context_line":"                tunnel_id_getter(a) for a in allocs if not a.allocated)"},{"line_number":159,"context_line":"            tunnel_ranges \u003d plugin_utils.normalize_ranges(self.tunnel_ranges)"},{"line_number":160,"context_line":"            to_remove.extend(x for x in unallocateds"},{"line_number":161,"context_line":"                             if plugin_utils.id_not_in_range(x, tunnel_ranges))"},{"line_number":162,"context_line":"            # Immediately delete tunnels in chunks. This leaves no work for"},{"line_number":163,"context_line":"            # flush at the end of transaction"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_dc6af9ec","line":160,"updated":"2015-12-08 00:51:08.000000000","message":"if you want to reduce mem usage, then don\u0027t build to_remove and missings at all and build on the fly chunks to remove/create","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"be8b00bd6ae3ec72df7a796cf5a49ea3c501a857","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            unallocateds \u003d ("},{"line_number":158,"context_line":"                tunnel_id_getter(a) for a in allocs if not a.allocated)"},{"line_number":159,"context_line":"            tunnel_ranges \u003d plugin_utils.normalize_ranges(self.tunnel_ranges)"},{"line_number":160,"context_line":"            to_remove.extend(x for x in unallocateds"},{"line_number":161,"context_line":"                             if plugin_utils.id_not_in_range(x, tunnel_ranges))"},{"line_number":162,"context_line":"            # Immediately delete tunnels in chunks. This leaves no work for"},{"line_number":163,"context_line":"            # flush at the end of transaction"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_cb53f869","line":160,"in_reply_to":"7a740942_dc6af9ec","updated":"2015-12-08 14:06:10.000000000","message":"Done.Changed to generators.","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"}],"neutron/tests/unit/common/test_utils.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e7deae731acce9433db831a55af7dd21861ecfab","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        tunnel_ids \u003d set()"},{"line_number":153,"context_line":"        _to_remove \u003d []"},{"line_number":154,"context_line":"        _missings \u003d []"},{"line_number":155,"context_line":"        self.assertEqual(1, 1)"},{"line_number":156,"context_line":"        allocs \u003d six.moves.range(allocs_range[0], allocs_range[1])"},{"line_number":157,"context_line":"        unallocateds \u003d six.moves.range(unallocs_range[0], unallocs_range[1])"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_dc099985","line":155,"updated":"2015-12-08 00:51:08.000000000","message":"??","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"be8b00bd6ae3ec72df7a796cf5a49ea3c501a857","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        tunnel_ids \u003d set()"},{"line_number":153,"context_line":"        _to_remove \u003d []"},{"line_number":154,"context_line":"        _missings \u003d []"},{"line_number":155,"context_line":"        self.assertEqual(1, 1)"},{"line_number":156,"context_line":"        allocs \u003d six.moves.range(allocs_range[0], allocs_range[1])"},{"line_number":157,"context_line":"        unallocateds \u003d six.moves.range(unallocs_range[0], unallocs_range[1])"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_cb2458c6","line":155,"in_reply_to":"7a740942_dc099985","updated":"2015-12-08 14:06:10.000000000","message":"Done. Removed. Sorry for being stupid.","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e7deae731acce9433db831a55af7dd21861ecfab","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        missings \u003d list(tunnel_ids - existings)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        # building removal and missings list using only range vectors"},{"line_number":167,"context_line":"        _tunnel_ranges \u003d plugin_utils.normalize_ranges(tunnel_ranges)"},{"line_number":168,"context_line":"        _to_remove.extend(x for x in unallocateds"},{"line_number":169,"context_line":"                          if plugin_utils.id_not_in_range(x, _tunnel_ranges))"},{"line_number":170,"context_line":"        _tunnel_ranges \u003d plugin_utils.split_ranges(_tunnel_ranges, allocs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_f7590e36","line":167,"updated":"2015-12-08 00:51:08.000000000","message":"this test should be splitted into many tests in order to have tests checking one thing, only one thing","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"be8b00bd6ae3ec72df7a796cf5a49ea3c501a857","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        missings \u003d list(tunnel_ids - existings)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        # building removal and missings list using only range vectors"},{"line_number":167,"context_line":"        _tunnel_ranges \u003d plugin_utils.normalize_ranges(tunnel_ranges)"},{"line_number":168,"context_line":"        _to_remove.extend(x for x in unallocateds"},{"line_number":169,"context_line":"                          if plugin_utils.id_not_in_range(x, _tunnel_ranges))"},{"line_number":170,"context_line":"        _tunnel_ranges \u003d plugin_utils.split_ranges(_tunnel_ranges, allocs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_ab0eac38","line":167,"in_reply_to":"7a740942_f7590e36","updated":"2015-12-08 14:06:10.000000000","message":"Done. Split in two.","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"e7deae731acce9433db831a55af7dd21861ecfab","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                base.BaseTestCase):"},{"line_number":200,"context_line":"    TUN_MIN \u003d p_const.MIN_VXLAN_VNI"},{"line_number":201,"context_line":"    # Full range may prove fatal for test env with set"},{"line_number":202,"context_line":"    TUN_MAX \u003d (p_const.MAX_VXLAN_VNI + 1) / 256"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class TestGreRangeUtilsVsSets(TestRangeUtilsVsSets,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_7c4425b6","line":202,"updated":"2015-12-08 00:51:08.000000000","message":"imo, performance tests should be outside of neutron/tests/unit","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"be8b00bd6ae3ec72df7a796cf5a49ea3c501a857","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                base.BaseTestCase):"},{"line_number":200,"context_line":"    TUN_MIN \u003d p_const.MIN_VXLAN_VNI"},{"line_number":201,"context_line":"    # Full range may prove fatal for test env with set"},{"line_number":202,"context_line":"    TUN_MAX \u003d (p_const.MAX_VXLAN_VNI + 1) / 256"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class TestGreRangeUtilsVsSets(TestRangeUtilsVsSets,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a740942_26d5111b","line":202,"in_reply_to":"7a740942_7c4425b6","updated":"2015-12-08 14:06:10.000000000","message":"I didn\u0027t intend it to be perf tests, but rather as a replacement for set, for operating on large ranges of numbers. So it should replicate set\u0027s union and diff ops, which is being compared/tested. \n\nIf you think it\u0027s out of place, please suggest a good place. I\u0027\u0027ll move them.","commit_id":"06d60c66133f16401f0a3d13b905981c825880bf"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"abdc251f8664b831029dae9e7caf8a96b15c1c8c","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def test_id_in_ranges_vs_sets_diff_stub1(self):"},{"line_number":192,"context_line":"        self._test_id_in_ranges_vs_sets_diff()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_id_in_ranges_vs_sets_merge_stub2(self):"},{"line_number":195,"context_line":"        tunnel_ranges \u003d [(20, 20), (11, 11), (25, 75), (15, 25), (5, 10),"},{"line_number":196,"context_line":"                         (10, 14), (1, 50), (1, self.TUN_MIN),"},{"line_number":197,"context_line":"                         (1, self.TUN_MAX), (98, 73)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_21ef3b88","line":194,"updated":"2015-12-13 15:36:51.000000000","message":"These function names - specifically the \"stub1,stub2\" are ugly.","commit_id":"880c10110645bb59d8079ff4b14bd3f78e68a73f"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"3b1337866f55b37dbdb5622210f860869c0f8507","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    def test_id_in_ranges_vs_sets_diff_stub1(self):"},{"line_number":192,"context_line":"        self._test_id_in_ranges_vs_sets_diff()"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_id_in_ranges_vs_sets_merge_stub2(self):"},{"line_number":195,"context_line":"        tunnel_ranges \u003d [(20, 20), (11, 11), (25, 75), (15, 25), (5, 10),"},{"line_number":196,"context_line":"                         (10, 14), (1, 50), (1, self.TUN_MIN),"},{"line_number":197,"context_line":"                         (1, self.TUN_MAX), (98, 73)]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_dd63b4af","line":194,"in_reply_to":"7a740942_21ef3b88","updated":"2015-12-14 05:18:26.000000000","message":":-) \n\"Beauty is in the eyes of the beholder.\"\n\nI intended it to be test stubs. Please suggest alternatives!","commit_id":"880c10110645bb59d8079ff4b14bd3f78e68a73f"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"d7b9f38e5880f0caf22bc6f74e66e67dc4a075a6","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                                base.BaseTestCase):"},{"line_number":223,"context_line":"    TUN_MIN \u003d p_const.MIN_VXLAN_VNI"},{"line_number":224,"context_line":"    # Full range may prove fatal for test env with set"},{"line_number":225,"context_line":"    TUN_MAX \u003d (p_const.MAX_VXLAN_VNI + 1) // 256"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"class TestGreRangeUtilsVsSets(TestRangeUtilsVsSets,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_49cebb84","line":225,"updated":"2015-12-10 06:40:44.000000000","message":"py34 constraints test failure due to \"TypeError: \u0027float\u0027 object cannot be interpreted as an integer\"\n\nUsed integer division operator \u0027//\u0027.","commit_id":"880c10110645bb59d8079ff4b14bd3f78e68a73f"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"d7b9f38e5880f0caf22bc6f74e66e67dc4a075a6","unresolved":false,"context_lines":[{"line_number":229,"context_line":"                              base.BaseTestCase):"},{"line_number":230,"context_line":"    TUN_MIN \u003d p_const.MIN_GRE_ID"},{"line_number":231,"context_line":"    # Full range may prove fatal for test env with set"},{"line_number":232,"context_line":"    TUN_MAX \u003d (p_const.MAX_GRE_ID + 1) // (1024 * 256)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"class UtilTestParseVlanRanges(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_c9a06ba8","line":232,"updated":"2015-12-10 06:40:44.000000000","message":"ditto","commit_id":"880c10110645bb59d8079ff4b14bd3f78e68a73f"}]}
