)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ab1c58e044a3012516cf356f6e02ec018c9ed251","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Li Ma \u003cskywalker.nick@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-02 10:30:22 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add popular IP protocols for security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iaef9b650449b4d9d362a59305c45e0aa3831507c"},{"line_number":10,"context_line":"Closes-Bug: #1475717"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_5135c343","line":7,"updated":"2015-12-02 04:39:27.000000000","message":"Please consider elaborating more in your commit message. It would be beneficial for all of us if you could explain why you are doing this. Even a sentence or two would be appreciated.","commit_id":"ff2bfbfdb6a9efc3ced15d4dd5da0663a6e5f520"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"1ad90b716d39add51236b65208b49b8370c74049","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Li Ma \u003cskywalker.nick@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-12-02 10:30:22 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add popular IP protocols for security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Iaef9b650449b4d9d362a59305c45e0aa3831507c"},{"line_number":10,"context_line":"Closes-Bug: #1475717"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a8ffd7b_af7d5e1d","line":7,"in_reply_to":"9a8ffd7b_5135c343","updated":"2015-12-03 07:26:13.000000000","message":"Done","commit_id":"ff2bfbfdb6a9efc3ced15d4dd5da0663a6e5f520"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e2d5c1aa67dc771a571f8b30351195315a24d0eb","unresolved":false,"context_lines":[{"line_number":11,"context_line":"these protocols. In addition, make the security"},{"line_number":12,"context_line":"group rules more readable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iaef9b650449b4d9d362a59305c45e0aa3831507c"},{"line_number":15,"context_line":"Closes-Bug: #1475717"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a8ffd7b_c9420bab","line":14,"updated":"2015-12-03 13:41:52.000000000","message":"DocImpact?","commit_id":"a008943e69f8eeda79fd60916aeea0504052ea1b"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c9952c09be0de577eb9feb8d22b732afe6b0af5c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"these protocols. In addition, make the security"},{"line_number":12,"context_line":"group rules more readable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact You can specify protocol names rather than"},{"line_number":15,"context_line":"protocol number in API and CLI commands. I\u0027ll update"},{"line_number":16,"context_line":"the documentation when it is merged."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_1bfa32be","line":14,"updated":"2015-12-04 14:03:54.000000000","message":"I just checked and the protocols are listed in the API reference documentation, so this should have an APIImpact too.","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"013c7921c5858ded288a366e6622b7b6cdaafd3f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"these protocols. In addition, make the security"},{"line_number":12,"context_line":"group rules more readable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact You can specify protocol names rather than"},{"line_number":15,"context_line":"protocol number in API and CLI commands. I\u0027ll update"},{"line_number":16,"context_line":"the documentation when it is merged."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_34f7ad8c","line":14,"in_reply_to":"7a740942_1bfa32be","updated":"2015-12-11 15:08:28.000000000","message":"Done","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5fc3d984210109ed56cce076bc87827ec916c6dd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"these protocols. In addition, make the security"},{"line_number":12,"context_line":"group rules more readable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact You can specify protocol names rather than"},{"line_number":15,"context_line":"protocol number in API and CLI commands. I\u0027ll update"},{"line_number":16,"context_line":"the documentation when it is merged."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_939d825b","line":14,"in_reply_to":"7a740942_1bfa32be","updated":"2015-12-06 07:49:08.000000000","message":"please also add in a release note","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"013c7921c5858ded288a366e6622b7b6cdaafd3f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"these protocols. In addition, make the security"},{"line_number":12,"context_line":"group rules more readable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact You can specify protocol names rather than"},{"line_number":15,"context_line":"protocol number in API and CLI commands. I\u0027ll update"},{"line_number":16,"context_line":"the documentation when it is merged."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a740942_d4ef49af","line":14,"in_reply_to":"7a740942_939d825b","updated":"2015-12-11 15:08:28.000000000","message":"Done","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"4390f48117beb2e5998660ec48c616062a4d6df5","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact You can specify protocol names rather than"},{"line_number":15,"context_line":"protocol number in API and CLI commands. I\u0027ll update"},{"line_number":16,"context_line":"the documentation when it is merged."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"APIImpact"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a7e1126_b790e3ed","line":16,"updated":"2015-12-17 09:39:44.000000000","message":"DocImpact then ?","commit_id":"86dcb5825ca6eb2ceb5431d43c730c89de3a3485"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d56fe38dc04a8cfe590373a29d2f2f8acfd3fcb1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add popular IP protocols for security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add these additional protocols to security groups"},{"line_number":10,"context_line":"brings convenience to operators on configuring"},{"line_number":11,"context_line":"these protocols. In addition, make the security"},{"line_number":12,"context_line":"group rules more readable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa69d971_862b2294","line":9,"updated":"2016-01-01 04:24:35.000000000","message":"Can you please elaborate what \u0027these additional protocols\u0027 we are talking about over here?","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"0fae749b954efbe952b9204f7f7196d89d79baad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add popular IP protocols for security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add these additional protocols to security groups"},{"line_number":10,"context_line":"brings convenience to operators on configuring"},{"line_number":11,"context_line":"these protocols. In addition, make the security"},{"line_number":12,"context_line":"group rules more readable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa69d971_e6fe53ad","line":9,"in_reply_to":"fa69d971_862b2294","updated":"2016-01-05 07:07:45.000000000","message":"Done","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d56fe38dc04a8cfe590373a29d2f2f8acfd3fcb1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"A related patch is submitted to neutron-lib project:"},{"line_number":15,"context_line":"https://review.openstack.org/259037"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact You can specify protocol names rather than"},{"line_number":18,"context_line":"protocol number in API and CLI commands. I\u0027ll update"},{"line_number":19,"context_line":"the documentation when it is merged."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa69d971_66306e02","line":17,"updated":"2016-01-01 04:24:35.000000000","message":"Better to mention either a \u0027:\u0027 after \u0027DocImpact\u0027 or description in the next line.","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"0fae749b954efbe952b9204f7f7196d89d79baad","unresolved":false,"context_lines":[{"line_number":14,"context_line":"A related patch is submitted to neutron-lib project:"},{"line_number":15,"context_line":"https://review.openstack.org/259037"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact You can specify protocol names rather than"},{"line_number":18,"context_line":"protocol number in API and CLI commands. I\u0027ll update"},{"line_number":19,"context_line":"the documentation when it is merged."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa69d971_862e7741","line":17,"in_reply_to":"fa69d971_66306e02","updated":"2016-01-05 07:07:45.000000000","message":"Done","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"69943ede7beab9dd2df6c2f2bb6722933b99aa95","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add popular IP protocols for security group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add these additional protocols listed below to"},{"line_number":10,"context_line":"security groups brings convenience to operators"},{"line_number":11,"context_line":"on configuring these protocols. In addition, make"},{"line_number":12,"context_line":"the security group rules more readable."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa69d971_16c388ee","line":9,"updated":"2016-01-05 14:24:53.000000000","message":"Rephrase: Added below listed protocol types to ...","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"69943ede7beab9dd2df6c2f2bb6722933b99aa95","unresolved":false,"context_lines":[{"line_number":11,"context_line":"on configuring these protocols. In addition, make"},{"line_number":12,"context_line":"the security group rules more readable."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"additional protocols: ah, dccp, egp, esp, gre,"},{"line_number":15,"context_line":"ipv6-encap, ipv6-frag, ipv6-nonxt, ipv6-opts,"},{"line_number":16,"context_line":"ipv6-route, ospf, pgm, rsvp, sctp, udplite, vrrp."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa69d971_7679a4c7","line":14,"updated":"2016-01-05 14:24:53.000000000","message":"Rephrase as \"New protocol types added:\"","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"69943ede7beab9dd2df6c2f2bb6722933b99aa95","unresolved":false,"context_lines":[{"line_number":19,"context_line":"https://review.openstack.org/259037"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact: You can specify protocol names rather than"},{"line_number":22,"context_line":"protocol number in API and CLI commands. I\u0027ll update"},{"line_number":23,"context_line":"the documentation when it is merged."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"APIImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa69d971_f632740f","line":22,"updated":"2016-01-05 14:24:53.000000000","message":"\u0027command\u0027 looks redundant. CLI itself means \"Command Line argument\"","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"}],"neutron/common/constants.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b0f0b5f14638cfe005084c87e351d0549413925f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"PROTO_NUM_IPV6_ROUTE \u003d 43"},{"line_number":159,"context_line":"PROTO_NUM_IPV6_FRAG \u003d 44"},{"line_number":160,"context_line":"PROTO_NUM_IPV6_NONXT \u003d 59"},{"line_number":161,"context_line":"PROTO_NUM_IPV6_OPTS \u003d 60"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# List of ICMPv6 types that should be allowed by default:"},{"line_number":164,"context_line":"# Multicast Listener Query (130),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_4a4b97b1","line":161,"updated":"2015-12-02 21:02:35.000000000","message":"nit: 132/SCTP, 136/UDPLITE and 33/DCCP are other common protocols.\n\nAnd it might be better if the numbers were ordered sequentially, so it\u0027s easier to search through them.","commit_id":"ff2bfbfdb6a9efc3ced15d4dd5da0663a6e5f520"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"1ad90b716d39add51236b65208b49b8370c74049","unresolved":false,"context_lines":[{"line_number":158,"context_line":"PROTO_NUM_IPV6_ROUTE \u003d 43"},{"line_number":159,"context_line":"PROTO_NUM_IPV6_FRAG \u003d 44"},{"line_number":160,"context_line":"PROTO_NUM_IPV6_NONXT \u003d 59"},{"line_number":161,"context_line":"PROTO_NUM_IPV6_OPTS \u003d 60"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"# List of ICMPv6 types that should be allowed by default:"},{"line_number":164,"context_line":"# Multicast Listener Query (130),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_cf7a2224","line":161,"in_reply_to":"9a8ffd7b_4a4b97b1","updated":"2015-12-03 07:26:13.000000000","message":"Done","commit_id":"ff2bfbfdb6a9efc3ced15d4dd5da0663a6e5f520"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c213783822257a63e7608e1c3704cb0dc2f9ac06","unresolved":false,"context_lines":[{"line_number":166,"context_line":"PROTO_NUM_SCTP \u003d 132"},{"line_number":167,"context_line":"PROTO_NUM_UDPLITE \u003d 136"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"IP_PROTOCOL_MAP \u003d {PROTO_NAME_ICMP: PROTO_NUM_ICMP,"},{"line_number":170,"context_line":"                   PROTO_NAME_IGMP: PROTO_NUM_IGMP,"},{"line_number":171,"context_line":"                   PROTO_NAME_TCP: PROTO_NUM_TCP,"},{"line_number":172,"context_line":"                   PROTO_NAME_EGP: PROTO_NUM_EGP,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_236ef1c9","line":169,"updated":"2015-12-04 09:21:29.000000000","message":"Arranging in alphabetical order will be useful.","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c9952c09be0de577eb9feb8d22b732afe6b0af5c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"PROTO_NUM_SCTP \u003d 132"},{"line_number":167,"context_line":"PROTO_NUM_UDPLITE \u003d 136"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"IP_PROTOCOL_MAP \u003d {PROTO_NAME_ICMP: PROTO_NUM_ICMP,"},{"line_number":170,"context_line":"                   PROTO_NAME_IGMP: PROTO_NUM_IGMP,"},{"line_number":171,"context_line":"                   PROTO_NAME_TCP: PROTO_NUM_TCP,"},{"line_number":172,"context_line":"                   PROTO_NAME_EGP: PROTO_NUM_EGP,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_e0f2119a","line":169,"in_reply_to":"7a740942_236ef1c9","updated":"2015-12-04 14:03:54.000000000","message":"+1","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"013c7921c5858ded288a366e6622b7b6cdaafd3f","unresolved":false,"context_lines":[{"line_number":166,"context_line":"PROTO_NUM_SCTP \u003d 132"},{"line_number":167,"context_line":"PROTO_NUM_UDPLITE \u003d 136"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"IP_PROTOCOL_MAP \u003d {PROTO_NAME_ICMP: PROTO_NUM_ICMP,"},{"line_number":170,"context_line":"                   PROTO_NAME_IGMP: PROTO_NUM_IGMP,"},{"line_number":171,"context_line":"                   PROTO_NAME_TCP: PROTO_NUM_TCP,"},{"line_number":172,"context_line":"                   PROTO_NAME_EGP: PROTO_NUM_EGP,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_7446957c","line":169,"in_reply_to":"7a740942_e0f2119a","updated":"2015-12-11 15:08:28.000000000","message":"Done","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e8fe0e91663411b777e643683054504f8fee6463","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                   PROTO_NAME_TCP: PROTO_NUM_TCP,"},{"line_number":187,"context_line":"                   PROTO_NAME_UDP: PROTO_NUM_UDP,"},{"line_number":188,"context_line":"                   PROTO_NAME_UDPLITE: PROTO_NUM_UDPLITE,"},{"line_number":189,"context_line":"                   PROTO_NAME_VRRP: PROTO_NUM_VRRP}"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"# List of ICMPv6 types that should be allowed by default:"},{"line_number":192,"context_line":"# Multicast Listener Query (130),"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_3345c2b2","line":189,"updated":"2015-12-15 21:46:56.000000000","message":"IMO these constants should not be added to neutron, because we will just end up moving them to neutron-lib soon. It is better to add them to neutron-lib from the start.","commit_id":"86dcb5825ca6eb2ceb5431d43c730c89de3a3485"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"4390f48117beb2e5998660ec48c616062a4d6df5","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                   PROTO_NAME_TCP: PROTO_NUM_TCP,"},{"line_number":187,"context_line":"                   PROTO_NAME_UDP: PROTO_NUM_UDP,"},{"line_number":188,"context_line":"                   PROTO_NAME_UDPLITE: PROTO_NUM_UDPLITE,"},{"line_number":189,"context_line":"                   PROTO_NAME_VRRP: PROTO_NUM_VRRP}"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"# List of ICMPv6 types that should be allowed by default:"},{"line_number":192,"context_line":"# Multicast Listener Query (130),"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_3a0e1a35","line":189,"in_reply_to":"5a710552_3345c2b2","updated":"2015-12-17 09:39:44.000000000","message":"( I saw latter comments from henry, that this could be done at a later time, ant that we\u0027re still accepting constants).\n\nLi Ma, could you at least add a parallel patch to neutron_lib now so a later switch is easier?\n\nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py  ?","commit_id":"86dcb5825ca6eb2ceb5431d43c730c89de3a3485"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"6eaf016f778509d80492b820ec3df4388d5697ec","unresolved":false,"context_lines":[{"line_number":123,"context_line":"ETHERTYPE_IPV6 \u003d 0x86DD"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Protocol names and numbers for Security Groups/Firewalls"},{"line_number":126,"context_line":"PROTO_NAME_ICMP \u003d \u0027icmp\u0027"},{"line_number":127,"context_line":"PROTO_NAME_IGMP \u003d \u0027igmp\u0027"},{"line_number":128,"context_line":"PROTO_NAME_TCP \u003d \u0027tcp\u0027"},{"line_number":129,"context_line":"PROTO_NAME_EGP \u003d \u0027egp\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_10867913","line":126,"updated":"2015-12-17 16:29:22.000000000","message":"Having these in alphabetical order would help.","commit_id":"9a37c462cf1efb83c84d0545d067a05dee09e569"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"2028445c4adef99406b6fc2146e0199cf1f2f18b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"ETHERTYPE_IPV6 \u003d 0x86DD"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"# Protocol names and numbers for Security Groups/Firewalls"},{"line_number":126,"context_line":"PROTO_NAME_ICMP \u003d \u0027icmp\u0027"},{"line_number":127,"context_line":"PROTO_NAME_IGMP \u003d \u0027igmp\u0027"},{"line_number":128,"context_line":"PROTO_NAME_TCP \u003d \u0027tcp\u0027"},{"line_number":129,"context_line":"PROTO_NAME_EGP \u003d \u0027egp\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a7e1126_bdbba7e4","line":126,"in_reply_to":"3a7e1126_10867913","updated":"2015-12-18 01:09:44.000000000","message":"In previous comments, others prefer sorting them according to protocol number.","commit_id":"9a37c462cf1efb83c84d0545d067a05dee09e569"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d56fe38dc04a8cfe590373a29d2f2f8acfd3fcb1","unresolved":false,"context_lines":[{"line_number":144,"context_line":"PROTO_NAME_PGM \u003d \u0027pgm\u0027"},{"line_number":145,"context_line":"PROTO_NAME_SCTP \u003d \u0027sctp\u0027"},{"line_number":146,"context_line":"PROTO_NAME_UDPLITE \u003d \u0027udplite\u0027"},{"line_number":147,"context_line":"PROTO_NUM_ICMP \u003d 1"},{"line_number":148,"context_line":"PROTO_NUM_IGMP \u003d 2"},{"line_number":149,"context_line":"PROTO_NUM_TCP \u003d 6"},{"line_number":150,"context_line":"PROTO_NUM_EGP \u003d 8"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_26191689","line":147,"updated":"2016-01-01 04:24:35.000000000","message":"Better have a blank line between NAME and NUM declaration.","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8f9a3371ed6ab4c54e3ace3e2e4047650ae361e0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"PROTO_NAME_PGM \u003d \u0027pgm\u0027"},{"line_number":145,"context_line":"PROTO_NAME_SCTP \u003d \u0027sctp\u0027"},{"line_number":146,"context_line":"PROTO_NAME_UDPLITE \u003d \u0027udplite\u0027"},{"line_number":147,"context_line":"PROTO_NUM_ICMP \u003d 1"},{"line_number":148,"context_line":"PROTO_NUM_IGMP \u003d 2"},{"line_number":149,"context_line":"PROTO_NUM_TCP \u003d 6"},{"line_number":150,"context_line":"PROTO_NUM_EGP \u003d 8"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_4979962e","line":147,"in_reply_to":"fa69d971_26191689","updated":"2016-01-04 14:34:42.000000000","message":"May be more readable with these in alpha order, versus numerical order, as well as in the map.","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"0fae749b954efbe952b9204f7f7196d89d79baad","unresolved":false,"context_lines":[{"line_number":144,"context_line":"PROTO_NAME_PGM \u003d \u0027pgm\u0027"},{"line_number":145,"context_line":"PROTO_NAME_SCTP \u003d \u0027sctp\u0027"},{"line_number":146,"context_line":"PROTO_NAME_UDPLITE \u003d \u0027udplite\u0027"},{"line_number":147,"context_line":"PROTO_NUM_ICMP \u003d 1"},{"line_number":148,"context_line":"PROTO_NUM_IGMP \u003d 2"},{"line_number":149,"context_line":"PROTO_NUM_TCP \u003d 6"},{"line_number":150,"context_line":"PROTO_NUM_EGP \u003d 8"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_460ddfe6","line":147,"in_reply_to":"fa69d971_4979962e","updated":"2016-01-05 07:07:45.000000000","message":"Done","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d56fe38dc04a8cfe590373a29d2f2f8acfd3fcb1","unresolved":false,"context_lines":[{"line_number":150,"context_line":"PROTO_NUM_EGP \u003d 8"},{"line_number":151,"context_line":"PROTO_NUM_UDP \u003d 17"},{"line_number":152,"context_line":"PROTO_NUM_DCCP \u003d 33"},{"line_number":153,"context_line":"PROTO_NUM_IPV6_ENCAP \u003d 41"},{"line_number":154,"context_line":"PROTO_NUM_IPV6_ROUTE \u003d 43"},{"line_number":155,"context_line":"PROTO_NUM_IPV6_FRAG \u003d 44"},{"line_number":156,"context_line":"PROTO_NUM_RSVP \u003d 46"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_a60d0640","line":153,"updated":"2016-01-01 04:24:35.000000000","message":"There looks some inconsistency on naming IPV6 constants. Old style used XXX_V6 (PROTO_NUM_ICMP_V6) but the new style named IPV6 protocols like XXX_IPV6_XXX. Request to follow uniform approach.","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"0fae749b954efbe952b9204f7f7196d89d79baad","unresolved":false,"context_lines":[{"line_number":150,"context_line":"PROTO_NUM_EGP \u003d 8"},{"line_number":151,"context_line":"PROTO_NUM_UDP \u003d 17"},{"line_number":152,"context_line":"PROTO_NUM_DCCP \u003d 33"},{"line_number":153,"context_line":"PROTO_NUM_IPV6_ENCAP \u003d 41"},{"line_number":154,"context_line":"PROTO_NUM_IPV6_ROUTE \u003d 43"},{"line_number":155,"context_line":"PROTO_NUM_IPV6_FRAG \u003d 44"},{"line_number":156,"context_line":"PROTO_NUM_RSVP \u003d 46"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_6612630b","line":153,"in_reply_to":"fa69d971_29d30206","updated":"2016-01-05 07:07:45.000000000","message":"Done","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8f9a3371ed6ab4c54e3ace3e2e4047650ae361e0","unresolved":false,"context_lines":[{"line_number":150,"context_line":"PROTO_NUM_EGP \u003d 8"},{"line_number":151,"context_line":"PROTO_NUM_UDP \u003d 17"},{"line_number":152,"context_line":"PROTO_NUM_DCCP \u003d 33"},{"line_number":153,"context_line":"PROTO_NUM_IPV6_ENCAP \u003d 41"},{"line_number":154,"context_line":"PROTO_NUM_IPV6_ROUTE \u003d 43"},{"line_number":155,"context_line":"PROTO_NUM_IPV6_FRAG \u003d 44"},{"line_number":156,"context_line":"PROTO_NUM_RSVP \u003d 46"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_29d30206","line":153,"in_reply_to":"fa69d971_a60d0640","updated":"2016-01-04 14:34:42.000000000","message":"I agree","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1ff0369fb8e7ee9e7384570715b0e2361efa17e3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"PROTO_NUM_TCP \u003d 6"},{"line_number":166,"context_line":"PROTO_NUM_UDP \u003d 17"},{"line_number":167,"context_line":"PROTO_NUM_UDPLITE \u003d 136"},{"line_number":168,"context_line":"PROTO_NUM_VRRP \u003d 112"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"IP_PROTOCOL_MAP \u003d {PROTO_NAME_AH: PROTO_NUM_AH,"},{"line_number":171,"context_line":"                   PROTO_NAME_DCCP: PROTO_NUM_DCCP,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9a68dd71_58f67b90","line":168,"updated":"2016-01-21 04:54:47.000000000","message":"can you provide a script to generate these from protocol-numbers.txt\nto make it easier to review and maintain consistency in the future?","commit_id":"ec7cd2ba8b149659239caa4ba8c589cb78a158e7"},{"author":{"_account_id":18289,"name":"Sreekumar S","email":"sreesiv@gmail.com","username":"sreesiv"},"change_message_id":"a8fc9c73137343e131fb48ac31f9abcd03008b63","unresolved":false,"context_lines":[{"line_number":165,"context_line":"PROTO_NUM_TCP \u003d 6"},{"line_number":166,"context_line":"PROTO_NUM_UDP \u003d 17"},{"line_number":167,"context_line":"PROTO_NUM_UDPLITE \u003d 136"},{"line_number":168,"context_line":"PROTO_NUM_VRRP \u003d 112"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"IP_PROTOCOL_MAP \u003d {PROTO_NAME_AH: PROTO_NUM_AH,"},{"line_number":171,"context_line":"                   PROTO_NAME_DCCP: PROTO_NUM_DCCP,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a5de9d1_a12bbe2f","line":168,"in_reply_to":"7a5de9d1_18f00b90","updated":"2016-01-28 06:53:16.000000000","message":"I agree, this patch shouldn\u0027t be waiting for the utility script!","commit_id":"ec7cd2ba8b149659239caa4ba8c589cb78a158e7"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"c9ee61bec03f6f924010721938e6c2d971f9834f","unresolved":false,"context_lines":[{"line_number":165,"context_line":"PROTO_NUM_TCP \u003d 6"},{"line_number":166,"context_line":"PROTO_NUM_UDP \u003d 17"},{"line_number":167,"context_line":"PROTO_NUM_UDPLITE \u003d 136"},{"line_number":168,"context_line":"PROTO_NUM_VRRP \u003d 112"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"IP_PROTOCOL_MAP \u003d {PROTO_NAME_AH: PROTO_NUM_AH,"},{"line_number":171,"context_line":"                   PROTO_NAME_DCCP: PROTO_NUM_DCCP,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a5de9d1_18f00b90","line":168,"in_reply_to":"9a68dd71_58f67b90","updated":"2016-01-28 04:22:36.000000000","message":"I suggest to make it as a follow-up patch.","commit_id":"ec7cd2ba8b149659239caa4ba8c589cb78a158e7"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"3cc20bb243013bf6582545cbb1cc1a89bdd366be","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"IP_PROTOCOL_MAP \u003d {constants.PROTO_NAME_ICMP: constants.PROTO_NUM_ICMP,"},{"line_number":41,"context_line":"                   constants.PROTO_NAME_IGMP: constants.PROTO_NUM_IGMP,"},{"line_number":42,"context_line":"                   constants.PROTO_NAME_TCP: constants.PROTO_NUM_TCP,"},{"line_number":43,"context_line":"                   constants.PROTO_NAME_EGP: constants.PROTO_NUM_EGP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_4537f3fe","line":40,"updated":"2015-12-03 08:34:39.000000000","message":"It would be better to order in alphabet. So, that people would be easy to find and modify it in future.\n\nBesides, is it possible to move it to constant.py, so that you can just use constant.IP_PROTOCOL_MAP.keys() at [1], which will also simplify your work.\n\n[1] https://review.openstack.org/#/c/252155/2/neutron/extensions/securitygroup.py","commit_id":"a008943e69f8eeda79fd60916aeea0504052ea1b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6753a789027a241f8a4be0a227c5942dd8bec0d7","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"IP_PROTOCOL_MAP \u003d {constants.PROTO_NAME_ICMP: constants.PROTO_NUM_ICMP,"},{"line_number":41,"context_line":"                   constants.PROTO_NAME_IGMP: constants.PROTO_NUM_IGMP,"},{"line_number":42,"context_line":"                   constants.PROTO_NAME_TCP: constants.PROTO_NUM_TCP,"},{"line_number":43,"context_line":"                   constants.PROTO_NAME_EGP: constants.PROTO_NUM_EGP,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_9958d632","line":40,"in_reply_to":"9a8ffd7b_4537f3fe","updated":"2015-12-03 12:17:06.000000000","message":"+1 for both the suggestions.","commit_id":"a008943e69f8eeda79fd60916aeea0504052ea1b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5fc3d984210109ed56cce076bc87827ec916c6dd","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def _validate_ethertype_and_protocol(self, rule):"},{"line_number":446,"context_line":"        \"\"\"Check if given ethertype and  protocol are valid or not\"\"\""},{"line_number":447,"context_line":"        if rule[\u0027protocol\u0027] in [constants.PROTO_NAME_ICMP_V6,"},{"line_number":448,"context_line":"                                constants.PROTO_NAME_IPV6_ENCAP,"},{"line_number":449,"context_line":"                                constants.PROTO_NAME_IPV6_ROUTE,"},{"line_number":450,"context_line":"                                constants.PROTO_NAME_IPV6_FRAG,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_d3930a4e","line":447,"updated":"2015-12-06 07:49:08.000000000","message":"are there unit tests for this change?","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"013c7921c5858ded288a366e6622b7b6cdaafd3f","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def _validate_ethertype_and_protocol(self, rule):"},{"line_number":446,"context_line":"        \"\"\"Check if given ethertype and  protocol are valid or not\"\"\""},{"line_number":447,"context_line":"        if rule[\u0027protocol\u0027] in [constants.PROTO_NAME_ICMP_V6,"},{"line_number":448,"context_line":"                                constants.PROTO_NAME_IPV6_ENCAP,"},{"line_number":449,"context_line":"                                constants.PROTO_NAME_IPV6_ROUTE,"},{"line_number":450,"context_line":"                                constants.PROTO_NAME_IPV6_FRAG,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_cf7492ff","line":447,"in_reply_to":"7a740942_d3930a4e","updated":"2015-12-11 15:08:28.000000000","message":"I cannot find any test cases that cover this function. I can add some kind new test cases for it in a follow-up patch.","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c10fc5ec406a02d7afe9ee176b324f22428b5374","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def _validate_ethertype_and_protocol(self, rule):"},{"line_number":446,"context_line":"        \"\"\"Check if given ethertype and  protocol are valid or not\"\"\""},{"line_number":447,"context_line":"        if rule[\u0027protocol\u0027] in [constants.PROTO_NAME_ICMP_V6,"},{"line_number":448,"context_line":"                                constants.PROTO_NAME_IPV6_ENCAP,"},{"line_number":449,"context_line":"                                constants.PROTO_NAME_IPV6_ROUTE,"},{"line_number":450,"context_line":"                                constants.PROTO_NAME_IPV6_FRAG,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_484c7542","line":447,"updated":"2015-12-15 13:11:37.000000000","message":"RE: garyk\u0027s comment in PS5, my preference would be to update the unit tests as part of this commit to include one for this, since we are changing it.","commit_id":"86dcb5825ca6eb2ceb5431d43c730c89de3a3485"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"dad86bddffdf66e68bd0463d3a3802e78e5a8b2e","unresolved":false,"context_lines":[{"line_number":444,"context_line":""},{"line_number":445,"context_line":"    def _validate_ethertype_and_protocol(self, rule):"},{"line_number":446,"context_line":"        \"\"\"Check if given ethertype and  protocol are valid or not\"\"\""},{"line_number":447,"context_line":"        if rule[\u0027protocol\u0027] in [constants.PROTO_NAME_ICMP_V6,"},{"line_number":448,"context_line":"                                constants.PROTO_NAME_IPV6_ENCAP,"},{"line_number":449,"context_line":"                                constants.PROTO_NAME_IPV6_ROUTE,"},{"line_number":450,"context_line":"                                constants.PROTO_NAME_IPV6_FRAG,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a7e1126_278cac34","line":447,"in_reply_to":"5a710552_484c7542","updated":"2015-12-17 14:11:21.000000000","message":"Done","commit_id":"86dcb5825ca6eb2ceb5431d43c730c89de3a3485"}],"neutron/extensions/securitygroup.py":[{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"11529e4c0ebed61a6e69697161227833c14f0f32","unresolved":false,"context_lines":[{"line_number":204,"context_line":"attr.validators[\u0027type:name_not_default\u0027] \u003d _validate_name_not_default"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"sg_supported_protocols \u003d [None]"},{"line_number":207,"context_line":"sg_supported_protocols.extend(const.IP_PROTOCOL_MAP.keys())"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"sg_supported_ethertypes \u003d [\u0027IPv4\u0027, \u0027IPv6\u0027]"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_99e72040","line":207,"updated":"2015-12-04 06:12:56.000000000","message":"considering \n\n[None] + const.IP_PROTOCOL_MAP.keys()","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b4774536c25a98991b5126263c68e487e0168eb7","unresolved":false,"context_lines":[{"line_number":204,"context_line":"attr.validators[\u0027type:name_not_default\u0027] \u003d _validate_name_not_default"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"sg_supported_protocols \u003d [None]"},{"line_number":207,"context_line":"sg_supported_protocols.extend(const.IP_PROTOCOL_MAP.keys())"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"sg_supported_ethertypes \u003d [\u0027IPv4\u0027, \u0027IPv6\u0027]"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_f11cfbc2","line":207,"in_reply_to":"7a740942_4000c534","updated":"2015-12-06 17:09:41.000000000","message":"For Python3 compatibility it would need to be:\n\n [None] + list(const.IP_PROTOCOL_MAP.keys())","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c9952c09be0de577eb9feb8d22b732afe6b0af5c","unresolved":false,"context_lines":[{"line_number":204,"context_line":"attr.validators[\u0027type:name_not_default\u0027] \u003d _validate_name_not_default"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"sg_supported_protocols \u003d [None]"},{"line_number":207,"context_line":"sg_supported_protocols.extend(const.IP_PROTOCOL_MAP.keys())"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"sg_supported_ethertypes \u003d [\u0027IPv4\u0027, \u0027IPv6\u0027]"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_4000c534","line":207,"in_reply_to":"7a740942_99e72040","updated":"2015-12-04 14:03:54.000000000","message":"+1","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"013c7921c5858ded288a366e6622b7b6cdaafd3f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"attr.validators[\u0027type:name_not_default\u0027] \u003d _validate_name_not_default"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"sg_supported_protocols \u003d [None]"},{"line_number":207,"context_line":"sg_supported_protocols.extend(const.IP_PROTOCOL_MAP.keys())"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"sg_supported_ethertypes \u003d [\u0027IPv4\u0027, \u0027IPv6\u0027]"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a740942_aff4a65a","line":207,"in_reply_to":"7a740942_f11cfbc2","updated":"2015-12-11 15:08:28.000000000","message":"Thanks for your suggestion. It is done.","commit_id":"5affbf86a710c90220f20aeba30b0e84584c5cc2"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d56fe38dc04a8cfe590373a29d2f2f8acfd3fcb1","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"attr.validators[\u0027type:name_not_default\u0027] \u003d _validate_name_not_default"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"sg_supported_protocols \u003d [None] + list(const.IP_PROTOCOL_MAP.keys())"},{"line_number":207,"context_line":"sg_supported_ethertypes \u003d [\u0027IPv4\u0027, \u0027IPv6\u0027]"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Attribute Map"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa69d971_66070e1d","line":206,"updated":"2016-01-01 04:24:35.000000000","message":"Nice!","commit_id":"77aae65c3eda4aca64e69ec24ef72143a26b5c60"}],"neutron/tests/unit/extensions/test_securitygroup.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5c040580de227481950dd5ec44e1c7ccd77586d9","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            security_group_id \u003d sg[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":524,"context_line":"            direction \u003d \"ingress\""},{"line_number":525,"context_line":"            remote_ip_prefix \u003d \"10.0.0.0/24\""},{"line_number":526,"context_line":"            protocol \u003d const.PROTO_NAME_TCP"},{"line_number":527,"context_line":"            port_range_min \u003d 22"},{"line_number":528,"context_line":"            port_range_max \u003d 22"},{"line_number":529,"context_line":"            ethertype \u003d const.IPv4"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_46b5917b","line":526,"updated":"2016-01-06 17:29:03.000000000","message":"const.PROTO_NAME_TCP is \"tcp\", so the point of this test - case insensitive - is being lost.  I think you should leave this and L529 alone for that reason.","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"ce685ee2115c0b71c184de6a659602c7edc882ff","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            security_group_id \u003d sg[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":524,"context_line":"            direction \u003d \"ingress\""},{"line_number":525,"context_line":"            remote_ip_prefix \u003d \"10.0.0.0/24\""},{"line_number":526,"context_line":"            protocol \u003d const.PROTO_NAME_TCP"},{"line_number":527,"context_line":"            port_range_min \u003d 22"},{"line_number":528,"context_line":"            port_range_max \u003d 22"},{"line_number":529,"context_line":"            ethertype \u003d const.IPv4"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_7305ee0e","line":526,"in_reply_to":"fa69d971_46b5917b","updated":"2016-01-06 21:17:28.000000000","message":"+1 to Brian\u0027s comments here and on L529","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"c7183df95eb0b556436c73720c34fa6e33ce68ed","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            security_group_id \u003d sg[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":524,"context_line":"            direction \u003d \"ingress\""},{"line_number":525,"context_line":"            remote_ip_prefix \u003d \"10.0.0.0/24\""},{"line_number":526,"context_line":"            protocol \u003d const.PROTO_NAME_TCP"},{"line_number":527,"context_line":"            port_range_min \u003d 22"},{"line_number":528,"context_line":"            port_range_max \u003d 22"},{"line_number":529,"context_line":"            ethertype \u003d const.IPv4"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_d84f0069","line":526,"in_reply_to":"fa69d971_7305ee0e","updated":"2016-01-07 09:38:29.000000000","message":"Thanks for your reminding. I\u0027ll fix it.","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5c040580de227481950dd5ec44e1c7ccd77586d9","unresolved":false,"context_lines":[{"line_number":526,"context_line":"            protocol \u003d const.PROTO_NAME_TCP"},{"line_number":527,"context_line":"            port_range_min \u003d 22"},{"line_number":528,"context_line":"            port_range_max \u003d 22"},{"line_number":529,"context_line":"            ethertype \u003d const.IPv4"},{"line_number":530,"context_line":"            with self.security_group_rule(security_group_id, direction,"},{"line_number":531,"context_line":"                                          protocol, port_range_min,"},{"line_number":532,"context_line":"                                          port_range_max,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_26765dd7","line":529,"updated":"2016-01-06 17:29:03.000000000","message":"I know this is \"IPv4\", but I had to go look that up where leaving it alone means I don\u0027t.","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"c7183df95eb0b556436c73720c34fa6e33ce68ed","unresolved":false,"context_lines":[{"line_number":526,"context_line":"            protocol \u003d const.PROTO_NAME_TCP"},{"line_number":527,"context_line":"            port_range_min \u003d 22"},{"line_number":528,"context_line":"            port_range_max \u003d 22"},{"line_number":529,"context_line":"            ethertype \u003d const.IPv4"},{"line_number":530,"context_line":"            with self.security_group_rule(security_group_id, direction,"},{"line_number":531,"context_line":"                                          protocol, port_range_min,"},{"line_number":532,"context_line":"                                          port_range_max,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa69d971_985508fb","line":529,"in_reply_to":"fa69d971_26765dd7","updated":"2016-01-07 09:38:29.000000000","message":"Done","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3b9918974da662f4eea39e082c2b96de32521bb0","unresolved":false,"context_lines":[{"line_number":526,"context_line":"            protocol \u003d \u0027TCP\u0027"},{"line_number":527,"context_line":"            port_range_min \u003d 22"},{"line_number":528,"context_line":"            port_range_max \u003d 22"},{"line_number":529,"context_line":"            ethertype \u003d \u0027ipV4\u0027"},{"line_number":530,"context_line":"            with self.security_group_rule(security_group_id, direction,"},{"line_number":531,"context_line":"                                          protocol, port_range_min,"},{"line_number":532,"context_line":"                                          port_range_max,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa69d971_edb30be8","line":529,"range":{"start_line":529,"start_character":25,"end_line":529,"end_character":29},"updated":"2016-01-07 18:24:17.000000000","message":"IPv4?","commit_id":"94f68a5dc4c375f31859c2357db83348cff951a0"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"4d2e9722f3fa1524eeaa0870355e86c36d6dd71c","unresolved":false,"context_lines":[{"line_number":526,"context_line":"            protocol \u003d \u0027TCP\u0027"},{"line_number":527,"context_line":"            port_range_min \u003d 22"},{"line_number":528,"context_line":"            port_range_max \u003d 22"},{"line_number":529,"context_line":"            ethertype \u003d \u0027ipV4\u0027"},{"line_number":530,"context_line":"            with self.security_group_rule(security_group_id, direction,"},{"line_number":531,"context_line":"                                          protocol, port_range_min,"},{"line_number":532,"context_line":"                                          port_range_max,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa69d971_5d9cdfbf","line":529,"range":{"start_line":529,"start_character":25,"end_line":529,"end_character":29},"in_reply_to":"fa69d971_edb30be8","updated":"2016-01-09 02:16:56.000000000","message":"Hi, Paul. It is for testing case insensitivity. It is right. Could you remove your -1, thanks.","commit_id":"94f68a5dc4c375f31859c2357db83348cff951a0"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"b57bfa8bdfc076221c634c9055417df4aa780ebb","unresolved":false,"context_lines":[{"line_number":526,"context_line":"            protocol \u003d \u0027TCP\u0027"},{"line_number":527,"context_line":"            port_range_min \u003d 22"},{"line_number":528,"context_line":"            port_range_max \u003d 22"},{"line_number":529,"context_line":"            ethertype \u003d \u0027ipV4\u0027"},{"line_number":530,"context_line":"            with self.security_group_rule(security_group_id, direction,"},{"line_number":531,"context_line":"                                          protocol, port_range_min,"},{"line_number":532,"context_line":"                                          port_range_max,"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa69d971_df0fce2c","line":529,"range":{"start_line":529,"start_character":25,"end_line":529,"end_character":29},"in_reply_to":"fa69d971_edb30be8","updated":"2016-01-07 18:34:39.000000000","message":"This test concerns case insensitivity and this takes it back to the trunk code.","commit_id":"94f68a5dc4c375f31859c2357db83348cff951a0"}],"releasenotes/notes/add-ip-protocols-in-sg-60467a073e771aee.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"825dc16161d6a16b65f53f585ccdfc401ad3012d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add popular IP protocols in security group. End-users can specify"},{"line_number":4,"context_line":"    protocol names instead protocol number in both restful API and"},{"line_number":5,"context_line":"    CLI of security group."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Add popular IP protocols in security group."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a7e1126_88754899","line":5,"updated":"2015-12-18 03:15:01.000000000","message":"There\u0027s a couple of grammatical errors in this text, I tried to correct it below.\n\n\"Add popular IP protocols to the security group code.  End-users can specify protocol names instead of protocol numbers in both RESTful API and python-neutronclient CLI.\"","commit_id":"401f6922744410b02a9dc3a026674e1b5e7ec1f5"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"205819f32d8dd807d41972d12b0b7fa602ed9777","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add popular IP protocols in security group. End-users can specify"},{"line_number":4,"context_line":"    protocol names instead protocol number in both restful API and"},{"line_number":5,"context_line":"    CLI of security group."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Add popular IP protocols in security group."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a7b0d38_dfd834f2","line":5,"in_reply_to":"3a7e1126_88754899","updated":"2015-12-23 03:52:25.000000000","message":"Done","commit_id":"401f6922744410b02a9dc3a026674e1b5e7ec1f5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"825dc16161d6a16b65f53f585ccdfc401ad3012d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    protocol names instead protocol number in both restful API and"},{"line_number":5,"context_line":"    CLI of security group."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Add popular IP protocols in security group."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a7e1126_c86350db","line":7,"updated":"2015-12-18 03:15:01.000000000","message":"...to security group code.","commit_id":"401f6922744410b02a9dc3a026674e1b5e7ec1f5"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"205819f32d8dd807d41972d12b0b7fa602ed9777","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    protocol names instead protocol number in both restful API and"},{"line_number":5,"context_line":"    CLI of security group."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Add popular IP protocols in security group."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1a7b0d38_7fe580a6","line":7,"in_reply_to":"3a7e1126_c86350db","updated":"2015-12-23 03:52:25.000000000","message":"Done","commit_id":"401f6922744410b02a9dc3a026674e1b5e7ec1f5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"825dc16161d6a16b65f53f585ccdfc401ad3012d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3a7e1126_889c68c1","line":8,"updated":"2015-12-18 03:15:01.000000000","message":"blank line, probably doesn\u0027t matter in a .yaml","commit_id":"401f6922744410b02a9dc3a026674e1b5e7ec1f5"},{"author":{"_account_id":7805,"name":"Li Ma","email":"skywalker.nick@gmail.com","username":"Nick"},"change_message_id":"205819f32d8dd807d41972d12b0b7fa602ed9777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"1a7b0d38_9fe2ac9e","line":8,"in_reply_to":"3a7e1126_889c68c1","updated":"2015-12-23 03:52:25.000000000","message":"Done","commit_id":"401f6922744410b02a9dc3a026674e1b5e7ec1f5"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"69943ede7beab9dd2df6c2f2bb6722933b99aa95","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Add popular IP protocols to the security group code. End-users can"},{"line_number":4,"context_line":"    specify protocol names instead of protocol numbers in both RESTful"},{"line_number":5,"context_line":"    API and python-neutronclient CLI."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Add popular IP protocols to security group code."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa69d971_d6ead073","line":5,"updated":"2016-01-05 14:24:53.000000000","message":"Do we really need to mention about pyhton-neutronclient over here?","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"69943ede7beab9dd2df6c2f2bb6722933b99aa95","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    specify protocol names instead of protocol numbers in both RESTful"},{"line_number":5,"context_line":"    API and python-neutronclient CLI."},{"line_number":6,"context_line":"upgrade:"},{"line_number":7,"context_line":"  - Add popular IP protocols to security group code."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"fa69d971_36e32ca6","line":7,"updated":"2016-01-05 14:24:53.000000000","message":":%s/Add/Added/g","commit_id":"0e83afc8814383eec77ab2fe8bf2906d89b06a71"}]}
